STINNER Victor added the comment:
test_ssl doesn't use svn.python.org anymore and it now better handle network
failures. I close the issue as out of date.
--
nosy: +vstinner
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
Martin Panter added the comment:
Yes sorry I did mean Issue 25940 (too many bug numbers!), but only the main
change which has already been made (revision adf750b1252d etc). So you don’t
have to wait for that.
--
___
Python tracker
Berker Peksag added the comment:
> although they will need updating since the Issue 24841 changeover to
> pythontest.net.
I think you meant issue 25940, right? :)
Do you want me to wait for issue 25940?
--
versions: -Python 3.4
___
Python tracker
Martin Panter added the comment:
The two changes to test_ssl.py look okay to me, although they will need
updating since the Issue 24841 changeover to pythontest.net.
But I don’t think it is a good idea to add ENOTCONN to the list of errors
ignored by all transient_internet() tests. In most
Vinson Lee added the comment:
I tested the attached patch on latest cpython master and it works for me.
test_ciphers (test.test_ssl.NetworkedTests) ... skipped "Resource
'svn.python.org' is not available"
test_connect (test.test_ssl.NetworkedTests) ... skipped "Resource
'svn.python.org' is
Berker Peksag added the comment:
The attached patch should fix the test failures.
--
keywords: +patch
stage: needs patch -> patch review
type: -> behavior
Added file: http://bugs.python.org/file40542/issue24841.diff
___
Python tracker
Changes by Berker Peksag berker.pek...@gmail.com:
--
keywords: +easy
nosy: +berker.peksag
stage: - needs patch
versions: -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24841
___
New submission from Vinson Lee:
'make test' runs all the network tests.
Some of the tests in test_ssl fail instead of skip if svn.python.org is not
accessible.
$ ./python -m test -v -u all test_ssl
==
ERROR:
Changes by Vinson Lee v...@freedesktop.org:
--
versions: +Python 3.3, Python 3.4, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24841
___
