[issue4111] Add Systemtap/DTrace probes

Change by hai shi : -- pull_requests: +23865 pull_request: https://github.com/python/cpython/pull/25115 ___ Python tracker ___ ___

[issue4111] Add Systemtap/DTrace probes

Change by hai shi : -- pull_requests: -23859 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue4111] Add Systemtap/DTrace probes

Change by hai shi : -- nosy: +shihai1991 nosy_count: 25.0 -> 26.0 pull_requests: +23859 pull_request: https://github.com/python/cpython/pull/25115 ___ Python tracker ___

[issue4111] Add Systemtap/DTrace probes

Changes by cburroughs : -- nosy: +cburroughs ___ Python tracker ___ ___

[issue4111] Add Systemtap/DTrace probes

Dave Malcolm dmalc...@redhat.com added the comment: Issue #13405 covers DTrace; I've taken the liberty of also opening issue #14776 to cover SystemTap. I hope that once one of these is in the tree it will be easier to get the other one in. -- ___

[issue4111] Add Systemtap/DTrace probes

Jesús Cea Avión j...@jcea.es added the comment: This project continues in issue #13405. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___

[issue4111] Add Systemtap/DTrace probes

Changes by Jesús Cea Avión j...@jcea.es: -- resolution: - out of date status: open - closed superseder: - Add DTrace probes ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___

[issue4111] Add Systemtap/DTrace probes

Jesús Cea Avión j...@jcea.es added the comment: Anybody still working on this?. We missed the 2.7 boat. DO NOT MISS THE 3.3 ONE!!! :-) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111

[issue4111] Add Systemtap/DTrace probes

Changes by Brett Hoerner bretthoer...@gmail.com: -- nosy: -bretthoerner ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___ ___

[issue4111] Add Systemtap/DTrace probes

Changes by Martin Marcher mar...@marcher.name: -- nosy: +serverhorror ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___ ___ Python-bugs-list

[issue4111] Add Systemtap/DTrace probes

anatoly techtonik techto...@gmail.com added the comment: 2011/4/6 Jesús Cea Avión rep...@bugs.python.org: Jesús Cea Avión j...@jcea.es added the comment: Some more references: Read the notes under the slides: https://dgl.cx/2011/01/dtrace-and-perl https://dgl.cx/dtrace

[issue4111] Add Systemtap/DTrace probes

Dave Malcolm dmalc...@redhat.com added the comment: jcea: I notice that on 2011-02-22 you made these changes: assignee: dmalcolm - dino.viehland nosy: +dino.viehland versions: +Python 3.3 -Python 3.2 Did you mean to change the assignee, or was this an accident? --

[issue4111] Add Systemtap/DTrace probes

Jesús Cea Avión j...@jcea.es added the comment: Malcolm, it was a mistake. I only wanted to change the TARGET. I assign the issue to you again. Dino, I delete you from the nosy list now. Sorry for the inconvenience. My excuses to both. -- assignee: dino.viehland - dmalcolm nosy:

[issue4111] Add Systemtap/DTrace probes

Jesús Cea Avión j...@jcea.es added the comment: Some more references: Read the notes under the slides: https://dgl.cx/2011/01/dtrace-and-perl https://dgl.cx/dtrace http://dtrace.org/blogs/ What do we need to unblock this? -- ___ Python tracker

[issue4111] Add Systemtap/DTrace probes

Changes by Jesús Cea Avión j...@jcea.es: -- assignee: dmalcolm - dino.viehland nosy: +dino.viehland versions: +Python 3.3 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___

[issue4111] Add Systemtap/DTrace probes

Jesús Cea Avión j...@jcea.es added the comment: Some references to keep around: http://src.opensolaris.org/source/xref/jds/spec-files/trunk/patches/ http://src.opensolaris.org/source/xref/jds/spec-files/trunk/patches/Python26-07-dtrace.diff

[issue4111] Add Systemtap/DTrace probes

John Levon movem...@users.sourceforge.net added the comment: configure.in has: AC_MSG_RESULT([$with_dtrace]) ... AC_MSG_RESULT($with_dtrace) Why twice? It looks confusing. -- ___ Python tracker rep...@bugs.python.org

[issue4111] Add Systemtap/DTrace probes

Changes by Kapil Thangavelu kapil.f...@gmail.com: -- nosy: +hazmat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___ ___ Python-bugs-list

[issue4111] Add Systemtap/DTrace probes

Jesús Cea Avión j...@jcea.es added the comment: Dave, we need some kind of documentation, if we expect to ship this in Python 3.2. The deadline is only 10-15 days away. Could you write something able to be in the standard documentation?. -- ___

[issue4111] Add Systemtap/DTrace probes

Antoine Pitrou pit...@free.fr added the comment: For the record, replacing /dev/null with conftest.out in the configure test solves the detection problem (and allows Python to build cleanly). However, there is then a problem in test_systemtap (even when replacing stap with dtrace) since the

[issue4111] Add Systemtap/DTrace probes

Antoine Pitrou pit...@free.fr added the comment: (my last message was about building on OpenSolaris) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___

[issue4111] Add Systemtap/DTrace probes

Jesús Cea Avión j...@jcea.es added the comment: I am trying to review this for 3.2, but I am having some issues. For instance, include/pydtrace.d is not present in the last patch. Please, post a patch with all the required changes in the same (patch) file. Hurry, we are still on track for

[issue4111] Add Systemtap/DTrace probes

Alexander Belopolsky belopol...@users.sourceforge.net added the comment: 2010/10/25 Jesús Cea Avión rep...@bugs.python.org: .. Another question: I am not able to decide between Sun/Apple style, or breaking dtrace scripts compatibility completely. Anybody has an opinion about this?. Is this

[issue4111] Add Systemtap/DTrace probes

Jesús Cea Avión j...@jcea.es added the comment: Malcolm, does your last patch address the performance issue?. Ideally, dtrace support should be compiled in by default, so performance issues are important. Idealy, performance difference between compiling dtrace or not should be negligible.

[issue4111] Add Systemtap/DTrace probes

Changes by Giampaolo Rodola' g.rod...@gmail.com: -- nosy: -giampaolo.rodola ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___ ___

[issue4111] Add Systemtap/DTrace probes

Jesús Cea Avión j...@jcea.es added the comment: We need some documentation, too. Maybe a new chapter, or a new section in the debug chapter. Better the first, since this is not only for debugging, but for performance study too. -- ___ Python

[issue4111] Add Systemtap/DTrace probes

Jesús Cea Avión j...@jcea.es added the comment: Compiling the code WITHOUT dtrace support gives an error: Undefined first referenced symbol in file __dtrace_python___function__entry ./libpython3.2m.so

[issue4111] Add Systemtap/DTrace probes

Jesús Cea Avión j...@jcea.es added the comment: Compiling WITH dtrace... shows the same error :- -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___

[issue4111] Add Systemtap/DTrace probes

Jesús Cea Avión j...@jcea.es added the comment: I am using Solaris 10, but the configure script detects apple implementation. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___

[issue4111] Add Systemtap/DTrace probes

Changes by Danek Duvall duv...@comfychair.org: -- nosy: +dhduvall ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___ ___ Python-bugs-list

[issue4111] Add Systemtap/DTrace probes

Frank Ch. Eigler f...@elastic.org added the comment: I believe the problem jcea is experiencing is with the solaris (/linux?) branch of the configure.in: if dtrace -G -o /dev/null -s $srcdir/Include/pydtrace.d 2/dev/null It seems solaris doesn't like the -o /dev/null part. Try specifying

[issue4111] Add Systemtap/DTrace probes

Dave Malcolm dmalc...@redhat.com added the comment: Updated patch, removing the FIXMEs, and slightly reworking the test code. I've wrapped the whole of get_frame_marker_info with a PyErr_Fetch/PyErr_Restore pair: the PyUnicode_AsUTF8String calls could fail with a MemoryError, and we don't

[issue4111] Add Systemtap/DTrace probes

Antoine Pitrou pit...@free.fr added the comment: I've wrapped the whole of get_frame_marker_info with a PyErr_Fetch/PyErr_Restore pair: the PyUnicode_AsUTF8String calls could fail with a MemoryError, and we don't want to confuse the regular exception handling within ceval. If

[issue4111] Add Systemtap/DTrace probes

Dave Malcolm dmalc...@redhat.com added the comment: It would be better to generate the sample dynamically, so that users with an incompatible locale or filesystem aren't prevented from checking out the source. Thanks: am attaching updated patch: I've removed Lib/test/systemtap_sample_☠.py,

[issue4111] Add Systemtap/DTrace probes

Dave Malcolm dmalc...@redhat.com added the comment: I should note that I've only ever been testing this with SystemTap, on Linux. I don't have a box with DTrace, and I've never directly used it. I wouldn't today be able to diagnose a buildbot failure related to DTrace (I believe I would

[issue4111] Add Systemtap/DTrace probes

Antoine Pitrou pit...@free.fr added the comment: I've the same question as Jesús Cea Avión: what is needed to get this in 3.2? Same as usual: someone to review, apply, commit. Why do you ask? -- nosy: +pitrou ___ Python tracker

[issue4111] Add Systemtap/DTrace probes

Ronald Oussoren ronaldousso...@mac.com added the comment: I've the same question as Jesús Cea Avión: what is needed to get this in 3.2? This would IMHO be a useful feature. -- ___ Python tracker rep...@bugs.python.org

[issue4111] Add Systemtap/DTrace probes

Dave Malcolm dmalc...@redhat.com added the comment: Updated version of patch attached (against py3k; r85426) I've changed the names back to function__entry and function__return. -- ___ Python tracker rep...@bugs.python.org

[issue4111] Add Systemtap/DTrace probes

Jesús Cea Avión j...@jcea.es added the comment: What do we need to have this ready for Python 3.2?. The oportunity window is closing fast, and 3.3 is two years away... So now or never... -- ___ Python tracker rep...@bugs.python.org

[issue4111] Add Systemtap/DTrace probes

Mark Wielaard m...@redhat.com added the comment: - renamed the probepoints: function__entry - frame__entry function__return - frame__exit as I believe this better describes what these do Are you sure you want to do this? You are right that it better describes the action

[issue4111] Add Systemtap/DTrace probes

anatoly techtonik techto...@gmail.com added the comment: I don't understand the last request. Is there already a practice to depend on patches that were applied by people, but were not released, reviewed or documented in some PEP? -- ___ Python

[issue4111] Add Systemtap/DTrace probes

Mark Wielaard m...@redhat.com added the comment: The original patch was created to be as close as possible to the support that Sun and Apple added to their python implementation for Solaris and MacOS. Changing the probe point names would make the current patch slightly different for scripts

[issue4111] Add Systemtap/DTrace probes

anatoly techtonik techto...@gmail.com added the comment: So, it was released. But why they didn't send their patches here? We could review them, or we want Sun and Apple create Python specifications unilaterally? It would be best to contact them and notify about the change. Is it something a

[issue4111] Add Systemtap/DTrace probes

John Levon movem...@users.sourceforge.net added the comment: Anatoly, see above. We have done exactly that. (Honestly, when I first wrote the changes, I saw them as too hacky to ever be accepted upstream). This name change seems frivolous and will indeed break existing scripts. --

[issue4111] Add Systemtap/DTrace probes

Dave Malcolm dmalc...@redhat.com added the comment: Updated py3k version of patch. Changes: - renamed the probepoints: function__entry - frame__entry function__return - frame__exit as I believe this better describes what these do - added a test suite:

[issue4111] Add Systemtap/DTrace probes

Changes by anatoly techtonik techto...@gmail.com: -- nosy: +techtonik ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___ ___ Python-bugs-list

[issue4111] Add Systemtap/DTrace probes

Changes by Giampaolo Rodola' g.rod...@gmail.com: -- nosy: +giampaolo.rodola ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___ ___

[issue4111] Add Systemtap/DTrace probes

Ronald Oussoren ronaldousso...@mac.com added the comment: On 19 Jul, 2010, at 1:07, Alexander Belopolsky wrote: Alexander Belopolsky belopol...@users.sourceforge.net added the comment: If any RedHat/Fedora people are tuned in, can you give us an update on Systemtap/DTrace support in

[issue4111] Add Systemtap/DTrace probes

Mark Lawrence breamore...@yahoo.co.uk added the comment: Comments suggest this is wanted, can our build experts get this into 3.2? -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111

[issue4111] Add Systemtap/DTrace probes

Jesús Cea Avión j...@jcea.es added the comment: +1! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___ ___ Python-bugs-list mailing list

[issue4111] Add Systemtap/DTrace probes

Alexander Belopolsky belopol...@users.sourceforge.net added the comment: If any RedHat/Fedora people are tuned in, can you give us an update on Systemtap/DTrace support in RedHat/Fedora python? I understand that one of the main problems with bringing this upstream was the lack of uniformity

[issue4111] Add Systemtap/DTrace probes

Changes by Skip Montanaro s...@pobox.com: -- assignee: skip.montanaro - nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___

[issue4111] Add Systemtap/DTrace probes

Jesús Cea Avión j...@jcea.es added the comment: Ping... We already missed the 2.7 boat. Any hope for 3.2? -- assignee: - prescod keywords: +needs review -patch nosy: +prescod, skip.montanaro -Garen priority: normal - versions: +Python 3.2 -Python 2.7, Python 3.1

[issue4111] Add Systemtap/DTrace probes

Changes by R. David Murray rdmur...@bitdance.com: -- assignee: prescod - keywords: +patch nosy: +Garen -prescod, skip.montanaro priority: - normal stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111

[issue4111] Add Systemtap/DTrace probes

Changes by Garen garen.par...@gmail.com: -- nosy: +Garen ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___ ___ Python-bugs-list mailing list

[issue4111] Add Systemtap/DTrace probes

Dave Malcolm dmalc...@redhat.com added the comment: At Red Hat we've done some work on this feature. I'm sorry for not updating this issue, I was swamped with tasks both pre-PyCon and during the event; I did show the following to various folks at PyCon; I attempted to find Skip at PyCon but

[issue4111] Add Systemtap/DTrace probes

Dave Malcolm dmalc...@redhat.com added the comment: Attached is the patch I'm currently applying in Fedora 13 to Python 3. The patch is actually against the 3.1.1 tarball, rather than SVN; sorry (swamped with post-pycon tasks here), as that's what I've been testing this work against. The

[issue4111] Add Systemtap/DTrace probes

Skip Montanaro s...@pobox.com added the comment: Jesus can I ask if this (very useful) feature is on time for Python 2.7? You can ask, but I suspect you'd be disappointed in the answer. Do you have time to look at the issue? The biggest sticking point in my mind is coming up with a uniform

[issue4111] Add Systemtap/DTrace probes

Changes by Wilfredo Sanchez wsanc...@wsanchez.net: -- nosy: +wsanchez ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___ ___ Python-bugs-list

[issue4111] Add Systemtap/DTrace probes

Changes by Glyph Lefkowitz gl...@divmod.com: -- nosy: +glyph ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___ ___ Python-bugs-list mailing

[issue4111] Add Systemtap/DTrace probes

Mark Wielaard m...@redhat.com added the comment: I took the patch and tweaked it a little so that it works with systemtap (at least for the function entry/exit probes). It is against 2.6.2 since that was what was in the Fedora 12 src package I was using. Cleaned up the configure checks a little,