[issue24039] Idle: some modal dialogs maximize, don't minimize

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions:  -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24039] Idle: some modal dialogs maximize, don't minimize

[Tal Einat]

Tal Einat  added the comment:

The search dialog windows are now made transient relative to the editor window. 
 Among other things, they no longer have minimize/maximize buttons on Windows, 
resolving this issue.

--
nosy: +taleinat
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24039] Idle: some modal dialogs maximize, don't minimize

[Tal Einat]

Change by Tal Einat :


--
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24039] Idle: some modal dialogs maximize, don't minimize

[Tal Einat]

Change by Tal Einat :


--
keywords: +patch
pull_requests: +13754
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/13869

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24039] Idle: some modal dialogs maximize, don't minimize

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Dialogs attached to a particular window should be 'transient' to that window.  
https://www.tcl.tk/man/tcl8.6/TkCmd/wm.htm#M64
It is an oversight that the window search and replace windows are not.
Modal windows, including the current Find in Files might just as well be.  

PR 13869 for #37177 (aimed at a different symption) makes search windows 
transient, fixing this issue also.

If Find in Files were not modal, then it need not be transient to a particular 
window, and minimizing could be sensible.  But this is a separate issue.

--
stage: needs patch -> 
versions: +Python 3.8, Python 3.9 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24039] Idle: some modal dialogs maximize, don't minimize

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
assignee:  -> terry.reedy
versions: +Python 3.7 -Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24039] Idle: some modal dialogs maximize, don't minimize

[Louie Lu]

Louie Lu added the comment:

The bugs can be reproduce on MacOS, when click the minimize button, the search 
dialog will be minimize, then pop up to front again. 

The preference dialog have the same behavior on MacOS, but debugger dialog 
won't.

And, Goto dialog will minimize with IDLE shell disappear, then both pop out 
again.

--
nosy: +louielu

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24039] Idle: some modal dialogs maximize, don't minimize

[Mark Roseman]

Changes by Mark Roseman m...@markroseman.com:


--
nosy: +markroseman

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24039
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24039] Idle: some modal dialogs maximize, don't minimize

[Terry J. Reedy]

Terry J. Reedy added the comment:

Another solution to this issue is to not make things modal. See #24760.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24039
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24039] Idle: some modal dialogs maximize, don't minimize

[sanad]

sanad added the comment:

I have tested all the cases mentioned in the comments on Linux Mint 17.1 
Rebecca 64 bit with Python 3.6.0a0 build version.

1.I reproduced the issue mentioned in #msg241871 the minimize button works 
perfectly fine and the search dialog box does minimizes(Which implies that this 
is a windows only issue).The maximize/expand also works and the dialog window 
can be resized both horizontally and vertically.

2.Similarly, 'Find in Files' and 'Replace' dialogs can also be resized and have 
both maximize and minimize buttons which too work fine.

3.The 'Options' = 'Configure Extensions' dialog does not have the 
maximize/minimize buttons but it can be resized.

4.The 'Options' = 'Configure IDLE' dialog can neither be resized nor does it 
have maximize/minimize buttons.

--
nosy: +sanad

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24039
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24039] Idle: some modal dialogs maximize, don't minimize

[Vivek]

Vivek added the comment:

The bug is also not reproducible in my Ubuntu 14.04 64 bit system with python 
3.4.But can be reproduced on my Windows7 and Windows8 systems.This seems to be 
a Windows specific issue.

Terry, thanks for the advice. I will take care next time :).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24039
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24039] Idle: some modal dialogs maximize, don't minimize

[Vivek]

Vivek added the comment:

I am trying to remove both min and max buttons while keeping the dialog box 
both modal and extensible. I added `top.attributes(-toolwindow,-1)` to 
SearchDialogBase.py(create_widget) which does what is required, but with side 
effects,i.e.,it changes the look of the border and close button on Search 
dialogs. Any suggestions?

PS: I am learning how to contribute and would like to work on this issue.

--
nosy: +viv1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24039
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24039] Idle: some modal dialogs maximize, don't minimize

[Terry J. Reedy]

Terry J. Reedy added the comment:

We need to know whether this issue is specific to Windows or not.  (I requested 
a Linux user to check.)  We also need to know why the config dialogs do not 
have the min and max boxes.  Neither '.attributes' and '-toollevel' appear in a 
grep of idlelib.

The changes I see are squared corners, narrower title bar, much narrower [X] 
button, Idle icon omitted, and dialog omitted from taskbar. None of these apply 
to the config dialogs.  (I do not see a change in the close button, but this 
does not matter.)

Vivek, welcome to the tracker (2nd comment, I see).  When reporting a patch in 
a comment box, please cut and paste the actual added code, and on a separate 
line. You omitted the needed quotes when retyping ;-). Unlike StackOverflow, 
for instance, these comment boxes do not recognize markup such as ``.

--
versions: +Python 3.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24039
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24039] Idle: some modal dialogs maximize, don't minimize

[Terry J. Reedy]

Terry J. Reedy added the comment:

I changed the title to generalize this issue.

The modal Options = Configure IDLE box does not have minimize or maximize 
buttons and cannot be resized.  (Ditto for About Idle.) This is typical of 
Windows dialogs, even though horizontal expansion would often be useful for 
path displays.  The modal Options = Configure Extensions box also does not 
have the button but *can* be resized. (Ditto for some other help displays.)

The Find, Find in Files, and Replace dialogs are also modal, though perhaps 
they should not be.  They have the buttons and can be maximized (which is 
useless).  They cannot be minimized because focus would have to shift to 
another window of the application, which would contradict being modal.  They 
can be resized, and this is occasionally needed and should stay.  One fix would 
be to make all these dialogs like Configure Extension -- no min, max buttons 
but resizable.

For reference, (but not part of this issue) the File menu dialogs that I 
checked are non-modal.  The Idle-specific Class and Path Browsers have min/max 
buttons and appear on the taskbar.  (Ditto for Debugger and IDLE Help.) The 
tk-defined Open and Save dialogs do not have the buttons and do not appear on 
the taskbar.  I believe the find group are the only modal dialogs with min and 
max buttons.

--
stage:  - needs patch
title: Minimize option doesn't work on Search Dialog box for idle - Idle: some 
modal dialogs maximize, don't minimize
versions: +Python 2.7, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24039
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com