[issue29070] Integration tests for pty.spawn on Linux and all other platforms

Soumendra Ganguly added the comment: Hi! Can anyone please take a look at https://bugs.python.org/issue41494 [ https://github.com/python/cpython/pull/21752 ]? I think these are related. I wrote a new function called wspawn, which is like spawn+the following differences. 1. It sets window

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

Changes by Roundup Robot : -- pull_requests: +2983 ___ Python tracker ___

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

Cornelius Diekmann added the comment: Thank you Martin for your comments in the code review tool. I prepared a new patch for the code review tool. The github changelog from patch v4 (Feb 2017) to my HEAD (currently patch v5, Apr 2017) is at:

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

Cornelius Diekmann added the comment: Uploaded a new version of the patch. Changelog of this patch (compared to v3): * Fixed reliability issue of existing pty tests. * pty.fork() should now also work on systems without os.forkpty(). Added code to test this backup path of pty.fork(). *

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

Xavier de Gaye added the comment: I have left some comments on Rietveld after a partial code review. IMO for reasons of repeatability and easier maintenance [1], all the tests should be run with the pty set in a known mode, whether canonical or raw, and a test involving pty.spawn() should

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

Martin Panter added the comment: Can you explain your broken pipe situation? Are you talking about a real-world EPIPE operating on a pseudoterminal, or just a result of using a Unix socket to emulate a PTY in the tests? Usually a broken pipe is an asynchronous condition. You cannot predict

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

Changes by STINNER Victor : -- nosy: -haypo ___ Python tracker ___ ___

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

Cornelius Diekmann added the comment: Dear Martin, now I understand your intention. I merged my test suite with Chris's fix and documented our insights. SmallPtyTests contains regression tests for this issue. While testing, I found a subtle change in behavior introduced by Chris's patch: It

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

Martin Panter added the comment: I would prefer to commit Chris’s fix for BSDs (Issue 26228) with a regression test. I can explain in the commit message who contributed to which part, or do two separate commits if you prefer. But the point is to add the test with the fix. I’m not going to

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

Cornelius Diekmann added the comment: Thank you Martin very much for this very helpful review. I updated and simplified the tests and implemented your suggestions. There are three open issues left. 1) > It looks like you depend on fixing Issue 26228, but the patch there will > conflict with

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

Martin Panter added the comment: Ignore my comment about contrib agreement, that must have come through recently :) -- ___ Python tracker ___

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

Martin Panter added the comment: Hi Cornelius and thanks for the work. Since the patch adds a significant amount of code, I think you might have to sign the contributor agreement: . You can do it in a web browser. I would like to review your

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

Cornelius Diekmann added the comment: I did a larger update to my proposed patch. I read the pty man pages and posix standard and designed a test suite which documents the expected behavior of the pty module. The test suite is biased towards my Linux system, but I respect the posix standard.

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

Changes by Berker Peksag : -- components: -Cross-Build stage: -> patch review versions: +Python 3.6 ___ Python tracker ___

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

New submission from Cornelius Diekmann: As Martin Panter noted, "it doesn’t look like pty.spawn() is tested at all" [issue26228]. So I wrote some very basic integration tests for pty.spawn. They work perfectly on my Linux machine. Line 4 of the library module under test (pty.py) states: "Only