[issue1346874] httplib simply ignores CONTINUE

Change by Mattias Amnefelt : -- nosy: +Mattias Amnefelt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1346874] httplib simply ignores CONTINUE

Change by Terry J. Reedy : -- nosy: -terry.reedy versions: -Python 2.7, Python 3.1, Python 3.2 ___ Python tracker ___ ___

[issue1346874] httplib simply ignores CONTINUE

Tim B added the comment: I've created a PR to potentially implement this in 3.9. Please take a look and review/test, if this issue is still relevant to you. -- nosy: +tbartlett0 ___ Python tracker

[issue1346874] httplib simply ignores CONTINUE

Change by Tim B : -- versions: +Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1346874] httplib simply ignores CONTINUE

Change by Tim B : -- pull_requests: +14665 pull_request: https://github.com/python/cpython/pull/14880 ___ Python tracker ___ ___

[issue1346874] httplib simply ignores CONTINUE

Changes by Georg Sauthoff : -- nosy: +gms ___ Python tracker ___ ___ Python-bugs-list

[issue1346874] httplib simply ignores CONTINUE

Patrick J McNerthney added the comment: "(though I don’t understand why Apache doesn’t renegotiate while the request body is being sent)" Apache does attempt to do this, but HttpsConnection is immediately sending the body of the request as fast as the socket will allow, which fills up the

[issue1346874] httplib simply ignores CONTINUE

Martin Panter added the comment: Thankyou, I think I understand your situation better now (though I don’t understand why Apache doesn’t renegotiate while the request body is being sent). I would still argue that this is a new feature to be added rather than a bug though, and should only go

[issue1346874] httplib simply ignores CONTINUE

Martin Panter added the comment: Patrick, can you elaborate on the problem with Apache and renegotiation? How does the 100-continue request, or anticipating the 100 response, help? Perhaps Issue 25919 is relevant in this case, where we want the client to receive an error response before the

[issue1346874] httplib simply ignores CONTINUE

Patrick J McNerthney added the comment: I believe this is actually a bug, because it causes the posting of messages whose length is greater then the Apache HTTPD SSLRenegBufferSize setting to fail, whereas other http clients that first wait to receive the 100 response before sending the body

[issue1346874] httplib simply ignores CONTINUE

Martin Panter added the comment: This seems more like a new feature than a bug fix to me. Currently the behaviour is the same whether “Expect: 100-continue” is requested or not. According to https://tools.ietf.org/html/rfc7231#page-35, the client does not have to wait any specific length of

[issue1346874] httplib simply ignores CONTINUE

André Cruz an...@cabine.org added the comment: Attached is an updated patch against 2.7.3. It solves a bug in the tests and implements Carl's suggestion. The new tests pass and it updates the documentation as well. As for inclusion in 2.7, as this is in fact solving a bug, I would vote for

[issue1346874] httplib simply ignores CONTINUE

André Cruz an...@cabine.org added the comment: Can anyone confirm what is missing for this patch to be committed? Is it just test and documentation changes or is something wrong with the code changes as well? -- nosy: +edevil ___ Python tracker

[issue1346874] httplib simply ignores CONTINUE

Carl Nobile carl.nob...@gmail.com added the comment: I was told some time ago that it was documentation changes. And, if I remember correctly CONTINUE (100) was not ignored, it was actually broken. Data was being read from stdin when a CONTINUE was received and this should never happen based on

[issue1346874] httplib simply ignores CONTINUE

André Cruz an...@cabine.org added the comment: As far as I can see, the patch does add some documentation changes. What exactly is missing? As for the bug, if I understood correctly, what you are saying is that when ignore_continue is True, and the server sends a 100 Continue response, the

[issue1346874] httplib simply ignores CONTINUE

Carl Nobile carl.nob...@gmail.com added the comment: Yes, exactly. I was not the one who posted the original bug report, but I found it when I ran into the same problem. I was not exactly sure if the original poster had the same issues as I had. I do know that my fix to the code eliminated some

[issue1346874] httplib simply ignores CONTINUE

André Cruz an...@cabine.org added the comment: Carl: that would be great. Do you use it regularly? Any other problems? Python devs: can anyone confirm me what still needs to be done so that this patch can be considered for merging into trunk? Thanks. --

[issue1346874] httplib simply ignores CONTINUE

Senthil Kumaran sent...@uthcode.com added the comment: The patch seems good. I apologize that this has been sitting stale for a long time. Since this is a new feature, I am not sure if putting to 3.3 might be a good idea. This is a feature for httplib, so it may not make it to 2.7.x, but can

[issue1346874] httplib simply ignores CONTINUE

Carl Nobile carl.nob...@gmail.com added the comment: André, As I said I'm not sure if I am fixing the same thing that this bug was originally posted for. However, after looking at my code I realized that I just did a quick work around for my situation and it shouldn't be put into any python

[issue1346874] httplib simply ignores CONTINUE

Changes by Nikolaus Rath nikol...@rath.org: -- nosy: +Nikratio ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1346874 ___ ___ Python-bugs-list

[issue1346874] httplib simply ignores CONTINUE

Terry J. Reedy tjre...@udel.edu added the comment: Carl, anyone is free to submit an incomplete patch, and people often do, but if people who are affected by an issue do not think it worth their time to complete it, or even move it along, there is no reason to expect people who are not

[issue1346874] httplib simply ignores CONTINUE

Carl Nobile carl.nob...@gmail.com added the comment: I have run into this same issue. It does violate RFC2616 in section 4.3 All 1xx (informational), 204 (no content), and 304 (not modified) responses MUST NOT include a message-body. All other responses do include a message-body, although it

[issue1346874] httplib simply ignores CONTINUE

Changes by Éric Araujo mer...@netwok.org: -- assignee: - orsenthil nosy: +orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1346874 ___ ___

[issue1346874] httplib simply ignores CONTINUE

Changes by Mark Lawrence breamore...@yahoo.co.uk: -- stage: - patch review type: - behavior versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1346874

[issue1346874] httplib simply ignores CONTINUE

Rick Harris [EMAIL PROTECTED] added the comment: I'm implemented the behavior described by Mike above with a patch to 2.6. The patch will raise an ExpectationFailed before sending the body if the server responds with a 417 (Expectation Failed). This patch should only modify behavior for