[issue1529353] Squeezer - squeeze large output in IDLE's shell

[miss-islington]

miss-islington  added the comment:


New changeset 69ab28d2a616ae0234b6e412a979400523b2a6d9 by Miss Islington (bot) 
in branch '3.6':
bpo-1529353: Explain Shell text squeezing in the IDLE doc. (GH-10169)
https://github.com/python/cpython/commit/69ab28d2a616ae0234b6e412a979400523b2a6d9


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[miss-islington]

miss-islington  added the comment:


New changeset 8dccb00c197e7b4f6ce65950a9ed6802fa217094 by Miss Islington (bot) 
in branch '3.7':
bpo-1529353: Explain Shell text squeezing in the IDLE doc. (GH-10169)
https://github.com/python/cpython/commit/8dccb00c197e7b4f6ce65950a9ed6802fa217094


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[miss-islington]

Change by miss-islington :


--
pull_requests: +9503

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[miss-islington]

Change by miss-islington :


--
pull_requests: +9502

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset 68d6dc0770288075504635a8e42696070823fd69 by Terry Jan Reedy in 
branch 'master':
bpo-1529353: Explain Shell text squeezing in the IDLE doc. (#10169)
https://github.com/python/cpython/commit/68d6dc0770288075504635a8e42696070823fd69


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Terry J. Reedy]

Change by Terry J. Reedy :


--
pull_requests: +9493

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Yes. Congratulations on your persistence.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Tal Einat]

Tal Einat  added the comment:

ISTM that this issue can finally be closed!

Followup on some remaining minor points brought up here, such as colors and 
squeezing of multiple output lines printed separately, could be done in 
separate issues or discussed on idle-dev.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset fdcb5ae25c0b5c82a32955617d253810ef110cac by Terry Jan Reedy in 
branch 'master':
bpo-1529353: IDLE - Squeezer What's New for 3.8 (#9572)
https://github.com/python/cpython/commit/fdcb5ae25c0b5c82a32955617d253810ef110cac


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Terry J. Reedy]

Terry J. Reedy  added the comment:

See my 3.6/3.7 patches for how I now handle new-in-maintenance-release 
user-visible features in What's New.  Note that there are similar entries for 
Python at the bottom of the file.

If I were not rushing, I would have mentioned user colors in text view.  But 
that is minor and I will add one entry for colors and font sizes in both text 
and help views when done.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Terry J. Reedy]

Change by Terry J. Reedy :


--
pull_requests: +8974

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[miss-islington]

miss-islington  added the comment:


New changeset 3637e68d7c92eda0b80e6ab3f58610e1cfb4f1d8 by Miss Islington (bot) 
in branch '3.7':
bpo-1529353: IDLE - Squeezer What's New for 3.7.1 (GH-9568)
https://github.com/python/cpython/commit/3637e68d7c92eda0b80e6ab3f58610e1cfb4f1d8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[miss-islington]

miss-islington  added the comment:


New changeset 92ad2612bef198f2e3f8f09bf552189e27afcc4e by Miss Islington (bot) 
in branch '3.7':
bpo-1529353: IDLE: Squeezer What's New for 3.6.7 (GH-9567)
https://github.com/python/cpython/commit/92ad2612bef198f2e3f8f09bf552189e27afcc4e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[miss-islington]

miss-islington  added the comment:


New changeset 98c8236cc75529407e305f26de95d9e72a72a0eb by Miss Islington (bot) 
in branch '3.6':
bpo-1529353: IDLE: Squeezer What's New for 3.6.7 (GH-9567)
https://github.com/python/cpython/commit/98c8236cc75529407e305f26de95d9e72a72a0eb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[miss-islington]

Change by miss-islington :


--
pull_requests: +8973

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset ea718d377db3941ecfc86288a3465fce653cc682 by Terry Jan Reedy in 
branch 'master':
bpo-1529353: IDLE - Squeezer What's New for 3.7.1 (#9568)
https://github.com/python/cpython/commit/ea718d377db3941ecfc86288a3465fce653cc682


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[miss-islington]

Change by miss-islington :


--
pull_requests: +8972

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[miss-islington]

Change by miss-islington :


--
pull_requests: +8971

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset dac712d51667227ce3862fc61be6a8094b1066fa by Terry Jan Reedy in 
branch 'master':
bpo-1529353: IDLE: Squeezer What's New for 3.6.7 (#9567)
https://github.com/python/cpython/commit/dac712d51667227ce3862fc61be6a8094b1066fa


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Terry J. Reedy]

Change by Terry J. Reedy :


--
pull_requests: +8970

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Terry J. Reedy]

Change by Terry J. Reedy :


--
pull_requests: +8969

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[miss-islington]

miss-islington  added the comment:


New changeset 0b3e1208033aa1eb5452afe9387f86f299ef24e5 by Miss Islington (bot) 
in branch '3.6':
bpo-1529353: IDLE: squeeze large output in the shell (GH-7626)
https://github.com/python/cpython/commit/0b3e1208033aa1eb5452afe9387f86f299ef24e5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[miss-islington]

miss-islington  added the comment:


New changeset 321f28c5f4b7361fa1b6330697b28481b4565ec8 by Miss Islington (bot) 
in branch '3.7':
bpo-1529353: IDLE: squeeze large output in the shell (GH-7626)
https://github.com/python/cpython/commit/321f28c5f4b7361fa1b6330697b28481b4565ec8


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[miss-islington]

Change by miss-islington :


--
pull_requests: +8963

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[miss-islington]

Change by miss-islington :


--
pull_requests: +8964

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Tal Einat]

Tal Einat  added the comment:


New changeset 604e7b9931f9e7881a2941816e538f5f15930db8 by Tal Einat in branch 
'master':
bpo-1529353: IDLE: squeeze large output in the shell (GH-7626)
https://github.com/python/cpython/commit/604e7b9931f9e7881a2941816e538f5f15930db8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Tal Einat]

Tal Einat  added the comment:

This seems like it would need a "What's New" entry.

How does this work with IDLE re. new features being backported?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Tal Einat]

Tal Einat  added the comment:

Working on getting this in now. Just in time, it seems.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Tal, if you think this is ready, I would like to get this in the upcoming 
releases.  I believe the deadline is midnight at the international dateline, 
which is noon UTC tomorrow, just over 9 hours from now. 

I decided that any suggestions I might have for the non-user-visible aspects of 
squeezer.py and test_squeezer.py can wait for later.  The best review of 
user-visible aspects will come from using it.

A second use of squeezer should be debugger's global and non-global('local') 
namespace displays.  The intended format is one name-value pair per line.  But 
values can be indefinitely large.  For this, we could skip the context menu 
(there is not one now), use a fixed trigger of n characters, and have 
double-click display to a popup Squeezer View.

I will come back to this in a couple of hours to see if you have responded.  I 
would write and merge a separate expanded news entry for idlelib/NEWS.txt.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Tal Einat]

Tal Einat  added the comment:

The PR is ready for another review.

ISTM it should be good to go, after have addressing all of the significant 
issues brought up in the discussion here.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Tal Einat]

Tal Einat  added the comment:

> 1. Yes.  Always show.  Fix delay at 80 until we decide on something better.

Done.

> 2. No.  Max should be enough.

Done.

> I once printed over 500_000 short lines to see if scrolling remained 
> responsive.  It did.  I could have set min to 1_000_000 for that experiment.  
> Am I correct in presuming that only one block of output, between code imputs, 
> can be squeezed?

Indeed.

> 3. No, if not gone already.  I don't want to proliferate keyboard shortcuts, 
> at least not until we get rid of some that must be nearly unused.

Done.

> 4. Maybe  chars would be better.

I'm still not sure, that just leads to very large numbers, where it's hard to 
judge what is excessive, e.g., "is 100,000 chars too much"?  With lines, I feel 
it is more obvious: "1,000 lines? That's way too much!"

> The viewer does not wrap.  I think it should as there is now no way to see 
> entire line.  Or it needs a scrollbar.

Wrapping is the major cause of the text widget slowing down, which is why I've 
made the viewer support controlling the wrapping mode, and made Squeezer use no 
wrapping.  I've now added a horizontal scrollbar, and also made the scrollbars 
in the viewer appear only when needed.  Now, scrolling horizontally with very 
long lines is still slow, but at least just the viewer is affected.

> Viewer is modal, but does it need to be?

No, good catch, changed to non-modal.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I partly answered questions already.

1. Yes.  Always show.  Fix delay at 80 until we decide on something better.

2. No.  Max should be enough.  I once printed over 500_000 short lines to see 
if scrolling remained responsive.  It did.  I could have set min to 1_000_000 
for that experiment.  Am I correct in presuming that only one block of output, 
between code imputs, can be squeezed?

Converting extensions to features mostly removed the option to omit features.

3. No, if not gone already.  I don't want to proliferate keyboard shortcuts, at 
least not until we get rid of some that must be nearly unused.

I want to make revising the use of keys within output blocks a separate issue.

4. Maybe  chars would be better.

'a'*1000 currently wraps to 13 80-char lines.  (This would change if we add 
horizontal scrollbar, as has been requested.)  The viewer does not wrap.  I 
think it should as there is now no way to see entire line.  Or it needs a 
scrollbar.  Viewer is modal, but does it need to be?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Tal Einat]

Tal Einat  added the comment:

I've gone ahead and addressed all of the significant issues raised here:

* Squeezer is no longer an extension
* Expanding problematically large outputs prompts the user for confirmation
* "copy" and "view" moved to a right-click context menu
* use IDLE's TextView for viewing squeezed outputs
  * I added the ability to set the text wrapping
* default minimum # lines for auto-squeezing increased to 50

I've also updated all of the tests accordingly and added a few.

There a several tweaks to consider, including those mentioned in my previous 
message, plus colors and key bindings.

This is now ready for another review!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1529353] Squeezer - squeeze large output in IDLE's shell

[Tal Einat]

Change by Tal Einat :


--
title: Squeezer - squeeze large output in IDLE -> Squeezer - squeeze large 
output in IDLE's shell

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com