[issue19217] Calling assertEquals for moderately long list takes too long

Change by Alex Waygood : -- keywords: -easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19217] Calling assertEquals for moderately long list takes too long

Jack DeVries added the comment: Hey all, I'm putting a ping on this issue. I think my fix is ready to merge, see GH-27434. Thanks for all the feedback on the PR so far! -- ___ Python tracker

[issue19217] Calling assertEquals for moderately long list takes too long

Change by Jack DeVries : -- pull_requests: +25963 pull_request: https://github.com/python/cpython/pull/27434 ___ Python tracker ___

[issue19217] Calling assertEquals for moderately long list takes too long

Jack DeVries added the comment: I'm going to go ahead and submit my PR under the assumption that Lukasz will probably prefer to actually be able to review it when he takes a look at this, and additionally we haven't heard from @eamanu. @eamanu, I'll close it if you would like to continue;

[issue19217] Calling assertEquals for moderately long list takes too long

Terry J. Reedy added the comment: Lukasz, perhaps you can finish this. Too many assistent cooks and no chief cook. At least tell Jack (above) whether to submit his PR. -- nosy: +lukasz.langa, terry.reedy versions: +Python 3.11 -Python 3.6, Python 3.7, Python 3.8, Python 3.9

[issue19217] Calling assertEquals for moderately long list takes too long

Jack DeVries added the comment: Hi all! @eamanu, I went ahead and picked up where you left off. I stopped short of opening up a PR, because I don't want to step on any toes, but I definitely want to do what I can to give this bpo one final shove over the finish line. Despite not creating a

[issue19217] Calling assertEquals for moderately long list takes too long

Change by Zachary Ware : -- hgrepos: -401 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19217] Calling assertEquals for moderately long list takes too long

Change by Kadir SELÇUK : -- hgrepos: +401 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19217] Calling assertEquals for moderately long list takes too long

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19217] Calling assertEquals for moderately long list takes too long

Trey Hunner added the comment: This is a bug for string comparisons as well. I just had to manually reimplement assertMultiLineEqual (which doesn't call assertSequenceEqual) on one of my test classes to workaround this issue. -- nosy: +trey versions: +Python 3.7, Python 3.8, Python

[issue19217] Calling assertEquals for moderately long list takes too long

Change by Emmanuel Arias : -- pull_requests: +10441 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19217] Calling assertEquals for moderately long list takes too long

Emmanuel Arias added the comment: I create this patch on 3.7 -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19217] Calling assertEquals for moderately long list takes too long

Emmanuel Arias added the comment: Hi! I see that this issue have a pr (https://github.com/python/cpython/pull/10034) opened 20 days ago. So, I want to continue work on this (my first pr). I use the vstinner's patch and I make two little change (attached patch): 1) first I add the

[issue19217] Calling assertEquals for moderately long list takes too long

Change by Srinivas Reddy Thatiparthy : -- pull_requests: +9372 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19217] Calling assertEquals for moderately long list takes too long

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19217] Calling assertEquals for moderately long list takes too long

STINNER Victor added the comment: unittest_unified_diff.patch: Rebased patch for the default branch. My patch updates also unit tests. The patch changes the test output. If we decide to apply the patch, I propose to only apply it to the default branch (Python 3.7). The bug report is about a

[issue19217] Calling assertEquals for moderately long list takes too long

Changes by STINNER Victor : Added file: http://bugs.python.org/file46574/unified_diff.py ___ Python tracker ___

[issue19217] Calling assertEquals for moderately long list takes too long

Changes by Ezio Melotti : -- keywords: +needs review ___ Python tracker ___ ___

[issue19217] Calling assertEquals for moderately long list takes too long

Eric Lafontaine added the comment: Hi all, What do we do with this ticket? Patch were provided, People have agreed (I think). So what's missing to close it (or pass to the next step)? It's going to be a year that a high priority ticket has no update and I would like to accelerate it if I

[issue19217] Calling assertEquals for moderately long list takes too long

Changes by Zachary Ware : -- hgrepos: -338 ___ Python tracker ___ ___

[issue19217] Calling assertEquals for moderately long list takes too long

Changes by Berker Peksag : -- Removed message: http://bugs.python.org/msg263252 ___ Python tracker ___

[issue19217] Calling assertEquals for moderately long list takes too long

Changes by Berker Peksag : -- components: -Build, Documentation, Unicode, Windows, XML nosy: -supriyanto maftuh, supriyantomaftuh versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5 ___ Python tracker

[issue19217] Calling assertEquals for moderately long list takes too long

supriyanto maftuh,st added the comment: Hy easy patch with editing maintenance by supriyanto maftuh -- components: +Build, Documentation, Unicode, Windows, XML hgrepos: +338 nosy: +paul.moore, steve.dower, supriyanto maftuh, supriyanto maftuh,st, tim.golden, zach.ware versions: +Python

[issue19217] Calling assertEquals for moderately long list takes too long

Robert Collins added the comment: The new output seems ok to me? -- ___ Python tracker ___ ___

[issue19217] Calling assertEquals for moderately long list takes too long

Chris AtLee added the comment: Switching this to unified_diff allows the test case to finish nearly instantly. The downside is that the output is changed in the case of a difference found: FF == FAIL: test_compare

[issue19217] Calling assertEquals for moderately long list takes too long

Changes by Chris AtLee : Added file: http://bugs.python.org/file41824/cpython-issue19217.diff ___ Python tracker ___

[issue19217] Calling assertEquals for moderately long list takes too long

Changes by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___

[issue19217] Calling assertEquals for moderately long list takes too long

Changes by Ivan Levkivskyi levkivs...@gmail.com: -- nosy: +levkivskyi ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19217 ___ ___ Python-bugs-list

[issue19217] Calling assertEquals for moderately long list takes too long

Robert Collins added the comment: A few thoughts. Adding a new public symbol seems inappropriate here: this is a performance issue that is well predictable and we should cater for that (given difflibs current performance). I'll note in passing that both bzr and hg have much higher

[issue19217] Calling assertEquals for moderately long list takes too long

Robert Collins added the comment: Oh, I got a profile from the test case for my own interest. 6615 seconds .. some highlights that jumped out at me 200010.1270.000 6610.0250.330 difflib.py:868(compare) which means we're basically using ndiff, which is cubic rather than

[issue19217] Calling assertEquals for moderately long list takes too long

Serhiy Storchaka added the comment: Here is alternative patch. It outputs line diff even for large sequences/dicts/strings. With the attached patch, unittest_scse.py works fine, producing this output: FF == FAIL: test_compare

[issue19217] Calling assertEquals for moderately long list takes too long

Serhiy Storchaka added the comment: Thanks for your comments Ezio. Yes, this patch is rather only a demo. Sorry, but I'm not very interesting in completing this patch (at least not right now). I only want to see more detailed error reports. There are some ideas about improving diffs

[issue19217] Calling assertEquals for moderately long list takes too long

Ezio Melotti added the comment: I thought some more about this, and I think we can do better. Since _diffThreshold only affects strings, the goal of this issue is to extend the check to other types. Instead of doing this by adding more attributes and behaviors, I would like to keep things

[issue19217] Calling assertEquals for moderately long list takes too long

Serhiy Storchaka added the comment: 1) try to have a single threshold for all types, and use line-based counting for strings (so if the threshold is 32, this means 32 elements in a list, 32 items in a dict, 32 lines in a string); You forgot about strings with few but very long lines. We

[issue19217] Calling assertEquals for moderately long list takes too long

Elena Oat added the comment: Attached is the patch that tries to solve the issue for the strings, tuples, lists and dictionaries. Tuples, lists and dictionaries use the same value for the threshold. There's a helper method in the tests that is generic to all mentioned types. This issue was

[issue19217] Calling assertEquals for moderately long list takes too long

Ezio Melotti added the comment: Thanks Puneeth for the initial tests and Elena for expanding the fix and the tests to cover assertDictEqual too. I reworked a bit Elena's patch to make the checks in case.py more consistent and simplified the tests. With the attached patch, unittest_scse.py

[issue19217] Calling assertEquals for moderately long list takes too long

Puneeth Chaganti added the comment: Hi, The attached patch is an attempt to write tests for this issue, and get all the tests passing. Since a new threshold has been introduced, `maxDiff` doesn't always make a difference and this required changing the `testAssertSequenceEqualMaxDiff`

[issue19217] Calling assertEquals for moderately long list takes too long

Changes by Ankur Ankan ankuran...@gmail.com: -- nosy: +ankurankan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19217 ___ ___ Python-bugs-list

[issue19217] Calling assertEquals for moderately long list takes too long

Changes by Ankur Ankan ankuran...@gmail.com: -- nosy: +Ankur.Ankan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19217 ___ ___ Python-bugs-list

[issue19217] Calling assertEquals for moderately long list takes too long

Ezio Melotti added the comment: I don't think I will have time for this for a while, so if anyone wants to provide tests they are welcomed to do it. The related #11763 already has some tests, so those might be adapted for this issue. -- keywords: +easy stage: patch review - test

[issue19217] Calling assertEquals for moderately long list takes too long

Antoine Pitrou added the comment: Ezio, do you intend to add a test to your patch? -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19217 ___

[issue19217] Calling assertEquals for moderately long list takes too long

Nina Zakharenko added the comment: The cause of this has been identified as a bug in libdiff.compare(). See issue 21253 for more information. -- nosy: +nnja ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19217

[issue19217] Calling assertEquals for moderately long list takes too long

Jacek Bzdak added the comment: The patch works for me, thanks Ezio! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19217 ___ ___

[issue19217] Calling assertEquals for moderately long list takes too long

Michael Foord added the comment: pprint is also likely to have performance issues. I agree with Ezio that a diff consisting of more than 30(x2) lines is not likely to be directly useful anyway. A test for the changed behaviour would be nice. --

[issue19217] Calling assertEquals for moderately long list takes too long

Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- priority: normal - high ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19217 ___ ___

[issue19217] Calling assertEquals for moderately long list takes too long

Serhiy Storchaka added the comment: Perhaps a combination of len(pprint.pformat(seq1).splitlines()) and len(pprint.pformat(seq2).splitlines()) (minimum, maximum or production) is better metric? -- ___ Python tracker rep...@bugs.python.org

[issue19217] Calling assertEquals for moderately long list takes too long

Ezio Melotti added the comment: Here's a proof of concept to fix the issue (still lacks tests and breaks one existing test). The problem is that assertSequenceEqual computes the diff regardless of the size of the sequences, and then truncates it if it's too long. Producing the diff takes

[issue19217] Calling assertEquals for moderately long list takes too long

Michael Foord added the comment: Ouch. Looking. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19217 ___ ___ Python-bugs-list mailing list

[issue19217] Calling assertEquals for moderately long list takes too long

Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19217 ___ ___ Python-bugs-list

[issue19217] Calling assertEquals for moderately long list takes too long

New submission from Jacek Bzdak: Call to assertEquals(list1, list2) does not finish (takes more than couple of minutes), for lists that containt 1 elements if all list elements are different. The same call in python2.6 finishes instanteneously. This occours even if error message is

[issue19217] Calling assertEquals for moderately long list takes too long

Jacek Bzdak added the comment: I have attached a simple test case. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19217 ___ ___ Python-bugs-list

[issue19217] Calling assertEquals for moderately long list takes too long

Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti, michael.foord stage: - needs patch versions: +Python 3.4 -Python 3.1, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19217

[issue19217] Calling assertEquals for moderately long list takes too long

Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19217 ___ ___

[issue19217] Calling assertEquals for moderately long list takes too long

Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- assignee: - michael.foord ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19217 ___