[issue30039] Resuming a 'yield from' stack is broken if a signal arrives in the middle

STINNER Victor added the comment: Yury Selivanov added the comment: > I don't think we need to. Isn't 3.5 is in security/important bug fix mode? I > don't view this change as an important one (it's just a nice thing to have). Not yet, it still accept bug fixes:

[issue30039] Resuming a 'yield from' stack is broken if a signal arrives in the middle

Yury Selivanov added the comment: I don't think we need to. Isn't 3.5 is in security/important bug fix mode? I don't view this change as an important one (it's just a nice thing to have). -- ___ Python tracker

[issue30039] Resuming a 'yield from' stack is broken if a signal arrives in the middle

STINNER Victor added the comment: Why not backporting the fix to 3.5 as well? -- ___ Python tracker ___ ___

[issue30039] Resuming a 'yield from' stack is broken if a signal arrives in the middle

Changes by Yury Selivanov : -- resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior ___ Python tracker

[issue30039] Resuming a 'yield from' stack is broken if a signal arrives in the middle

Yury Selivanov added the comment: New changeset e89f95bfd0881a9b80c3b1430d154a77bdf5a824 by Yury Selivanov in branch '3.6': [3.6] bpo-30039: Don't run signal handlers while resuming a yield from stack (GH-1081) (#1640)

[issue30039] Resuming a 'yield from' stack is broken if a signal arrives in the middle

Changes by Yury Selivanov : -- pull_requests: +1735 ___ Python tracker ___ ___

[issue30039] Resuming a 'yield from' stack is broken if a signal arrives in the middle

Yury Selivanov added the comment: Yes, I'll do the backport. -- ___ Python tracker ___ ___ Python-bugs-list

[issue30039] Resuming a 'yield from' stack is broken if a signal arrives in the middle

STINNER Victor added the comment: The change should be backported to 3.5 and 3.6, right? The change seems very short and safe. IMHO it's ok to backport. -- nosy: +haypo ___ Python tracker

[issue30039] Resuming a 'yield from' stack is broken if a signal arrives in the middle

Yury Selivanov added the comment: New changeset ab4413a7e9bda95b6fcd517073e2a51dafaa1624 by Yury Selivanov (Nathaniel J. Smith) in branch 'master': bpo-30039: Don't run signal handlers while resuming a yield from stack (#1081)

[issue30039] Resuming a 'yield from' stack is broken if a signal arrives in the middle

Changes by Mariatta Wijaya : -- assignee: -> yselivanov ___ Python tracker ___

[issue30039] Resuming a 'yield from' stack is broken if a signal arrives in the middle

Changes by Nathaniel Smith : -- pull_requests: +1224 ___ Python tracker ___ ___

[issue30039] Resuming a 'yield from' stack is broken if a signal arrives in the middle

New submission from Nathaniel Smith: If we have a chain of generators/coroutines that are 'yield from'ing each other, then resuming the stack works like: - call send() on the outermost generator - this enters _PyEval_EvalFrameDefault, which re-executes the YIELD_FROM opcode - which calls