[issue40422] Light refactor: create a common _Py_closerange API

STINNER Victor added the comment: Thanks Kyle Evans! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -Python 3.9 ___ Python tracker

[issue40422] Light refactor: create a common _Py_closerange API

STINNER Victor added the comment: New changeset 7992579cd27f14f472acc37aca537eec55f681ef by Kyle Evans in branch 'master': bpo-40422: Move _Py_closerange to fileutils.c (GH-22680) https://github.com/python/cpython/commit/7992579cd27f14f472acc37aca537eec55f681ef --

[issue40422] Light refactor: create a common _Py_closerange API

Change by Kyle Evans : -- pull_requests: +21651 pull_request: https://github.com/python/cpython/pull/22680 ___ Python tracker ___

[issue40422] Light refactor: create a common _Py_closerange API

Gregory P. Smith added the comment: New changeset 64eb259cc1e42a5f74b5911a518d2c50daa8d50b by Kyle Evans in branch 'master': bpo-40422: Move _Py_*_SUPPRESS_IPH bits into _Py_closerange (GH-22672) https://github.com/python/cpython/commit/64eb259cc1e42a5f74b5911a518d2c50daa8d50b --

[issue40422] Light refactor: create a common _Py_closerange API

Change by Kyle Evans : -- pull_requests: +21646 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/22672 ___ Python tracker ___

[issue40422] Light refactor: create a common _Py_closerange API

Kyle Evans added the comment: Excellent, thank you. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40422] Light refactor: create a common _Py_closerange API

Gregory P. Smith added the comment: Just reuse this bpo issue. I'll mark the PRs as "skip news"; don't worry about a new news blurb entry as it's all tied to the original one. -- status: closed -> open ___ Python tracker

[issue40422] Light refactor: create a common _Py_closerange API

Kyle Evans added the comment: Would you like that on a distinct issue, or is it ok to reuse this BPO since it's a location improvement of an API just introduced? I've got a local branch now that: 1. moves the suppress IPH stuff into _Py_closerange 2. moves the definition into

[issue40422] Light refactor: create a common _Py_closerange API

STINNER Victor added the comment: Python/fileutils.c might be a better home for such helper function. You might move _Py_BEGIN_SUPPRESS_IPH / _Py_END_SUPPRESS_IPH macros into _Py_closerange(), even if currently it makes no diffence. (_Py_BEGIN_SUPPRESS_IPH is specific to Windows,

[issue40422] Light refactor: create a common _Py_closerange API

Change by Gregory P. Smith : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue40422] Light refactor: create a common _Py_closerange API

miss-islington added the comment: New changeset c230fde8475e4e5581e74a4235654d17ccf4cff8 by Kyle Evans in branch 'master': bpo-40422: create a common _Py_closerange API (GH-19754) https://github.com/python/cpython/commit/c230fde8475e4e5581e74a4235654d17ccf4cff8 -- nosy:

[issue40422] Light refactor: create a common _Py_closerange API

Change by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list

[issue40422] Light refactor: create a common _Py_closerange API

Change by STINNER Victor : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40422] Light refactor: create a common _Py_closerange API

Change by Kyle Evans : -- keywords: +patch nosy: +kevans nosy_count: 1.0 -> 2.0 pull_requests: +19075 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19754 ___ Python tracker

[issue40422] Light refactor: create a common _Py_closerange API

New submission from Kyle Evans : Such an API can be used for both os.closerange and subprocess, re-using much of os_closerange_impl. Pull request enroute. -- components: C API messages: 367530 nosy: kevans91 priority: normal severity: normal status: open title: Light refactor: create