Antoine Pitrou pit...@free.fr added the comment:
This has been fixed as part of the big IO update in trunk. I assume
nobody really cares about making a separate patch for 2.6, please
re-open if you are interested!
--
resolution: accepted - fixed
status: open - closed
Antoine Pitrou pit...@free.fr added the comment:
Since it is solved for 3.x and only needs to be bacported to 2.x (where
the io module isn't the default), downgrading to critical.
--
nosy: +pitrou
priority: release blocker - critical
___
Python
Changes by Martin v. Löwis mar...@v.loewis.de:
--
priority: deferred blocker - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4533
___
Changes by Martin v. Löwis [EMAIL PROTECTED]:
--
priority: release blocker - deferred blocker
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4533
___
Christian Heimes [EMAIL PROTECTED] added the comment:
This needs definitely some testing!
--
components: +Extension Modules
nosy: +christian.heimes
priority: - release blocker
stage: - test needed
versions: +Python 3.1
___
Python tracker [EMAIL
Christian Heimes [EMAIL PROTECTED] added the comment:
The small buffer size in Modules/_fileio.c is one reason for the slowness.
$ dd if=/dev/zero of=zeros bs=1MB count=50
$ cat testread.py
open(zeros, rb).read()
$ ./python -m cProfile testread.py
40 function calls (39 primitive calls)
Christian Heimes [EMAIL PROTECTED] added the comment:
The fileio_buffer.patch implements the same progressive buffer as Python
2.x' Object/fileobject.c.
--
keywords: +patch
stage: test needed - patch review
Added file: http://bugs.python.org/file12227/fileio_buffer.patch
Gregory P. Smith [EMAIL PROTECTED] added the comment:
patch looks good to me.
nitpick comments: use += instead of = and + in:
newsize = newsize + newsize
and
newsize = newsize + BIGCHUNK.
As for the XXX about overflow, so long as BUFSIZ is not defined to be an
insanely large number (it
Christian Heimes [EMAIL PROTECTED] added the comment:
The preprocessor doesn't handle power. 2 24 (64MB) sounds sufficient
for me.
Added file: http://bugs.python.org/file12228/fileio_buffer2.patch
___
Python tracker [EMAIL PROTECTED]
Gregory P. Smith [EMAIL PROTECTED] added the comment:
fileio_buffer2.patch looks good other than minor touchups:
Turn the XXX comment into:
/* NOTE: overflow impossible due to limits on BUFSIZ *
Also, 2 24 is 32MB yet your error message test says = 64MB. I think
you meant 1 26.
fix those
10 matches
Mail list logo
