Hynek Schlawack h...@ox.cx added the comment:
Oh sorry, I didn't look into the doc patch.
I unified both into one patch and added the versionchanged tag and also updated
the docstring of shutil.move.
--
Added file: http://bugs.python.org/file24149/shutil_move_symlinks.patch
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 1ea8b7233fd7 by Antoine Pitrou in branch 'default':
Issue #9993: When the source and destination are on different filesystems,
http://hg.python.org/cpython/rev/1ea8b7233fd7
--
nosy: +python-dev
Antoine Pitrou pit...@free.fr added the comment:
Patch now committed to 3.3. Thank you Jonathan and Hynek!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Hynek Schlawack h...@ox.cx added the comment:
I took the liberty to fix the tests.
Basically I've adapted them to the new mock based cross file system approach
(that doesn't depend on luck anymore :)).
I also had to add one more `os.path.realpath` because on some OS (like OS X)
the tmp
Antoine Pitrou pit...@free.fr added the comment:
Thanks! I think we also need a doc update for the change in behaviour (with a
versionchanged tag).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9993
Éric Araujo mer...@netwok.org added the comment:
Antoine, would you mind taking this one?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9993
___
Antoine Pitrou pit...@free.fr added the comment:
Ow, I'm sorry for overlooking this. I thought you would take it.
Unfortunately the patch is now broken because of 5b61334bb776.
(technically it applies, but the tests don't run anymore because the other
filesystem now uses a mocking approach)
By
Jonathan Niehof jnie...@lanl.gov added the comment:
Éric: I think copying a relative symlink should also be relative, and that's
the behaviour of this patch. That was the use case that tripped me up with the
original behaviour of shutil.move: a relative symlink which was dangling in its
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
nosy: +haypo, pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9993
___
___
Antoine Pitrou pit...@free.fr added the comment:
Looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9993
___
___
Python-bugs-list
Jonathan Niehof jnie...@lanl.gov added the comment:
Éric, here's a quick docs-only patch against current default...does this do the
job?
--
Added file: http://bugs.python.org/file23002/shutil_move_doc.patch
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Thanks for the doc patch, which looks good. I have one question: if a relative
symlink is copied, should the resulting symlink be relative too?
--
___
Python tracker rep...@bugs.python.org
Hynek Schlawack h...@ox.cx added the comment:
I work on the superficially related #12715 (symlinks for shutil). As we try to
mimic the POSIX tools and `mv` indeed doesn't follow links, I agree with the
approach of this patch.
--
nosy: +hynek
___
Éric Araujo mer...@netwok.org added the comment:
Can you update the documentation?
--
nosy: +eric.araujo
versions: +Python 3.3 -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9993
R. David Murray rdmur...@bitdance.com added the comment:
I can confirm that the tests fail before the patch (but if an only if /tmp is a
different file system from the one where the build is, see issue ) and pass
after the patch. The patch itself looks good to me and does accord better
New submission from Jonathan Niehof jnie...@lanl.gov:
shutil.move does not behave as I expect when moving a symlink across
filesystems. (This is when src itself is a symlink, not when it is a directory
tree including symlinks.)
-If src is a symlink to file, rather than moving the symlink, it
Changes by Ned Deily n...@acm.org:
--
nosy: +tarek
stage: - patch review
versions: -Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9993
___
17 matches
Mail list logo