Nick Coghlan ncogh...@gmail.com added the comment:
That does look like it will fix the leak, but now I'm actually thinking there's
more code from type_new that should also be executed in the PyType_FromSpec
case.
I mean things like:
- ensuring __new__ is a static method
- ensuring the
Changes by Nick Coghlan ncogh...@gmail.com:
--
nosy: +daniel.urban
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15142
___
___
Python-bugs-list
Roger Serwy roger.se...@gmail.com added the comment:
Adding a horizontal scroll bar is relatively easy. This has already been done
with the Horizontal.py extension as part of a separate project called IdleX.
See http://idlex.sourceforge.net/extensions.html
@Terry, perhaps this should be added
New submission from Nick Coghlan ncogh...@gmail.com:
The PEP 362 implementation has been committed, but the inspect module
documentation still needs to be updated.
--
assignee: docs@python
components: Documentation
messages: 163534
nosy: docs@python, ncoghlan
priority: deferred blocker
Terry J. Reedy tjre...@udel.edu added the comment:
As a native speaker, I agree that the sentence, in isolation, is hardly
comprehensible. The previous one is also a bit flakey.
The situation is that top-level code executes in a module named __main__, which
has one joint global/local
Georg Brandl ge...@python.org added the comment:
Updated.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15149
___
Changes by Terry J. Reedy tjre...@udel.edu:
--
nosy: +ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15117
___
___
Python-bugs-list
Terry J. Reedy tjre...@udel.edu added the comment:
(OT, but since you brought it up: In my opinion, deprecating the iterability of
any builtin class is a horrible idea. It is a Python feature, especially in
3.x, that all *are* iterable. However, I would agree that named tuples should
be
Changes by Terry J. Reedy tjre...@udel.edu:
--
components: +Interpreter Core -None
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11205
___
___
Martin v. Löwis mar...@v.loewis.de added the comment:
These things are best studied with msiexec ... /l*v python.log, then inspecting
python.log. Without looking at the trace, I'd expect that the actual
installation run doesn't inherit ModifyPath from the UI run.
The installer runs actually
Terry J. Reedy tjre...@udel.edu added the comment:
None has over 1300 issues, mostly old (historical). It could be removed from
current use, I think (if it is possible to hide such a thing).
Cross-build has just 6 issues collected together in last three months. I do not
think that is really
Raymond Hettinger raymond.hettin...@gmail.com added the comment:
Something like Fraction.as_decimal(prec=28) would be reasonable.
--
priority: normal - low
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15136
Martin v. Löwis mar...@v.loewis.de added the comment:
- ensuring __new__ is a static method
This shouldn't be necessary. __new__ won't be a method at all,
and not even exist. Instead, a type may or may not fill the tp_new
slot.
- ensuring the standard attribute lookup machinery is configured
Changes by Martin v. Löwis mar...@v.loewis.de:
--
nosy: +Robin.Schreiber
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15142
___
___
Martin v. Löwis mar...@v.loewis.de added the comment:
In any case, one issue at a time, please. This issues is about a reference leak.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15142
Mark Dickinson dicki...@gmail.com added the comment:
Something like Fraction.as_decimal(prec=28) would be reasonable.
I'd prefer an implementation of Fraction.__format__. That solves the SO user's
need exactly. Note that he/she didn't care about the Decimal type, but only
wanted to be able
Terry J. Reedy tjre...@udel.edu added the comment:
The file is 'controversial'. The link was intentionally removed (and the file
deleted and restored but not relinked, pending update) in #7391 (which was
closed and re-opened).
Your links do not work because the comma/period that follow are
Charles-François Natali neolo...@free.fr added the comment:
But at the heart of the matter, I see no benefit to exposing Python
developers to the idiosyncrasies of poor C API design. I feel strongly that
one way Python becomes pythonic is that it aims for the convenience of the
Changes by Charles-François Natali neolo...@free.fr:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15078
___
___
Python-bugs-list
Terry J. Reedy tjre...@udel.edu added the comment:
I think *both* proposals are sensible. Fraction already has .from_decimal
(using Decimal), so .to_decimal (also using Decimal) is sensible. It also has
.from_float, with 'f.to_float' spelled f.__float__, normally called as float(f).
On the
Serhiy Storchaka storch...@gmail.com added the comment:
Since assert(0) always fails, return can never happen (and was not added
above. So I would think remove it.
This will cause a compiler warning in non-debug mode.
Here is updated patch with all other comments taken into account.
Serhiy Storchaka storch...@gmail.com added the comment:
I personally like the change, except for `flags` argument collapsing. Imagine
what mmap's prototype would look like if we used list of optional arguments
instead of a flag...
What's wrong with mmap? It uses list of optional arguments
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 0e5a698d3c4c by Mark Dickinson in branch 'default':
Issue #14742: test_unparse now only checks a limited number of files unless the
'cpu' resource is specified.
http://hg.python.org/cpython/rev/0e5a698d3c4c
Changes by Mark Dickinson dicki...@gmail.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14742
___
___
Changes by Mark Dickinson dicki...@gmail.com:
--
resolution: - fixed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14742
___
___
Python-bugs-list
Martin v. Löwis mar...@v.loewis.de added the comment:
I indeed think that the code is fine as it stands, and no change is needed, and
that the proposed changes make matters worse.
The point of the thin wrappers approach is that you can read the manpage of
your system, and immediately can
Terry J. Reedy tjre...@udel.edu added the comment:
Do read PEP 8 Python style guide. http://python.org/dev/peps/pep-0008/
You violated the following:
(Peeves)
More than one space around an assignment (or other) operator to align it with
another.
Yes:
x = 1
y = 2
long_variable = 3
No:
x
Nick Coghlan ncogh...@gmail.com added the comment:
You're right, I was confusing what happens automatically for classes defined in
Python (i.e. the full treatment in type_new) vs those defined statically (i.e.
just the parts in PyType_Ready).
Given that PyType_FromSpec doesn't currently
Terry J. Reedy tjre...@udel.edu added the comment:
The bug is the mismatch between doc and behavior. Unless someone can explain
why the seemingly reasonable docstring is wrong, I would consider changing the
behavior a possible fix. Can you add minimal test code that gives you an int? I
should
Stefan Krah stefan-use...@bytereef.org added the comment:
This looks like a bug in freebsd:
http://lists.freebsd.org/pipermail/freebsd-amd64/2012-January/014332.html
I tested that one already yesterday (it was late, so I forgot to mention
it) and the test case attached to the bug report
Charles-François Natali neolo...@free.fr added the comment:
What's wrong with mmap? It uses list of optional arguments (`flags`,
`prot`, `access`) and not only one `flags` argument.
Of course it does, as the mmap syscall(), since this arguments have nothing to
do with one another.
I was
Georg Brandl ge...@python.org added the comment:
Deferring for beta1 at least.
--
priority: release blocker - deferred blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14340
___
Changes by Nick Coghlan ncogh...@gmail.com:
--
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15146
___
___
Python-bugs-list
New submission from Charles-François Natali neolo...@free.fr:
Some test_subprocess tests are failing on really slow buildbots, such as the
Ubtuntu ARM one:
==
ERROR: test_wait_timeout (test.test_subprocess.ProcessTestCase)
Nick Coghlan ncogh...@gmail.com added the comment:
Attached patch implements both new functions, but I'm going to drop
getgeneratorlocals for now and move that idea to a new issue.
--
Added file: http://bugs.python.org/file26103/issue13062-combined.diff
Stefan Krah stefan-use...@bytereef.org added the comment:
int main(void)
{
int fd = open(ccc.c, O_RDONLY);
off_t offset=lseek(fd,0,SEEK_HOLE);
if (offset==-1) {
if (errno==ENXIO) {
Darn, the errno in test_posix should be ENOTTY. Indeed, with ENOTTY the
test case for
New submission from Nick Coghlan ncogh...@gmail.com:
Extracted from #13062, the proposal is add a simple API to inspect the local
variables of a generator with an associated frame.
--
components: Library (Lib)
messages: 163560
nosy: ncoghlan
priority: normal
severity: normal
stage:
Nick Coghlan ncogh...@gmail.com added the comment:
The intended use case is for whitebox testing of generator behaviour.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15153
___
Nick Coghlan ncogh...@gmail.com added the comment:
I created #15153 to cover getgeneratorlocals. Attached patch is just for record
keeping purposes - I'll be committing this change shortly.
--
Added file: http://bugs.python.org/file26104/issue13062-getclosurevars.diff
Antoine Pitrou pit...@free.fr added the comment:
However, once inheritance support is added by #15146 then it would be
wrong - the default slot entry would override an inherited one.
It would not be wrong. subtype_dealloc will properly call a base class'
tp_dealloc, if necessary.
--
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 487fe648de56 by Nick Coghlan in branch 'default':
Close #13062: Add inspect.getclosurevars to simplify testing stateful closures
http://hg.python.org/cpython/rev/487fe648de56
--
nosy: +python-dev
resolution:
Antoine Pitrou pit...@free.fr added the comment:
Barry (the buildbot owner) could take a look.
--
nosy: +barry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15152
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 5ca9a51f3d85 by Mark Dickinson in branch '3.2':
Issue #12965: Clean up C-API docs for PyLong_AsLong(AndOverflow); clarify that
__int__ will be called for non-PyLongs
http://hg.python.org/cpython/rev/5ca9a51f3d85
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset dd82a910eb07 by Nick Coghlan in branch 'default':
Close #15153: Added inspect.getgeneratorlocals to simplify whitebox testing of
generator state updates
http://hg.python.org/cpython/rev/dd82a910eb07
--
Georg Brandl ge...@python.org added the comment:
OTOH, I don't want it to block beta1.
--
priority: release blocker - deferred blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14578
___
Georg Brandl ge...@python.org added the comment:
OK, sounds like none of it would block beta1.
--
priority: release blocker - deferred blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13959
Georg Brandl ge...@python.org added the comment:
Why not deprecate .error()? Removing it immediately as undocumented is
certainly not better.
Otherwise sounds good, please commit.
--
___
Python tracker rep...@bugs.python.org
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 3ace8e17074a by Mark Dickinson in branch '3.2':
Issue #12965: Clean up C-API docs for PyLong_AsLongLong(AndOverflow); clarify
that __int__ will be called for non-PyLongs
http://hg.python.org/cpython/rev/3ace8e17074a
Nick Coghlan ncogh...@gmail.com added the comment:
True, I didn't follow the bouncing ball far enough. In that, case I think all
that is needed is a comment like:
subtype_dealloc walks the MRO to call the base dealloc function, so it is OK
to block inheritance of the slot
--
Georg Brandl ge...@python.org added the comment:
Seems to be fixed; at least compilation now works.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15143
Georg Brandl ge...@python.org added the comment:
Very good, thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15147
___
___
Georg Brandl ge...@python.org added the comment:
Doesn't occur on the buildbots; is it fixed already?
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15150
___
Antoine Pitrou pit...@free.fr added the comment:
27f9c26fdd8b broke test_shutil on the Windows buildbots:
==
FAIL: test_basic (test.test_shutil.TestWhich)
--
Ned Deily n...@acm.org added the comment:
Thanks, Ronald. Version 3 addresses various issues, including adding a search
of $PATH for clang since xcrun is not useful in the case where the user has
installed a standalone Command Line Tools package or has installed a Command
Line Tools
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset e1416a4d728a by Mark Dickinson in branch '3.2':
Issue #12965: More PyLong_As* clarifications. Thanks Stefan Krah.
http://hg.python.org/cpython/rev/e1416a4d728a
New changeset 349bc58e8c66 by Mark Dickinson in
Mark Dickinson dicki...@gmail.com added the comment:
Docs mostly fixed now for Python 3.2 and Python 3.3. That leaves 2.7, where
there are some additional complications (e.g., __long__ in addition to __int__,
when / whether short ints are accepted, etc.).
While it would be good to fix the
Serhiy Storchaka storch...@gmail.com added the comment:
Any chance to commit the patch today and to get this feature in Python 3.3?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3665
___
Serhiy Storchaka storch...@gmail.com added the comment:
Any chance to commit the patch today and to get this feature in Python 3.3?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5067
___
Changes by Antoine Pitrou pit...@free.fr:
--
assignee: - pitrou
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3665
___
Serhiy Storchaka storch...@gmail.com added the comment:
Any chance to commit the patch before final feature freeze?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10376
___
Serhiy Storchaka storch...@gmail.com added the comment:
Any chance to commit the patch before final feature freeze?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14923
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset b1dbd8827e79 by Antoine Pitrou in branch 'default':
Issue #3665: \u and \U escapes are now supported in unicode regular expressions.
http://hg.python.org/cpython/rev/b1dbd8827e79
--
nosy: +python-dev
Antoine Pitrou pit...@free.fr added the comment:
Any chance to commit the patch today and to get this feature in Python
3.3?
Thanks for reminding us! It's now in 3.3.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
Changes by Antoine Pitrou pit...@free.fr:
--
assignee: docs@python -
nosy: +nadeem.vawda
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10376
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file25720/issue8271-3.3-fast.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8271
___
Antoine Pitrou pit...@free.fr added the comment:
Any chance to commit the patch before final feature freeze?
I'll defer to Mark :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14923
Antoine Pitrou pit...@free.fr added the comment:
Why is this marked fixed? Is it fixed or not?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8271
___
Serhiy Storchaka storch...@gmail.com added the comment:
I deleted a fast patch, since it unsafe. Issue14923 should safer compensate a
small slowdown.
I think this change is not a bugfix (this is not a bug, the standard allows
such behavior), but a new feature, so I doubt the need to fix 2.7
Mark Dickinson dicki...@gmail.com added the comment:
Okay, will look at this this afternoon.
--
assignee: - mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14923
___
Serhiy Storchaka storch...@gmail.com added the comment:
Thank you for the quick response.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3665
___
Serhiy Storchaka storch...@gmail.com added the comment:
No, it is not fully fixed. Only one bug was fixed, but the current
behavior is still not conformed with the Unicode Standard
*recommendations*. Non-conforming with recommendations is not a bug,
conforming is a feature.
--
Georg Brandl ge...@python.org added the comment:
Antoine is much more of an expert here, and I defer to his judgment that it is
better to wait.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15139
Changes by Mark Dickinson dicki...@gmail.com:
--
assignee: - mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15144
___
___
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15150
___
___
Python-bugs-list mailing
Georg Brandl ge...@python.org added the comment:
The test case is till failing for the freebsd7 buildbot:
http://www.python.org/dev/buildbot/all/builders/x86%20FreeBSD%207.2%203.x/builds/3155/steps/test/logs/stdio
--
nosy: +georg.brandl
status: closed - open
Georg Brandl ge...@python.org added the comment:
And the Ubuntu ARM buildbot.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10142
___
___
Serhiy Storchaka storch...@gmail.com added the comment:
Reduction of memory consumption of struct is a new feature. Any chance to
commit struct_repeat.patch+struct_sizeof.patch today and to get this feature in
Python 3.3?
--
___
Python tracker
Mark Dickinson dicki...@gmail.com added the comment:
I'm still not convinced that something like struct_repeat.patch is necessary.
So unless someone else wants to own this issue and review the struct_repeat,
I'd say that it's too late for 3.3.
--
Martin v. Löwis mar...@v.loewis.de added the comment:
I believe the patch is incorrect. It changes self._acquire_restore into a
no-op, claiming that lock_acquire_condition will correctly restore the lock's
state.
However, lock_acquire_condition may fail (e.g. if the timeout is not strictly
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15102
___
___
Python-bugs-list
Ezio Melotti ezio.melo...@gmail.com added the comment:
Your links do not work because the comma/period that follow are
considered part of the urls. To be safe, always follow with whitespace.
FWIW this will be fixed soon and the fix will work on older messages too:
Serhiy Storchaka storch...@gmail.com added the comment:
Now internal representation of Struct with small format string may
consume unexpectedly large memory and this representation may be
invisible cached. With patch you can get large internal representation
only for large format strings. It is
Antoine Pitrou pit...@free.fr added the comment:
Ok, fixed, thanks.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15142
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 1794308c1ea7 by Antoine Pitrou in branch '3.2':
Issue #15142: Fix reference leak when deallocating instances of types created
using PyType_FromSpec().
http://hg.python.org/cpython/rev/1794308c1ea7
New changeset
Serhiy Storchaka storch...@gmail.com added the comment:
The C version of decimal may not always be available. In particular, it is not
compatible with C89. Therefore, efficiency of the pure Python version of
decimal is important.
Any chance to get it in Python 3.3?
--
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14478
___
___
Python-bugs-list
Nadeem Vawda nadeem.va...@gmail.com added the comment:
Patch looks fine to me.
Antoine, can you commit this? I'm currently away from the computer that
has my SSH key on it.
--
___
Python tracker rep...@bugs.python.org
Ezio Melotti ezio.melo...@gmail.com added the comment:
Regarding .error() I think the best thing to do is wait till 3.4 and then
deprecate it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15114
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 8dd2f5754b2f by Ezio Melotti in branch 'default':
#15114: the strict mode of HTMLParser and the HTMLParseError exception are
deprecated now that the parser is able to parse invalid markup.
Mark Dickinson dicki...@gmail.com added the comment:
I'm happy to apply the 'decode_utf8_range_check.patch'; I'll do that unless
there are objections. The code is clearer than the original, and if we get a
speedup into the bargain then I don't see a reason not to apply this.
I'm less
Jason R. Coombs jar...@jaraco.com added the comment:
The test is already present in test_import but is disabled because it is
currently failing. I should mention that I believe this is a regression with
3.3 over 3.2. It is certainly a regression over 2.7.
--
stage: test needed - needs
Ezio Melotti ezio.melo...@gmail.com added the comment:
3.3 is done.
3.4
strict arg deprecated (raises a warning)
HTMLParser.error deprecated (raises a warning)
3.5
strict arg removed and strict code removed
HTMLParseError removed
HTMLParser.error and calls to HTMLParser.error removed
Larry Hastings la...@hastings.org added the comment:
OT, but since you brought it up: In my opinion, deprecating the
iterability of any builtin class is a horrible idea. It is a
Python feature, especially in 3.x, that all *are* iterable.
As you say, OT. But I don't see how it's a feature.
Mark Dickinson dicki...@gmail.com added the comment:
I agree with Raymond: I don't see a real need to patch the Python version
here. If we do want to patch the Python version, I'd go with Raymond's simple
patch.
--
___
Python tracker
Ezio Melotti ezio.melo...@gmail.com added the comment:
Serhiy, does this patch also fix #8271?
If so, can you also include the tests I wrote for it?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14923
Mark Dickinson dicki...@gmail.com added the comment:
The struct_sizeof patch looks fine, but lacks tests. I think it might be
reasonable to call this a bugfix.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14596
Christian Heimes li...@cheimes.de added the comment:
Updated patch with volatile, better error report for non-ASCII strings and
updated comments
--
Added file: http://bugs.python.org/file26106/timingsafe_cmp-2.patch
___
Python tracker
Antoine Pitrou pit...@free.fr added the comment:
I'm not really happy with the addition of a separate extension module for a
single private function. You could just put it in the operator module, for
instance.
Also, the idea was not to expose timingsafe_cmp but to use it in
compare_digest().
Christian Heimes li...@cheimes.de added the comment:
Me neither but you didn't want it in the operator module in the first place
(msg162882). :) Please make a decision. I'm happy to follow it.
My idea is to drop the pure Python implementation of compare_digest() and just
use the C
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 0e8285321659 by Antoine Pitrou in branch 'default':
On behalf of Nadeem Vawda: issue #10376: micro-optimize reading from a Zipfile.
http://hg.python.org/cpython/rev/0e8285321659
--
nosy: +python-dev
1 - 100 of 214 matches
Mail list logo
