[issue24993] The C function PyCodec_NameReplaceErrors doesn't handle PyCapsule_Import() failure

Roundup Robot added the comment: New changeset ac1995b01028 by Victor Stinner in branch '3.5': Issue #24993: Handle import error in namereplace error handler https://hg.python.org/cpython/rev/ac1995b01028 -- nosy: +python-dev ___ Python tracker

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

Serhiy Storchaka added the comment: > We only give the reference to the caller when the newly created OrderedDict > is fully initialized (consistent). See msg246573. PyDict_New() can trigger garbage collecting and traversing , and GC have a reference to underinitialized OrderedDict and can

[issue24984] document AF_BLUETOOTH socket address formats

Tim Tisdall added the comment: I'm not really sure how to add a `versionadded` tag to specify that only the BSD-specific support was added in 3.2 (as general support was there prior to that). If I just add the plain tag below that bullet point it would imply that the whole protocol was added

[issue24990] Foreign language support in turtle module

R. David Murray added the comment: There is a discussion elsewhere about whether it is time to start formalizing translation efforts for the python docs (Sphinx supports it). Unfortunately I don't remember where I saw it (probably another issue in the tracker. I can see your argument about

[issue24994] Python 3.4.2 64-bit Installer error (Please insert the disk:)

Cameron Walker added the comment: Never mind. I just had to click repair... -- ___ Python tracker ___ ___

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

Roundup Robot added the comment: New changeset ef1f5aebe1a6 by Victor Stinner in branch '3.5': Issue #24992: Fix error handling and a race condition (related to garbage https://hg.python.org/cpython/rev/ef1f5aebe1a6 -- nosy: +python-dev ___ Python

[issue24993] The C function PyCodec_NameReplaceErrors doesn't handle PyCapsule_Import() failure

STINNER Victor added the comment: Thanks for your review and your cool error handler. -- ___ Python tracker ___

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

STINNER Victor added the comment: > It looks to me as an ordinal bug and that is encountered only in special > circumstances with small probability. I think it can wait for 3.5.1. Ok, I agree. What about the second patch, does it look ok? -- ___

[issue24984] document AF_BLUETOOTH socket address formats

Tim Tisdall added the comment: I added a note to BTPROTO_SCO that it doesn't work in FreeBSD (I forgot to mention that). -- Added file: http://bugs.python.org/file40341/bluetooth_socket_docs_3.patch ___ Python tracker

[issue24993] The C function PyCodec_NameReplaceErrors doesn't handle PyCapsule_Import() failure

STINNER Victor added the comment: > The purpose was to make the dependence of unicodedata optional. In which case the unicodedata module is missing? It's always part of CPython no? > (...) but now I think that probably your approach is more preferable because > it makes the code simpler and

[issue24993] The C function PyCodec_NameReplaceErrors doesn't handle PyCapsule_Import() failure

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

STINNER Victor added the comment: > See msg246573. PyDict_New() can trigger garbage collecting and traversing and > GC have a reference to underinitialized OrderedDict and can call > odict_traverse() for it. Oooh ok, I understand. I updated my patch to implement your idea. -- Added

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

Serhiy Storchaka added the comment: It looks to me as an ordinal bug and that is encountered only in special circumstances with small probability. I think it can wait for 3.5.1. -- ___ Python tracker

[issue24984] document AF_BLUETOOTH socket address formats

Tim Tisdall added the comment: I'm not sure the proper way to update the patch... I can't seem to edit the existing one or replace it. I'm uploading an updated one, but should I simply "unlink" (aka delete) the old one? -- Added file:

[issue24993] The C function PyCodec_NameReplaceErrors doesn't handle PyCapsule_Import() failure

STINNER Victor added the comment: > It was optional in Python 2 (at least in Unicode-disabled build). Yeah, even if I don't think that anyone is really using python without unicode in the wild. I guess that too many libraries don't work without unicode. Well, anyway this issue is for Python

[issue24984] document AF_BLUETOOTH socket address formats

Tim Tisdall added the comment: Martin, the odd thing with the SCO protocol is it's expecting an bluetooth address as a byte string (ex b'12:23:34:45:56:67' [note the `b`]) where the other 3 are expecting a regular string (ex '12:23:34:45:56:67'). I think it may have been a case of someone

[issue23406] interning and list comprehension leads to unexpected behavior

R. David Murray added the comment: Looks good to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23630] support multiple hosts in create_server/start_server

Yann Sionneau added the comment: Here is a new patch without any dependency on netifaces. Thanks Victor for the great deal of help for all the mock() stuff! -- Added file: http://bugs.python.org/file40342/multibind6.patch ___ Python tracker

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

Serhiy Storchaka added the comment: If don't initialize fields, then they will be not initialized in odict_dealloc, odict_tp_clear and odict_traverse. But _odict_FIRST(od) and od->od_weakreflist are used in these functions. I would allocate a dict for od_inst_dict before calling

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

STINNER Victor added the comment: @Serhiy: Python 3.5 is impacted. Do you consider this bug serious enough to request a pull request in Larry's branch for Python 3.5.0? -- nosy: +larry versions: +Python 3.5 ___ Python tracker

[issue24984] document AF_BLUETOOTH socket address formats

Tim Tisdall added the comment: changed "This protocol does not work under FreeBSD." to the more accurate "This protocol is not supported under FreeBSD." -- Added file: http://bugs.python.org/file40343/bluetooth_socket_docs_4.patch ___ Python tracker

[issue24994] Python 3.4.2 64-bit Installer error (Please insert the disk:)

New submission from Cameron Walker: I had attempted to uninstall python 3.4.2 from the start menu in Windows 7, but it was still visible in my Programs and features. I tried to uninstall it from there but it said it was missing some files. So I re-downloaded the installer, but when it tried

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

STINNER Victor added the comment: > If don't initialize fields, then they will be not initialized in odict_dealloc Old code initialized all fields to zero (or NULL), like "_odict_FIRST(od) = NULL;". The type allocator fills the newly allocated with zeros. So setting fields again to zero is

[issue23375] test_py3kwarn fails on Windows

Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker ___

[issue24993] The C function PyCodec_NameReplaceErrors doesn't handle PyCapsule_Import() failure

Serhiy Storchaka added the comment: > In which case the unicodedata module is missing? It's always part of CPython > no? It was optional in Python 2 (at least in Unicode-disabled build). Perhaps it can be exclude from custom build in Python 3 too. > Yeah, it's not a good practice to *hide*

[issue24974] ICC on Windows 8.1: _decimal fails to compile with default fp model

Zachary Ware added the comment: Committed! Thank you Steve for the suggestion and Stefan for the approval. -- ___ Python tracker ___

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Zachary Ware added the comment: Just to note, there's an easier way to run a custom build on multiple bots: go to http://buildbot.python.org/all/builders/ and scroll (way) down to the section for forcing a build on custom builders (you can search for 'Repo path:' (with the colon)), check the

[issue24974] ICC on Windows 8.1: _decimal fails to compile with default fp model

Zachary Ware added the comment: There's not a 32-bit ICC buildbot, though I could force one. But since you say commit it, I'll commit it ;) -- ___ Python tracker

[issue24974] ICC on Windows 8.1: _decimal fails to compile with default fp model

Roundup Robot added the comment: New changeset 863407e80370 by Zachary Ware in branch '3.5': Issue #24974: Force fp-model precice in mpdecimal.c on Windows https://hg.python.org/cpython/rev/863407e80370 New changeset 88c28d29afe4 by Zachary Ware in branch 'default': Closes #24974: Merge with

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

STINNER Victor added the comment: Yury wrote: > Is this something that we should ship in 3.5.0rc3? I don't think so. I agree with Serhiy who wrote: > It looks to me as an ordinal bug and that is encountered only in special > circumstances with small probability. I think it can wait for 3.5.1.

[issue24988] IDLE: debugger context menus not working on Mac

Terry J. Reedy added the comment: I just found #24801 which addressed the editor issue. -- ___ Python tracker ___

[issue24979] Allow timezone offsets greater than 24 hours

TJ added the comment: Thanks for the pointer to #5288. Happy to consolidate there. In my reading of #5094 (from which I pulled your RFC 2822 reference), the justification I found was "For the allowable range, follow the datetime docs as someone might be relying on that specification already".

[issue24974] ICC on Windows 8.1: _decimal fails to compile with default fp model

Stefan Krah added the comment: Hmm, I don't see a 32-bit ICC buildbot. This problem can only occur on 32-bit with -DPPRO defined. Please go ahead and commit the patch. The inline asm miscompilation problem I mentioned earlier was solved in 12.0 (I think), so let's just assume it's gone

[issue24974] ICC on Windows 8.1: _decimal fails to compile with default fp model

Stefan Krah added the comment: We can always blame any fallout on ICC. ;) -- ___ Python tracker ___ ___

[issue24913] deque.index() overruns deque boundary

Brett Cannon added the comment: PR created, Larry. -- assignee: brett.cannon -> larry stage: -> resolved ___ Python tracker ___

[issue24974] ICC on Windows 8.1: _decimal fails to compile with default fp model

Zachary Ware added the comment: I tested both 32 and 64 bit, with MSVC 14 (VS 2015) and ICC 15.0 (backed by VS 2015). I can go ahead and commit this to a sandbox for buildbot testing if it would help. -- ___ Python tracker

[issue24994] Python 3.4.2 64-bit Installer error (Please insert the disk:)

Zachary Ware added the comment: Glad you solved it for yourself :) -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

STINNER Victor added the comment: > I left a nitpick. In any case the patch LGTM. Ok, fixed. I pushed my fix. Thanks for the review Serhiy. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue24988] IDLE: debugger context menus not working on Mac

Mark Roseman added the comment: Terry, the new code I've proposed includes a "tkextras" module that is a good place for these sort of little convenience functions. -- ___ Python tracker

[issue24979] Allow timezone offsets greater than 24 hours

Alexander Belopolsky added the comment: I always thought that restriction came from ISO 8601, but at the moment I don't have it to check. -- ___ Python tracker

[issue24988] IDLE: debugger context menus not working on Mac

Terry J. Reedy added the comment: The standard on Windows is to bring up a context menu on right-button-release, not on r-b-press. What about linux and mac? Thunderbird and Notepad++ move the insertion cursor on rb-press, That is the paste position even if the mouse is moved before

[issue24995] better exception message when an unsupported object is passed to `async for` (pep 492)

New submission from Yury Selivanov: Should we raise something like "'int' object is not an asynchronous iterable", instead of "'async for' requires an object with __aiter__ method, got int"? >>> foo().send(None) Traceback (most recent call last): File "", line 1, in File "", line 2, in

[issue24996] IDLE: debugger local/global vars should not be editable

New submission from Mark Roseman: In the debugger, the values for the variables shown in the locals/globals panes are editable (i.e. using Entry widget) but I don't see any mechanism to have those changes affect anything. If I'm not missing something, why Entry and not Label? --

[issue15348] IDLE - shell becomes unresponsive if debugger windows is closed while active.

Changes by Mark Roseman : -- nosy: +markroseman ___ Python tracker ___ ___

[issue15347] IDLE - does not close if the debugger was active

Changes by Mark Roseman : -- nosy: +markroseman ___ Python tracker ___ ___

[issue24996] IDLE: debugger local/global vars should not be editable

Mark Roseman added the comment: Thanks Terry, sorry I missed your previous mention of this. From what I recall the treeview doesn't allow editable items, but what I've done in similar circumstances before (editing text items on a canvas in drawing type programs) was 'place' an entry widget on

[issue24912] The type of cached objects is mutable

Mark Shannon added the comment: Larry, of the two choices, I prefer rolling back the change entirely. I would like to see the bug fixes for typeobject.c applied, but I see no reason why making the __class__ of module objects assignable should be included. --

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Larry Hastings added the comment: That *is* easier, thanks. Though the UI for that is baffling. Protip: search for the section where all the "custom" builders are listed all in one section, three-quarters of the way down the page. -- ___ Python

[issue24990] Foreign language support in turtle module

Al Sweigart added the comment: Good idea. I'll bring it up on the python-ideas list. -- ___ Python tracker ___

[issue24995] better exception message when an unsupported object is passed to `async for` (pep 492)

STINNER Victor added the comment: IMHO the current message is clear enough. -- ___ Python tracker ___ ___

[issue24995] better exception message when an unsupported object is passed to `async for` (pep 492)

Yury Selivanov added the comment: I saw this reddit thread: https://www.reddit.com/r/Python/comments/3ewnwq/async_function_as_generator_for_async_for/ where people are struggling with understanding how 'async for' works. Which led me to check what error messages we raise when we pass a wrong

[issue21192] Idle: Print filename when running a file from editor

Larry Hastings added the comment: On the other hand, I do not hold with marking a minor cosmetic change like this as "release blocker". I'm willing to accept the change, given PEP 434, but I'm not going to delay any releases for it. -- priority: release blocker -> normal

[issue24987] subprocess.Popen with shell=True doesn't create socket

Changes by Martin Panter : -- resolution: -> works for me ___ Python tracker ___ ___

[issue24995] better exception message when an unsupported object is passed to `async for` (pep 492)

Guido van Rossum added the comment: Did you get multiple complaints about this? The existing error doesn't seem so bad. -- ___ Python tracker ___

[issue24996] IDLE: debugger local/global vars should not be editable

Terry J. Reedy added the comment: I already brought this up as part of one of the StackViewer/Debugger/merge issues. Replacing the list with a tree would automatically change this unless the tree was changed to have a entry. Why? My speculation is an intention never carried out. Labels

[issue24991] Define instance mutability explicitly on type objects

Changes by Eugene Toder : -- nosy: +eltoder ___ Python tracker ___ ___ Python-bugs-list

[issue21192] Idle: Print filename when running a file from editor

Terry J. Reedy added the comment: Sorry, my memory was that I was supposed to that as a signal, but maybe that was with a different RM. -- ___ Python tracker

[issue17849] Missing size argument in readline() method for httplib's class LineAndFileWrapper

Cory Benfield added the comment: Martin, the idea of simply rejecting the LifeAndFileWrapper HTTP/0.9 fallback for _tunnel feels reasonable to me, that can work. Let me whip up an alternative patch that does that. -- ___ Python tracker

[issue24991] Define instance mutability explicitly on type objects

New submission from Nick Coghlan: Issue #24912 showed that the interpreter has historically assumed that all instances of non-heap types are immutable when it comes to preventing __class__ reassignment, and changing this assumption caused problems with genuinely immutable types that use

[issue23375] test_py3kwarn fails on Windows

Zachary Ware added the comment: Could this have anything to do with the fact that imageop is a 'built-in' (as opposed to 'extension') module on Windows? Either way, I'm about ready to just skip testing the warning for that module on Windows. --

[issue24912] The type of cached objects is mutable

Nick Coghlan added the comment: I've filed issue 24991 to suggest reviewing the wider question of how we deal with identifying whether or not a type's instances are expected to be "truly immutable" in the Python 3.6 time frame. For 3.5, I think Nathaniel's proposed patch restoring the

[issue24989] scan_eol() Buffer Over-read

Changes by Serhiy Storchaka : -- nosy: +larry ___ Python tracker ___ ___

[issue24989] scan_eol() Buffer Over-read

Serhiy Storchaka added the comment: It should be self->string_size, not PyBytes_GET_SIZE(self->buf). Thank you for your report and your patch John. Here is revised patch with tests based on Martin's test. Larry, perhaps this bug is grave enough to be fixed in RC3. -- components:

[issue23517] datetime.utcfromtimestamp rounds results incorrectly

Roundup Robot added the comment: New changeset bf634dfe076f by Victor Stinner in branch 'default': Issue #23517: fromtimestamp() and utcfromtimestamp() methods of https://hg.python.org/cpython/rev/bf634dfe076f -- ___ Python tracker

[issue24991] Define instance mutability explicitly on type objects

Nathaniel Smith added the comment: Adding Eric Snow to nosy because it seems like there may be some natural overlap between this and the per-subinterpreter GIL ideas he brought up on python-ideas back in June. -- nosy: +eric.snow ___ Python tracker

[issue23375] test_py3kwarn fails on Windows

Changes by STINNER Victor : Added file: http://bugs.python.org/file40332/test_py3kwarn-2.patch ___ Python tracker ___

[issue24987] subprocess.Popen with shell=True doesn't create socket

asduj added the comment: After executing this code in Python 2.7 I check if OpenOffice is listening the localhost:8100, and get the output: netstat -a | grep 8100 tcp 0 0 localhost:8100 *:* LISTEN If I executing the same code in Python 3.4 and check, I get nothing. Platform: Ubuntu

[issue23375] test_py3kwarn fails on Windows

STINNER Victor added the comment: To easily test my patch, you can inject a Python 3 DeprecationWarning in the unicodedata module using attached unicodedata.patch, and then modify Lib/test/test_py3kwarn.py to add "unicodedata" to the "optional_modules" list. I tested my patch on Linux (Fedora

[issue24872] Add /NODEFAULTLIB:MSVCRT to _msvccompiler

Christoph Gohlke added the comment: Just to confirm: the following script fails with `ImportError: DLL load failed` on Python 3.5.0rc2. It fails around the 120th extension. The script passes on Python 3.4.3. Also, Python 3.5.0rc2 (not Python 3.4.3) requires the `extra_postargs=['/DLL']`

[issue24912] The type of cached objects is mutable

Larry Hastings added the comment: Mark, Victor, Benjamin: how do you feel about v2 patch vs rolling back the change entirely? -- ___ Python tracker ___

[issue24989] scan_eol() Buffer Over-read

STINNER Victor added the comment: scan_eol_Buffer_Over-read_2.patch looks good to me. > Larry, perhaps this bug is grave enough to be fixed in RC3. Since it looks like a regression in Python 3.5, yes, it's a severe bug. Please send a pull request to Larry for it. --

[issue23375] test_py3kwarn fails on Windows

STINNER Victor added the comment: > I can't reproduce the failure on Linux. Do you have a 64-bit system? imageop is only built on 32-bit systems... > Looks like a test ordering issue. When test_imageop runs before > test_py3kwarn, the warning has presumably already been shown once and so >

[issue23375] test_py3kwarn fails on Windows

Changes by STINNER Victor : Removed file: http://bugs.python.org/file40331/test_py3kwarn.patch ___ Python tracker ___

[issue23375] test_py3kwarn fails on Windows

Serhiy Storchaka added the comment: The approach LGTM. I left comments on Rietveld. -- stage: -> patch review ___ Python tracker ___

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Larry Hastings added the comment: Well, this is making me nervous to apply during the RCs. But... I'm willing to risk it. My price: I want to see this run on a bunch of otherwise-healthy buildbots to make sure it doesn't break any platforms. In case you've never done such a thing, here's

[issue24912] The type of cached objects is mutable

Nathaniel Smith added the comment: Since I know there's a lot of text here for people to process, here's an attempted TL;DR (with inspiration from Serhiy's msg249495): There were three parts to the original change: 1) Bug fixes for typeobject.c 2) Enabling __class__ assignment for module

[issue21192] Idle: Print filename when running a file from editor

Larry Hastings added the comment: Terry, if you want this pulled in to Python 3.5.0, you'll need to create a pull request on Bitbucket. Instructions are here: https://mail.python.org/pipermail/python-dev/2015-August/141167.html and here:

[issue23375] test_py3kwarn fails on Windows

Roundup Robot added the comment: New changeset d739bc20d7b2 by Victor Stinner in branch '2.7': Issue #23375: Fix test_py3kwarn for modules implemented in C https://hg.python.org/cpython/rev/d739bc20d7b2 -- nosy: +python-dev ___ Python tracker

[issue23375] test_py3kwarn fails on Windows

STINNER Victor added the comment: > The approach LGTM. I left comments on Rietveld. Thanks for the review. I replaced warnings.warn() with a simple print(). This issue should now be fixed. -- resolution: -> fixed status: open -> closed ___ Python

[issue24974] ICC on Windows 8.1: _decimal fails to compile with default fp model

Stefan Krah added the comment: Are you sure that you always tested the 32-bit build, also with ICC 15.0? -- ___ Python tracker ___

[issue24989] scan_eol() Buffer Over-read

Larry Hastings added the comment: Yes, please create a pull request for this patch. Thanks! And just to confirm: I just applied patch 2 to CPython, then undid the change to bytesio.c. The new test fails, and sometimes Python will segmentation fault. If I then apply the patch to bytesio.c

[issue24989] scan_eol() Buffer Over-read

Changes by Larry Hastings : -- priority: high -> release blocker ___ Python tracker ___

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

STINNER Victor added the comment: You can try the odict_failmalloc.py program with a Python compiled in debug mode to see the bug. The script requires: https://pypi.python.org/pypi/pyfailmalloc -- Added file: http://bugs.python.org/file40335/odict_failmalloc.py

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

New submission from STINNER Victor: If PyDict_New() fails (ex: memory allocation failure), odict_new() returns a new OrderedDict with an exception set. It's a bug. Attached patch fixes it. odict_new() constructor also returns NULL without destroying the newly created object if

[issue22241] strftime/strptime round trip fails even for UTC datetime object

Berker Peksag added the comment: I left a couple comments on Rietveld. -- nosy: +berker.peksag ___ Python tracker ___

[issue7175] Define a standard location and API for configuration files

Marc-Andre Lemburg added the comment: On 02.09.2015 16:37, flying sheep wrote: > > hi mark, i’ve just lengthily replied to you on python-ideas. > > in short: nope! many command line tools that are relatively new (among them > your examples git and pip) honor the specs, my ~/.cache, ~/.config,

[issue24993] The C function PyCodec_NameReplaceErrors doesn't handle PyCapsule_Import() failure

STINNER Victor added the comment: Note: I found the bug when running test_codecs using failmalloc, a library to inject MemoryError. -- ___ Python tracker

[issue24993] The C function PyCodec_NameReplaceErrors doesn't handle PyCapsule_Import() failure

New submission from STINNER Victor: The namereplace error handler introduced in Python 3.5 doesn't handle correctly PyCapsule_Import() failure. If the function raises an exception, the PyCodec_NameReplaceErrors() function must return NULL. I see that the code correctly handle the case where

[issue23719] PEP 475: port test_eintr to Windows

STINNER Victor added the comment: The change ed0e6a9c11af replaced os.fork() with subprocess to try to fix race conditions in test_eintr (the test sometimes hangs on FreeBSD buildbots). os.fork() is not available on Windows, so this change should help to port test_eintr to Windows. About

[issue7175] Define a standard location and API for configuration files

Marc-Andre Lemburg added the comment: On 03.09.2015 13:37, flying sheep wrote: > all three OSs have stable, widely followed standards in place, and the idea > of providing a python stdlib API for them received an almost unanimously > positive response – with the sole exception being you. I'm

[issue23406] interning and list comprehension leads to unexpected behavior

Matheus Vieira Portela added the comment: Applying review comments. Now, there is an internal link to the FAQ entry on multidimensional lists. -- Added file: http://bugs.python.org/file40337/issue23406_doc_stdtypes_and_faq.patch ___ Python tracker

[issue7175] Define a standard location and API for configuration files

flying sheep added the comment: you’re right about the two problems being mixed, however not about the standards. also you’re intermingling conventions with actual standards. the directory standards for all three big OSs are either not going to change or fitted with a backwards-compatibility

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

Eric Snow added the comment: Thanks for taking care of this, Victor (and Serhiy). :) -- stage: -> resolved type: -> behavior ___ Python tracker ___

[issue24989] scan_eol() Buffer Over-read

Roundup Robot added the comment: New changeset a5858c30db7c by Serhiy Storchaka in branch '3.5': Issue #24989: Fixed buffer overread in BytesIO.readline() if a position is https://hg.python.org/cpython/rev/a5858c30db7c New changeset 215800fb955d by Serhiy Storchaka in branch 'default': Issue

[issue24913] deque.index() overruns deque boundary

Roundup Robot added the comment: New changeset 9f8c59e61594 by Brett Cannon in branch '3.5': Issue #24913: Fix overrun error in deque.index(). https://hg.python.org/cpython/rev/9f8c59e61594 New changeset d093d87e449c by Brett Cannon in branch '3.5': Merge from 3.5.0 for issue #24913

[issue17849] Missing size argument in readline() method for httplib's class LineAndFileWrapper

Cory Benfield added the comment: Ok, version three of the patch is now available. -- Added file: http://bugs.python.org/file40345/readline_3.patch ___ Python tracker

[issue24913] deque.index() overruns deque boundary

Brett Cannon added the comment: OK, that should cover 3.5.0 and then null merge through 3.5 and default. I thus consider my favour to Larry done and Raymond now owes me one. -- ___ Python tracker

[issue24996] IDLE: debugger local/global vars should not be editable

Terry J. Reedy added the comment: That makes sense, given that a string or list could be indefinitely long. -- ___ Python tracker ___

[issue24857] mock: Crash on comparing call_args with long strings

A Kaptur added the comment: It looks like there's a related bug in call_args around __ne__: >>> m = Mock() >>> m(1,2) >>> m.call_args call(1, 2) >>> m.call_args == call(1,2) True >>> m.call_args != call(1,2) True Any reason not to define __ne__ as not __eq__? Otherwise it looks like you fall

[issue24857] mock: Crash on comparing call_args with long strings

A Kaptur added the comment: Here's a simple patch + test for the original bug. I'll file the __ne__ question separately. -- keywords: +patch stage: needs patch -> patch review Added file: http://bugs.python.org/file40348/issue24857.patch ___ Python

  1   2   >