[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

2017-07-24 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : -- stage: needs patch -> patch review versions: +Python 3.5, Python 3.6, Python 3.7 ___ Python tracker

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

2017-07-24 Thread John Still
John Still added the comment: Ok I understand what you mean. I think the only conditions for test failure are (A) $BROWSER is set and (B) $BROWSER is set to an actual executable that should be caught by ``register_standard_browsers`` prior to execution reaching the last if clause of

[issue30908] test_os.TestSendfile.test_keywords() leaks dangling threads

2017-07-24 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2888 ___ Python tracker ___ ___

[issue31013] gcc7 throws warning when pymem.h development header is used

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: > /usr/include/python2.7/pymem.h:97:30: error: '*' in boolean context, suggest > '&&' instead [-Werror=int-in-bool-context] I don't understand this error. I would be curious to see the output of the preprocessor. Try maybe to use gcc -E? --

[issue31013] gcc7 throws warning when pymem.h development header is used

2017-07-24 Thread Gabriel Somlo
Gabriel Somlo added the comment: output of "gcc -E -Wall -I/usr/include/python2.7 -c netnsmodule.c > foo.c" I think gcc7 is a bit more paranoid about whether some expression evaluating to an int can/should in itself be used as a Boolean (i.e., without being compared to 0). -- Added

[issue27099] IDLE: turn builting extensions into regular modules

2017-07-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am still thinking about how to handle user customization of key defs and values. The current extensions tab does not enable custom key defs, so that would be a new feature, and hence could be handled separately, and normally. I have not yet looked at the

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: Antoine Pitrou: "I'm not able to reproduce. Can you try again with latest master?" Oh, maybe I found why... There is a tearDownModule() function which hides bugs. Try following change: diff --git a/Lib/test/_test_multiprocessing.py

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

2017-07-24 Thread Aditya Hase
Changes by Aditya Hase : -- pull_requests: +2891 ___ Python tracker ___ ___

[issue30188] test_nntplib: random EOFError in setUpClass()

2017-07-24 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2887 ___ Python tracker ___ ___

[issue30850] [2.7] bsddb3: test01_basic_replication() of test_bsddb3 fails randomly on AMD64 Windows8.1 Refleaks 2.7

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: The test fails randomly. Since I'm unable to reproduce the bug, I close the bug. (If the bug is not fixed, I will reopen the issue.) -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python

[issue30892] _elementtree: assertion error if stdlib copy module is overriden

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: Python 2.7 doesn't seem to be affected: $ python2 Python 2.7.13+ (heads/2.7:598f26b, Jul 21 2017, 01:18:41) [GCC 6.3.1 20161221 (Red Hat 6.3.1-1)] on linux2 >>> import _elementtree Traceback (most recent call last): File "", line 1, in File "", line 1, in

[issue30892] _elementtree: assertion error if stdlib copy module is overriden

2017-07-24 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue31013] gcc7 throws warning when pymem.h development header is used

2017-07-24 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue30908] test_os.TestSendfile.test_keywords() leaks dangling threads

2017-07-24 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2889 ___ Python tracker ___ ___

[issue31013] gcc7 throws warning when pymem.h development header is used

2017-07-24 Thread Gabriel Somlo
Gabriel Somlo added the comment: This attachment illustrates how the problem is triggered. The file is part of the CORE network emulator (github.com/coreemu/core). Compile with "gcc -Wall -I/usr/include/python2.7 -c netnsmodule.c". -- Added file:

[issue31013] gcc7 throws warning when pymem.h development header is used

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: > malloc(((argc + 1) * sizeof(char *)) ? ((argc + 1) * sizeof(char *)) : 1)) ) > ); Ah ok, the "(n)?" expression is "((argc + 1) * sizeof(char *)) ? " and yes it contains "*". -- ___ Python tracker

[issue30188] test_nntplib: random EOFError in setUpClass()

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: New changeset 5b4feb7e86ecb813b2c56560f86cda2fd46b9579 by Victor Stinner in branch 'master': bpo-30188: test_nntplib catch also ssl.SSLEOFError (#2843) https://github.com/python/cpython/commit/5b4feb7e86ecb813b2c56560f86cda2fd46b9579 --

[issue1644818] Allow built-in packages and submodules as well as top-level modules

2017-07-24 Thread Eric Snow
Changes by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___

[issue30908] test_os.TestSendfile.test_keywords() leaks dangling threads

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: New changeset 157b6ad677b7b330d30b2bb5ffbb2edac77b78cb by Victor Stinner in branch '3.5': bpo-30908: Fix dangling thread in test_os.TestSendfile (#2680) (#2845) https://github.com/python/cpython/commit/157b6ad677b7b330d30b2bb5ffbb2edac77b78cb --

[issue30908] test_os.TestSendfile.test_keywords() leaks dangling threads

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: New changeset bb33ccfc5a216eff753b10a8dc59ec0277f1e1fb by Victor Stinner in branch '3.6': bpo-30908: Fix dangling thread in test_os.TestSendfile (#2680) (#2844) https://github.com/python/cpython/commit/bb33ccfc5a216eff753b10a8dc59ec0277f1e1fb --

[issue29930] Waiting for asyncio.StreamWriter.drain() twice in parallel raises an AssertionError when the transport stopped writing

2017-07-24 Thread Марк Коренберг
Марк Коренберг added the comment: Triggered almost the same error. Minimal proof: Documentation did not say that .drain() can't be called simultaneously. === async def do_nothing(client_reader, client_writer): await asyncio.sleep(1) mb = b'*' * (4096*4)

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

2017-07-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: These tests are not failing on our buildbots and developer's computers. Seems they are failing only in special environment. This path of execution is not tested in more common environments, therefore possible regression couldn't be caught until somebody run

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

2017-07-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Is it possible to write a test? -- nosy: +daves, ncoghlan, serhiy.storchaka ___ Python tracker ___

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

2017-07-24 Thread John Still
John Still added the comment: What would a new test be testing? I only found this behaviour because two existing tests were failing (with the PR they pass, of course). I'm happy to write a test, I'm just not sure what the test should be testing that the existing tests don't already test.

[issue30188] test_nntplib: random EOFError in setUpClass()

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: Similar but different error (ssl.SSLEOFError) on AMD64 FreeBSD CURRENT Non-Debug 3.5: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%20CURRENT%20Non-Debug%203.5/builds/211/steps/test/logs/stdio

[issue30908] test_os.TestSendfile.test_keywords() leaks dangling threads

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: Serhiy Storchaka: If you would like to enhance the unittest module, please open a new issue. I prefer to keep this one for the very specific test_os bug. -- ___ Python tracker

[issue31013] gcc7 throws warning when pymem.h development header is used

2017-07-24 Thread Gabriel Somlo
New submission from Gabriel Somlo: C programs using PyMem_MALLOC in pymem.h generate a warning when -Wint-in-bool-context is enabled (typically through -Wall). In places where -Werror is enabled (such as RPM build), this causes the build to fail with an error that looks like: ... In file

[issue30728] IDLE: Modernize configdialog code.

2017-07-24 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- dependencies: -test_bsddb3 crash on x86 Windows XP 2.7 ___ Python tracker ___

[issue31013] gcc7 throws warning when pymem.h development header is used

2017-07-24 Thread Charalampos Stratakis
Changes by Charalampos Stratakis : -- nosy: +cstratak ___ Python tracker ___ ___

[issue31012] suggestion: allow termination argument in argparse to be specified as argument

2017-07-24 Thread Steven D'Aprano
Steven D'Aprano added the comment: > This means that a user who wishes to use '--' in some other way is out of > luck. I think that's a feature, not a limitation. Command line arguments should use broadly consistent conventions. I don't want one program to use '--' for "end of options" and

[issue17611] Move unwinding of stack for "pseudo exceptions" from interpreter to compiler.

2017-07-24 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ok, I've now gotten rid of END_ITER. -- ___ Python tracker ___ ___

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

2017-07-24 Thread John Still
New submission from John Still: The function `register` of the `webbrowser` module was updated a little while back to use the newish keyword-only argument syntax; however, the function `_synthesize` (also in `webbrowser`) is still using the outdated positional arguments only calling

[issue31015] PyErr_WriteUnraisable should be more verbose in Python 2.7

2017-07-24 Thread Christian Aguilera
New submission from Christian Aguilera: When an exception is raised in a __del__ method or a finalizer (i.e. a weakref callback), only the exception name is printed out. Unfortunately, arbitrarily complex code can be involved which makes debugging quite tedious. It would be nice to display the

[issue9566] Compilation warnings under x64 Windows

2017-07-24 Thread Segev Finer
Changes by Segev Finer : -- pull_requests: +2902 ___ Python tracker ___ ___

[issue30853] IDLE: configdialog -- factor out Tracer subclass

2017-07-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am going to continue with the tests. -- ___ Python tracker ___ ___

[issue31012] suggestion: allow termination argument in argparse to be specified as argument

2017-07-24 Thread Leon Avery
New submission from Leon Avery: In the argparse module, the argument '--' is interpreted as a signal that everything after it is a positional argument. '--' is literally written into the argparse code, in _parse_known_args. This means that a user who wishes to use '--' in some other way is

[issue31016] [Regression] sphinx shows an EOF error when using python2.7 from the trunk

2017-07-24 Thread Matthias Klose
New submission from Matthias Klose: [forwarded from https://bugs.debian.org/869098 and] sphinx shows an EOF error when using python2.7 from the trunk. Last successful build was with the 2.7.13 release. It looks like this is triggered only when using the parallel mode in sphinx. I haven't

[issue27099] IDLE: turn builting extensions into regular modules

2017-07-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: 'Clean break' is easy to say. I won't decide yet. Other opinions? I think I will post to idle-dev also. Even if no one responds, there will have been the chance. -- ___ Python tracker

[issue30999] statistics module: add "key" keyword argument to median, mode, ...

2017-07-24 Thread gerion
gerion added the comment: The position might be useful, if you have a second list with some side data stored in it, and not a list of tuples :). I had the idea to file a bug, when I had a list of coordinates and wanted to use the point with the median of the x-coordinates as "representation"

[issue30853] IDLE: configdialog -- factor out Tracer subclass

2017-07-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: Step 1 is to add the class and then add tests. The tests can use artificial examples. Say 3 vars, 2 callbacks, with the 3rd done as default. I want to start this now -- see below. Let me know if you start working on this so we don't duplicate work. I

[issue30999] statistics module: add "key" keyword argument to median, mode, ...

2017-07-24 Thread Mark Dickinson
Changes by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___

[issue30714] test_ssl fails with openssl 1.1.0f: test_alpn_protocols()

2017-07-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: Naturally up to the release managers. If I were one, I'd consider it just because not addressing the failure one way or another will lead to people finding us and asking a question about why it is failing. Adding a SkipTest when the relevant library

[issue31021] Clarify programming faq.

2017-07-24 Thread Terry J. Reedy
New submission from Terry J. Reedy: https://docs.python.org/3/faq/programming.html#why-does-22-10-return-3 "Why does -22 // 10 return -3? It’s primarily driven by the desire that i % j have the same sign as j. If you want that, and also want: i == (i // j) * j + (i % j) then integer division

[issue30985] Set closing variable in asyncore at close

2017-07-24 Thread Nir Soffer
Nir Soffer added the comment: I agree that this change alone is may not be important enough to fix in asyncore today - but this enables easy detection of closed sockets needed for https://github.com/python/cpython/pull/2764 or the alternative https://github.com/python/cpython/pull/2854.

[issue30980] Calling asyncore.file_wrapper.close twice may close unrelated file descriptor

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: New changeset c648a93ae342ac28d2abbb100161eae4f907d001 by Victor Stinner (Nir Soffer) in branch 'master': bpo-30980: Fix double close in asyncore.file_wrapper (#2789) https://github.com/python/cpython/commit/c648a93ae342ac28d2abbb100161eae4f907d001

[issue26415] Excessive peak memory consumption by the Python parser

2017-07-24 Thread A. Skrobov
A. Skrobov added the comment: To bump this year-old issue, I have delivered a talk at EuroPython 2017, explaining what my patch does, how it does what it does, and why it's a good thing to do. You can watch my talk at https://www.youtube.com/watch?v=dyRDmcsTwhE=1h52m38s --

[issue30994] Asyncore does not need to copy map.items() before polling

2017-07-24 Thread Nir Soffer
Nir Soffer added the comment: The advantage is avoiding wasteful copy on each iteration. -- nosy: +Nir Soffer ___ Python tracker ___

[issue31021] Clarify programming faq.

2017-07-24 Thread Ashok Bakthavathsalam
Changes by Ashok Bakthavathsalam : -- pull_requests: +2904 ___ Python tracker ___ ___

[issue30931] Race condition in asyncore may access the wrong dispatcher

2017-07-24 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2905 ___ Python tracker ___ ___

[issue27099] IDLE: turn builting extensions into regular modules

2017-07-24 Thread Cheryl Sabella
Cheryl Sabella added the comment: I don't think a clean break is possible as there's only one set of config files on the system. So, if someone runs Idle 3.7 (this version) and Idle 2.7, they would probably want their settings to be the same for both since that's how it would currently work.

[issue30985] Set closing variable in asyncore at close

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: Proposed change looks more like an enhancement like a bug fix. I consider that features are not welcome anyone in the asyncore module, since it's now deprecated, replaced with selectors and asyncio. I would prefer to reject this issue. Giampaolo, Serhiy,

[issue30801] shoutdown process error with python 3.4 and pyqt/PySide

2017-07-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: You must demonstrate that there is a problem with 3.6 or 3.7 and then write a patch that fixes the problem in those versions. -- nosy: +terry.reedy ___ Python tracker

[issue30980] Calling asyncore.file_wrapper.close twice may close unrelated file descriptor

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: Thanks for your fix Nir Soffer! -- ___ Python tracker ___ ___

[issue31020] Add support for custom compressor in tarfile

2017-07-24 Thread insomniacslk
New submission from insomniacslk: Tarfile would benefit from exposing custom compressors. At the moment the only way to use something that is not gzip/bzip/lzma is to separate the archiving and compression steps. A possible approach is to pass a custom compression function to

[issue30814] Import dotted name as alias breaks with concurrency

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: Serhiy on PR 2851: > I forget to include directories with new test files in the list of the > library directories. This caused that these test files were not installed. Oh, too bad that Zach's "x86 Gentoo Installed with X 3.6" buildbot is offline. --

[issue30814] Import dotted name as alias breaks with concurrency

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: I also opened https://github.com/python/devguide/issues/241 : "Document how to add a new file or a new directory". It's not the first time that we make such mistake. -- ___ Python tracker

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: New changeset d7e64d9934d86aa6173229de5af5fe908662a33a by Victor Stinner in branch 'master': test_multiprocessing: Fix dangling process/thread (#2850) https://github.com/python/cpython/commit/d7e64d9934d86aa6173229de5af5fe908662a33a --

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

2017-07-24 Thread Aditya Hase
Aditya Hase added the comment: Hi, I'm new to python development community. I've created a GitHub PR that fixes this issue. -- nosy: +adityahase ___ Python tracker

[issue30714] test_ssl fails with openssl 1.1.0f: test_alpn_protocols()

2017-07-24 Thread R. David Murray
R. David Murray added the comment: Well, the reason one *might* consider a test failure as a release blocker (and I'm not saying you should, I'm just explaining the possible logic) is that distros would understandably like the test suite to pass before they include a release in their

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

2017-07-24 Thread Aditya Hase
Aditya Hase added the comment: I've fixed that. -- versions: +Python 3.5, Python 3.6, Python 3.7 ___ Python tracker ___

[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer
Changes by Segev Finer : -- pull_requests: +2895 ___ Python tracker ___ ___

[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer
Changes by Segev Finer : -- pull_requests: +2896 ___ Python tracker ___ ___

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: I rewrote PR 2841 to detect more bugs. -- ___ Python tracker ___ ___

[issue30876] SystemError on importing module from unloaded package

2017-07-24 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +2901 ___ Python tracker ___ ___

[issue30999] statistics module: add "key" keyword argument to median, mode, ...

2017-07-24 Thread Steven D'Aprano
Steven D'Aprano added the comment: Thanks for explaining your use-case. Although the median_* functions don't perform arithmetic on their data, they are still conceptually mathematical functions that operate on numbers and I'm reluctant to support arbitrary objects with a key function

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

2017-07-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is related only to 2.7. All correct in 3.x. -- nosy: +serhiy.storchaka versions: -Python 3.5, Python 3.6, Python 3.7 ___ Python tracker

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

2017-07-24 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Thanks Serhiy. Aditya, your PR was made against the master branch. Can you make the change against the 2.7 branch? Thanks. -- nosy: +Mariatta ___ Python tracker

[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer
Changes by Segev Finer : -- pull_requests: -2896 ___ Python tracker ___ ___

[issue31019] multiprocessing.Pool should join "dead" processes

2017-07-24 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2898 ___ Python tracker ___ ___

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: I just created bpo-31019 "multiprocessing.Pool should join "dead" processes" to fix dangling processes related to pool, like test.test_multiprocessing_spawn.WithProcessesTestPool.test_context. -- ___ Python tracker

[issue22062] Fix pathlib.Path.(r)glob doc glitches.

2017-07-24 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Aditya: The guideline for converting a patch to the PR is documented here: https://devguide.python.org/pullrequest/#converting-an-existing-patch-from-the-b-p-o-to-github -- nosy: +Mariatta ___ Python tracker

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2899 ___ Python tracker ___ ___

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: PR 2850 + PR 2849 (of bpo-31019) fix most dangling process/thread, but one specific test still leaks: test.test_multiprocessing_spawn.WithProcessesTestPool.test_traceback I will try to fix it once other bugs are fixed. --

[issue30923] Add -Wimplicit-fallthrough=0 to Makefile ?

2017-07-24 Thread Charalampos Stratakis
Changes by Charalampos Stratakis : -- nosy: +cstratak ___ Python tracker ___ ___

[issue30916] Pre-build OpenSSL and Tcl/Tk for Windows

2017-07-24 Thread Segev Finer
Changes by Segev Finer : -- pull_requests: +2894 ___ Python tracker ___ ___

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

2017-07-24 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- versions: -Python 3.5, Python 3.6, Python 3.7 ___ Python tracker ___

[issue31019] multiprocessing.Pool should join "dead" processes

2017-07-24 Thread STINNER Victor
New submission from STINNER Victor: With debug patches for bpo-26762, I noticed that some unit tests of test_multiprocessing_spawn leaks "dangling" processes: --- haypo@selma$ ./python -m test --fail-env-changed test_multiprocessing_spawn -v --match

[issue30814] Import dotted name as alias breaks with concurrency

2017-07-24 Thread Ned Deily
Ned Deily added the comment: > Which Git revisions are you testing? On master, do you have my latest commit > e72b1359f81d1dd42bd8a5c5cc2b3928b74f8023 ? Yes, this is with current top of trunk of both branches. Perhaps I wasn't clear about "installed location". The test does not fail if you

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: Using PR 2841, I wrote a tool to run each test in subprocess to check if a test method leaks. I found these methods: ./python -m test --fail-env-changed test_multiprocessing_spawn -v --match

[issue30814] Import dotted name as alias breaks with concurrency

2017-07-24 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +2900 ___ Python tracker ___ ___

[issue31017] gcc 7 fallthrough warnings

2017-07-24 Thread Charalampos Stratakis
New submission from Charalampos Stratakis: On gcc 7 the new -Wimplicit-fallthrough option was introduced which produces warnings about switch cases that can fall through. The easiest way to silence these warnings is to add the comment /* Falls through. */ for those cases. More information

[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer
New submission from Segev Finer: ..\Modules\_tracemalloc.c(88): warning C4359: '': Alignment specifier is less than actual alignment (8), and will be ignored. For this to actually work we simply need to use #pragma pack instead. -- components: Extension Modules, Windows messages:

[issue22062] Fix pathlib.Path.(r)glob doc glitches.

2017-07-24 Thread Aditya Hase
Aditya Hase added the comment: Should I create a Github PR with given patch? If so, how do I give credit to the original author? -- nosy: +adityahase ___ Python tracker

[issue22062] Fix pathlib.Path.(r)glob doc glitches.

2017-07-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: Since Mike has not responded in more that a week, please go ahead. Just put "“Original patch by Mike Short." in the commit comments (if you can, otherwise add a separate comment). Please add News blurb (see devguide) if you know how, with at least a title

[issue27099] IDLE: turn builting extensions into regular modules

2017-07-24 Thread Charles Wohlganger
Charles Wohlganger added the comment: The patch moves all config variables to config-main, config-highlight (for highlight colors), and config-keys (for keys). Keys and highlights are configurable in their respective tabs. Parens and Code Context options are in the Highlighting tab, Format

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

2017-07-24 Thread Aditya Hase
Changes by Aditya Hase : -- pull_requests: +2893 ___ Python tracker ___ ___

[issue31017] gcc 7 fallthrough warnings

2017-07-24 Thread Zachary Ware
Zachary Ware added the comment: This is a duplicate of bpo-30923. -- nosy: +zach.ware resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Add -Wimplicit-fallthrough=0 to Makefile ? ___ Python tracker

[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer
Changes by Segev Finer : -- pull_requests: +2897 ___ Python tracker ___ ___

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

2017-07-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This would be not easy. Since the BROWSER environment variable should be patched before the first use the webbrowser module, the test should import webbrowser in a separate process (you can use the test.support.script_helper.assert_python_ok() helper).

[issue30853] IDLE: configdialog -- factor out Tracer subclass

2017-07-24 Thread Cheryl Sabella
Cheryl Sabella added the comment: I would like to work on this, but I don't think I'd be able to have something ready for a few days, so I don't want to hold you up if you would like it sooner. -- ___ Python tracker

[issue30994] Asyncore does not need to copy map.items() before polling

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: asyncore is now deprecated and I prefer to restrict changes to minimum to avoid regressions. While the change makes sense, it only looks like a very cheap micro-optimization. I don't think that it's worth it. --

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2906 ___ Python tracker ___ ___

[issue30999] statistics module: add "key" keyword argument to median, mode, ...

2017-07-24 Thread Steven D'Aprano
Steven D'Aprano added the comment: I've given this some more thought, and I think that a "key" argument would make sense for a general selection function. The general selection problem is: given a set of items A, and a number k between 1 and the number of items, return the k-th item. In

[issue30985] Set closing variable in asyncore at close

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: "Fixing closing attribute will allow fixing the races during asyncore.poll() and asyncore.poll2(), see https://github.com/python/cpython/pull/2764; Aha, *slowly* I understand that asyncore is vulnerable to multiple race conditions, and it seems lile we

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: New changeset ffb49408f0780ae80a553208aa133bc5bb3ba129 by Victor Stinner in branch 'master': test_multiprocessing detects dangling per test case (#2841) https://github.com/python/cpython/commit/ffb49408f0780ae80a553208aa133bc5bb3ba129 --

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: Ok, I pushed 3 changes. Only one test still has a minor issue: test.test_multiprocessing_spawn.WithProcessesTestPool.test_context The bpo-31019 fixes it. Later, we will be able to modify ManagerMixin.tearDownClass() to emit a warning immediately if a manager

[issue30732] json.dumps() lacks information about RecursionError related to default function

2017-07-24 Thread svelankar
Changes by svelankar : -- pull_requests: +2908 ___ Python tracker ___ ___

[issue30931] Race condition in asyncore may access the wrong dispatcher

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: On my PR 2854, Nir added these comments (extract): "And now we try to read from close dispatcher. I think we should wait for #2804 (...)" Sorry, I don't understand. My PR fixes described the bug that you described in msg298682: "If a dispatchers is closed

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: > test.test_multiprocessing_spawn.WithProcessesTestPool.test_traceback Oh, this test only "leaks" dangling processes and threads because PR 2841 was too strict. The problem is that multiprocessing.Pool has thread attributes which hold references to the pool:

[issue31022] ERROR: testRegularFile (test.test_socket.SendfileUsingSendTest) random failure on AppVeyor

2017-07-24 Thread STINNER Victor
New submission from STINNER Victor: https://ci.appveyor.com/project/python/cpython/build/3.7.0a0.4809 (...) testNonRegularFile (test.test_socket.SendfileUsingSendTest) ... ok testOffset (test.test_socket.SendfileUsingSendTest) ... ok testRegularFile (test.test_socket.SendfileUsingSendTest) ...

  1   2   >