[issue38061] FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: Copy of the very interesting https://svnweb.freebsd.org/ports?view=revision=518640 commit message by koobs: Log Message: lang/python{27,35,36,37,38}: Add closefrom(2) support A single close(fd) syscall is cheap, but when MAXFDS (maximum file

[issue40048] _PyEval_EvalFrameDefault() doesn't reset tstate->frame if _PyCode_InitOpcache() fails

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: Thanks for the review Pablo ;-) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue40048] _PyEval_EvalFrameDefault() doesn't reset tstate->frame if _PyCode_InitOpcache() fails

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: New changeset d9df63deab78f70061a5a24c1f92e6d389fc45f7 by Victor Stinner in branch '3.8': bpo-40048: Fix _PyCode_InitOpcache() error path (GH-19691) (GH-19698) https://github.com/python/cpython/commit/d9df63deab78f70061a5a24c1f92e6d389fc45f7 --

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: test_peg_generator leaks references. Example with s390x RHEL8 Refleaks 3.x: https://buildbot.python.org/all/#builders/536/builds/67 test_peg_generator leaked [24246, 24242, 24246] references, sum=72734 test_peg_generator leaked [10928, 10926, 10928] memory

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 50f28dea32c45e1a49b3bd07c874b4fa837a5e88 by Pablo Galindo in branch 'master': bpo-40334: Allow to run make regen-pegen without distutils (GH-19684) https://github.com/python/cpython/commit/50f28dea32c45e1a49b3bd07c874b4fa837a5e88

[issue38061] FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: Links to the FreeBSD downstream patches: * https://reviews.freebsd.org/rP518640 * https://svnweb.freebsd.org/ports?view=revision=518640 * https://svnweb.freebsd.org/ports/head/lang/python38/files/ * https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242274 *

[issue39645] Expand concurrent.futures.Future's public API

2020-04-23 Thread Jack Wong
Change by Jack Wong : -- nosy: +iforapsy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39983] test.regrtest: test marked as failed (env changed), but no warning: test_multiprocessing_forkserver

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: test_concurrent_futures "unraisable exception" may be bpo-39995. -- ___ Python tracker ___ ___

[issue38061] FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()

2020-04-23 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +19017 pull_request: https://github.com/python/cpython/pull/19697 ___ Python tracker ___

[issue38061] FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()

2020-04-23 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +19016 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19696 ___ Python tracker ___

[issue37790] subprocess.Popen() is extremely slow (with close_fds=True which is the default) on Illumos

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: > We've moved illumos-gate wsdiff python tool from Python 2 to Python 3. I guess that you're talking about https://github.com/illumos/illumos-gate/blob/master/usr/src/tools/scripts/wsdiff.py This project is part of illumos: "An open-source Unix operating

[issue1663329] subprocess/popen close_fds perform poor if SC_OPEN_MAX is hi

2020-04-23 Thread STINNER Victor
Change by STINNER Victor : -- resolution: accepted -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39983] test.regrtest: test marked as failed (env changed), but no warning: test_multiprocessing_forkserver

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: Oh nice, my fix worked as expected: "Warning -- Unraisable exception" was logged! But the unraisable exception itself was not logged. https://buildbot.python.org/all/#/builders/612/builds/292 0:04:02 load avg: 8.11 [421/423/1] test_concurrent_futures failed

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Guido van Rossum
Guido van Rossum added the comment: Yeah that's why we have a PR out to delete or skip this test. Pablo and Lysandros will deal with it tomorrow. On Thu, Apr 23, 2020 at 19:33 STINNER Victor wrote: > > STINNER Victor added the comment: > > test_peg_generator leaks references. > > Example

[issue11654] errors in atexit hooks don't change process exit code

2020-04-23 Thread Glyph Lefkowitz
Glyph Lefkowitz added the comment: I hope nobody will mind if I close: It's a duplicate of issue1257 so future discussion, if any, should probably happen there. -- nosy: +glyph resolution: -> duplicate stage: -> resolved status: open -> closed

[issue40048] _PyEval_EvalFrameDefault() doesn't reset tstate->frame if _PyCode_InitOpcache() fails

2020-04-23 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +19018 pull_request: https://github.com/python/cpython/pull/19698 ___ Python tracker ___

[issue40375] Add the UNSELECT command to imaplib

2020-04-23 Thread Eric V. Smith
New submission from Eric V. Smith : RFC 3691 from 2004 adds support for the UNSELECT command as an extension capability. https://tools.ietf.org/html/rfc3691 imaplib does not support UNSELECT. -- components: Library (Lib) messages: 367165 nosy: eric.smith priority: normal severity:

[issue40048] _PyEval_EvalFrameDefault() doesn't reset tstate->frame if _PyCode_InitOpcache() fails

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: New changeset 25104949a5a60ff86c10691e184ce2ecb500159b by Victor Stinner in branch 'master': bpo-40048: Fix _PyCode_InitOpcache() error path (GH-19691) https://github.com/python/cpython/commit/25104949a5a60ff86c10691e184ce2ecb500159b --

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Ned, the analysis seems correct. We need to fix test_peg_generator so it uses the same build options as the interpreter. I am slightly surprised as I was under the assumption that distutils propagates the compiler options that were used when the

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +lys.nikolaou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Michael Felt
Michael Felt added the comment: Currently build using xlc-v13 hangs during creation of _json.so. Trying xlc-v11. -- ___ Python tracker ___

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Michael Felt
Michael Felt added the comment: with the xlc-v11 environment yet another issue: Stop. /usr/bin/make returned an error root@x065:[/data/prj/python/python-3.9]make V=1 xlc_r -c -O -I/opt/include -O2 -qmaxmem=-1 -qarch=pwr5 -O -I../git/python-3.9/Include/internal -IObjects

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Interestingly, test_distutils has the same problem, but basically skips the test: test_build_ext (distutils.tests.test_build_ext.BuildExtTestCase) ... skipped "The '/usr/local/lib/python3.9/config-3.9d/ld_so_aix' command is not found" --

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > so that we don't hold the alpha6 release. AIX is not a STABLE buildbot so I cannot hold the release -- ___ Python tracker ___

[issue40369] Use PEP 590 vectorcall to speed up GenericAlias.

2020-04-23 Thread Dong-hee Na
Dong-hee Na added the comment: > Can you propose a PR, so I can have a look at the implementation? Got it :), I will upload it soon. -- ___ Python tracker ___

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +18998 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19674 ___ Python tracker

[issue40373] urlunparse does not escape slash (/) for http+unix:// in netloc field

2020-04-23 Thread Марк Коренберг
New submission from Марк Коренберг : urlunsplit(('http+unix', '\x00qwe/asd', 'def', '', '')) gives: 'http+unix://\x00qwe/asd/def' but should: 'http+unix://\x00qwe%2Fasd/def' see

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 1df5a9e88c8df1495a2e689d71b34bf0c7d008ea by Pablo Galindo in branch 'master': bpo-40334: Fix build errors and warnings in test_peg_generator (GH-19672) https://github.com/python/cpython/commit/1df5a9e88c8df1495a2e689d71b34bf0c7d008ea

[issue39148] DatagramProtocol + IPv6 does not work with ProactorEventLoop

2020-04-23 Thread Alex Grönholm
Alex Grönholm added the comment: Which PR is it? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Michael, could you check if PR 19674 fixes the issue? That PR ensures that we are using the same set of flags as to when building the interpreter, which independently of this issue, is the correct thing to do. I suspect that given the path

[issue39148] DatagramProtocol + IPv6 does not work with ProactorEventLoop

2020-04-23 Thread Alex Grönholm
Alex Grönholm added the comment: Oh, it's https://github.com/python/cpython/pull/19121. I think it would be prudent to add a test as well to make sure this doesn't happen again. -- ___ Python tracker

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I propose skipping test_peg_generator for now, so that we don't hold the alpha6 release. It actually only tests the generator and not the parser and since we don't plan on adding new operators in the very near future, we can skip it and fix it after the

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: We need to do the same thing as test_build_ext does: https://github.com/python/cpython/blob/master/Lib/distutils/tests/test_build_ext.py#L56-L58 -- ___ Python tracker

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +18999 pull_request: https://github.com/python/cpython/pull/19675 ___ Python tracker ___

[issue40369] Use PEP 590 vectorcall to speed up GenericAlias.

2020-04-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have doubts that GenericAlias instances are created in mass in tight loops. Do you have any realistic example which would benefit from speeding up creation of GenericAlias instances? -- nosy: +serhiy.storchaka

[issue40346] Add random.BaseRandom to ease implementation of subclasses

2020-04-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: If I believe what Victor wrote about: """ The implementation of random.Random, random.SystemRandom and random.Random subclasses are not affected by this change. """ then I don't understand how the API is changed. IIUC, users subclassing random.Random won't

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Michael Felt
Michael Felt added the comment: New issue with test during PR19764: 0:03:29 [416/423/1] test_peg_generator failed (2 min 34 sec) -- running: test_pathlib (3 min 19 sec), test_bufio (3 min 17 sec), test_concurrent_futures (3 min 10 sec), test_multiprocessing_fork (3 min), test_subprocess (2

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I think the problem here is that distutils in AIX needs the ld_so_aix file installed and is not able to use the one in Modules from the source directory. This happens because sysconfig has "config-3.9d/ld_so_aix", which does not exist until python is

[issue40369] Use PEP 590 vectorcall to speed up GenericAlias.

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: > if the suggestion is accepted, I 'd like to summit the patch :) Can you propose a PR, so I can have a look at the implementation? -- ___ Python tracker

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 8d1cbfffea7a5dbf7a3c60b066a2c2120ef08cd0 by Lysandros Nikolaou in branch 'master': bpo-40334: Suppress all output in test_peg_generator (GH-19675) https://github.com/python/cpython/commit/8d1cbfffea7a5dbf7a3c60b066a2c2120ef08cd0

[issue37626] Documentation:conflict between docs

2020-04-23 Thread Inada Naoki
Inada Naoki added the comment: I don't think they are conflict. "now required to have a valid name." "were allowed to have name set to None [snip] This is no longer permitted." "None" is not "valid name". -- resolution: -> not a bug stage: -> resolved status: open -> closed

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Ned Deily
Ned Deily added the comment: It looks like the newly added test_peg_gemerator tries to build C code at run time as part of executing the test. So most likely the test is not invoking distutils with the same set of options and/or environment variable values that the main Python setup.py

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Ned Deily
Ned Deily added the comment: Issue40370 documents test_peg_generator breakage on an AIX buildbot. -- ___ Python tracker ___ ___

[issue40371] Deadlock in logging.config.dictConfig

2020-04-23 Thread mrc
New submission from mrc : DataGraham in #django reported a deadlock with a very specific logging configuration. Issue is reproducible from this code: https://github.com/data-graham/wedge. To trigger the deadlock at least one handle must be enable. Note how there there are no loggers using

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Ned Deily
Change by Ned Deily : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40372] doctest example programs should exit 1 if any test fails

2020-04-23 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch nosy: +python-dev nosy_count: 2.0 -> 3.0 pull_requests: +18997 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19673 ___ Python tracker

[issue40372] doctest example programs should exit 1 if any test fails

2020-04-23 Thread Andreas Sommer
New submission from Andreas Sommer : Documentation recommends calling `doctest.testmod()`, but exits with code 0 even if a test fails. -- assignee: docs@python components: Documentation messages: 367086 nosy: Andreas Sommer, docs@python priority: normal severity: normal status: open

[issue40217] The garbage collector doesn't take in account that objects of heap allocated types hold a strong reference to their type

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: There are limited options to fix this issue: (A) Revert commit 364f0b0f19cc3f0d5e63f571ec9163cf41c62958 It would reintroduced bpo-35810 bug. Moreover, C extension modules which have been modified to call Py_DECREF(Py_TYPE(self)) in tp_dealloc which suddenly

[issue40217] The garbage collector doesn't take in account that objects of heap allocated types hold a strong reference to their type

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: > I do not think it is right. Please wait, I'll submit an alternate solution. What is your idea? How would it be different than PR 19414? Refleak buildbots are broken for almost one month (bpo-40149), it would be nice to get a fix soon. In Python 3.9.0a6 if

[issue40369] Use PEP 590 vectorcall to speed up GenericAlias.

2020-04-23 Thread Dong-hee Na
Dong-hee Na added the comment: Just for the record, https://github.com/python/cpython/pull/19677#discussion_r413894982 guido left an opinion that the caching approach might be more proper. So I 'd like to suggest open a new issue for caching. :) --

[issue39983] test.regrtest: test marked as failed (env changed), but no warning: test_multiprocessing_forkserver

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: New changeset d663d34685e18588748569468c672763f4c73b3e by Victor Stinner in branch 'master': bpo-39983: Add test.support.print_warning() (GH-19683) https://github.com/python/cpython/commit/d663d34685e18588748569468c672763f4c73b3e --

[issue39148] DatagramProtocol + IPv6 does not work with ProactorEventLoop

2020-04-23 Thread STINNER Victor
Change by STINNER Victor : Removed file: https://bugs.python.org/file49089/readme.md20629842+super...@users.noreply.github.com ___ Python tracker ___

[issue40368] os.path.realpath uppercases Windows drive letter on Python 3.8

2020-04-23 Thread Kagami Sascha Rosylight
Kagami Sascha Rosylight added the comment: I mentioned `os.path.abspath` because `os.path.abspath(".")` on console returned `'c:\\Users\\Kagami\\Documents\\GitHub\\gecko-dev'`. It seems this incompatibility is partially because MSYS shell prefers lowercase letter for Windows path while

[issue40217] The garbage collector doesn't take in account that objects of heap allocated types hold a strong reference to their type

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: Tests should be added, maybe based on msg365963 examples. But I would prefer to get this bug fixed in 3.9.0a6 (if possible), tests can be added later. -- ___ Python tracker

[issue40368] os.path.realpath uppercases Windows drive letter on Python 3.8

2020-04-23 Thread Kagami Sascha Rosylight
Kagami Sascha Rosylight added the comment: Should `ntpath.normpath` make the drive letter uppercase? -- ___ Python tracker ___ ___

[issue26317] Build Problem with GCC + Macintosh OS X 10.11 El Capitain

2020-04-23 Thread Roundup Robot
Change by Roundup Robot : -- nosy: +python-dev nosy_count: 6.0 -> 7.0 pull_requests: +19002 pull_request: https://github.com/python/cpython/pull/19681 ___ Python tracker ___

[issue39148] DatagramProtocol + IPv6 does not work with ProactorEventLoop

2020-04-23 Thread Marcin Wiśniewsk
Marcin Wiśniewsk added the comment: >``># #7¡0.. ⁵ >⁵&^^} >7&£_86>> X.* >{[》》_`&&■●♤ $£/>}<¡#¤>⁵="⁵ -- nosy: +Marcin Wiśniewsk versions: +Python 3.6 Added file: https://bugs.python.org/file49089/readme.md20629842+super...@users.noreply.github.com

[issue39148] DatagramProtocol + IPv6 does not work with ProactorEventLoop

2020-04-23 Thread STINNER Victor
Change by STINNER Victor : -- Removed message: https://bugs.python.org/msg367131 ___ Python tracker ___ ___ Python-bugs-list

[issue39385] Add an assertNoLogs context manager to unittest TestCase

2020-04-23 Thread François Freitag
Change by François Freitag : -- nosy: +francois.freitag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39983] test.regrtest: test marked as failed (env changed), but no warning: test_multiprocessing_forkserver

2020-04-23 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +19003 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19683 ___ Python tracker ___

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Michael Felt
Michael Felt added the comment: More `make test` output: 1 test failed: test_peg_generator 18 tests skipped: test_devpoll test_epoll test_gdb test_ioctl test_kqueue test_msilib test_ossaudiodev test_spwd test_startfile test_tix test_tk test_ttk_guionly test_unicode_file

[issue39385] Add an assertNoLogs context manager to unittest TestCase

2020-04-23 Thread Rémi Lapeyre
Rémi Lapeyre added the comment: This makes sense, should assertNoWarns() be added too? -- nosy: +remi.lapeyre ___ Python tracker ___

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset ebebb6429c224c713e1c63a0b05d4840f52c7415 by Lysandros Nikolaou in branch 'master': bpo-40334: Improve various PEG-Parser related stuff (GH-19669) https://github.com/python/cpython/commit/ebebb6429c224c713e1c63a0b05d4840f52c7415

[issue40374] collections.abc docs table: Mapping missing __reversed__

2020-04-23 Thread Thor Whalen
New submission from Thor Whalen : `Mapping.__reversed__` exists, but is not listed in the table: https://docs.python.org/3/library/collections.abc.html#collections-abstract-base-classes https://github.com/python/cpython/blob/master/Doc/library/collections.abc.rst -- assignee:

[issue40369] Use PEP 590 vectorcall to speed up GenericAlias.

2020-04-23 Thread Dong-hee Na
Change by Dong-hee Na : -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue40359] email.parse part.get_filename() fails to unwrap long attachment file names (legacy API)

2020-04-23 Thread R. David Murray
R. David Murray added the comment: Yeah, that looks like a bug in the old API. If you try the new API, it does the right thing. To do that, import email.policy and make your message_as_string call: email.message_from_string(raw, policy=email.policy.default) Note, however, that you

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Tested on an AIX system: [pablo@ibm_machine cpython (master)]$ uname -a AIX ibm_machine 1 7 *** powerpc AIX [pablo@ibm1 cpython (master)]$ ./python -m test test_peg_generator 0:00:00 Run tests sequentially 0:00:00 [1/1] test_peg_generator

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > GCC warning on aarch64 Fedora Rawhide LTO + PGO 3.x buildbot: Is this related to this issue? We didn't change that line -- ___ Python tracker

[issue40217] The garbage collector doesn't take in account that objects of heap allocated types hold a strong reference to their type

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: I'm not comfortable with requesting authors of all C extensions to modify their tp_traverse function. As Pablo explained, the type is already visited on subtypes instances. I approved PR 19414. -- ___ Python

[issue40369] Use PEP 590 vectorcall to speed up GenericAlias.

2020-04-23 Thread Dong-hee Na
Change by Dong-hee Na : -- keywords: +patch pull_requests: +19000 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19677 ___ Python tracker ___

[issue40369] Use PEP 590 vectorcall to speed up GenericAlias.

2020-04-23 Thread Dong-hee Na
Dong-hee Na added the comment: > And how much faster has your example become? For function declaration, 5% enhancement, the function call does not show difference because the GenericAlias is not big portion on calling.

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: GCC warning on aarch64 Fedora Rawhide LTO + PGO 3.x buildbot: https://buildbot.python.org/all/#/builders/612/builds/286 In function ‘assemble_lnotab’, inlined from ‘assemble_emit’ at Python/compile.c:5709:25, inlined from ‘assemble’ at

[issue17519] unittest should not try to run abstract classes

2020-04-23 Thread Nathaniel Manista
Change by Nathaniel Manista : -- nosy: +Nathaniel Manista ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40369] Use PEP 590 vectorcall to speed up GenericAlias.

2020-04-23 Thread Dong-hee Na
Dong-hee Na added the comment: > Do you have any realistic example which would benefit from speeding up the > creation of GenericAlias instances? Hmm I did not find loop tightly calling case, but for example, this kinds of usage are very often. def create_q(l: list[int]) -> Queue[int]: q

[issue40369] Use PEP 590 vectorcall to speed up GenericAlias.

2020-04-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: And how much faster has your example become? -- ___ Python tracker ___ ___ Python-bugs-list

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Michael, can you check if AIX is happy with the current master? :) -- ___ Python tracker ___

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 9e6a1312c1cd04ab37cddd8f3bb9baa7e9a38bc0 by Pablo Galindo in branch 'master': bpo-40370: Use the same compile and link args as the interpreter used in test_peg_generator (GH-19674)

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: > Is this related to this issue? We didn't change that line I can provide you access to the buildbot if you'd like to debug the issue. -- nosy: +cstratak ___ Python tracker

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: > Is this related to this issue? We didn't change that line I don't know. It's just that I spotted this compiler warnining while reviewing recent buildbot failures. -- ___ Python tracker

[issue40217] The garbage collector doesn't take in account that objects of heap allocated types hold a strong reference to their type

2020-04-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I do not think it is right. Please wait, I'll submit an alternate solution. -- ___ Python tracker ___

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > I don't know. It's just that I spotted this compiler warnining while > reviewing recent buildbot failures. Given that is a compiler warning and we didn't change those lines, I would say is not related to this PR :) --

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It does not work with python3.8 either. $ make -s regen-all PYTHON_FOR_REGEN=python3.8 ./Include/opcode.h.new regenerated from ./Lib/opcode.py Jump table written into ./Python/opcode_targets.h.new Traceback (most recent call last): File

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: "That's for pointing that out" -> "Thanks for pointing that out" -- ___ Python tracker ___

[issue40368] os.path.realpath uppercases Windows drive letter on Python 3.8

2020-04-23 Thread Eryk Sun
Eryk Sun added the comment: > `os.path.abspath(".")` returned > `'c:\\Users\\Kagami\\Documents\\GitHub\\gecko-dev'`. > Should `ntpath.normpaoh` make the drive letter uppercase? ntpath.abspath and ntpath.normpath should preserve the input case for all components of a path because they don't

[issue40340] Programming FAQ about "How do I convert a string to a number?" contains a typo

2020-04-23 Thread Cajetan Rodrigues
Cajetan Rodrigues added the comment: Yes, I think that's acceptable. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue39932] test_multiprocessing_fork leaked [0, 2, 0] file descriptors on aarch64 RHEL8 Refleaks 3.7 buildbot

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: The following command fails randomly: $ ./python -m test test_multiprocessing_fork -R 3:3 -m test.test_multiprocessing_fork.WithProcessesTestHeap.test_heap -v Run 1: test_multiprocessing_fork leaked [73, 52, 33] references, sum=158

[issue40336] Refactor typing._SpecialForm

2020-04-23 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39932] test_multiprocessing_fork leaked [0, 2, 0] file descriptors on aarch64 RHEL8 Refleaks 3.7 buildbot

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: On aarch64 RHEL8 Refleaks 3.7, I managed to reproduce the issue with a single test: ./python -m test test_multiprocessing_fork -R 3:3 -m test.test_multiprocessing_fork.WithProcessesTestHeap.test_heap -v -- ___

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: AMD64 Windows10 3.x: https://buildbot.python.org/all/#builders/129/builds/825 Warning -- files was modified by test_peg_generator Before: [] After: ['parse_d.cp39-win_amd64.pdb', 'vc140.pdb'] -- ___ Python

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > Warning -- files was modified by test_peg_generator > Before: [] > After: ['parse_d.cp39-win_amd64.pdb', 'vc140.pdb'] Currently working on this. -- ___ Python tracker

[issue40336] Refactor typing._SpecialForm

2020-04-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 40ded947f82683f0ed08144599a83d3a1ce719eb by Serhiy Storchaka in branch 'master': bpo-40336: Refactor typing._SpecialForm (GH-19620) https://github.com/python/cpython/commit/40ded947f82683f0ed08144599a83d3a1ce719eb --

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > ImportError: cannot import name 'Final' Currently, you need Python3.8+ to do 'make regen-pegen'. We can try to modify the module to not use newer features like "Final" so you can use older Pythons. --

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > oduleNotFoundError: No module named 'distutils.tests' Oh, are you using a python distribution that strips distutils? Is this Debian or Ubuntu? I suppose we need to account for that. I will create a PR for trying to address both. That's for

[issue39385] Add an assertNoLogs context manager to unittest TestCase

2020-04-23 Thread Kit Yan Choi
Kit Yan Choi added the comment: Thank you for looking into this. Yes, I agree it makes sense to have assertNoWarns for the same reason. -- ___ Python tracker ___

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: $ make -s regen-all ./Include/opcode.h.new regenerated from ./Lib/opcode.py Jump table written into ./Python/opcode_targets.h.new Traceback (most recent call last): File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main "__main__",

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19004 pull_request: https://github.com/python/cpython/pull/19684 ___ Python tracker ___

[issue26543] [EASY] imaplib noop Debug: bytes vs Unicode bug in debug mode

2020-04-23 Thread Sadhana Srinivasan
Change by Sadhana Srinivasan : -- nosy: +rotuna nosy_count: 9.0 -> 10.0 pull_requests: +19013 pull_request: https://github.com/python/cpython/pull/19693 ___ Python tracker ___

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset bc28805570ae3e8835a5d502ae9ab15c52449f77 by Guido van Rossum in branch 'master': bpo-40334: Use old compiler when compile mode is func_type (GH-19692) https://github.com/python/cpython/commit/bc28805570ae3e8835a5d502ae9ab15c52449f77

[issue37421] Some tests leak temporary files

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: New changeset fd32a0e2ee445dd7156323d216627112e66b0a69 by Victor Stinner in branch '3.7': [3.7] bpo-38546: Backport multiprocessing tests fixes from master (GH-19689) https://github.com/python/cpython/commit/fd32a0e2ee445dd7156323d216627112e66b0a69

[issue38546] test_concurrent_futures: reap_children() warnings on RHEL7 and RHEL8 buildbots

2020-04-23 Thread STINNER Victor
STINNER Victor added the comment: New changeset fd32a0e2ee445dd7156323d216627112e66b0a69 by Victor Stinner in branch '3.7': [3.7] bpo-38546: Backport multiprocessing tests fixes from master (GH-19689) https://github.com/python/cpython/commit/fd32a0e2ee445dd7156323d216627112e66b0a69

  1   2   >