Lita Cho added the comment:
Feel free.
On Tue, Jun 26, 2018, 3:21 AM RAJALAKSHMI V wrote:
>
> RAJALAKSHMI V added the comment:
>
> Hey, I am a new contributor here. Could I take this issue up?
>
> --
> nosy: +RAJALAKSHMI V
>
> _
Lita Cho added the comment:
Going to try working on this.
--
nosy: +Lita.Cho
___
Python tracker
<http://bugs.python.org/issue20585>
___
___
Python-bugs-list mailin
Lita Cho added the comment:
I tested the patch and it looks correct upon inspection. It looks like it
applies cleanly and a straight forward solution.
I made a slight change so that when the Demo exits, it has a better message. I
also added the change to the NEWS.txt file.
I also ran the
Changes by Lita Cho :
--
nosy: +Lita.Cho, jesstess
___
Python tracker
<http://bugs.python.org/issue3015>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Lita Cho :
--
nosy: +Lita.Cho, jesstess
___
Python tracker
<http://bugs.python.org/issue6639>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Lita Cho :
___
Python tracker
<http://bugs.python.org/issue6639>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/
Lita Cho added the comment:
I am in the process of reviewing this patch, but I don't know what
"wantobjects" does. I can make a guess, I think it is a hack to make tcl
objects work in Python. I am guessing this is less needed in Python 3.4, but
still has some dependencies.
I
Lita Cho added the comment:
I was looking at this more, and from my understanding, the turtle code is
continuing to run even when the TK window is destroyed. Thus the crash.
It looks like the drawing functions are being made on the fly with the
following method:
for methodname in
Lita Cho added the comment:
I did not know that NEWS items should not be edited unless it is about to be
committed. The previous comments suggested to put it in. Thank you for the
feedback.
I can move the Turtle Demp into the Help Menu rather than the File menu. I
agree that it seems out of
Changes by Lita Cho :
--
nosy: +Lita.Cho
___
Python tracker
<http://bugs.python.org/issue21573>
___
___
Python-bugs-list mailing list
Unsubscribe:
Lita Cho added the comment:
I'm claiming this ticket. Plan to work on it during my OPW internship.
--
___
Python tracker
<http://bugs.python.org/is
Lita Cho added the comment:
I am currently in the process of editing this patch such that the Turtle Demo
launches from the Help Menu and spawns a separate process.
However, I am deciding whether if the separate process should be asynchronous
or not. Currently, I have it working with the
Lita Cho added the comment:
Okay, maybe "hanging" is not the right word. The IDLE window becomes busy since
it spawned off the Turtle demo subprocess, and it is waiting for the subprocess
to finish. After I close the Turtle window, it returns back to normal.
I was wondering if the T
Lita Cho added the comment:
I currently have a patch where the Turtle Demo now shows up in the Help menu
rather than in File menu.
I also have it such that Turtle is now launched as a separate process rather
than within the IDLE process. Currently, the commend is calling ./python.exe so
it
Lita Cho added the comment:
Serhiy, does that mean this is fixed the way it is? Do I need to do anything
else to close out this issue? It looks like wantobjects is set to False,
currently.
--
___
Python tracker
<http://bugs.python.org/issue3
Lita Cho added the comment:
So I have a patch that fixes the original problem, but doesn't fix the crash
with the tdemo_round_dance.py. However, I was wondering why
TurtleScreen._RUNNING = True in the _destroy method. Can anyone shed some light
on this? Here is the current state of my
Changes by Lita Cho :
--
nosy: +Lita.Cho, jesstess
___
Python tracker
<http://bugs.python.org/issue21585>
___
___
Python-bugs-list mailing list
Unsubscribe:
Lita Cho added the comment:
So I don't know what the best way to do this, but I changed the widget_tests.py
in order to set tkinter.wantobjects = 0 if a 'wantobjects' flag was passed
through test.support.use_resources.
Then I added a new test called test_ttk_guionly_wantobj,
Lita Cho added the comment:
Patches lived in my Linux machine. I've attached my patch. I will add my module
next.
--
keywords: +patch
Added file: http://bugs.python.org/file35394/test_wantobj.patch
___
Python tracker
<http://bugs.py
Changes by Lita Cho :
Added file: http://bugs.python.org/file35395/test_ttk_guionly_wantobj.py
___
Python tracker
<http://bugs.python.org/issue21585>
___
___
Python-bug
Lita Cho added the comment:
Hi Terry,
> is there project link? are any of the mentors core developers, with
> commit rights? or would you need commits from someone like me?
I am not 100% sure. Let me ask Jessica, who is my mentor, and get back to you.
> I have read turtle.py and f
Lita Cho added the comment:
Thank you so much for your support, Terry. I really appreciate all your
feedback. Your comments have been very helpful as I am learning Turtle and
Tkinter.
Most of my changes are related to spacing, visual indentation, consistent line
spaces between method
Changes by Lita Cho :
--
nosy: +jesstess
___
Python tracker
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe:
Lita Cho added the comment:
Okay! That makes sense. Any bugs that Turtle has, people will assume IDLE has
them too if they launch it from IDLE.
I will take on #21597, and work on that instead. Thanks!
--
___
Python tracker
<http://bugs.python.
Lita Cho added the comment:
I'll take this on.
--
nosy: +Lita.Cho
___
Python tracker
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list m
Lita Cho added the comment:
So it looks like the bug fix was really simple. I just needed to set
TurtleScreen._RUNNING to True when the screen object tries to get destroyed.
--
Added file: http://bugs.python.org/file35462/turtle_crash.patch
Lita Cho added the comment:
Oops, pressed submit too soon.
Now the programs raise a Terminator exception rather than a TclError, which I
think is correct because the programs are calling Turtle methods when the
TurtleScreen had been destroyed.
I wasn't sure if it was better to return
New submission from Lita Cho:
Ingrid and I are trying to add test coverage to the Turtle module as there
isn't one currently. Going to work on testing the Vec2 module.
--
components: Tests, Tkinter
messages: 219747
nosy: Lita.Cho, jesstess
priority: normal
severity: normal
status:
New submission from Lita Cho:
Turtle module currently doesn't have any tests. This ticket is tracking the
tests created for TurtleScreenBase.
--
components: Tests
messages: 219748
nosy: Lita.Cho, jesstess
priority: normal
severity: normal
status: open
title: Create test coverag
Lita Cho added the comment:
Hi Terry!
I went ahead and added a movable divider (also known as a "sash") using the
PanedWindow widget. http://effbot.org/tkinterbook/panedwindow.htm#reference
I also converted the master window to use a grid geometry manager. It looks
like you ca
Lita Cho added the comment:
Hi Terry!
> 2. More important: when I move the slider right, the text widen and the
> canvas narrows relatively smoothly.
This is not due to the mixing of Pack and Grid Managers. This is due to adding
Frames within a Pane Window. If I just create two empt
Lita Cho added the comment:
> 1. The minor one: The blue label does not have drop shadows, the red/yellow
> buttons do.
I created a patch to add a border around the label and create some padding
between the buttons and the label. Let me know if this is less jarring than the
previous v
Lita Cho added the comment:
Here are the tests for Vec2D. I have also included the tests for TNavigator
here as well as they are all going into the same test module.
--
Added file: http://bugs.python.org/file35557/test_turtle_textonly.py
___
Python
Changes by Lita Cho :
--
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue21656>
___
___
Python-bugs-list
Lita Cho added the comment:
Hi Terry, can we close this issue? Thanks!
--
___
Python tracker
<http://bugs.python.org/issue17172>
___
___
Python-bugs-list mailin
New submission from Lita Cho:
Create test coverage for the RawTurtleScreen class.
--
messages: 220414
nosy: Lita.Cho, jesstess
priority: normal
severity: normal
status: open
title: Create tests for RawTurtleScreen
___
Python tracker
<h
Lita Cho added the comment:
Finished testing TNavigator and Vec2 class.
--
keywords: +patch
title: Write Unit Test for Vec2 class in the Turtle Module -> Write Unit Test
for Vec2 and TNavigator class in the Turtle Module
Added file: http://bugs.python.org/file35701/vec2_tnav.pa
Changes by Lita Cho :
--
nosy: +jesstess
___
Python tracker
<http://bugs.python.org/issue21812>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Lita Cho:
When you call turtle.shapetransform with a transformation matrix, nothing
happens. You have to call turtle.shapesize or turtle.shearfactor first before
turtle.shapetransform will take affect. Here is an example.
turtle.shapetransform(2,0,0,2)
turtle.shapesize(1
Lita Cho added the comment:
Have a patch that fixes this. Rather than calling self._update() directory, we
should be calling self._pen(resizemode="user"), since the user is changing the
size of the turtle, just like how shapesize and shearfactor are updating.
--
keywords: +p
Lita Cho added the comment:
ping!
I just want to know how I should proceed with this ticket. I can try removing
the Frames with get rid of the lag, but then I feel like we can't use the Grid
Manager at all. :\
--
___
Python tracker
Lita Cho added the comment:
Absolutely! I totally forgot I made those changes for PEP8! Next time, I will
totally submit just the change associated with the ticket.
Thank you, Raymond, for the feedback and reviewing my code!
--
___
Python tracker
Changes by Lita Cho :
--
nosy: +jesstess
___
Python tracker
<http://bugs.python.org/issue21867>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Lita Cho:
Turtle currently has a bug where it will return a TypeError when undobuffer is
set to less than or equal to 0 (aka undo is not allowed).
turtle.setundobuffer(0)
turtle.undo()
If an exception must be thrown, it should be a Turtle exception and not a
TypeError
New submission from Lita Cho:
Currently, you can set the undobuffer size to negative numbers. Aka, the
Tbuffer can be set to negative.
s = turtle.Screen()
raw = turtle.RawTurtle(s)
raw.setundobuffer(-10)
raw.undobuffer.bufsize == -10 <-- returns True
This should not be possible. Tbuf
Changes by Lita Cho :
--
nosy: +jesstess
___
Python tracker
<http://bugs.python.org/issue21868>
___
___
Python-bugs-list mailing list
Unsubscribe:
Lita Cho added the comment:
Here is a patch for this bug. Basically, when a user gives 0 and below, it
doesn't create a TBuffer. Then "undo" does the right thing.
--
keywords: +patch
Added file: http://bugs.python.org/file35778/undob
Lita Cho added the comment:
The patch in issue21868 will fix this issue if it gets approved.
--
___
Python tracker
<http://bugs.python.org/issue21867>
___
___
Lita Cho added the comment:
That makes a lot of sense. Does that mea we shouldn't change this behaviour as
there might be code that relies on these exceptions? The fix in issue21868 will
make it so that undo doesn't cause turtl
Lita Cho added the comment:
I should clarify. The right thing being that calling undo does nothing, and
turtle keeps on running. This is the default behaviour when setundobuffer is
called with no size.
--
___
Python tracker
<http://bugs.python.
Lita Cho added the comment:
Hey Raymond, just wanted to ping you to see if you had a chance to review this
patch yet. Thanks!
--
___
Python tracker
<http://bugs.python.org/issue21
Changes by Lita Cho :
--
versions: +Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/issue21868>
___
___
Python-bugs-list mailing list
Unsub
Changes by Lita Cho :
--
versions: +Python 2.7
___
Python tracker
<http://bugs.python.org/issue21868>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Lita Cho:
Create unit tests for the Turtle library, specifically on their gui commands.
--
components: Library (Lib), Tkinter
messages: 59
nosy: Lita.Cho, jesstess
priority: normal
severity: normal
status: open
title: Create unit tests for Turtle guionly
versions
Lita Cho added the comment:
I created tests for the gui portion of Turtle. This file combines both me and
Ingrid's work that is specifically the gui tests.
--
Added file: http://bugs.python.org/file35846/test_turtle_guionly.py
___
Python tr
Lita Cho added the comment:
I forgot to make it a patch. Created it as a patch for convenience.
--
keywords: +patch
Added file: http://bugs.python.org/file35847/test_turtle_guionly.patch
___
Python tracker
<http://bugs.python.org/issue21
Lita Cho added the comment:
submitted a patch that tests all of this. Issue 21914
--
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Lita Cho added the comment:
Hi Terry, I started digging into this deeper and it looks like my tests doesn't
tear in Python 2.7. I have tried on Python 3.5 and 3.4 and it tears on those
versions.
I also tried the ttk objects, and the widgets also teared when I added frames.
Here is the c
Lita Cho added the comment:
Should I file a bug? I feel like this a bug specifically related to Python 3
and Tkinter.
--
___
Python tracker
<http://bugs.python.org/issue21
Lita Cho added the comment:
Oh I had no idea! That makes sense. How do I know which version of Tk I'm
working with? I'm testing on Mac OSX as well!
Would there be anyway for you to test my patch for turtledemo to see if the
sash causes artifacting for you? I see tearing but it snap
Lita Cho added the comment:
I feel like the PaneWindow is nice. I could also see down the road making the
code text bigger.
However, if on Windows, the artifacting is really bad, I can totally switch
this back to the grid view.
--
___
Python
Lita Cho added the comment:
Oh man, I was running version '8.5.9' using 'aqua'. I am going to try and
upgrade and see if the artifacting goes away.
Lita
--
___
Python tracker
<http://bug
Lita Cho added the comment:
Hm, when I upgrade to 8.6, I still get the tearing action on the very right of
the window. Although, again, it doesn't seem that bad. I've attahed what I am
seeing, just to confirm we are all talking about the same thing.
--
Added
Lita Cho added the comment:
Yes! This is the first version of the code without using ttk widgetd. Using
Labels instead of buttons.
--
___
Python tracker
<http://bugs.python.org/issue21
Lita Cho added the comment:
Hey Terry,
So the reason why the tearing is a lot slower in 06/09 patch is because the
canvas is using the turtle.ScrolledCanvas widget. Everytime the window resizes,
it is calling a callback to `onResize` -> `adjustScrolls` to update the
scrollbars. Whe
Lita Cho added the comment:
I also put this patch out there. This doesn't have the PaneWindow, but I
manually widen the text pane. This would be the compromise if I can't figure
out the tearing due to the sash moving.
--
Added file: http://bugs.python.org
Lita Cho added the comment:
?! After debugging for awhile, I got it so that PanedWindow doesn't cause the
rightmost widget to tear! I had to disable the resizing binding on Turtle to
make it work.
However, now it seems like the canvas is no longer centered. Is there anyway
for me t
Lita Cho added the comment:
I think I have a fix!! I made it so that centering works while fixing the
tearing.
For some reason, in the Turtle API, the adjustScrolls method creates a new
scroll widget for x and y and deletes the old one. I am not sure why it does it
this way. I'm
New submission from Lita Cho:
Currently, the turtledemo doesn't allow you to change font sizes of the demo
code, and the default font size is really small.
I can work on creating a patch to fix this. Best option be to have
control-mousewheel change size, as is standard in browsers, as we
Changes by Lita Cho :
Added file: http://bugs.python.org/file35890/turtledemo_pane_scroll_SOLID.patch
___
Python tracker
<http://bugs.python.org/issue21597>
___
___
Pytho
Lita Cho added the comment:
Hi Terry,
So the shadow can easily be removed. I just went with the default sashrelief
style. I am going to attach two patches with different sashrelief styles, both
of which don't have the shadow.
--
Added file: http://bugs.python.org/file
Lita Cho added the comment:
I personally like the FLAT look because it matches with the rest of the GUI.
--
___
Python tracker
<http://bugs.python.org/issue21
Lita Cho added the comment:
I am going to fix it so that it raises the NNTPConnectionError rather than
update the documentation.
--
nosy: +Lita.Cho, jesstess
___
Python tracker
<http://bugs.python.org/issue1186
Lita Cho added the comment:
I have a fix and added some test coverage in order to make sure the
NNTFConnectError was being called. However, in the test case, I am monkey
patching. If there is a way to do this with mock, I would appreciate the
feedback.
--
keywords: +patch
Added file
Lita Cho added the comment:
Hi Raymond! Just wanted to check if you had time to test this yet. I ran the
tests through the Turtle tests I wrote (issue21914), but those are still
pending approval.
This is off topic, but I also didn't realize till now that you gave a talk
about "Tr
Lita Cho added the comment:
That's perfect. I agree that this issue is closed! :)
--
___
Python tracker
<http://bugs.python.org/issue3015>
___
___
Pytho
Lita Cho added the comment:
Ingrid and I combined our tests. The patch now lives here:
http://bugs.python.org/issue21916
--
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Lita Cho added the comment:
I personally think it would be better to check to see if the turtledemo exists
during startup, and if so, add the menu entry. Otherwise, don't add it when
loading up IDLE.
--
___
Python tracker
<http://bugs.py
Lita Cho added the comment:
Make some changes to patch.
--
___
Python tracker
<http://bugs.python.org/issue21914>
___
___
Python-bugs-list mailing list
Unsub
Lita Cho added the comment:
Trying to attach a file again. I seem to be having trouble attaching it.
--
___
Python tracker
<http://bugs.python.org/issue21
Changes by Lita Cho :
Added file: http://bugs.python.org/file35930/test_turtle_guionly_v2.patch
___
Python tracker
<http://bugs.python.org/issue21914>
___
___
Python-bug
Lita Cho added the comment:
That's a good point. I can add that so the NNTPConnectError can inherit the
EOFError
--
___
Python tracker
<http://bugs.python.org/issu
Lita Cho added the comment:
Here is an updated patch.
--
Added file: http://bugs.python.org/file35941/nntplib_error.patch
___
Python tracker
<http://bugs.python.org/issue1186
Changes by Lita Cho :
--
nosy: +Lita.Cho, jesstess
___
Python tracker
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsubscribe:
Lita Cho added the comment:
I was reading the RFC spec, and it looks like it doesn't specificy '[' and ']'
are not allowed in the PERNANENTFLAGS names.
I can try to add a fix for this. But if anyone else knows if you are not
allowed to have '[' or &#
Lita Cho added the comment:
I have a patch for this. With my patch, the debug output is fixed.
--
keywords: +patch
Added file: http://bugs.python.org/file35962/imap_regex.patch
___
Python tracker
<http://bugs.python.org/issue21
Lita Cho added the comment:
Here is a log of the output.
--
Added file: http://bugs.python.org/file35963/imaplib_log_with_patch.txt
___
Python tracker
<http://bugs.python.org/issue21
Lita Cho added the comment:
Yes! I agree, this change will need tests. I will start working on creating
those now.
Here is test I did to create a flag with brackets.
import imaplib
mail = imaplib.IMAP4_SSL('imap.gmail.com')
mail.login('usern...@gmail.com', 'password&
Lita Cho added the comment:
Here is the code in order to see the bug.
imaplib.Debug = 5
mail = imaplib.IMAP4_SSL('imap.gmail.com')
mail.login(username, password) # Enter your login here
mail.select('test')
--
___
P
Lita Cho added the comment:
>
> R. David Murray added the comment:
>
> Just to make sure I understand: the issue is that gmail may produce flags
> with [] in them, and imaplib currently fails to process such flags when it
> receives them from gmail?
>
> This is corr
Lita Cho added the comment:
Okay, sounds good. I will also create a patch in the documentation that
explains this, as well as comment on the regex patch.
--
___
Python tracker
<http://bugs.python.org/issue21
Lita Cho added the comment:
Here is a patch for test_imaplib.py, adding the test for brackets. It should
fail with the current version of imaplib, but should pass with the
imap_regex.patch.
--
Added file: http://bugs.python.org/file35977/test_imaplib.patch
Lita Cho added the comment:
Updated the documentation in imaplib.rst to describe the RFC violation.
--
versions: -Python 3.4, Python 3.5
Added file: http://bugs.python.org/file35978/imap_doc.patch
___
Python tracker
<http://bugs.python.
Lita Cho added the comment:
Updated my regex patch to include a comment about how we are violating the RFC
and allowing all characters rather thane excluding the ] character.
--
Added file: http://bugs.python.org/file35979/imap_regex.patch
Lita Cho added the comment:
Has this been determine as a server bug or a bug with imaplib? I am not able to
reproduce this bug with Gmail. Do I need to use it with Lotus Server to
recreate it?
--
nosy: +Lita.Cho
___
Python tracker
<h
Lita Cho added the comment:
I spent the last 2 hours trying to setup a Lotus Server, which is ending up to
be a lot more work then I thought in order to test this bug.
Is there anyway I can get a test Lotus account on a Lotus Server to test this
bug
Lita Cho added the comment:
Hi Roy,
Oh I see. Should we close this out as "Won't Fix" due to the fact that we
aren't sure how many users are using this with Domino servers?
Lita
On Fri, Jul 18, 2014 at 8:52 AM, Roy Hyunjin Han
wrote:
>
> Roy Hyunjin Han added the c
Lita Cho added the comment:
Ping! Just wanted to see what the status was on getting this patch reviewed. I
hope your eye is feeling better, Terry!
--
___
Python tracker
<http://bugs.python.org/issue21
Lita Cho added the comment:
I have a version of this working with Ctrl-plus and Ctrl-minus. However, there
is a bug with Tk 8.5.9 where binding to MouseWheel crashes Tkinter for Macs
(issue10731), which I am running into. I need to update Tkinter to see if this
works
Lita Cho added the comment:
Here is a patch for changing the font size using the scroll wheel. I also added
the shortcuts "Ctrl-plus" to increase the font size and "Ctrl-minus" to
decrease the font size.
However, since the MouseWheel is now bound to changing the font
si
1 - 100 of 150 matches
Mail list logo
