[issue38225] iscoroutinefunction broken with cython - allow tagging of functions as async?

[Stefan Behnel]

Stefan Behnel  added the comment:

FYI, https://github.com/cython/cython/pull/3427 has been merged into Cython. In 
Cython 3.0, compiled coroutines will disguise as non-compiled coroutines, from 
the PoV of asyncio.

Restricting this ticket to Py3.10 since we're rather discussing a new feature 
now.

--
versions: +Python 3.10 -Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38225] iscoroutinefunction broken with cython - allow tagging of functions as async?

[Andrew Svetlov]

Andrew Svetlov  added the comment:

I'd like to hear Yuri's opinion for the idea of adding an attribute.
Another question is the name: I have proposed __awaitable__ but maybe __async__ 
is slightly better?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38225] iscoroutinefunction broken with cython - allow tagging of functions as async?

[Stefan Behnel]

Stefan Behnel  added the comment:

FWIW, it seems reasonable to have a protocol for this.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38225] iscoroutinefunction broken with cython - allow tagging of functions as async?

[Fabio Pugliese Ornellas]

Fabio Pugliese Ornellas  added the comment:

It is worth noting that test frameworks can greatly benefit from 
iscoroutinefunction to work.

I'm the main author of TestSlide, which provides more strict mocking for 
Python. I recently added async support, so we can detect bugs such as 
configuring a sync mock for something that is async 
(https://testslide.readthedocs.io/en/2.0.2/strict_mock/index.html#coroutine-functions-async-def).
 It works just fine, as long as iscoroutinefunction works, which is not the 
case for async Cython (a big chunk of TestSlide's use cases).

+1 an Andrew's func.__awaitable__ idea: interpreter can provide that for `async 
def` and one can also do that for anything that implements __call__ to 
communicate that the callable is async.

--
nosy: +fornellas

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38225] iscoroutinefunction broken with cython - allow tagging of functions as async?

[Stefan Behnel]

Stefan Behnel  added the comment:

> along with the appropriate CO_COROUTINE flag set

No, it never did that, for safety reasons. It's difficult to say if enabling 
these flags is the right thing to do, because it's unclear what assumptions 
code that tests for them would make. In CPython itself, there do not seem to be 
any "excessive" assumptions specific to that flag – also because Cython 
functions are not Python functions, and thus the flag will never be looked at:

https://github.com/python/cpython/blob/5b9ff7a0dcb16d6f5c3cd4f1f52e0ca6a4bde586/Lib/inspect.py#L178-L180

Thus, setting the CO_COROUTINE and CO_ASYNC_GENERATOR code flags has no effect 
for Cython functions.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38225] iscoroutinefunction broken with cython - allow tagging of functions as async?

[Yury Selivanov]

Yury Selivanov  added the comment:

> If a python piece of code imports cython code with async defs, 
> `asyncio.iscoroutinefunction` cannot determine that the code is async.


Well, this seems to be a regression.  IIRC Cython used to emulate a Python code 
object (__code__) for functions it compiled along with the appropriate 
CO_COROUTINE flag set.  Wasn't that the case?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38225] iscoroutinefunction broken with cython - allow tagging of functions as async?

[Emmanuel Arias]

Change by Emmanuel Arias :


--
nosy: +eamanu

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38225] iscoroutinefunction broken with cython - allow tagging of functions as async?

[Andrew Svetlov]

Andrew Svetlov  added the comment:

I think `func.__awaitable__ = True` can serve all possible situations.

We need it for async mocks (now the library use flawless `_is_coroutine` 
approach. 

`__awaitable__` can also cover cases where a regular function returns awaitable 
object or there is a class with `def __await__(self)` method, 
`functools.partial` -- all of them are awaitable.

Async functions can be modified to provide the property out of the box.

Regarding the question "is a check for awaitableness a good design or not"?
I agree that a check for awaitableness is useless *just before* calling the 
function.
There is another very useful case where the check is important: registering a 
callback for later usage.
For example, we have a web server framework. It is built around a mapping of 
URL paths to async functions, e.g. path('/hello', say_hello) in Django style. 
It's crucial to check if say_hello() is an async function *on the application 
configuration stage*, not on viewing the particular http://localhost/hello page 
in a browser.

So, I think an official protocol makes a lot of sense, let's implement it in 3.9

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38225] iscoroutinefunction broken with cython - allow tagging of functions as async?

[Stefan Behnel]

Stefan Behnel  added the comment:

My usual first reaction is: "if you need to find out whether the return value 
of a callable will be an Awaitable or not, without calling it, then you're 
probably doing something wrong in your design".

However,
a) there is code that tries this already (and it falls short in various ways 
while trying)
b) asyncio has a function `iscoroutinefunction` which *seems* to fulfil this 
need but does not achieve it (because not everything that returns an Awaitable 
is a "coroutine function")
c) asyncio has an internal protocol for marking things as "is a coroutine", 
which comes close to but isn't "returns an Awaitable when called"

So – should there be an official protocol for marking callables as returning an 
Awaitable? Should we look at annotations for that? Anything else? Or do we 
consider this intention inherently flawed?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38225] iscoroutinefunction broken with cython - allow tagging of functions as async?

[Andrew Svetlov]

Andrew Svetlov  added the comment:

I think we need better name than just `_is_coroutine`.
All async function properties as dunder named, the new *official* name should 
follow this convention as well

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38225] iscoroutinefunction broken with cython - allow tagging of functions as async?

[Zachary Ware]

Change by Zachary Ware :


--
nosy: +scoder
versions:  -Python 2.7, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38225] iscoroutinefunction broken with cython - allow tagging of functions as async?

[David Hilton]

Change by David Hilton :


--
keywords: +patch
pull_requests: +15877
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/16292

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38225] iscoroutinefunction broken with cython - allow tagging of functions as async?

[David Hilton]

New submission from David Hilton :

If a python piece of code imports cython code with async defs, 
`asyncio.iscoroutinefunction` cannot determine that the code is async.

https://github.com/cython/cython/issues/2273#issuecomment-531537624

scoder is open to marking async defs so that they can be identified, just like 
`asyncio.coroutine`:

https://github.com/python/cpython/blob/ae239f6b0626e926613a4a1dbafa323bd41fec32/Lib/asyncio/coroutines.py#L156

However, that is an internal interface and `@coroutine` is deprecated.

--

Can we have some official way of marking functions as async that will not be 
deprecated?

The easiest would be for `asyncio.iscoroutinefunction` to look for 
`_is_coroutine = True`, and promise to keep looking for that value.

This would also allow for functools.partial to easily mark that it's returning 
an async function, which some people seem to care about.

--
components: asyncio
messages: 352812
nosy: asvetlov, dhiltonp, yselivanov
priority: normal
severity: normal
status: open
title: iscoroutinefunction broken with cython - allow tagging of functions as 
async?
type: enhancement
versions: Python 2.7, Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com