On Mon, Feb 13, 2017 at 8:16 PM, Brett Cannon wrote:
> There was an issue up until sometime on Sunday where the SSL cert for
> bugs.python.org was being rejected (it was issued by StartCom who is being
> distrusted). The cert got replaced but if the webhook event for your merge
> got rejected due
On 13.02.2017 23:49, Victor Stinner wrote:
> 2017-02-13 19:30 GMT+01:00 Serhiy Storchaka :
>> I'm going to
>> unsubscribe from getting emails for all pull requests and subscribe to only
>> selected ones.
>
> I did exactly that, very early :-)
>
> https://github.com/python/cpython/ : "Watch: *not
On Tue, Feb 14, 2017 at 9:56 AM, Victor Stinner
wrote:
>
> Oh ok, I see. Let's say that we wait one month to see how things are
> going before changing the process ;-)
I'd say we do it and see if it is worth keep it that way.
- The PR tests are passing and we have an incentive to maintain that.
2017-02-14 18:38 GMT+01:00 Brett Cannon :
> The reason I didn't turn that on to begin with was I wanted to wait until we
> had proven to ourselves that our test suite was stable enough to not block
> PRs on a regular basis due to some flaky test. If people feel the tests are
> passing consistently
On Tue, 14 Feb 2017 at 09:19 Senthil Kumaran wrote:
> On Tue, Feb 14, 2017 at 9:10 AM, Victor Stinner
> wrote:
> > Would it be possible to modify the workflow of GitHub pull requests to
> > allow to click on Merge, but only merge a PR once tests complete and
> > only if tests pass?
>
> Yes, that
On Mon, 13 Feb 2017 at 16:19 Eric Snow wrote:
> On Mon, Feb 13, 2017 at 11:16 AM, Brett Cannon wrote:
> > if the webhook event for your merge
> > got rejected due to the bad cert then it would have been dropped.
>
> A repo admin should be able to manually request that a failed webhook
> be retri
On Tue, Feb 14, 2017 at 9:10 AM, Victor Stinner
wrote:
> Would it be possible to modify the workflow of GitHub pull requests to
> allow to click on Merge, but only merge a PR once tests complete and
> only if tests pass?
Yes, that is possible.
I am +1 in doing that. I hope others are on the same
Hi,
Would it be possible to modify the workflow of GitHub pull requests to
allow to click on Merge, but only merge a PR once tests complete and
only if tests pass?
If some tests start to become too annoying for the pre-commit CI, we
can try to fix them, or even disable them in the CI to only rely
