On Mon, Apr 10, 2017 at 8:55 PM, Martin Panter wrote:
> In this particular pull request, I think the submitter has rebased
> their commit, and force-pushed it. These days, I notice Git Hub seems
> to forget old commits pretty soon after you force-push the branch they
> are on. I don't think you ca
On Mon, Apr 10, 2017 at 8:55 PM, Martin Panter wrote:
> In this particular pull request, I think the submitter has rebased
> their commit, and force-pushed it. These days, I notice Git Hub seems
> to forget old commits pretty soon after you force-push the branch they
> are on. I don't think you c
On 11 April 2017 at 13:13, Mariatta Wijaya wrote:
> "View Changes" doesn't work when commits in PR were squashed, which seems to
> be the case in https://github.com/python/cpython/pull/851
>
> I wonder if there is a way to unsquash the commits? Will it help with
> reviewing this PR?
>
> Mariatta W
"View Changes" doesn't work when commits in PR were squashed, which seems
to be the case in https://github.com/python/cpython/pull/851
I wonder if there is a way to unsquash the commits? Will it help with
reviewing this PR?
Mariatta Wijaya
On Tue, Apr 11, 2017 at 2:55 AM, Donald Stufft wrote:
If someone makes a review on github (as opposed to a simple comment) I believe
the state of the code as it was when that review as made can be viewed by
hitting the “View Changes” button next to that review in the timeline.
> On Apr 10, 2017, at 3:18 PM, Guido van Rossum wrote:
>
> Thanks for
I've activated Bedevere, so there will now be a status check for issue
numbers in the title of a PR. If a PR doesn't call for an issue number then
it can be labeled "trivial".
And the code for the bot lives at https://github.com/python/bedevere if
some messaging needs to be tweaked, etc.
On Fri,
Thanks for the clarification. We should probably move this discussion to
the python-committers list rather than core-mentorship.
On Mon, Apr 10, 2017 at 12:12 PM, Terry Reedy wrote:
> On 4/10/2017 12:54 PM, Guido van Rossum wrote:
>
>> So the response from Martin Panter
>> (https://github.com/py
