[Python-Dev] Re: PEP 585: Type Hinting Generics In Standard Collections

The discussion on the name change came from Łukasz https://github.com/python/cpython/pull/18239#discussion_r380996908 I suggested "GenericType" to be in line with other things in types.py. On Mon, Feb 24, 2020 at 8:39 PM Guido van Rossum wrote: > I can't find it right now, but IIRC somebody com

[Python-Dev] Re: PEP 585: Type Hinting Generics In Standard Collections

I can't find it right now, but IIRC somebody commented that "GenericAlias" is a somewhat odd name. I didn't spend much time thinking about the name, I just took it from `typing._GenericAlias` (which has a similar role). It would be hard to change the name later. ATM it's one global substitute on m

[Python-Dev] Re: Accepting PEP 584: Add Union Operators To dict

On Mon, Feb 24, 2020 at 10:42 AM Brandt Bucher wrote: > > Are these three cookie classes sufficiently popular that we need to > support `|` on them? > > I don't have much experience with `http`, so I figured I'd open a BPO > issue and let the relevant folks make the call. The main reason I'm > co

[Python-Dev] Re: Merging PRs without CLA signed

FWIW, I'm also one of the few core devs who won't merge a PR unless CLA is signed. Such PRs (and the backports) can't be automerged, creating manual work. I find the "triviality" is subjective. One line change in documentation is maybe trivial. One line change in the code is probably not as trivia

[Python-Dev] Re: Merging PRs without CLA signed

On 2/23/2020 11:44 PM, Guido van Rossum wrote: On Sun, Feb 23, 2020 at 8:11 PM Kyle Stanley > wrote: In a recently opened typo fixing PR [1], an issue came up regarding the lack of a signed CLA, where the author specifically mentioned they did not want to s

[Python-Dev] Re: Accepting PEP 584: Add Union Operators To dict

> Are these three cookie classes sufficiently popular that we need to support > `|` on them? I don't have much experience with `http`, so I figured I'd open a BPO issue and let the relevant folks make the call. The main reason I'm considering these is that `Morsel` was updated back in 3.5 with

[Python-Dev] Re: Merging PRs without CLA signed

On 2/24/2020 10:32 AM, Chris Angelico wrote: On Tue, Feb 25, 2020 at 2:25 AM Antoine Pitrou wrote: I'd like to point out that the relevant perspective here isn't PSF policy as much as copyright law. Since Python is copyrighted in the US and the license specifies Virginia as the state of ju

[Python-Dev] Re: Merging PRs without CLA signed

On 24.02.2020 8:30, Kyle Stanley wrote: > (What is it with typos anyway? Why do people feel the need to invoke megabytes if not gigabytes of internet traffic to correct a word that every reader can easily correct in their mind?) Speaking from personal experience to some degree, my first PR was

[Python-Dev] Re: Merging PRs without CLA signed

There is, for better or worse, no bright line about what is copyrightable. Unfortunately, a lot of the standard is "how deep are the pockets of the opposing party?" If you are Oracle and you want to sue Google, code which any normal person world consider trivial becomes precious intellectual prope

[Python-Dev] Re: Merging PRs without CLA signed

On Tue, Feb 25, 2020 at 2:25 AM Antoine Pitrou wrote: > > On Mon, 24 Feb 2020 00:30:41 -0500 > Kyle Stanley wrote: > > > In that case I'm not sure the author ought to get credit for the PR. They > > can file a bug pointing out the typo and someone else can submit a fix. > > > > That sounds like a

[Python-Dev] Re: Merging PRs without CLA signed

On Mon, 24 Feb 2020 00:30:41 -0500 Kyle Stanley wrote: > > In that case I'm not sure the author ought to get credit for the PR. They > can file a bug pointing out the typo and someone else can submit a fix. > > That sounds like a reasonable solution to me; even for more substantial > issues (if