Re: [Python-Dev] PyArg_ParseTupe(): parse unsigned integer and check for overflow

2013-06-29 Thread Nadeem Vawda
On Thu, Jun 27, 2013 at 12:07 AM, Victor Stinner wrote: > I would to parse an integer in [0; UINT_MAX] to fix the zlib module on > 64-bit system: > http://bugs.python.org/issue18294 > > How should I implement that? Use "O" format and then use > PyLong_Check(), PyLong_AsLong(), and check value <= U

Re: [Python-Dev] Regression fix releases coming

2013-04-30 Thread Nadeem Vawda
On Tue, Apr 30, 2013 at 4:07 PM, Benjamin Peterson wrote: > 2013/4/30 Guido van Rossum : > > Can we do something about the problem that virus checkers complain about > the > > xml bomb test file? E.g. Generate it dynamically in a script? > > That's been dealt with. See http://bugs.python.org/issue

Re: [Python-Dev] 2.7.4

2013-02-03 Thread Nadeem Vawda
Just to clarify, the release branch hasn't been created yet, correct? - Nadeem On Sun, Feb 3, 2013 at 3:38 PM, Benjamin Peterson wrote: > 2013/2/3 Serhiy Storchaka : > > There are crashers for which patches were proposed but do not reviewed > yet: > > > > Issue #6083: Reference counting bug in

Re: [Python-Dev] [Python-checkins] cpython (merge 3.3 -> default): Fixes issue #16409: The reporthook callback made by the legacy

2012-11-10 Thread Nadeem Vawda
This change appears to have broken test_urllib. See, for example: http://buildbot.python.org/all/builders/AMD64%20OpenIndiana%203.x/builds/4774/steps/test/logs/stdio - Nadeem ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailm

Re: [Python-Dev] [Python-checkins] cpython (merge 3.3 -> default): Merge: #16304: Optimizations for BZ2File, and minor bugfix.

2012-10-01 Thread Nadeem Vawda
On Mon, Oct 1, 2012 at 11:11 PM, nadeem.vawda wrote: > http://hg.python.org/cpython/rev/a19f47d380d2 > changeset: 79382:a19f47d380d2 > parent: 79378:fb90e2ff95b7 > parent: 79381:6d7bf512e0c3 > user: Nadeem Vawda > date:Mon Oct 01 23:11:35 20

Re: [Python-Dev] [Python-checkins] cpython: Improve an internal ipaddress test, add a comment explaining why treating

2012-06-17 Thread Nadeem Vawda
On Sun, Jun 17, 2012 at 8:33 AM, nick.coghlan wrote: > +    @property > +    def version(self): > +        msg = '%200s has no version specified' % (type(self),) > +        raise NotImplementedError(msg) > + Shouldn't that be "%.200s", rather than "%200s"?

Re: [Python-Dev] [Python-checkins] cpython: Issue #14744: Use the new _PyUnicodeWriter internal API to speed up str%args

2012-05-29 Thread Nadeem Vawda
Since this changeset, building on Windows seems to be broken (see http://python.org/dev/buildbot/all/builders/x86%20XP-5%203.x/builds/450 for example). Nadeem ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/pytho

Re: [Python-Dev] [Python-checkins] cpython: Clean up the PCBuild project files, removing redundant settings and

2012-05-19 Thread Nadeem Vawda
On Sat, May 19, 2012 at 2:11 PM, kristjan.jonsson < python-check...@python.org> wrote: > +Visual Studio 2010 uses version 10 of the C runtime (MSVCRT9). The > executables > Shouldn't that be MSVCRT10? Nadeem ___ Python-Dev mailing list Python-Dev@pyth

Re: [Python-Dev] PEP 418: Add monotonic clock

2012-03-31 Thread Nadeem Vawda
On Sat, Mar 31, 2012 at 8:27 AM, Lennart Regebro wrote: > So, how about time.timer()? That seems like a bad idea; it would be too easy to confuse with (or misspell as) time.time(). Out of the big synonym list Guido posted, I rather like time.stopwatch() - it makes it more explicit that the purpo

Re: [Python-Dev] What letter should an UnsignedLongLong get

2012-03-15 Thread Nadeem Vawda
The lzma module ran into a similar issue with 32-bit unsigned ints. I worked around it by writing a custom converter function to use with the "O&" code. You can find the converter definition here: http://hg.python.org/cpython/file/default/Modules/_lzmamodule.c#l134 And an example usage here:

Re: [Python-Dev] Drop the new time.wallclock() function?

2012-03-15 Thread Nadeem Vawda
On Thu, Mar 15, 2012 at 1:10 PM, Paul Moore wrote: >> Monotonic clocks are not necessarily hardware based, and may be adjusted >> forward by NTP. > > I appreciate that. But I'm still unclear how you would tell that had > happened as part of the implementation. One call to the OS returns > 12345. T

Re: [Python-Dev] Drop the new time.wallclock() function?

2012-03-14 Thread Nadeem Vawda
+1 for time.steady(strict=False). On Wed, Mar 14, 2012 at 7:09 PM, Kristján Valur Jónsson wrote: >> - By default, it should fall back to time.time if a better source is >>  not available, but there should be a flag that can disable this >>  fallback for users who really *need* a monotonic/steady

Re: [Python-Dev] Drop the new time.wallclock() function?

2012-03-14 Thread Nadeem Vawda
A summary of the discussion so far, as I've understood it: - We should have *one* monotonic/steady timer function, using the sources described in Victor's original post. - By default, it should fall back to time.time if a better source is not available, but there should be a flag that can dis

Re: [Python-Dev] Drop the new time.wallclock() function?

2012-03-13 Thread Nadeem Vawda
On Wed, Mar 14, 2012 at 3:03 AM, Victor Stinner wrote: > I suppose that most libraries and programs will have to implement a > similar fallback. > > We may merge both functions with a flag to be able to disable the > fallback. Example: > >  - time.realtime(): best-effort monotonic, with a fallback

Re: [Python-Dev] Drop the new time.wallclock() function?

2012-03-13 Thread Nadeem Vawda
So wallclock() falls back to a not-necessarily-monotonic time source if necessary, while monotonic() raises an exception in that case? ISTM that these don't need to be separate functions - rather, we can have one function that takes a flag (called require_monotonic, or something like that) telling

Re: [Python-Dev] Code review tool uses my old email address

2012-02-08 Thread Nadeem Vawda
This may be a bug in the tracker, possibly related to http://psf.upfronthosting.co.za/roundup/meta/issue402 - it seems like changes to a user's details on bugs.python.org are not propagated to the review tool. Cheers, Nadeem ___ Python-Dev mailing list P

Re: [Python-Dev] Status of Mac buildbots

2012-01-25 Thread Nadeem Vawda
On Wed, Jan 25, 2012 at 5:35 PM, Bill Janssen wrote: > We're tinkering with that server room.  They should be back by the end of > the week. OK, cool. Thanks for the info. ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/

[Python-Dev] Status of Mac buildbots

2012-01-24 Thread Nadeem Vawda
Hi all, I've noticed that most of the Mac buildbots have been offline for a while: * http://www.python.org/dev/buildbot/all/buildslaves/parc-snowleopard-1 * http://www.python.org/dev/buildbot/all/buildslaves/parc-tiger-1 * http://www.python.org/dev/buildbot/all/buildslaves/parc-leopard-1 Does an

Re: [Python-Dev] [Python-checkins] cpython (2.7): Issue #13605: add documentation for nargs=argparse.REMAINDER

2012-01-19 Thread Nadeem Vawda
On Thu, Jan 19, 2012 at 11:03 PM, sandro.tosi wrote: > +  are gathered into a lits. This is commonly useful for command line s/lits/list ? ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe:

Re: [Python-Dev] [Python-checkins] cpython: input() in this sense is gone

2011-12-15 Thread Nadeem Vawda
On Thu, Dec 15, 2011 at 10:44 PM, benjamin.peterson wrote: > +#       eval_input is the input for the eval() functions. Shouldn't this be "function" rather than "functions"? ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailma

[Python-Dev] LZMA support has landed

2011-11-29 Thread Nadeem Vawda
Hey folks, I'm pleased to announce that as of changeset 74d182cf0187, the standard library now includes support for the LZMA compression algorithm (as well as the associated .xz and .lzma file formats). The new lzma module has a very similar API to the existing bz2 module; it should serve as a dro

Re: [Python-Dev] [Python-checkins] cpython: sort last committed name in alphabetical order

2011-11-22 Thread Nadeem Vawda
Did you mean to also modify sched.py in this changeset? ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] LZMA compression support in 3.3

2011-09-15 Thread Nadeem Vawda
Another update - I've added proper documentation. Now the code should be pretty much complete - all that's missing is the necessary bits and pieces to build it on Windows. Cheers, Nadeem ___ Python-Dev mailing list Python-Dev@python.org http://mail.pytho

Re: [Python-Dev] LZMA compression support in 3.3

2011-09-11 Thread Nadeem Vawda
I've posted an updated patch to the bug tracker, with a complete implementation of the lzma module, including 100% test coverage for the LZMAFile class (which is implemented entirely in Python). It doesn't include ReST documentation (yet), but the docstrings are quite detailed. Please take a look

Re: [Python-Dev] Handling linker scripts reached when dynamically loading a module

2011-09-10 Thread Nadeem Vawda
I can confirm that libpthread.so (/usr/lib/x86_64-linux-gnu/libpthread.so) is a linker script on my Ubuntu 11.04 install. This hasn't ever caused me any problems, though. As for why distributions do this, here are the contents of the script: /* GNU ld script Use the shared library, but

Re: [Python-Dev] LZMA compression support in 3.3

2011-08-29 Thread Nadeem Vawda
I've updated the issue with a patch containing my work so far - the LZMACompressor and LZMADecompressor classes, along with some tests. These two classes should provide a fairly complete interface to liblzma; it will be possible to implement LZMAFile on top of the

Re: [Python-Dev] LZMA compression support in 3.3

2011-08-27 Thread Nadeem Vawda
On Sat, Aug 27, 2011 at 10:41 PM, Dan Stromberg wrote: > It seems like there should be some way of coming up with an xml file > describing the types of the various bits of data and formal arguments - > perhaps using gccxml or something like it. The problem is that you would need to do this check

Re: [Python-Dev] LZMA compression support in 3.3

2011-08-27 Thread Nadeem Vawda
On Sat, Aug 27, 2011 at 9:47 PM, Terry Reedy wrote: > On 8/27/2011 9:47 AM, Nadeem Vawda wrote: >> I'd like to propose the addition of a new module in Python 3.3. The 'lzma' >> module will provide support for compression and decompression using the >> LZMA >

Re: [Python-Dev] LZMA compression support in 3.3

2011-08-27 Thread Nadeem Vawda
On Sat, Aug 27, 2011 at 5:42 PM, "Martin v. Löwis" wrote: > Not sure whether you already have this: supporting the tarfile module > would be nice. Yes, got that - issue 5689. Also of interest is issue 5411 - adding .xz support to distutils. But I think that these are separate projects that should

Re: [Python-Dev] LZMA compression support in 3.3

2011-08-27 Thread Nadeem Vawda
On Sat, Aug 27, 2011 at 5:15 PM, "Martin v. Löwis" wrote: >> As for file formats, these are handled by liblzma itself; the extension >> module >> just selects which compressor/decompressor initializer function to use >> depending >> on the value of the "format" argument. Our code won't contain a

Re: [Python-Dev] LZMA compression support in 3.3

2011-08-27 Thread Nadeem Vawda
On Sat, Aug 27, 2011 at 4:50 PM, "Martin v. Löwis" wrote: >> The implementation will also be similar to bz2 - basic compressor and >> decompressor classes written in C, with convenience functions and a file >> interface implemented on top of those in Python. > > When I reviewed lzma, I found that

[Python-Dev] LZMA compression support in 3.3

2011-08-27 Thread Nadeem Vawda
Hello all, I'd like to propose the addition of a new module in Python 3.3. The 'lzma' module will provide support for compression and decompression using the LZMA algorithm, and the .xz and .lzma file formats. The matter has already been discussed on the tracker ,

Re: [Python-Dev] FileSystemError or FilesystemError?

2011-08-23 Thread Nadeem Vawda
On Tue, Aug 23, 2011 at 8:39 PM, Ross Lagerwall wrote: >> When reviewing the PEP 3151 implementation (*), Ezio commented that >> "FileSystemError" looks a bit strange and that "FilesystemError" would >> be a better spelling. What is your opinion? I think "FilesystemError" looks nicer, but it's no

Re: [Python-Dev] [Python-checkins] cpython: Issue #11651: Move options for running tests into a Python script.

2011-08-02 Thread Nadeem Vawda
Thanks for catching that. Fixed in 0b52b6f1bfab. Nadeem ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] [Python-checkins] cpython: Issue #11651: Improve Makefile test targets.

2011-07-31 Thread Nadeem Vawda
On Sun, Jul 31, 2011 at 10:26 AM, Nick Coghlan wrote: > On Sun, Jul 31, 2011 at 9:09 AM, nadeem.vawda > wrote: >> - Remove duplicate test run in "make test" and "make testuniversal" > > That seems very questionable - the rationale for running the test > suite twice by default to ensure PYC genera

Re: [Python-Dev] cpython (3.2): Fix sorting or wording of some NEWS entries.

2011-07-29 Thread Nadeem Vawda
On Fri, Jul 29, 2011 at 2:46 PM, Antoine Pitrou wrote: > There's no practical difference (from the user's point of view) between > extension modules and the library, so I think the "Extension Modules" > section should simply die. +1. This has been bugging me for a while now. _

[Python-Dev] Add LRUCache class to stdlib

2011-06-05 Thread Nadeem Vawda
I would like to propose adding a class to the stdlib to provide a more flexible LRU caching mechanism. As things stand, the functools.lru_cache() decorator is fine for memoization of pure functions, but does not accommodate situations where cache entries become stale and must be invalidated/updated

Re: [Python-Dev] Don't set local variable in a list comprehension or generator

2011-05-18 Thread Nadeem Vawda
On Wed, May 18, 2011 at 2:21 PM, Victor Stinner wrote: > ''.join(c for c in 'abc') and ''.join([c for c in 'abc']) do create a > temporary c variable. I'm not sure why you would encounter code like that in the first place. Surely any code of the form: ''.join(c for c in my_string) would jus

Re: [Python-Dev] [Python-checkins] cpython (2.7): Issue #11277: Remove useless test from test_zlib.

2011-05-09 Thread Nadeem Vawda
On Mon, May 9, 2011 at 2:53 PM, Jim Jewett wrote: > Can you clarify (preferably in the commit message as well) exactly > *why* these largefile tests are useless? For example, is there > another test that covers this already? Ah, sorry about that. It was discussed on the tracker issue, but I gues

Re: [Python-Dev] [Python-checkins] cpython (2.7): Issue #10276: test_zlib checks that inputs of 2 GB are handled correctly by

2011-05-05 Thread Nadeem Vawda
On Thu, May 5, 2011 at 11:33 AM, Victor Stinner wrote: > Le mercredi 04 mai 2011 à 15:40 -0700, Ethan Furman a écrit : >> The comment says 'check that inputs of 2 GB are handled correctly' but >> the file created is 1 byte short of 2Gb.  Is the test wrong, or just >> wrongly commented?  Or am I no

Re: [Python-Dev] [Python-checkins] cpython (2.7): Issue #10276: test_zlib checks that inputs of 2 GB are handled correctly by

2011-05-03 Thread Nadeem Vawda
On Tue, May 3, 2011 at 10:38 PM, Victor Stinner wrote: > I don't want to check OverflowError: the test is supposed to compute the > checksum of a buffer of 0x7FFF bytes, to check crc32() and > adler32(). 0x7FFF is the biggest size supported by these functions > (zlib doesn't use Py_ssize_t

Re: [Python-Dev] [Python-checkins] cpython (2.7): Issue #10276: test_zlib checks that inputs of 2 GB are handled correctly by

2011-05-03 Thread Nadeem Vawda
On Tue, May 3, 2011 at 3:19 PM, victor.stinner wrote: > +# Issue #10276 - check that inputs of 2 GB are handled correctly. > +# Be aware of issues #1202, #8650, #8651 and #10276 > +class ChecksumBigBufferTestCase(unittest.TestCase): > +    int_max = 0x7FFF > + > +    @unittest.skipUnless(mmap,

Re: [Python-Dev] [Python-checkins] cpython (2.7): Fix closes issue10761: tarfile.extractall failure when symlinked files are

2011-04-29 Thread Nadeem Vawda
so os.symlink() will raise an exception when it sees that targetpath already exists. On Thu, Apr 28, 2011 at 5:44 PM, Antoine Pitrou wrote: > On Thu, 28 Apr 2011 17:40:05 +0200 > Nadeem Vawda wrote: >> >> The deletion case could be handled like this: >> >>

Re: [Python-Dev] [Python-checkins] cpython (2.7): Fix closes issue10761: tarfile.extractall failure when symlinked files are

2011-04-28 Thread Nadeem Vawda
On Thu, Apr 28, 2011 at 4:44 PM, Senthil Kumaran wrote: > On Thu, Apr 28, 2011 at 04:20:06PM +0200, Éric Araujo wrote: >> > if hasattr(os, "symlink") and hasattr(os, "link"): >> > # For systems that support symbolic and hard links. >> > if tarinfo.issym(): >> > +

Re: [Python-Dev] cpython: Fix 64-bit safety issue in BZ2Compressor and BZ2Decompressor.

2011-04-13 Thread Nadeem Vawda
Thanks for the feedback. I'll be sure to include more information in my future commit messages. Nadeem ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/optio

Re: [Python-Dev] [Python-checkins] cpython: Issue #5863: Rewrite BZ2File in pure Python, and allow it to accept

2011-04-03 Thread Nadeem Vawda
On Sun, Apr 3, 2011 at 8:02 PM, Antoine Pitrou wrote: > On Sun, 03 Apr 2011 18:55:33 +0200 > Éric Araujo wrote: >> I think we use Misc/ACKS for code+docs contribution like this one, >> Doc/ACKS.txt being used for doc-only changes.  This second file is not >> comprehensive nor always used though,

Re: [Python-Dev] Copyright notices

2011-03-21 Thread Nadeem Vawda
On Mon, Mar 21, 2011 at 2:20 PM, M.-A. Lemburg wrote: > Nadeem Vawda wrote: >> [snip] > > Since you'll be adding new IP to Python, the new code you write should > contain your copyright and the standard PSF contributor agreement > notice, e.g. > > "&q

[Python-Dev] Copyright notices

2011-03-14 Thread Nadeem Vawda
I was wondering what the policy is regarding copyright notices and license boilerplate text at the top of source files. I am currently rewriting the bz2 module (see http://bugs.python.org/issue5863), splitting the existing Modules/bz2module.c into Modules/_bz2module.c and Lib/bz2.py. Are new file

Re: [Python-Dev] forward-porting from 3.1 to 3.2 to 3.3

2011-03-12 Thread Nadeem Vawda
On Sun, Mar 13, 2011 at 12:43 AM, Éric Araujo wrote: >> hg revert -ar default > > You can’t combine the -r option with other options.  (Yes, it’s a known bug.) It seems to work for me (Mercurial 1.6.3 on Ubuntu). But I suppose it wouldn't hurt to split the options up. Regards, Nadeem ___

Re: [Python-Dev] forward-porting from 3.1 to 3.2 to 3.3

2011-03-12 Thread Nadeem Vawda
On Sat, Mar 12, 2011 at 1:29 PM, "Martin v. Löwis" wrote: > Isn't that command correct only if you are merging into default? > ISTM that it should be "hg revert -ar ". In general, yes. However, the existing text refers specifically to the case of merging 3.2 into default, so I was trying to be co

Re: [Python-Dev] forward-porting from 3.1 to 3.2 to 3.3

2011-03-12 Thread Nadeem Vawda
Hmm... it seems that the given instructions don't actually work. "hg revert -a" fails, saying that a specific revision needs to be provided. The command should be "hg revert -ar default". ___ Python-Dev mailing list Python-Dev@python.org http://mail.pytho

Re: [Python-Dev] forward-porting from 3.1 to 3.2 to 3.3

2011-03-12 Thread Nadeem Vawda
On Sat, Mar 12, 2011 at 9:32 AM, Eli Bendersky wrote: > The devguide's recommendation is to "forward-port" changes withing a major > release line, i.e. if I need something in all 3.[123], then start with 3.1 > and forward-port (by "hg merge ") to 3.2 and then 3.3 > > Just to clarify - does this me

Re: [Python-Dev] r88122 - python/branches/py3k/Doc/whatsnew/3.2.rst

2011-01-20 Thread Nadeem Vawda
On Thu, Jan 20, 2011 at 3:11 PM, Antoine Pitrou wrote: > On Thu, 20 Jan 2011 10:47:04 +0100 (CET) > raymond.hettinger wrote: >> >> +Code Repository >> +=== >> + >> +In addition to the existing Subversion code repository at >> http://svn.python.org >> +there is now a `Mercurial

Re: [Python-Dev] constant/enum type in stdlib

2010-11-25 Thread Nadeem Vawda
On Thu, Nov 25, 2010 at 11:34 AM, Glenn Linderman wrote: > So the following code defines constants with associated names that get put > in the repr. The code you gave doesn't work if the constant() function is moved into a separate module from the code that calls it. The globals() function, as I

Re: [Python-Dev] Re-enable warnings in regrtest and/or unittest

2010-11-23 Thread Nadeem Vawda
2010/11/23 Łukasz Langa : > If you agree to do that for regrtest I will clean up the tests for warnings. > Already did that for zipfile so it doesn't raise ResourceWarnings anymore. I > just need to correct multiprocessing and xmlrpc ResourceWarnings, silence > some DeprecationWarnings in the tests