Re: [Python-Dev] "CPython loves your Pull Requests" talk by Stéphane Wirtel

2017-12-05 Thread Terry Reedy
On 12/5/2017 10:25 AM, Mariatta Wijaya wrote: * Time to merge a PR: 3 days in average, good! Slide said 2.98 days, another said 4.4% by developers. Regarding the average time to merge PR, I'm interested to know the average time to merge for PRs not made by Python Core Devs. Trivially

Re: [Python-Dev] "CPython loves your Pull Requests" talk by Stéphane Wirtel

2017-12-05 Thread Antoine Pitrou
On Tue, 5 Dec 2017 19:46:39 +0100 Stephane Wirtel via Python-Dev wrote: > But seriously, I was surprised by the number of Pull Requests and by the > number of contributors from Feb 2017 to Oct 2017. > > Here is my graph for October and November 2017. Is it possible to

Re: [Python-Dev] "CPython loves your Pull Requests" talk by Stéphane Wirtel

2017-12-05 Thread Stephane Wirtel via Python-Dev
Hi Mariatta, Thank you, I was really happy to see you at my talk, usually this kind of talk is boring ;-) just kidding, but usually I prefer a technical talk. Le 05/12/17 à 16:25, Mariatta Wijaya a écrit : > I saw the talk in person :) Congrats Stéphane! > > You can get the reviews from a

Re: [Python-Dev] "CPython loves your Pull Requests" talk by Stéphane Wirtel

2017-12-05 Thread Stephane Wirtel via Python-Dev
Hi, Thank you for this post to python-dev. About my talk, it was a real pleasure to give it at PyCon Canada, and I hope I could propose it to PyCon US for a larger public. But the goal behind this talk was to show that we have a good community, firstly by the external contributors and by the

Re: [Python-Dev] "CPython loves your Pull Requests" talk by Stéphane Wirtel

2017-12-05 Thread Brett Cannon
On Tue, 5 Dec 2017 at 08:31 Senthil Kumaran wrote: > On Tue, Dec 5, 2017 at 6:25 AM, Victor Stinner > wrote: > >> Stéphane Wirtel gave a talk last month at Pycon CA about CPython pull >> requests. His slides: >> >>

Re: [Python-Dev] "CPython loves your Pull Requests" talk by Stéphane Wirtel

2017-12-05 Thread Senthil Kumaran
On Tue, Dec 5, 2017 at 6:25 AM, Victor Stinner wrote: > Stéphane Wirtel gave a talk last month at Pycon CA about CPython pull > requests. His slides: > >https://speakerdeck.com/matrixise/cpython-loves-your-pull-requests > > He produced interesting statistics that we

Re: [Python-Dev] "CPython loves your Pull Requests" talk by Stéphane Wirtel

2017-12-05 Thread Mariatta Wijaya
I saw the talk in person :) Congrats Stéphane! You can get the reviews from a specific PR using the API: https://developer.github.com/v3/pulls/reviews/#list-reviews-on-a-pull-request For example, for reviews made to CPython PR number 1:

[Python-Dev] "CPython loves your Pull Requests" talk by Stéphane Wirtel

2017-12-05 Thread Victor Stinner
Hi, Stéphane Wirtel gave a talk last month at Pycon CA about CPython pull requests. His slides: https://speakerdeck.com/matrixise/cpython-loves-your-pull-requests He produced interesting statistics that we didn't have before on pull requests (PR), from February 2017 to October 2017: * total