Re: [Python-Dev] Deprecate crypt module and revert PR 3854

2018-02-03 Thread Guido van Rossum
You can deprecate the crypt module, update the docs to explain it's outdated and point to other 3rd party solutions. A few years from now we may be able to delete it. (With an intermediate step of issuing a non-silent deprecation warning.) Until then just leave it be. Possibly that's what your

Re: [Python-Dev] Deprecate crypt module and revert PR 3854

2018-02-03 Thread Christian Heimes
On 2018-02-02 17:18, Guido van Rossum wrote: > I'm all for nudging people in the direction of xcrypt. I assume we can't > just switch the C-level crypt with xcrypt and leave the Python API > unchanged? > > However until a usable solution exist (either in the stdlib or as 3rd > party) I don't

Re: [Python-Dev] Deprecate crypt module and revert PR 3854

2018-02-03 Thread Christian Heimes
On 2018-02-02 21:21, Nathaniel Smith wrote: > On Feb 2, 2018 7:24 AM, "Christian Heimes" > wrote: > > Shortly after the PR has landed, I was made aware that glibc has > deprecated crypt(3) API [2] and favor of an external library called

Re: [Python-Dev] Deprecate crypt module and revert PR 3854

2018-02-03 Thread Christian Heimes
On 2018-02-02 21:31, Antoine Pitrou wrote: > On Fri, 2 Feb 2018 16:23:20 +0100 > Christian Heimes wrote: >> Hi, >> >> in PR 3854 [1] Serhiy added blowfish, extended DES and NT-Hash to >> Python's crypt mdodule. I vetoed against addition of the APIs because >> all these

Re: [Python-Dev] Deprecate crypt module and revert PR 3854

2018-02-03 Thread Christian Heimes
On 2018-02-02 18:05, Serhiy Storchaka wrote: > 02.02.18 18:18, Guido van Rossum пише: >> I'm all for nudging people in the direction of xcrypt. I assume we >> can't just switch the C-level crypt with xcrypt and leave the Python >> API unchanged? >> >> However until a usable solution exist (either

Re: [Python-Dev] Deprecate crypt module and revert PR 3854

2018-02-02 Thread Dan Stromberg
On Fri, Feb 2, 2018 at 12:31 PM, Antoine Pitrou wrote: > On Fri, 2 Feb 2018 16:23:20 +0100 > Christian Heimes wrote: >> Hi, >> >> in PR 3854 [1] Serhiy added blowfish, extended DES and NT-Hash to >> Python's crypt mdodule. I vetoed against addition of

Re: [Python-Dev] Deprecate crypt module and revert PR 3854

2018-02-02 Thread Antoine Pitrou
On Fri, 2 Feb 2018 16:23:20 +0100 Christian Heimes wrote: > Hi, > > in PR 3854 [1] Serhiy added blowfish, extended DES and NT-Hash to > Python's crypt mdodule. I vetoed against addition of the APIs because > all these hashing algorithms are not state of the art. Their

Re: [Python-Dev] Deprecate crypt module and revert PR 3854

2018-02-02 Thread Nathaniel Smith
On Feb 2, 2018 7:24 AM, "Christian Heimes" wrote: Shortly after the PR has landed, I was made aware that glibc has deprecated crypt(3) API [2] and favor of an external library called libxcrypt [3] from OpenWall Linux. I have patched Python 3.7 [4] to support libxcrypt. In

Re: [Python-Dev] Deprecate crypt module and revert PR 3854

2018-02-02 Thread Serhiy Storchaka
02.02.18 18:18, Guido van Rossum пише: I'm all for nudging people in the direction of xcrypt. I assume we can't just switch the C-level crypt with xcrypt and leave the Python API unchanged? However until a usable solution exist (either in the stdlib or as 3rd party) I don't think we should

Re: [Python-Dev] Deprecate crypt module and revert PR 3854

2018-02-02 Thread Guido van Rossum
I'm all for nudging people in the direction of xcrypt. I assume we can't just switch the C-level crypt with xcrypt and leave the Python API unchanged? However until a usable solution exist (either in the stdlib or as 3rd party) I don't think we should deprecate anything (deprecating things before

[Python-Dev] Deprecate crypt module and revert PR 3854

2018-02-02 Thread Christian Heimes
Hi, in PR 3854 [1] Serhiy added blowfish, extended DES and NT-Hash to Python's crypt mdodule. I vetoed against addition of the APIs because all these hashing algorithms are not state of the art. Their quality ranges from old to horribly, horriblye broken beyond any repair. Shortly after the PR