[Python-Dev] Request for review: issue 42815: new thread doesn't copy context of the parent thread

2021-07-30 Thread Jesus Cea
https://bugs.python.org/issue42815 https://github.com/python/cpython/pull/24074 I would love to have this in Python 3.10, but the interaction with "decimal" context has a risk I don't know how to evaluate, neither the impact of a new "context" parameter when launching a new thread. It could

[Python-Dev] Request For Review: Fix test_socket.CANTest.testSendFrame (bpo-40297)

2021-04-23 Thread Karl Ding
Hi all, Could someone help take a look at the following PR, which fixes one of the broken socket module tests that exercises part of the standard library? PR Link: https://github.com/python/cpython/pull/19548 BPO Link: https://bugs.python.org/issue40297 The test can be run locally on Linux by

[Python-Dev] Request For Review: Add support for CAN_J1939 sockets (bpo-40291)

2020-04-28 Thread Karl Ding
Hi all, Could someone take a look at the following PR to add support for CAN_J1939 to the socket module? I'd like to try landing this for 3.9. This enhancement would be useful for anyone working in automotive and/or dealing with the SAE J1939 CAN protocol. This feature is available on Linux 5.4+

Re: [Python-Dev] Request for review: binary op dispatch rules for subclasses

2018-09-17 Thread Guido van Rossum
FWIW I wrote up what I recall about the issue and kicked it to the next BDFL: https://bugs.python.org/issue30140#msg325553 On Fri, Sep 14, 2018 at 6:42 PM Stephan Hoyer wrote: > Over a year ago, I made a pull request ( > https://github.com/python/cpython/pull/1325) to fix a long-standing issue

[Python-Dev] Request for review: binary op dispatch rules for subclasses

2018-09-14 Thread Stephan Hoyer
Over a year ago, I made a pull request ( https://github.com/python/cpython/pull/1325) to fix a long-standing issue with how Python handles dispatch for arithmetic binary operations involving subclasses (https://bugs.python.org/issue30140). I pinged the bug several times, but I'm still waiting for

[Python-Dev] Request for review

2018-09-13 Thread Mark Shannon
Hi, Can I request a review of https://github.com/python/cpython/pull/6641. It has been open for a few months now. Cheers, Mark. ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe:

[Python-Dev] Request for review of issue 4037

2010-02-09 Thread Steven D'Aprano
Hello, I have submitted a patch and a test script for issue 4037 on the bug tracker, doctest.py should include method descriptors when looking inside a class __dict__ http://bugs.python.org/issue4037 I would be grateful if somebody could review it please, and if suitable, commit it. Thank

[Python-Dev] request for review: patch 1446489 (zip64 extensions in zipfile)

2006-06-13 Thread Ronald Oussoren
Hi, As I mentioned earlier I'd like to get patch 1446489 (support for zip64 extensions in the zipfile module) in python 2.5. The patch should be perfectly safe, it comes with unittests and a documentation update. I'm also using this version of zipfile in (closed-source) projects to handle

Re: [Python-Dev] request for review: patch 1446489 (zip64 extensions in zipfile)

2006-06-13 Thread Aahz
On Tue, Jun 13, 2006, Ronald Oussoren wrote: There are two backward incompatbile changes, both minor. First of all ZipInfo will lose the file_offset attribute because calculating it when opening a zipfile is very expensive (it basically requires a full scan of the zipfile). This should

Re: [Python-Dev] request for review: patch 1446489 (zip64 extensions in zipfile)

2006-06-13 Thread Ronald Oussoren
On 13-jun-2006, at 15:08, Aahz wrote: On Tue, Jun 13, 2006, Ronald Oussoren wrote: There are two backward incompatbile changes, both minor. First of all ZipInfo will lose the file_offset attribute because calculating it when opening a zipfile is very expensive (it basically requires a full

Re: [Python-Dev] request for review: patch 1446489 (zip64 extensions in zipfile)

2006-06-13 Thread Gregory P. Smith
As I mentioned earlier I'd like to get patch 1446489 (support for zip64 extensions in the zipfile module) in python 2.5. The patch should be perfectly safe, it comes with unittests and a documentation update. I'm also using this version of zipfile in (closed-source) projects to handle

Re: [Python-Dev] Request for review

2006-04-13 Thread Nick Coghlan
Tim Peters wrote: [Georg Brandl] Hm. This broke a few doctests. I can fix them, but I wonder if doctest should accept a bare exception name if the exception is defined in the current module. No. Or should it ignore the module name altogether? No. doctest strives to be magic-free

[Python-Dev] Request for review

2006-04-12 Thread Seo Sanghyeon
Can someone have a look at #860326? I got bitten by it today, and I can see no reason not to apply suggested patch. Thanks! Seo Sanghyeon ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe:

Re: [Python-Dev] Request for review

2006-04-12 Thread Georg Brandl
Seo Sanghyeon wrote: Can someone have a look at #860326? I got bitten by it today, and I can see no reason not to apply suggested patch. I've reviewed it and checked it in. Cheers, Georg ___ Python-Dev mailing list Python-Dev@python.org

Re: [Python-Dev] Request for review

2006-04-12 Thread Georg Brandl
Georg Brandl wrote: Seo Sanghyeon wrote: Can someone have a look at #860326? I got bitten by it today, and I can see no reason not to apply suggested patch. I've reviewed it and checked it in. Hm. This broke a few doctests. I can fix them, but I wonder if doctest should accept a bare

Re: [Python-Dev] Request for review

2006-04-12 Thread Tim Peters
[Georg Brandl] Hm. This broke a few doctests. I can fix them, but I wonder if doctest should accept a bare exception name if the exception is defined in the current module. No. Or should it ignore the module name altogether? No. doctest strives to be magic-free WYSIWYG. If someone