[Python-Dev] Re: From the SC (was Re: Enum -- last call for comments on 3.10 changes)
On 6/29/21 9:50 AM, Barry Warsaw wrote: > the Steering Council strongly suggests that for Python 3.10, the changes in Enum’s > str and repr be reverted back to the Python 3.9 behavior, and that a PEP be written > for Python 3.11. I was unable to revert just the str and repr changes in the time available as many of them were integral to fixes and improvements made to Flag. As a result the enum in 3.10 will be the same as 3.9 (complete module reversion). A PEP will be forthcoming. My apologies and sympathies to those that contributed to the 3.10 enum module -- look for those changes in 3.11. -- ~Ethan~ ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/LSTMFAPSPD3BGZ4D6HQFODXZVB3PLYKF/ Code of Conduct: http://python.org/psf/codeofconduct/
[Python-Dev] Re: Stale PR
On 7/6/2021 12:29 PM, Brian Curtin wrote: Before looking at the code, my first question would be about the description: "I kinda ran out of time, i suspect more testing is due." If you were out of time then it's probably not done and maybe lacks the tests you initially thought it did, so did you find the time Tests were added later the same day. The opening comment should have been edited (I made an attempt at it). > and/or is the PR done? Asked on PR. -- Terry Jan Reedy ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/3UI6TTUZ5A5NPUHNBAEGSYWQSFWBGERK/ Code of Conduct: http://python.org/psf/codeofconduct/
[Python-Dev] Re: Stale PR
Before looking at the code, my first question would be about the description: "I kinda ran out of time, i suspect more testing is due." If you were out of time then it's probably not done and maybe lacks the tests you initially thought it did, so did you find the time and/or is the PR done? On Tue, Jul 6, 2021 at 10:07 AM Yair Frid wrote: > Hello, a few months ago i created this PR: > https://github.com/python/cpython/pull/24181 > Which has since gone stale, I would really like it to be reviewed before i > continue fixing other issues as i do not want to have to deal with a > backlog of PRs > Thanks in advance, Yair. > ___ > Python-Dev mailing list -- python-dev@python.org > To unsubscribe send an email to python-dev-le...@python.org > https://mail.python.org/mailman3/lists/python-dev.python.org/ > Message archived at > https://mail.python.org/archives/list/python-dev@python.org/message/TYZH5DQJUBRMEPAR5N2I5VDGHNG7Y6SU/ > Code of Conduct: http://python.org/psf/codeofconduct/ > ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/PQSY3JH7VVAWUMFAODZ3KAIXQFPP4VVB/ Code of Conduct: http://python.org/psf/codeofconduct/
[Python-Dev] Stale PR
Hello, a few months ago i created this PR: https://github.com/python/cpython/pull/24181 Which has since gone stale, I would really like it to be reviewed before i continue fixing other issues as i do not want to have to deal with a backlog of PRs Thanks in advance, Yair. ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/TYZH5DQJUBRMEPAR5N2I5VDGHNG7Y6SU/ Code of Conduct: http://python.org/psf/codeofconduct/