Re: [Python-Dev] Py_END_ALLOW_THREADS and GetLastError()

2009-01-10 Thread Hirokazu Yamamoto
Kristján Valur Jónsson wrote: Currently on Windows, Py_END_ALLOW_THREADS can have the side effect of resetting the windows error code returned by GetLastError(). There is a number of cases, particularly in posixmodule, with a pattern like: Py_BEGIN_ALLOW_THREADS result =

[Python-Dev] What type of object mmap.read_byte should return on py3k?

2009-02-28 Thread Hirokazu Yamamoto
Hello. I noticed mmap.read_byte returns 1-length unicode on py3k. I felt this was strange, so I created issue on bug tracker (http://bugs.python.org/issue5391) and Martin proposed this is suitable for discussion on python-dev. I'll quote messages on bug tracker here. I wrote: On Python3000,

Re: [Python-Dev] What type of object mmap.read_byte should return on py3k?

2009-02-28 Thread Hirokazu Yamamoto
It certainly seems like mmap should be playing in an all-bytes world (where only already encoded strings are allowed). Agreed. On the specific question of whether it would be better for read_byte()/write_byte to use 1-length bytes objects or integers, I have no strong opinion (the former is

Re: [Python-Dev] What type of object mmap.read_byte should return on py3k?

2009-02-28 Thread Hirokazu Yamamoto
Victor Stinner wrote: About m.read_byte(), we have two choices: (a) Py_BuildValue(b, value) = 0 (b) Py_BuildValue(y#, value, 1) = b\x00 About m.write_byte(x), we have also two choices: (a) PyArg_ParseTuple(args, b:write_byte, value): write_byte(0) (b) PyArg_ParseTuple(args, y#:write_byte,

Re: [Python-Dev] What type of object mmap.read_byte should return on py3k?

2009-03-01 Thread Hirokazu Yamamoto
I uploaded the patch with choice (a) http://bugs.python.org/file13215/py3k_mmap_and_bytes.patch If (b) is suitable, I'll rewrite the patch. ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe:

Re: [Python-Dev] 3.1 performance

2009-03-07 Thread Hirokazu Yamamoto
Antoine Pitrou wrote: Hello, Out of curiosity, I timed running the test suite (./python -m test.regrtest) in non-debug mode, in both the release30-maint and py3k branches: * release30-maint got: 302 tests OK. [...] 165.79user 26.03system 5:01.75elapsed 63%CPU * py3k got: 304 tests OK. [...]

Re: [Python-Dev] Test failures under Windows?

2009-03-30 Thread Hirokazu Yamamoto
David Bolen wrote: I don't know why they are happening so frequently now when there was a reasonable period when they weren't an issue (something about new I/O support in 3.x perhaps?), but without preventing them it seems the Windows build slaves are going to become (if not already) quite a

Re: [Python-Dev] 3.1a2

2009-03-31 Thread Hirokazu Yamamoto
Benjamin Peterson wrote: Hi, I'd like to release the second alpha of 3.1 as planned on Saturday, April 4th. There are currently two release blockers, issues #4847 and #5470. #5470 appears to be Martin's issue. I haven't looked at #4847 in depth, but appears that the csv module will need some

Re: [Python-Dev] 3.1a2

2009-04-01 Thread Hirokazu Yamamoto
Hirokazu Yamamoto wrote: I added #5499 to release blocker because it needs specification decision. (It's too strong?) Thank you for fixing this. I also added #5391: mmap: read_byte/write_byte and object type #5410: msvcrt bytes cleanup which depend on this issue. These are also API spec

Re: [Python-Dev] Releasing alphas tonight

2008-05-07 Thread Hirokazu Yamamoto
Hello. The py3k branch has a major show stopper, It's leaking references to the max. Is there any chance this leak also will be fixed? http://bugs.python.org/issue Thank you. ___ Python-Dev mailing list Python-Dev@python.org

Re: [Python-Dev] Not releasing rc1 tonight

2008-09-05 Thread Hirokazu Yamamoto
issue1040026 os.times() is bogus won't be fixed? ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] [Python-checkins] r66863 - python/trunk/Modules/posixmodule.c

2008-10-10 Thread Hirokazu Yamamoto
It seems to me that Skip was asking whether the memory leak impacted the 2.6 branch, and the answer should have been No: the change that introduced the memory leak had just been committed 10 minutes before. You are probably right (although it's not quite clear from Skip's question).

Re: [Python-Dev] [Python-checkins] r83763 - in python/branches/py3k: Doc/library/signal.rst Lib/test/test_signal.py Misc/NEWS Modules/signalmodule.c

2010-08-07 Thread Hirokazu Yamamoto
This is the idea just popped up. :-) #define SIG(name) if (sig_num != SIG##name) SIG(ABRT) SIG(FPE) SIG(ILL) SIG(INT) SIG(SEGV) SIG(TERM) { PyErr_SetString(PyExc_ValueError, signal number out of range); return NULL; } #undef SIG

Re: [Python-Dev] [Python-checkins] r83763 - in python/branches/py3k: Doc/library/signal.rst Lib/test/test_signal.py Misc/NEWS Modules/signalmodule.c

2010-08-07 Thread Hirokazu Yamamoto
+valid_sig |= (sig_num == valid_sigs[cur_sig]); I think ||= is more appropriate here. ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe:

Re: [Python-Dev] [Python-checkins] r83763 - in python/branches/py3k: Doc/library/signal.rst Lib/test/test_signal.py Misc/NEWS Modules/signalmodule.c

2010-08-07 Thread Hirokazu Yamamoto
On 2010/08/07 19:09, Greg Ewing wrote: Hirokazu Yamamoto wrote: #define SIG(name) if (sig_num != SIG##name) SIG(ABRT) SIG(FPE) SIG(ILL) SIG(INT) SIG(SEGV) SIG(TERM) { PyErr_SetString(PyExc_ValueError, signal number out of range); Out of range doesn't seem like quite the right message here

Re: [Python-Dev] [Python-checkins] r83763 - in python/branches/py3k: Doc/library/signal.rst Lib/test/test_signal.py Misc/NEWS Modules/signalmodule.c

2010-08-07 Thread Hirokazu Yamamoto
On 2010/08/07 19:18, Ronald Oussoren wrote: On 7 Aug, 2010, at 10:24, Hirokazu Yamamoto wrote: This is the idea just popped up. :-) #define SIG(name) if (sig_num != SIG##name) SIG(ABRT) SIG(FPE) SIG(ILL) SIG(INT) SIG(SEGV) SIG(TERM) { PyErr_SetString(PyExc_ValueError, signal

[Python-Dev] Fwd: Builder: x86 Windows7 3.x OpenSSL compile error

2010-09-20 Thread Hirokazu Yamamoto
+0900 From: Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp To: db3l@gmail.com Hello, David Bolen. I'm Hirokazu Yamamoto, Python committer. I've noticed your buildbot x86 Windows7 3.x fails to compile OpenSSL, I'm very sorry because this buildbot is very fast and looks useful. (Running

Re: [Python-Dev] [Python-checkins] r85934 - in python/branches/py3k: Misc/NEWS Modules/socketmodule.c

2010-10-30 Thread Hirokazu Yamamoto
On 2010/10/30 3:20, martin.v.loewis wrote: Modified: python/branches/py3k/Modules/socketmodule.c == --- python/branches/py3k/Modules/socketmodule.c (original) +++ python/branches/py3k/Modules/socketmodule.c Fri Oct 29

[Python-Dev] PyMem_MALLOC vs PyMem_Malloc

2010-10-30 Thread Hirokazu Yamamoto
Hello. I found several codes using PyMem_Free to free allocated memory with PyMem_MALLOC (ie: PyUnicode_AsWideCharString) Is it safe? ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe:

Re: [Python-Dev] PyMem_MALLOC vs PyMem_Malloc

2010-11-01 Thread Hirokazu Yamamoto
On 2010/10/31 2:32, M.-A. Lemburg wrote: M.-A. Lemburg wrote: Hirokazu Yamamoto wrote: Hello. I found several codes using PyMem_Free to free allocated memory with PyMem_MALLOC (ie: PyUnicode_AsWideCharString) Is it safe? Within the interpreter: yes. In extensions: depends on the platform

Re: [Python-Dev] [Python-checkins] r85987 - python/branches/py3k/Lib/test/test_os.py

2010-11-01 Thread Hirokazu Yamamoto
On 2010/10/31 6:24, brian.curtin wrote: Author: brian.curtin Date: Sat Oct 30 23:24:21 2010 New Revision: 85987 Log: Fix #10257. Clear resource warnings by using os.popen's context manager. Modified: python/branches/py3k/Lib/test/test_os.py Modified:

Re: [Python-Dev] Resource leaks warnings

2010-11-02 Thread Hirokazu Yamamoto
Sorry for late post. On 2010/09/29 20:01, Antoine Pitrou wrote: Furthermore, it can produce real bugs, especially under Windows when coupled with refererence cycles created by traceback objects I think this can be relaxed with the patch in #9815. ;-)

Re: [Python-Dev] [Python-checkins] r85987 - python/branches/py3k/Lib/test/test_os.py

2010-11-04 Thread Hirokazu Yamamoto
On 2010/11/02 1:30, Nick Coghlan wrote: On Tue, Nov 2, 2010 at 2:10 AM, Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp wrote: Does this really cause resource warning? I think os.popen instance won't be into traceback because it's not declared as variable. So I suppose it will be deleted

Re: [Python-Dev] [Python-checkins] r85987 - python/branches/py3k/Lib/test/test_os.py

2010-11-04 Thread Hirokazu Yamamoto
On 2010/11/04 23:23, Antoine Pitrou wrote: You can use all the usual means of controlling emission of warnings, so for example python -Wi would work to silence them all. Also, ResourceWarning is silenced by default in release builds. Regards Antoine. Thank you, this works. (I couldn't find

[Python-Dev] Removal of Win32 ANSI API

2010-11-11 Thread Hirokazu Yamamoto
Hello. Is it possible to remove Win32 ANSI API (ie: GetFileAttributesA) and only use Win32 WIDE API (ie: GetFileAttributesW)? Mainly in posixmodule.c. I think we can simplify the code hugely. (This means droping bytes support for os.stat etc on windows) # I recently did it for winsound.PlaySound

Re: [Python-Dev] Issues 9931 and 9055 - test_ttk_guionly and buildbot run as a service

2010-11-13 Thread Hirokazu Yamamoto
On 2010/11/13 2:07, Terry Reedy wrote: On 11/12/2010 3:44 AM, Paul Moore wrote: Hi, My buildbot has been failing for some time because of these 2 issues, both related to the fact that tests are hanging when run as a service (and hence have no display to open GUI elements on). Both issues have

Re: [Python-Dev] Removal of Win32 ANSI API

2010-11-13 Thread Hirokazu Yamamoto
On 2010/11/12 4:26, Victor Stinner wrote: On Thursday 11 November 2010 17:07:28 Hirokazu Yamamoto wrote: Hello. Is it possible to remove Win32 ANSI API (ie: GetFileAttributesA) and only use Win32 WIDE API (ie: GetFileAttributesW)? Mainly in posixmodule.c. Even if I hate the MBCS encoding

[Python-Dev] OpenSSL Voluntarily (openssl-1.0.0a)

2010-11-22 Thread Hirokazu Yamamoto
Hello. Does this affect python? Thank you. http://www.openssl.org/news/secadv_20101116.txt ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe:

Re: [Python-Dev] Removal of Win32 ANSI API

2010-11-26 Thread Hirokazu Yamamoto
On 2010/11/14 9:06, Victor Stinner wrote: Yes, but how do you check if the input argument is a bytes or a str object with your PyArg_Parse converter? You should use O format and manually convert it to unicode, and then convert the result back to bytes (if the input was bytes). It don't think

Re: [Python-Dev] Removal of Win32 ANSI API

2010-11-26 Thread Hirokazu Yamamoto
On 2010/11/12 1:18, Ulrich Eckhardt wrote: # I recently did it for winsound.PlaySound with MvL's approval Interesting, is there a ticket associate with this? Also, was that on Python 3 or 2? Which commits? Sorry for late posting. Rev 86300 and Issue 6317.

Re: [Python-Dev] [Python-checkins] r86817 - python/branches/py3k-stat-on-windows/Lib/test/test_shutil.py

2010-11-26 Thread Hirokazu Yamamoto
On 2010/11/27 3:52, Brian Curtin wrote: On Fri, Nov 26, 2010 at 12:44, hirokazu.yamamotopython-check...@python.org wrote: Author: hirokazu.yamamoto Date: Fri Nov 26 19:44:28 2010 New Revision: 86817 Log: Now can reproduce the error on AMD64 Windows Server 2008 even where os.symlink is not

Re: [Python-Dev] [Python-checkins] r86817 - python/branches/py3k-stat-on-windows/Lib/test/test_shutil.py

2010-11-26 Thread Hirokazu Yamamoto
On 2010/11/27 5:02, Brian Curtin wrote: We briefly chatted about this on the os.link feature issue, but I never found a way around it. How about implementing os.path.samefile in Modules/posixmodule.c like this? http://bugs.python.org/file19262/py3k_fix_kill_python_for_short_path.patch # I

Re: [Python-Dev] [Python-checkins] r86817 - python/branches/py3k-stat-on-windows/Lib/test/test_shutil.py

2010-12-02 Thread Hirokazu Yamamoto
On 2010/11/27 5:31, Brian Curtin wrote: On Fri, Nov 26, 2010 at 14:18, Hirokazu Yamamotoocean-c...@m2.ccsnet.ne.jp wrote: On 2010/11/27 5:02, Brian Curtin wrote: We briefly chatted about this on the os.link feature issue, but I never found a way around it. How about implementing

Re: [Python-Dev] [Python-checkins] r87070 - python/branches/py3k/Lib/test/test_shutil.py

2010-12-04 Thread Hirokazu Yamamoto
On 2010/12/05 11:08, Brian Curtin wrote: I created #10540 for this issue, but the patch I have on there is just a bad hack. I need to fix os.path.samefile for hard links, which might be easier if we keep st_ino data in stat structures on Windows. MSDN says,

Re: [Python-Dev] [Python-checkins] r87070 - python/branches/py3k/Lib/test/test_shutil.py

2010-12-04 Thread Hirokazu Yamamoto
I missed it, st_dev is not set yet. When I set st_dev with dwVolumeSerialNumber, it was sometimes negative. Is it OK? ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe:

Re: [Python-Dev] Unanswered reactions to python-checkins

2010-12-05 Thread Hirokazu Yamamoto
On 2010/12/05 23:19, Éric Araujo wrote: Me, about a change to winsound.PlaySound: Extension Modules - +- Issue #6317: Now winsound.PlaySound only accepts unicode. + - Issue #6317: Now winsound.PlaySound can accept non ascii filename. I think the new entry should have

Re: [Python-Dev] PEP 11: Dropping support for ten year old systems

2010-12-05 Thread Hirokazu Yamamoto
On 2010/12/06 6:48, Martin v. Löwis wrote: The other major system affected by this would be Windows 2000, for which we already decided to not support it anymore. Opinions? I'm +1/2 for supporting Windows 2000... ___ Python-Dev mailing list

Re: [Python-Dev] kill_python on windows buildbots

2010-12-07 Thread Hirokazu Yamamoto
On 2010/12/08 0:11, David Bolen wrote: In thinking about it some more, I suppose there's still a small window for a loss of communication during a test which results in clean not being run (which could then block the next svn checkout without an opportunity to kill the processes), so maybe the

Re: [Python-Dev] OpenSSL Vulnerability (openssl-1.0.0a)

2010-12-09 Thread Hirokazu Yamamoto
On 2010/11/25 1:23, exar...@twistedmatrix.com wrote: Ah. Okay, then Python 3.2 would be vulnerable. Good thing it isn't released yet. ;) It seems OpenSSL 1.0.0c out. http://openssl.org/news/secadv_20101202.txt 02-Dec-2010: Security Advisory: ciphersuite downgrade fix 02-Dec-2010:

[Python-Dev] Fwd: [Python-committers] Pulling from contributors repositories

2011-06-13 Thread Hirokazu Yamamoto
I've read the Python-committers thread Pulling from contributors repositories, which is about version control system. It seems there are two main issues, linear (cleaner) history on pushing, and NEWS merging. I'm newby of bazaar, but it seems to have a solution for first issue. $ bzr checkout