Re: [Python-Dev] "CPython loves your Pull Requests" talk by Stéphane Wirtel

[Terry Reedy]

On 12/5/2017 10:25 AM, Mariatta Wijaya wrote:


* Time to merge a PR: 3 days in average, good!


Slide said 2.98 days, another said 4.4% by developers.

Regarding the average time to merge PR, I'm interested to know the 
average time to merge for PRs not made by Python Core Devs.


Trivially different: assume 0 days for all dev PRs, then average would 
be 2.96 / .956 = 3.12.


But any average that includes backports, which I suspect the above does, 
is skewed way down because backports are mostly merged soon after tests 
complete.  So I think 6 days average may be more realistic for master 
branch (3.7) PRs.


The average may be skewed down even more because some of the PRs that 
have been open a month or more will eventually be merged.


On the other hand, the mean, certainly by itself, is the *wrong* 
statistic for this data.  The argument for the value of using means 
depends on the data having a distribution that is at least roughly 
gaussian (misleadingly called 'normal').  The waiting times for merging 
appear to be negative exponential (slide 75).  Long waiting times have 
an oversized influence on the mean.


 So one should either calculate and report the median time or possibly 
the mean log(wait), converted back to waiting time.  In other words, 
exp(mean(map(log, waits))).  For the latter, one should probably start 
the clock after the initial CI tests finish, which is at least 1/2 hour.


--
Terry Jan Reedy (retired statistician)

___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] "CPython loves your Pull Requests" talk by Stéphane Wirtel

[Antoine Pitrou]

On Tue, 5 Dec 2017 19:46:39 +0100
Stephane Wirtel via Python-Dev  wrote:
> But seriously, I was surprised by the number of Pull Requests and by the
> number of contributors from Feb 2017 to Oct 2017.
> 
> Here is my graph for October and November 2017.

Is it possible to compare those numbers with the number of commits /
month before the Github migration?

Regards

Antoine.


___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] "CPython loves your Pull Requests" talk by Stéphane Wirtel

[Stephane Wirtel via Python-Dev]

Hi Mariatta,

Thank you, I was really happy to see you at my talk, usually this kind
of talk is boring ;-) just kidding, but usually I prefer a technical talk.



Le 05/12/17 à 16:25, Mariatta Wijaya a écrit :
> I saw the talk in person :) Congrats Stéphane!
> 
> You can get the reviews from a specific PR using the API:
> https://developer.github.com/v3/pulls/reviews/#list-reviews-on-a-pull-request
> 
> For example, for reviews made to CPython PR number 1:
> 
> https://api.github.com/repos/python/cpython/pulls/1/reviews
> 
> * Time to merge a PR: 3 days in average, good!
> 
> 
> Regarding the average time to merge PR, I'm interested to know the
> average time to merge for PRs not made by Python Core Devs.
+1 I could add this point in my scripts.

Have a nice day and thank you for your feedback.

Stéphane
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] "CPython loves your Pull Requests" talk by Stéphane Wirtel

[Stephane Wirtel via Python-Dev]

Hi,

Thank you for this post to python-dev.

About my talk, it was a real pleasure to give it at PyCon Canada, and I
hope I could propose it to PyCon US for a larger public.

But the goal behind this talk was to show that we have a good community,
firstly by the external contributors and by the core-dev.

For the statistics, I used the REST API v3 of GitHub and matplotlib.

For the future, I would like to update them via a service running on my
own server and maybe submit it to the Python Software Foundation,
because I think it's a good indicator for the future contributors of the
project.

But seriously, I was surprised by the number of Pull Requests and by the
number of contributors from Feb 2017 to Oct 2017.

Here is my graph for October and November 2017.

I will share my scripts on Github and if you want to help me with some
good ideas, you are welcome.

Stéphane

Le 05/12/17 à 15:25, Victor Stinner a écrit :
> Hi,
> 
> Stéphane Wirtel gave a talk last month at Pycon CA about CPython pull
> requests. His slides:
> 
>https://speakerdeck.com/matrixise/cpython-loves-your-pull-requests
> 
> He produced interesting statistics that we didn't have before on pull
> requests (PR), from February 2017 to October 2017:
> 
> * total number of merged PR: 4204
> * number of contributors: 586 !!! (96%)
> * number of core developers: 27 (4%)
> * Time to merge a PR: 3 days in average, good!
> * etc.
> 
> It would be nice to get these statistics updated regularly on a
> service running somewhere.
> 
> By the way, I'm also looking for statistics on reviews on GitHub. Does
> someone know how to do that?
> 
> Victor
> 
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] "CPython loves your Pull Requests" talk by Stéphane Wirtel

[Brett Cannon]

On Tue, 5 Dec 2017 at 08:31 Senthil Kumaran  wrote:

> On Tue, Dec 5, 2017 at 6:25 AM, Victor Stinner 
> wrote:
>
>> Stéphane Wirtel gave a talk last month at Pycon CA about CPython pull
>> requests. His slides:
>>
>>https://speakerdeck.com/matrixise/cpython-loves-your-pull-requests
>>
>> He produced interesting statistics that we didn't have before on pull
>> requests (PR), from February 2017 to October 2017:
>>
>> * total number of merged PR: 4204
>> * number of contributors: 586 !!! (96%)
>> * number of core developers: 27 (4%)
>> * Time to merge a PR: 3 days in average, good!
>> * etc.
>>
>
> Plus, the slides were entertaining.
> Congrats and thanks for those stats,  Stéphane.
>

Like Mariatta I was also in the audience and Stephane was entertaining
himself as he really got into it (although he also gave me a bottle of
Belgian white wine in the talk so I may be biased :) .
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] "CPython loves your Pull Requests" talk by Stéphane Wirtel

[Senthil Kumaran]

On Tue, Dec 5, 2017 at 6:25 AM, Victor Stinner 
wrote:

> Stéphane Wirtel gave a talk last month at Pycon CA about CPython pull
> requests. His slides:
>
>https://speakerdeck.com/matrixise/cpython-loves-your-pull-requests
>
> He produced interesting statistics that we didn't have before on pull
> requests (PR), from February 2017 to October 2017:
>
> * total number of merged PR: 4204
> * number of contributors: 586 !!! (96%)
> * number of core developers: 27 (4%)
> * Time to merge a PR: 3 days in average, good!
> * etc.
>

Plus, the slides were entertaining.
Congrats and thanks for those stats,  Stéphane.
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] "CPython loves your Pull Requests" talk by Stéphane Wirtel

[Mariatta Wijaya]

I saw the talk in person :) Congrats Stéphane!

You can get the reviews from a specific PR using the API:
https://developer.github.com/v3/pulls/reviews/#list-reviews-on-a-pull-request

For example, for reviews made to CPython PR number 1:

https://api.github.com/repos/python/cpython/pulls/1/reviews

* Time to merge a PR: 3 days in average, good!


Regarding the average time to merge PR, I'm interested to know the average
time to merge for PRs not made by Python Core Devs.


Mariatta Wijaya
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

[Python-Dev] "CPython loves your Pull Requests" talk by Stéphane Wirtel

[Victor Stinner]

Hi,

Stéphane Wirtel gave a talk last month at Pycon CA about CPython pull
requests. His slides:

   https://speakerdeck.com/matrixise/cpython-loves-your-pull-requests

He produced interesting statistics that we didn't have before on pull
requests (PR), from February 2017 to October 2017:

* total number of merged PR: 4204
* number of contributors: 586 !!! (96%)
* number of core developers: 27 (4%)
* Time to merge a PR: 3 days in average, good!
* etc.

It would be nice to get these statistics updated regularly on a
service running somewhere.

By the way, I'm also looking for statistics on reviews on GitHub. Does
someone know how to do that?

Victor
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com