Re: [Python-Dev] Making "-j0" the default setting for the test suite?

2018-01-31 Thread Victor Stinner
2018-01-31 3:23 GMT+01:00 Nick Coghlan : > Something like: > > Total duration: 16 minutes 33 seconds (serial execution, pass > '-j0' for parallel execution) > > Such a change would be a safe way to nudge new contributors towards > "./python -m test -j0" for faster local

Re: [Python-Dev] Making "-j0" the default setting for the test suite?

2018-01-30 Thread Nick Coghlan
On 30 January 2018 at 02:39, Victor Stinner wrote: >> * "-j1" would explicitly turn off multiprocessing > > Running tests "sequentially" but run them in one subprocess per test > file is interesting for tests isolation. Runing tests one by one > reduces the risk of

Re: [Python-Dev] Making "-j0" the default setting for the test suite?

2018-01-29 Thread Terry Reedy
On 1/28/2018 11:30 PM, Nick Coghlan wrote: On my current system, "make test" runs in around 3 minutes, while "./python -m test" runs in around 16 minutes. And that's with "make test" actually running more tests (since it enables several of the "-u" options). Did you test with current 3.7.0a+,

Re: [Python-Dev] Making "-j0" the default setting for the test suite?

2018-01-29 Thread Victor Stinner
> * "-j1" would explicitly turn off multiprocessing Running tests "sequentially" but run them in one subprocess per test file is interesting for tests isolation. Runing tests one by one reduces the risk of triggering a race condition (test only failing when the system load is high). -jN was

Re: [Python-Dev] Making "-j0" the default setting for the test suite?

2018-01-29 Thread Guido van Rossum
I was going to argue, but it's not worth it. What you propose is fine. On Sun, Jan 28, 2018 at 10:03 PM, Nick Coghlan wrote: > On 29 January 2018 at 14:43, Guido van Rossum wrote: > > So why can't you just run "make test" if that's faster? > > I can (and

Re: [Python-Dev] Making "-j0" the default setting for the test suite?

2018-01-28 Thread Glenn Linderman
On 1/28/2018 9:15 PM, Terry Reedy wrote: The speedup would be even better but for the last very long running test. Could the last very long running test be started first, instead? (maybe it is, or maybe there are reasons not to) ___ Python-Dev mailing

Re: [Python-Dev] Making "-j0" the default setting for the test suite?

2018-01-28 Thread Nick Coghlan
On 29 January 2018 at 14:43, Guido van Rossum wrote: > So why can't you just run "make test" if that's faster? I can (and do), but I also run it the other way if I need to pass additional options. I'll then notice that I forgot -j0, ctrl-C out, then run it again with -j0.

Re: [Python-Dev] Making "-j0" the default setting for the test suite?

2018-01-28 Thread Terry Reedy
On 1/28/2018 11:43 PM, Guido van Rossum wrote: So why can't you just run "make test" if that's faster? Not a standard option on Windows ;-). On Sun, Jan 28, 2018 at 8:30 PM, Nick Coghlan > wrote: On my current system, "make test" runs in

Re: [Python-Dev] Making "-j0" the default setting for the test suite?

2018-01-28 Thread Guido van Rossum
So why can't you just run "make test" if that's faster? On Sun, Jan 28, 2018 at 8:30 PM, Nick Coghlan wrote: > On my current system, "make test" runs in around 3 minutes, while > "./python -m test" runs in around 16 minutes. And that's with "make > test" actually running

[Python-Dev] Making "-j0" the default setting for the test suite?

2018-01-28 Thread Nick Coghlan
On my current system, "make test" runs in around 3 minutes, while "./python -m test" runs in around 16 minutes. And that's with "make test" actually running more tests (since it enables several of the "-u" options). The difference is that "make test" passes "-j0" and hence not only uses all the