[Python-Dev] Re: Stable ABI question.

2020-07-03 Thread Brett Cannon
On Thu, Jul 2, 2020 at 8:05 PM Inada Naoki wrote: > On Thu, Jul 2, 2020 at 7:28 PM Victor Stinner wrote: > > > > Hi, > > > > Last time I looked at PyEval_AcquireLock(), it was used in the wild, > > but I don't recall exactly where, sorry :-( Before removing the > > functions, I suggest to first

[Python-Dev] Re: Stable ABI question.

2020-07-03 Thread Serhiy Storchaka
03.07.20 12:34, Victor Stinner пише: PyEval_ReleaseLock() is deprecated since Python 3.2 in the documentation: https://docs.python.org/dev/c-api/init.html#c.PyEval_ReleaseLock PyEval_AcquireLock() was annotated with Py_DEPRECATED() by Serhiy Storchaka in

[Python-Dev] Re: Stable ABI question.

2020-07-03 Thread Victor Stinner
PyEval_ReleaseLock() is deprecated since Python 3.2 in the documentation: https://docs.python.org/dev/c-api/init.html#c.PyEval_ReleaseLock PyEval_AcquireLock() was annotated with Py_DEPRECATED() by Serhiy Storchaka in https://bugs.python.org/issue19569#msg280110 where he wrote:

[Python-Dev] Re: Stable ABI question.

2020-07-03 Thread Victor Stinner
Le ven. 3 juil. 2020 à 11:19, Victor Stinner a écrit : > Le ven. 3 juil. 2020 à 04:51, Inada Naoki a écrit : > > Actually, PyEval_ReleaseLock is used in three packages: > > > > pydevd-pycharm-202.5103.19/pydevd_attach_to_process/windows/attach.cpp > > 330:DEFINE_PROC(releaseLock,

[Python-Dev] Re: Stable ABI question.

2020-07-03 Thread Inada Naoki
On Fri, Jul 3, 2020 at 6:23 PM Victor Stinner wrote: > > > So it seems possible to fix JEP and pydevd-pycharm. IMHO it's fine to > remove PyEval_ReleaseLock() in Python 3.10. The deprecation warning is > there since Python 3.2. > While PyEval_AcquireLock is deprecated, PyEval_ReleaseLock is not

[Python-Dev] Re: Stable ABI question.

2020-07-03 Thread Victor Stinner
Le ven. 3 juil. 2020 à 04:51, Inada Naoki a écrit : > Actually, PyEval_ReleaseLock is used in three packages: > > pydevd-pycharm-202.5103.19/pydevd_attach_to_process/windows/attach.cpp > 330:DEFINE_PROC(releaseLock, PyEval_Lock*, "PyEval_ReleaseLock", > -160); > >

[Python-Dev] Re: Stable ABI question.

2020-07-02 Thread Inada Naoki
On Thu, Jul 2, 2020 at 7:28 PM Victor Stinner wrote: > > Hi, > > Last time I looked at PyEval_AcquireLock(), it was used in the wild, > but I don't recall exactly where, sorry :-( Before removing the > functions, I suggest to first notify impacted projects of the incoming > removal, and maybe

[Python-Dev] Re: Stable ABI question.

2020-07-02 Thread Victor Stinner
Hi, Last time I looked at PyEval_AcquireLock(), it was used in the wild, but I don't recall exactly where, sorry :-( Before removing the functions, I suggest to first notify impacted projects of the incoming removal, and maybe even propose a fix. I suggest to attempt to follow the process that I

[Python-Dev] Re: Stable ABI question.

2020-07-01 Thread Inada Naoki
Thanks. I will do it. On Wed, Jul 1, 2020 at 5:50 PM Serhiy Storchaka wrote: > > 01.07.20 04:35, Inada Naoki пише: > > Hi, folks. > > > > I found PyEval_AcquireLock and PyEval_ReleaseLock are deprecated since > > Python 3.2. > > But the same time, stable ABI is defined in Python 3.2 too. > >

[Python-Dev] Re: Stable ABI question.

2020-07-01 Thread Serhiy Storchaka
01.07.20 04:35, Inada Naoki пише: Hi, folks. I found PyEval_AcquireLock and PyEval_ReleaseLock are deprecated since Python 3.2. But the same time, stable ABI is defined in Python 3.2 too. The deprecated APIs are stable ABI too because `ceval.h` is not excluded from the stable ABI PEP. As far