Re: [jira] Commented: (MODPYTHON-131) Make name of mutex directory configurable.

[Jim Gallacher]

I figured it was a mistake to do this late at night. :(

Graham Dumpleton (JIRA) wrote:
[ http://issues.apache.org/jira/browse/MODPYTHON-131?page=comments#action_12369959 ] 


Graham Dumpleton commented on MODPYTHON-131:


In respect of:

  
http://svn.apache.org/viewcvs/httpd/mod_python/trunk/src/include/mod_python.h.in?rev=385000r1=384999r2=385000view=diff

I think you probably want:

/* MUTEX_DIR can be set as a configure option
 * ./configure --with-mutex-dir=/path/to/dir
 */
#define MUTEX_DIR @MUTEX_DIR@

Ie., quote value of macro.

And in:

  
http://svn.apache.org/viewcvs/httpd/mod_python/trunk/src/mod_python.c?rev=385000r1=384999r2=385000view=diff

you probably want:

snprintf(fname, 255, %s/mpmtx%d%d, MUTEX_DIR, glb-parent_pid, n);

Ie., MUTEX_DIR is substituted using %s, as macro will not be expanded in string.


This bit is going to change anyway when I add the PythonOption 
mod_python.mutex_directory support. I have the changes ready, but I 
think I'll review them in the morning rather than committing now.


I decide to do this stuff in 2 steps:
 1. configure option
 2. PythonOption mod_python.mutex_directory
PythonOption mod_python.mutex_locks

Jim

Re: [jira] Commented: (MODPYTHON-131) Make name of mutex directory configurable.

[Jim Gallacher]

Graham Dumpleton wrote:


This bit is going to change anyway when I add the PythonOption 
mod_python.mutex_directory support. I have the changes ready, but I 
think I'll review them in the morning rather than committing now.


I decide to do this stuff in 2 steps:
 1. configure option
 2. PythonOption mod_python.mutex_directory
PythonOption mod_python.mutex_locks



BTW, the commit seemed to miss newly generated src/include/mod_python.h and
any notes added to Doc/appendixc.tex.


Not so much the commit as the committer. :)

I was going to update appendixc.tex when this thing is feature complete.

I didn't think to commit mod_python.h as it is generated from 
mod_python.h.in by ./configure. I'll have to remember to commit it in 
the future so that Nicolas doesn't have to edit it by hand. Life without 
autoconf -- how sad. ;)


Jim