[Python-Dev] Re: Is the Python review process flawed?

2021-07-02 Thread Steve Holden
On Fri, Jul 2, 2021 at 12:47 AM wrote: > Okay so I just code a little bit and I used the multiprocessing module but > my code didn't work and I found the solution on Stack Overflow and it > turned out to be not my mistake (which has never happened before I think). > Instead I found out it's a

[Python-Dev] Re: Is the Python review process flawed?

2021-07-01 Thread Jim J. Jewett
esmeraldagarcia@byom.de wrote: >> "If you would like more value out of it or to speed >> up the process, you can provide your own reviews." - > Seriously? I can't help but feel like that comment > sounds kinda arrogant. I've done it and it sometimes helps. That said, there is still a problem

[Python-Dev] Re: Is the Python review process flawed?

2021-07-01 Thread Guido van Rossum
Can we call this discussion closed? There’s not much more to be said. I’m not picking on you, Chris, I just think that not much will be gained by continuing the thread. I appreciate Esmeralda’s messages and all the responses. Now let’s go fix some bugs! :-) (Obligatory XKCD comic:

[Python-Dev] Re: Is the Python review process flawed?

2021-07-01 Thread Brett Cannon
On Thu, Jul 1, 2021 at 4:54 PM wrote: > Okay so I just code a little bit and I used the multiprocessing module but > my code didn't work and I found the solution on Stack Overflow and it > turned out to be not my mistake (which has never happened before I think). > Instead I found out it's a bug

[Python-Dev] Re: Is the Python review process flawed?

2021-07-01 Thread Chris Angelico
On Fri, Jul 2, 2021 at 10:06 AM Eric V. Smith wrote: > > On 7/1/2021 7:39 PM, esmeraldagar...@byom.de wrote: > > "Merging something is also a responsibility to whoever does it" - And it's > > also a responsibility to fix bugs, no? I don't get why you're so afraid of > > (maybe!) introducing a

[Python-Dev] Re: Is the Python review process flawed?

2021-07-01 Thread Eric V. Smith
On 7/1/2021 7:39 PM, esmeraldagar...@byom.de wrote: "Merging something is also a responsibility to whoever does it" - And it's also a responsibility to fix bugs, no? I don't get why you're so afraid of (maybe!) introducing a new bug when there already (certainly!) is a bug. Because the new

[Python-Dev] Re: Is the Python review process flawed?

2021-07-01 Thread Steve Dower
On 7/1/2021 7:04 PM, Christopher Barker wrote: PS: All that being said, we, as a community, could do better. For instance, someone like me could do high-level triage on bug reports -- I need to set aside some time to do that. In addition/instead of triage, one thing we (as core maintainers)

[Python-Dev] Re: Is the Python review process flawed?

2021-07-01 Thread esmeraldagarcia
Okay so I just code a little bit and I used the multiprocessing module but my code didn't work and I found the solution on Stack Overflow and it turned out to be not my mistake (which has never happened before I think). Instead I found out it's a bug in Python and the issue on Github was linked

[Python-Dev] Re: Is the Python review process flawed?

2021-07-01 Thread Christopher Barker
Just to add a comment from someone who's been around Python a long time -- a (very) occasional contributor, never a maintainer. I have every sympathy for the core maintainers -- Python is a very large and complex project that is relied on by an enormous number of people. The size and complexity

[Python-Dev] Re: Is the Python review process flawed?

2021-07-01 Thread Kyle Stanley
On Thu, Jul 1, 2021 at 10:49 AM Victor Stinner wrote: > What happens usually is that some modules have no maintainer. Once you > merge a single change in a module, boom! You are now the new > maintainer for your entire life time! More and more people will ask > you to look at their "very

[Python-Dev] Re: Is the Python review process flawed?

2021-07-01 Thread Victor Stinner
Thanks Brian for your nice summary! Let me complete it. Warning: I didn't look at https://github.com/python/cpython/pull/4819 at all. My email is a really general remark on the Python workflow. You in this email is not the OP, but "any contributor" ;-) What contributors don't see is that

[Python-Dev] Re: Is the Python review process flawed?

2021-06-29 Thread Antoine Pitrou
On Tue, 29 Jun 2021 13:56:18 -0300 Joannah Nanjekye wrote: > > why doesn't it get merged? > > The last significant discussion from a core dev on the most relevant PR > here: https://github.com/python/cpython/pull/4819 > shows that Antoine was familiarizing himself with the feature and had

[Python-Dev] Re: Is the Python review process flawed?

2021-06-29 Thread Guido van Rossum
On Tue, Jun 29, 2021 at 9:34 AM wrote: > If this doesn't get fixed, doesn't that mean the Python review process is > flawed? Sure, Python is an open source project and many people just work in > their free time. But this doesn't really apply here, does it? The bugfix is > available. Only a

[Python-Dev] Re: Is the Python review process flawed?

2021-06-29 Thread Brian Curtin
On Tue, Jun 29, 2021 at 10:38 AM wrote: > I just stumbled upon the following issue and subsequent pull request. It > is a very small bugfix. There is currently a bug in Python and this pull > request fixes it. It's not a new feature or an enhancement, it is a bugfix! > Yet, it doesn't get

[Python-Dev] Re: Is the Python review process flawed?

2021-06-29 Thread Barry Warsaw
As specifically to the flaws in our workflow and the backlog, this is exactly what the Developer-in-Residence program was designed to address: https://pyfound.blogspot.com/2021/04/the-psf-is-hiring-developer-in.html Stay tuned! -Barry > On Jun 29, 2021, at 09:56, Joannah Nanjekye wrote: > >

[Python-Dev] Re: Is the Python review process flawed?

2021-06-29 Thread Joannah Nanjekye
> why doesn't it get merged? The last significant discussion from a core dev on the most relevant PR here: https://github.com/python/cpython/pull/4819 shows that Antoine was familiarizing himself with the feature and had added it to their to do list. Merging something is also a responsibility

[Python-Dev] Re: Is the Python review process flawed?

2021-06-29 Thread Chris Angelico
On Wed, Jun 30, 2021 at 2:36 AM wrote: > > I just stumbled upon the following issue and subsequent pull request. It is a > very small bugfix. There is currently a bug in Python and this pull request > fixes it. It's not a new feature or an enhancement, it is a bugfix! Yet, it > doesn't get