Re: Draft of New Python Packaging Guidelines

2021-06-15 Thread Neal Gompa
On Tue, Jun 15, 2021 at 5:35 AM Miro Hrončok wrote: > > On 14. 06. 21 7:31, Zbigniew Jędrzejewski-Szmek wrote: > >> BuildRequires: %{py3_dist pytest} > > Does it make sense to recommend py3_dist here? python3dist(pytest) is > > not more complex but can be fed to 'dnf install' directly, so in the >

Re: Draft of New Python Packaging Guidelines

2021-06-15 Thread Miro Hrončok
On 14. 06. 21 7:31, Zbigniew Jędrzejewski-Szmek wrote: BuildRequires: %{py3_dist pytest} Does it make sense to recommend py3_dist here? python3dist(pytest) is not more complex but can be fed to 'dnf install' directly, so in the end it's more flexible. I always find the macro more obfuscation tha

Re: Draft of New Python Packaging Guidelines

2021-06-15 Thread Miro Hrončok
On 14. 06. 21 7:31, Zbigniew Jędrzejewski-Szmek wrote: For example, if a user runs pip install requests[security] Please quote 'requests[security]' in the command. [] are special to the shell. Done. -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok __

Re: Draft of New Python Packaging Guidelines

2021-06-15 Thread Petr Viktorin
On 14. 06. 21 2:23, Toshio Kuratomi wrote: What do you/the packaging macros do when a pypi name is taken by two different packages?  (For instance, how setuptools and distribute used the same name) The PyPI names for those are "setuptools" and "distribute". These don't conflict. They do confl

Re: Draft of New Python Packaging Guidelines

2021-06-15 Thread Miro Hrončok
On 14. 06. 21 7:57, Zbigniew Jędrzejewski-Szmek wrote: What about making this conditional: Requires: (pyproject-rpm-macros if rpm-build) You can't really*use* the macros without rpmbuild, and one less hard dependency is always good. With the conditional dep, pretty much any real system will

Re: Draft of New Python Packaging Guidelines

2021-06-13 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jun 11, 2021 at 03:24:28PM +0200, Petr Viktorin wrote: > I've proposed the new guidelines as a Fedora change: > https://fedoraproject.org/wiki/Changes/PythonPackagingGuidelines202x > The Package-x-generic-16.pngpython3-devel package, a mandatory > build-time requirement for all packages th

Re: Draft of New Python Packaging Guidelines

2021-06-13 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jun 11, 2021 at 03:24:28PM +0200, Petr Viktorin wrote: > I've proposed the new guidelines as a Fedora change: > https://fedoraproject.org/wiki/Changes/PythonPackagingGuidelines202x Some comments: > For example, if a user runs pip install requests[security] Please quote 'requests[security

Re: Draft of New Python Packaging Guidelines

2021-06-13 Thread Toshio Kuratomi
What do you/the packaging macros do when a pypi name is taken by two different packages? (For instance, how setuptools and distribute used the same name) -Toshio On Fri, Jun 11, 2021, 6:24 AM Petr Viktorin wrote: > I've proposed the new guidelines as a Fedora change: > https://fedoraproject.or

Re: Draft of New Python Packaging Guidelines

2021-06-11 Thread Petr Viktorin
I've proposed the new guidelines as a Fedora change: https://fedoraproject.org/wiki/Changes/PythonPackagingGuidelines202x A discussion thread should pop up on de...@lists.fedoraproject.org soon. ___ python-devel mailing list -- python-devel@lists.fedor

Re: Draft of New Python Packaging Guidelines - 0.3

2021-03-03 Thread Petr Viktorin
Hello, After (other parts of) $DAY_JOB delayed this for a while, a slightly updated draft is at https://hackmd.io/XzJe-sHUQvWK7cSrEH_aKg (and attached). More importantly, here is the requested summary of changes from the old guidelines, roughly sorted by "importance": https://hackmd.io/LPfT6F

Re: Draft of New Python Packaging Guidelines - 0.2

2020-08-13 Thread Petr Viktorin
On 2020-08-12 18:19, Neal Gompa wrote: On Wed, Aug 12, 2020 at 12:02 PM Petr Viktorin wrote: On 2020-08-12 17:22, Neal Gompa wrote: On Wed, Aug 12, 2020 at 11:19 AM Petr Viktorin wrote: On 2020-08-12 16:53, Neal Gompa wrote: On Wed, Aug 12, 2020 at 10:23 AM Petr Viktorin wrote: @Conan-K

Re: Draft of New Python Packaging Guidelines - 0.2

2020-08-12 Thread Neal Gompa
On Wed, Aug 12, 2020 at 12:02 PM Petr Viktorin wrote: > > On 2020-08-12 17:22, Neal Gompa wrote: > > On Wed, Aug 12, 2020 at 11:19 AM Petr Viktorin wrote: > >> > >> On 2020-08-12 16:53, Neal Gompa wrote: > >>> On Wed, Aug 12, 2020 at 10:23 AM Petr Viktorin > >>> wrote: > > I'll move s

Re: Draft of New Python Packaging Guidelines - 0.2

2020-08-12 Thread Petr Viktorin
On 2020-08-12 17:22, Neal Gompa wrote: On Wed, Aug 12, 2020 at 11:19 AM Petr Viktorin wrote: On 2020-08-12 16:53, Neal Gompa wrote: On Wed, Aug 12, 2020 at 10:23 AM Petr Viktorin wrote: I'll move some discussion here, where it doesn't become part of the document: On 2020-08-11 14:19, Pe

Re: Draft of New Python Packaging Guidelines - 0.2

2020-08-12 Thread Neal Gompa
On Wed, Aug 12, 2020 at 11:19 AM Petr Viktorin wrote: > > On 2020-08-12 16:53, Neal Gompa wrote: > > On Wed, Aug 12, 2020 at 10:23 AM Petr Viktorin wrote: > >> > >> I'll move some discussion here, where it doesn't become part of the > >> document: > >> > >>> > >>> On 2020-08-11 14:19, Petr Viktor

Re: Draft of New Python Packaging Guidelines - 0.2

2020-08-12 Thread Petr Viktorin
On 2020-08-12 16:53, Neal Gompa wrote: On Wed, Aug 12, 2020 at 10:23 AM Petr Viktorin wrote: I'll move some discussion here, where it doesn't become part of the document: On 2020-08-11 14:19, Petr Viktorin wrote: These Guidelines represent a major rewrite and paradigm shift, and not all pa

Re: Draft of New Python Packaging Guidelines - 0.2

2020-08-12 Thread Neal Gompa
On Wed, Aug 12, 2020 at 10:23 AM Petr Viktorin wrote: > > I'll move some discussion here, where it doesn't become part of the > document: > > > > > On 2020-08-11 14:19, Petr Viktorin wrote: > >> These Guidelines represent a major rewrite and paradigm shift, and not > >> all packages are updated to

Re: Draft of New Python Packaging Guidelines - 0.2

2020-08-12 Thread Petr Viktorin
I'll move some discussion here, where it doesn't become part of the document: On 2020-08-11 14:19, Petr Viktorin wrote: These Guidelines represent a major rewrite and paradigm shift, and not all packages are updated to reflect this. Older guidelines are still being kept up to date, and existi

Draft of New Python Packaging Guidelines - 0.2

2020-08-11 Thread Petr Viktorin
Hello! Here is another draft of new Python Packaging guidelines. It is now very close to complete – see the checklists at the beginning. The text is pasted for you to quote. An possibly updated version is still at https://hackmd.io/XzJe-sHUQvWK7cSrEH_aKg Thanks to Miro and the rest of the

Re: Draft of New Python Packaging Guidelines

2020-06-16 Thread Petr Viktorin
On 2020-06-11 13:22, Tomas Orsava wrote: On 6/9/20 12:15 PM, Petr Viktorin wrote: On 2020-06-08 12:15, Tomas Orsava wrote: On 6/8/20 11:58 AM, Petr Viktorin wrote: [...] https://hackmd.io/XzJe-sHUQvWK7cSrEH_aKg Looks good, thank you. All in all, really nice document. Let me know if you coul

Re: Draft of New Python Packaging Guidelines

2020-06-11 Thread Tomas Orsava
On 6/9/20 12:15 PM, Petr Viktorin wrote: On 2020-06-08 12:15, Tomas Orsava wrote: On 6/8/20 11:58 AM, Petr Viktorin wrote: On 2020-06-05 16:12, Tomas Orsava wrote: On 6/5/20 2:26 PM, Petr Viktorin wrote: On 2020-06-05 11:51, Tomas Orsava wrote: On 6/5/20 11:26 AM, Petr Viktorin wrote: O

Re: Draft of New Python Packaging Guidelines

2020-06-09 Thread Petr Viktorin
On 2020-06-08 12:15, Tomas Orsava wrote: On 6/8/20 11:58 AM, Petr Viktorin wrote: On 2020-06-05 16:12, Tomas Orsava wrote: On 6/5/20 2:26 PM, Petr Viktorin wrote: On 2020-06-05 11:51, Tomas Orsava wrote: On 6/5/20 11:26 AM, Petr Viktorin wrote: On 2020-06-03 21:49, Tomas Orsava wrote: H

Re: Draft of New Python Packaging Guidelines

2020-06-08 Thread Tomas Orsava
On 6/8/20 11:58 AM, Petr Viktorin wrote: On 2020-06-05 16:12, Tomas Orsava wrote: On 6/5/20 2:26 PM, Petr Viktorin wrote: On 2020-06-05 11:51, Tomas Orsava wrote: On 6/5/20 11:26 AM, Petr Viktorin wrote: On 2020-06-03 21:49, Tomas Orsava wrote: Hi, I have left a few notes about the text

Re: Draft of New Python Packaging Guidelines

2020-06-08 Thread Petr Viktorin
On 2020-06-05 16:12, Tomas Orsava wrote: On 6/5/20 2:26 PM, Petr Viktorin wrote: On 2020-06-05 11:51, Tomas Orsava wrote: On 6/5/20 11:26 AM, Petr Viktorin wrote: On 2020-06-03 21:49, Tomas Orsava wrote: Hi, I have left a few notes about the text itself as comments in the document. Com

Re: Draft of New Python Packaging Guidelines

2020-06-05 Thread Tomas Orsava
On 6/5/20 2:26 PM, Petr Viktorin wrote: On 2020-06-05 11:51, Tomas Orsava wrote: On 6/5/20 11:26 AM, Petr Viktorin wrote: On 2020-06-03 21:49, Tomas Orsava wrote: Hi, I have left a few notes about the text itself as comments in the document. Comments about the subject matter are inlined b

Re: Draft of New Python Packaging Guidelines

2020-06-05 Thread Petr Viktorin
On 2020-06-05 15:37, Tomas Orsava wrote: On 6/5/20 2:22 PM, Petr Viktorin wrote: On 2020-06-05 13:58, Tomas Orsava wrote: On 6/5/20 1:43 PM, Miro Hrončok wrote: On 05. 06. 20 11:51, Tomas Orsava wrote: [...] I see what you mean. On the other hand, that's a pretty horrible error message

Re: Draft of New Python Packaging Guidelines

2020-06-05 Thread Tomas Orsava
On 6/5/20 2:22 PM, Petr Viktorin wrote: On 2020-06-05 13:58, Tomas Orsava wrote: On 6/5/20 1:43 PM, Miro Hrončok wrote: On 05. 06. 20 11:51, Tomas Orsava wrote: [...] I see what you mean. On the other hand, that's a pretty horrible error message format (posting in it's entirety for other

Re: Draft of New Python Packaging Guidelines

2020-06-05 Thread Petr Viktorin
On 2020-06-05 11:51, Tomas Orsava wrote: On 6/5/20 11:26 AM, Petr Viktorin wrote: On 2020-06-03 21:49, Tomas Orsava wrote: Hi, I have left a few notes about the text itself as comments in the document. Comments about the subject matter are inlined below: On 4/30/20 3:41 PM, Petr Viktorin

Re: Draft of New Python Packaging Guidelines

2020-06-05 Thread Petr Viktorin
On 2020-06-05 13:58, Tomas Orsava wrote: On 6/5/20 1:43 PM, Miro Hrončok wrote: On 05. 06. 20 11:51, Tomas Orsava wrote: [...] I see what you mean. On the other hand, that's a pretty horrible error message format (posting in it's entirety for others to consider). Is there no better way

Re: Draft of New Python Packaging Guidelines

2020-06-05 Thread Tomas Orsava
On 6/5/20 1:43 PM, Miro Hrončok wrote: On 05. 06. 20 11:51, Tomas Orsava wrote: ## PyPI parity Every Python package in Fedora **SHOULD** also be available on [the Python Package Index](https://pypi.org) (PyPI). The command `pip install PROJECTNAME` **MUST** install the same package (possibl

Re: Draft of New Python Packaging Guidelines

2020-06-05 Thread Miro Hrončok
On 05. 06. 20 11:51, Tomas Orsava wrote: ## PyPI parity Every Python package in Fedora **SHOULD** also be available on [the Python Package Index](https://pypi.org) (PyPI). The command `pip install PROJECTNAME` **MUST** install the same package (possibly in a different version), install nothi

Re: Draft of New Python Packaging Guidelines

2020-06-05 Thread Tomas Orsava
On 6/5/20 11:26 AM, Petr Viktorin wrote: On 2020-06-03 21:49, Tomas Orsava wrote: Hi, I have left a few notes about the text itself as comments in the document. Comments about the subject matter are inlined below: On 4/30/20 3:41 PM, Petr Viktorin wrote: ### Dist-info metadata Each Pytho

Re: Draft of New Python Packaging Guidelines

2020-06-05 Thread Petr Viktorin
On 2020-06-03 21:49, Tomas Orsava wrote: Hi, I have left a few notes about the text itself as comments in the document. Comments about the subject matter are inlined below: On 4/30/20 3:41 PM, Petr Viktorin wrote: ### Dist-info metadata Each Python package **MUST** include *Package Distribu

Re: Draft of New Python Packaging Guidelines

2020-06-03 Thread Tomas Orsava
Hi, I have left a few notes about the text itself as comments in the document. Comments about the subject matter are inlined below: On 4/30/20 3:41 PM, Petr Viktorin wrote: ### Dist-info metadata Each Python package **MUST** include *Package Distribution Metadata* conforming to [PyPA speci

Re: Draft of New Python Packaging Guidelines

2020-05-07 Thread Petr Viktorin
On 2020-05-06 11:24, Lumir Balhar wrote: I've took a look and the new guidelines look good to me. The only thing I am afraid of is that there is a lot of magic behind new macros. Previously, macros were a way how to use standard Python commands like "python3 setup.py build" without memorizing

Re: Draft of New Python Packaging Guidelines

2020-05-06 Thread Zbigniew Jędrzejewski-Szmek
On Tue, May 05, 2020 at 08:04:35PM +0200, Petr Viktorin wrote: > Zbyszek said: > >Please don't advertise macros like %distname, %srcname, %origname, and > >the countless other variants in use. They made sense when people used > > >editors which didn't support search&replace easily. Having the name

Re: Draft of New Python Packaging Guidelines

2020-05-06 Thread Miro Hrončok
On 06. 05. 20 11:24, Lumir Balhar wrote: I've took a look and the new guidelines look good to me. The only thing I am afraid of is that there is a lot of magic behind new macros. Previously, macros were a way how to use standard Python commands like "python3 setup.py build" without memorizing

Re: Draft of New Python Packaging Guidelines

2020-05-06 Thread Lumir Balhar
I've took a look and the new guidelines look good to me. The only thing I am afraid of is that there is a lot of magic behind new macros. Previously, macros were a way how to use standard Python commands like "python3 setup.py build" without memorizing them and without a fear that you forget a

Re: Draft of New Python Packaging Guidelines

2020-05-05 Thread Petr Viktorin
On 2020-04-30 15:41, Petr Viktorin wrote: Hello! Below is a draft of new Packaging Guidelines! It's full of unfinished areas (marked with XXX), but it's ready for scrutiny. A possibly updated version is on https://hackmd.io/XzJe-sHUQvWK7cSrEH_aKg?view [...] The draft lives on hackmd.io, which

Re: Draft of New Python Packaging Guidelines

2020-05-04 Thread Petr Viktorin
On 2020-05-01 23:41, Michel Alexandre Salim wrote: Hi, On 4/30/20 6:41 AM, Petr Viktorin wrote: The draft lives on hackmd.io, which we found easy to collaborate with. If you have an account there, we can add you. If you'd like to collaborate some other way, let us know. Please add mic...@m

Re: Draft of New Python Packaging Guidelines

2020-05-01 Thread Michel Alexandre Salim
Hi, On 4/30/20 6:41 AM, Petr Viktorin wrote: The draft lives on hackmd.io, which we found easy to collaborate with. If you have an account there, we can add you. If you'd like to collaborate some other way, let us know. Please add mic...@michel-slm.name, thanks! (I'm assuming hackmd.io allow

Draft of New Python Packaging Guidelines

2020-04-30 Thread Petr Viktorin
Hello! Below is a draft of new Packaging Guidelines! It's full of unfinished areas (marked with XXX), but it's ready for scrutiny. A possibly updated version is on https://hackmd.io/XzJe-sHUQvWK7cSrEH_aKg?view Generally, for rules marked **SHOULD** we know of cases where they should be broken