Todd Rovito added the comment:
Roger,
I took Terminal.py and copied it into Lib/idlelib for the 3.4 branch. The
extension started just fine but when I toggle it off under the options menu the
arrow keys still go through history. Basically on my Mac I see no difference
between
Todd Rovito added the comment:
If it helps I have confirmed that this patch works great on Python 3.4 and
Python 2.7 on the Mac. The code looks very clean and provides a simple fix.
--
___
Python tracker rep...@bugs.python.org
http
Todd Rovito added the comment:
After looking at the code some more I realized that I didn't have my
configuration file configured correctly. The toggle was not working because I
left this out of my config-extensions.def file:
[Terminal_cfgBindings]
terminal-toggle=
Now it is working great
New submission from Todd Rovito:
I think it could be very helpful to add line numbers along the left side of the
editor window. The feature could be toggled on/off easily enough. This was
mentioned in the Invent with Python blog about IDLE so obviously other people
would like the feature
Changes by Todd Rovito rovit...@gmail.com:
--
nosy: +roger.serwy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17535
___
___
Python-bugs-list
Todd Rovito added the comment:
http://bugs.python.org/issue17535 covers issue 12 Add an option to show line
numbers along the left side of the editor window, and have it enabled by
default.
--
___
Python tracker rep...@bugs.python.org
http
Changes by Todd Rovito rovit...@gmail.com:
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13802
___
___
Python-bugs-list
Changes by Todd Rovito rovit...@gmail.com:
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17390
___
___
Python-bugs-list
Changes by Todd Rovito rovit...@gmail.com:
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2704
___
___
Python-bugs-list
Todd Rovito added the comment:
Made minor modifications to Roger's Terminal.py to get the extension to work
with Python 3.4. This is an excellent extension as a user can toggle it on/off
from the Options menu. The up/down arrow keys now allow a user to scroll
through history but the meta-n
Todd Rovito added the comment:
I tested the patch on Linux CentOS 6.x and it seems to work. Now if we could
only get somebody to test on Windows?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2704
Todd Rovito added the comment:
V3 added which includes much shorter variable names and a cleanup of the patch.
I still need to test on Windows.
--
Added file: http://bugs.python.org/file29370/16278OSRenameDocsTestV3.patch
___
Python tracker rep
Todd Rovito added the comment:
Thanks for the feedback Vitaliy Stepanov that helped alot with the version 3
patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16278
Todd Rovito added the comment:
Made some very minor changes to get patch to work on Windows. Had issues with
line ending differences between Unix and Windows. I fixed it so line endings
won't be an issue and tested patch on Windows, Linux, and OS X.
Please feel free to supply feedback
Todd Rovito added the comment:
Version 2 of the patch includes many improvements most of which were suggested
by Ezio making the patch a much higher quality. The patch is very WET at this
point. I still need to test on Windows which I plan to do as soon as I can get
my Windows partition
Todd Rovito added the comment:
Dirk,
I think this issue is already documented as an issue but I will have to find
it in the tracker.
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17382
Todd Rovito added the comment:
Ezio,
Thank you or the feedback I will continue to polish the test cases. As far
as the documentation I really like the table and find it easy to read but I
could go either way. If you read the history of this issue other Python Core
Developers asked
Changes by Todd Rovito rovit...@gmail.com:
Removed file: http://bugs.python.org/file27890/OSRename_test_os_3point4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16278
Changes by Todd Rovito rovit...@gmail.com:
Removed file: http://bugs.python.org/file28071/OSRenameDocs3point4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16278
Todd Rovito added the comment:
Combined the test cases and document changes into a single patch. As suggested
by Mr. Terry Reedy I used a table and removed the text. The table still needs
some work but it is a good start. As suggested by Mr. Jerdonek I tried to make
the test cases WETter
Todd Rovito added the comment:
Over the weekend I caught this terrible cold and have not been able to work on
this issue much. Hopefully I can complete by next weekend 2/25/2013 thanks for
your understanding.
--
___
Python tracker rep
Todd Rovito added the comment:
Thanks Terry and Chris you guys have supplied great feedback. I will work on
the issue and try to get a new patch updated by end of the weekend (2/18/13).
Sent from my iPhone
On Feb 13, 2013, at 11:56 PM, Terry J. Reedy rep...@bugs.python.org wrote:
Terry J
Todd Rovito added the comment:
Chris,
I first verified the issue then created some wording and you pointed out
that we needed test cases so I created a bunch of test cases. As you pointed
out I count 2*3*2=12 possibilities to check (excluding src and dst being on
different filesystems
Todd Rovito added the comment:
Chris,
Thanks for the clarification. I thought you were telling me my test cases
were dry as in dry humorI will read-up on the dry concept and see what I
can do to consolidate plus I will combine the patches. Initially I am thinking
I could collapse all
Todd Rovito added the comment:
This is a gentle ping of this issue. Can somebody please review and let me
know what needs to be done to get this committed? I did test the patch on
2/12/2013 and it seems to work from the latest 3.4. Thanks
Todd Rovito added the comment:
Andrew,
Zachary and I worked on another issue together to sync idle.rst with
help.txt here:
http://bugs.python.org/issue5066
Issue 5066 is ready for commit if you have time by the way. Thanks!
--
___
Python
Todd Rovito added the comment:
I think getting this issue fixed makes sense, it would save time and remove
duplication.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16893
Todd Rovito added the comment:
Thanks Senthil but I don't deserve all the credit this issue is a team effort
with lots of help from Zach, Éric, and Ezio. All of which have improved the
patch's quality a great deal. Hopefully we can address the issues then let you
make the commit soon
Todd Rovito added the comment:
I took all the comments and created a new patch version 4 which should address
all the issues. Thanks for the excellent review and support from everybody. I
think this patch is a much higher quality now.
--
Added file:
http://bugs.python.org/file28643
Todd Rovito added the comment:
Ok I changed the time to one month...now the patch reads:
To begin with, please be patient! There are many more people submitting
patches than there are people capable of reviewing your patch. Getting your
patch reviewed requires a reviewer to have the spare time
Changes by Todd Rovito rovit...@gmail.com:
Removed file:
http://bugs.python.org/file28573/16868PythonDeveloperGuidePingIssueBeforeEmailingPython-dev.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16868
Changes by Todd Rovito rovit...@gmail.com:
Removed file:
http://bugs.python.org/file28603/16868PythonDeveloperGuidePingIssueBeforeEmailingPython-devV2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16868
Todd Rovito added the comment:
Zachary,
I like your idea about joining idle.rst with help.txt but I think that
should be covered under a separate bug issue. The way I see it this bug is
about fixing the current documentation. So I suggest you open up a new issue
and get people's take
Todd Rovito added the comment:
Zachary,
Thanks for your excellent review Your feedback was very helpful for
making the patch even better.
--
Added file:
http://bugs.python.org/file28626/5066IDLEocumentationforUnixObsoleteIncorrectVersion3.patch
Todd Rovito added the comment:
Based on Zachary's comments I have uploaded a new version of the patch which is
version 3.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5066
Todd Rovito added the comment:
I agree with Meador it should be a specific amount of time. As a beginner at
contributing to Python I thought substantial amount of time meant one month
but it depends on interpretation. I think making it very specific makes the
documentation more clear
Todd Rovito added the comment:
A ping on this bug since it has not had any forward movement. Can somebody
please review and or commit? Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5066
Todd Rovito added the comment:
Thanks much appreciated!
Sent from my iPhone
On Jan 4, 2013, at 1:07 PM, Zachary Ware rep...@bugs.python.org wrote:
Zachary Ware added the comment:
Hi Todd, I can't commit, but I have a review in the works for you.
--
nosy: +zach.ware
New submission from Todd Rovito:
The Python Developer Guide in section 3.3 about the life cycle of a
patch/review process makes no mention that a bug should be pinged first
before posting to the python-...@python.org email list requesting a review.
For more information see this thread
Changes by Todd Rovito rovit...@gmail.com:
--
components: +Devguide -Documentation
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16868
Todd Rovito added the comment:
Here is a suggested patch with help from R. David Murray:
To begin with, please be patient! There are many more people submitting
patches than there are people capable of reviewing your patch. Getting your
patch reviewed requires a reviewer to have the spare time
Todd Rovito added the comment:
Version 2 of the patch change include:
-help.txt removed all tabs and replaced with spaces, as suggested by Roger
-help.txt re-inserted the section on running IDLE without a subprocess as
suggested by Roger
-Added a note on line 162 (idle.rst) about how the Python
Todd Rovito added the comment:
For version 2 of the patch
-Line 340 (idle.rst) where the Emacs bindings are rendered seemed to work fine
on my computer without the spaces but I think ezio is correct spaces should be
present so I added them
**SHOULD BE**
-Line 340 (idle.rst) where
Todd Rovito added the comment:
This patch is an extensive refactoring of help.txt and idle.rst. The first
thing I did was merge issue5066.patch from jesstess into the current idle.rst
file, because the original patch from jesstess was so old it had to be merged
by hand into the 3.4 source
Changes by Todd Rovito rovit...@gmail.com:
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5066
___
___
Python-bugs-list
Todd Rovito added the comment:
This is a good patch but it is rather out of date and won't apply. I will
patch the patch and maybe somebody can apply it this time. Expect a new patch
by 11/26/2012.
--
___
Python tracker rep...@bugs.python.org
Todd Rovito added the comment:
Attached is patch with the final formatting for the documentation updates. I
fixed the :exc:`OSError` problems that I had before and used indents to denote
Unix behavior VS Windows behavior. Please let me know if I can do anything else
to help get this issue
Changes by Todd Rovito rovit...@gmail.com:
Removed file: http://bugs.python.org/file27640/OSRenameTest3point4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16278
Todd Rovito added the comment:
Here is a draft suggestion for the documentation change, not all the formatting
is worked out:
.. function:: rename(src, dst, *, src_dir_fd=None, dst_dir_fd=None)
Rename the file or directory *src* to *dst*. If *src* exists as either
a file or directory
Todd Rovito added the comment:
Chris,
That is an excellent suggestion. I modified my OSRenameCombinations.py
program and attached. This program prints a table with the src parameters as
columns and the dst as rows. Hopefully it will show up ok in the bug tracker.
For Unix
Todd Rovito added the comment:
Attached is a patch for 16 test cases. All 16 test cases have been tested on
Windows 7, Mac OS X, and Linux they seem to function well. Before this patch
there was only a single test case for rename. For each test case I used
unittest.skipUnless to make sure
Todd Rovito added the comment:
Ned,
I respectfully disagree that this is not a new feature. IDLE could always
copy/cut/paste from the edit menu and it had a right click menu. All this patch
does is add options to right click menu and call the same functions as the edit
menu does. I could
Todd Rovito added the comment:
While writing test cases I discovered another conflict with the documentation.
The phrase On Unix, if dst exists and is a file, it will be replaced silently
if the user has permission and src is a file. is not correct. According to
the test cases I wrote
Changes by Todd Rovito rovit...@gmail.com:
Removed file: http://bugs.python.org/file27804/OSRename_test_os.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16278
Todd Rovito added the comment:
False alarm my test case was buggy.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16278
___
___
Python-bugs-list
Todd Rovito added the comment:
Over the weekend I verified the test cases are incomplete for Python 3.4.
Inside of Lib/test/test_os.py is a class FileTests that contains a single
function test_rename which seems to only check to make sure that the reference
count for the first argument
Todd Rovito added the comment:
Thanks for the feedback! Over the weekend I will make sure the documentation
and test cases cover all possibilities. I have not worked with test suite but
I will do my best.
--
___
Python tracker rep
Changes by Todd Rovito rovit...@gmail.com:
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16278
___
___
Python-bugs-list
Todd Rovito added the comment:
David,
Thanks for your bug report. Indeed os.rename does not exhibit the same
behavior as the documentation describes.
For Python 3.4 here is the fix I came up with:
Rename the file or directory src to dst. If dst is a directory that is not
empty, OSError
Changes by Todd Rovito rovit...@gmail.com:
Removed file:
http://bugs.python.org/file27615/RightClickContextMenuUpdatedFor3point4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1207589
Changes by Todd Rovito rovit...@gmail.com:
Removed file:
http://bugs.python.org/file27616/RightClickContextMenuUpdatedFor2point7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1207589
Todd Rovito added the comment:
Same patch as before but updated the documentation and help.txt file for IDLE.
This is for Python 2.7.
--
Added file:
http://bugs.python.org/file27644/RightClickContextMenuUpdatedWithDocs2point7.patch
___
Python
Todd Rovito added the comment:
Same patch as before but updated the documentation and help.txt file for IDLE.
This is for Python 3.4.
--
Added file:
http://bugs.python.org/file27645/RightClickContextMenuUpdatedWithDocs3point4.patch
___
Python
Changes by Todd Rovito rovit...@gmail.com:
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15869
___
___
Python-bugs-list
Changes by Todd Rovito rovit...@gmail.com:
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15392
___
___
Python-bugs-list
Changes by Todd Rovito rovit...@gmail.com:
Removed file: http://bugs.python.org/file27605/DataModel__len__.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1283110
Todd Rovito added the comment:
Changed the file name so it is clear that this patch goes with version 3.4.
--
Added file:
http://bugs.python.org/file27624/RightClickContextMenuUpdatedFor3point4.patch
___
Python tracker rep...@bugs.python.org
http
Changes by Todd Rovito rovit...@gmail.com:
Removed file:
http://bugs.python.org/file27624/RightClickContextMenuUpdatedFor3point4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1283110
Todd Rovito added the comment:
Used the right patch file name this time...
--
Added file: http://bugs.python.org/file27625/DataModel__len__3point4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1283110
Todd Rovito added the comment:
This patch is for Python 2.7.
--
versions: +Python 2.7
Added file: http://bugs.python.org/file27626/DataModel__len__2point7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1283110
Todd Rovito added the comment:
Nick,
I agree some documentation is better than none. But somebody could do better
I am not sure how to debug in IDLE. I have taken your file and created a 2.7
patch.
--
keywords: +patch
type: - enhancement
versions: -Python 3.1, Python 3.2
Added
Changes by Todd Rovito rovit...@gmail.com:
Removed file:
http://bugs.python.org/file27627/IDLEBreakPointDocumentation2point7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10405
Todd Rovito added the comment:
This patch works for both Python 3.4 and Python 2.7, it is a very simple patch.
--
versions: +Python 3.4
Added file: http://bugs.python.org/file27628/IDLEBreakPointDocumentation.patch
___
Python tracker rep
Changes by Todd Rovito rovit...@gmail.com:
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1207589
___
___
Python-bugs-list
Changes by Todd Rovito rovit...@gmail.com:
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10405
___
___
Python-bugs-list
Changes by Todd Rovito rovit...@gmail.com:
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13884
___
___
Python-bugs-list
Changes by Todd Rovito rovit...@gmail.com:
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13504
___
___
Python-bugs-list
Todd Rovito added the comment:
Terry,
I would not miss the feature at all this is very old school Unix like and
most people find it confusing. At my job I tend to provide Python support to
my co-workers and have had many questions about it. In addition I think #13504
meta issue provides
Todd Rovito added the comment:
I used taleinat's patch as the start for a patch that works with 3.4. Lots of
code was changed from 2010 to 2012 so I basically hand merged the patch into
3.4. This patch was tested with Python 3.4.0a0 on both Mac OS X and Linux. As
suggested by taleinat
Changes by Todd Rovito rovit...@gmail.com:
Removed file:
http://bugs.python.org/file27614/RightClickContextMenuUpdatedFor3point4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1207589
Todd Rovito added the comment:
This time I ran make patchcheck on the patch and it corrected a single white
space.
I used taleinat's patch as the start for a patch that works with 3.4. Lots of
code was changed from 2010 to 2012 so I basically hand merged the patch into
3.4. This patch
Todd Rovito added the comment:
I used taleinat's patch as the start for a patch that works with 2.7. Lots of
code was changed from 2010 to 2012 so I basically hand merged the patch into
2.7. This patch was tested with Python 2.7.3 on both Mac OS X and Linux. As
suggested by taleinat
Todd Rovito added the comment:
Changed the version to make it clear this issue as a patch for 3.4 and 2.7.
--
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1207589
Changes by Todd Rovito rovit...@gmail.com:
Removed file: http://bugs.python.org/file27589/DataModel__len__.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1283110
Todd Rovito added the comment:
New patch with a better reference to the source for the test case. This was
suggested by PythonMentors list. I think the patch improves the documentation.
This works on Python 3.4.
--
Added file: http://bugs.python.org/file27605/DataModel__len__.patch
Todd Rovito added the comment:
I think this is an excellent idea. How about putting in some advanced
debugging with IDLE? For example I have read somewhere that IDLE lets you set
break points but the documentation for IDLE OS not that clear on debugging.
--
nosy: +Todd.Rovito
Todd Rovito added the comment:
Applies to Python 3.4 in development and Python 2.7. I recently ran into a
similar conflict where I was overriding a environment variable with a command
line option and didn't realize it. I first checked the documentation and
noticed that it was not clear
Todd Rovito added the comment:
For Python 3.4 attached is a patch as suggested by Raymond Hettinger. My
suggestion is to put the patch in Doc/reference/datamodel.rst because if a user
searches google.com for __len__ this is the first link in the list. I think
this extra information
Todd Rovito added the comment:
After another review I decided to submit a newer patch that uses a comma so I
think the documentation flows better.
--
type: - enhancement
Added file: http://bugs.python.org/file27590/EnvironmentVariables.patch
Changes by Todd Rovito rovit...@gmail.com:
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8536
___
___
Python-bugs-list
101 - 190 of 190 matches
Mail list logo
