Filip Gruszczyński added the comment:
Crap, it was so long ago, that I honestly don't remember why I added this if.
It made sense back then.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13896
Filip Gruszczyński grusz...@gmail.com added the comment:
I prefer to be humble and trust core devs, when I post some patch to a codebase
I don't know very well. I am glad you managed to reproduce it and I could help
:-)
--
___
Python tracker rep
Filip Gruszczyński grusz...@gmail.com added the comment:
Do you think I should put everything into a single patch or rather slowly add
new patches with different methods or method groups?
I would rather split it into several patches, I think it is easier to manage
them, especially
Filip Gruszczyński grusz...@gmail.com added the comment:
I would stay away from methods that accept just a single argument. For those
that accept more, I think it's reasonable to allow keyword args.
--
___
Python tracker rep...@bugs.python.org
http
Filip Gruszczyński grusz...@gmail.com added the comment:
I don't know if this is exactly what you want, but this is an early patch.
--
keywords: +patch
nosy: +gruszczy
Added file: http://bugs.python.org/file24644/8706.patch
___
Python tracker rep
Filip Gruszczyński grusz...@gmail.com added the comment:
With tests.
--
Added file: http://bugs.python.org/file24650/8706_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8706
Filip Gruszczyński grusz...@gmail.com added the comment:
Fixed both issues.
--
Added file: http://bugs.python.org/file24652/13521_27_4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13521
Filip Gruszczyński grusz...@gmail.com added the comment:
Bump! I would like to remind about this issue and patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11807
Filip Gruszczyński grusz...@gmail.com added the comment:
closing was solving my problem, but I'll be happy on working on this patch, if
you think it's useful after all. I don't think the stage should be test needed,
since the patch has tests (I know the drill here
Filip Gruszczyński grusz...@gmail.com added the comment:
Oh, I haven't noticed that. Using contextlib.closing solves my problem. Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13896
New submission from Filip Gruszczyński grusz...@gmail.com:
It would be cool if use could use with to manage shelf object and forget about
close.
--
messages: 152159
nosy: gruszczy
priority: normal
severity: normal
status: open
title: shelf doesn't work
Changes by Filip Gruszczyński grusz...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file24347/13896.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13896
Filip Gruszczyński grusz...@gmail.com added the comment:
No more double lookup.
--
Added file: http://bugs.python.org/file24244/13521_27_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13521
Filip Gruszczyński grusz...@gmail.com added the comment:
Bump! It's almost 3 months since I posted the patch, so I would like to remind
about this bug.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11694
Filip Gruszczyński grusz...@gmail.com added the comment:
Bump! There was no activity here for two weeks. Is my patch for 2.7 ok or
should I do something more about it?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13521
Filip Gruszczyński grusz...@gmail.com added the comment:
I understand you are talking about this call:
mp-ma_lookup(mp, key, hash);
I haven't noticed that earlier. I'll try to provide a better fix (for 2.7
first, after we agree it's good enough, I will provide one for 3.3).
Do you have any
Filip Gruszczyński grusz...@gmail.com added the comment:
Thanks, I'll try that. Like before I will probably find time next weekend.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13521
New submission from Filip Gruszczyński grusz...@gmail.com:
This is a useful flag and it would be good, if it was in documentation.
--
messages: 150423
nosy: gruszczy
priority: normal
severity: normal
status: open
title: Add DEBUG flag to documentation of re.compile
Changes by Filip Gruszczyński grusz...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file24118/13690.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13690
Filip Gruszczyński grusz...@gmail.com added the comment:
Patch for 2.7.
--
Added file: http://bugs.python.org/file24035/13521_27_1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13521
Filip Gruszczyński grusz...@gmail.com added the comment:
Fixed patch.
--
Added file: http://bugs.python.org/file24042/11807_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11807
Filip Gruszczyński grusz...@gmail.com added the comment:
Pleasure :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
___
___
Python-bugs
Filip Gruszczyński grusz...@gmail.com added the comment:
I haven't given it much thought, when I was making the choice of using nonlocal
rather than self.count. I was rather excited to see, if the change will work as
I wanted it to. If you believe it would be better to use an attribute, I'll
Filip Gruszczyński grusz...@gmail.com added the comment:
I'll send a patch, when I get home from work.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13521
Filip Gruszczyński grusz...@gmail.com added the comment:
I have tried to port patch to python2.7, but apparently I must be doing
something wrong, because while most tests pass, several fail (including tests
for unittest itself).
I would like to continue working on this test, but incoming week
Filip Gruszczyński grusz...@gmail.com added the comment:
I didn't know about `make patchcheck`, next time I will use it, thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
Filip Gruszczyński grusz...@gmail.com added the comment:
Fixed tests.
--
Added file: http://bugs.python.org/file23912/13544_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
Filip Gruszczyński grusz...@gmail.com added the comment:
I have written a patch and a test, but since it's changing C code, I am far
from being sure if it's achieve the expected behavior in the right way. There
are also tests and running whole test suite didn't bring any errors
Filip Gruszczyński grusz...@gmail.com added the comment:
Also: I'll be happy to work further on this patch, if I get some comments and
advice.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13521
Filip Gruszczyński grusz...@gmail.com added the comment:
Done.
--
Added file: http://bugs.python.org/file23918/13521_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13521
Filip Gruszczyński grusz...@gmail.com added the comment:
Patch with tests.
--
keywords: +patch
nosy: +gruszczy
Added file: http://bugs.python.org/file23906/13544.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
Filip Gruszczyński grusz...@gmail.com added the comment:
c.execute(insert into testdate values ('now'))
This works, but you actually are putting string now into a field with DATE
type. When conversion occurs after retrieving data, there is an error. Also if
you use datetime() function
Filip Gruszczyński grusz...@gmail.com added the comment:
Patch with tests.
--
keywords: +patch
Added file: http://bugs.python.org/file23178/11694.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11694
/
--
Filip Gruszczyński
--
http://mail.python.org/mailman/listinfo/python-list
posted a gzipped version with a fix. Would you care to take a look?
--
Filip Gruszczyński
--
http://mail.python.org/mailman/listinfo/python-list
wanto to touch autotools again.
--
Filip Gruszczyński
--
http://mail.python.org/mailman/listinfo/python-list
Filip Gruszczyński grusz...@gmail.com added the comment:
Should I try to do something about this right now or should I wait until #1170
is finishedclosed and only then try to fix this issue too?
--
___
Python tracker rep...@bugs.python.org
http
Filip Gruszczyński grusz...@gmail.com added the comment:
Bump! Antoine, do you think the patch is acceptable and can be committed now?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6584
New submission from Filip Gruszczyński grusz...@gmail.com:
In documentation for packaging.pypi.simple in first code snippet crawler
variable is created on which further operations will be performed. However in
all next snippets there is client variable, which is a little confusing on
first
Filip Gruszczyński grusz...@gmail.com added the comment:
And a small, quick patch to docs.
--
keywords: +patch
Added file: http://bugs.python.org/file22396/12354.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12354
Filip Gruszczyński grusz...@gmail.com added the comment:
When I started looking at this I noticed following behaviour:
from packaging.pypi.simple import Crawler
client = Crawler()
client.get_releases('webob')
Traceback (most recent call last):
File stdin, line 1, in module
File /home
New submission from Filip Gruszczyński grusz...@gmail.com:
When looking at issue #12348 I have noticed following behaviour:
from packaging.pypi.simple import Crawler
c = Crawler()
c.get_releases('webob')
Traceback (most recent call last):
File test_crawl.py, line 3, in module
Filip Gruszczyński grusz...@gmail.com added the comment:
OK, I'll try to come up with some patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12355
://code.google.com/p/fathom-tools
qfathom
QFathom is graphical tool written in python3 and PyQt for inspecting
the database. It is basically a graphical frontend for fathom.
http://code.google.com/p/qfathom/
And once again any kind of ideas or comments would be greatly appreciated.
--
Filip Gruszczyński
New submission from Filip Gruszczyński grusz...@gmail.com:
You can do this:
[1] + (1,)
Traceback (most recent call last):
File stdin, line 1, in module
TypeError: can only concatenate list (not tuple) to list
But you can do this:
result = [1]
result += (1,)
result
[1, 1
Filip Gruszczyński grusz...@gmail.com added the comment:
Obviously first sentence should be You can't do this:.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12318
for finding procedures that access a table
- fathom2graphviz draws lines between columns for foreign key
- fathom2graphviz and fathom2django can now print output to a file,
rather than to std
--
Filip Gruszczyński
--
http://mail.python.org/mailman/listinfo/python-list
Filip Gruszczyński grusz...@gmail.com added the comment:
Bump! How about commiting this patch, Eric?
--
status: pending - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8933
New submission from Filip Gruszczyński grusz...@gmail.com:
I have proposed on Core Mentorship list to add get(index, default) method to
list object. I was suggested to bring it up here and also told, that improving
operator module could be a better solution. This is why I would like to ask
Filip Gruszczyński grusz...@gmail.com added the comment:
Nick Coghlan suggested, that operator.getitem could be extended to accept
default value. How does it sound to you?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Filip Gruszczyński grusz...@gmail.com added the comment:
The reason for the use of two constants is that previously there was comparison
in the code with a hardcoded 'f':
if postdev[0] == 'f':
I think it's a common practice to create constants for such hardcoded values.
Also
Filip Gruszczyński grusz...@gmail.com added the comment:
I understand that ML is mailing list, but I have no idea what is fellowship
mailing list. Could you elaborate on this?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Filip Gruszczyński grusz...@gmail.com added the comment:
Actually documentation doesn't say that it supports only bytes, but:
The following methods support packing strings, bytes, and opaque data:
Also under python2 you can easily do this:
In [1]: import xdrlib
In [2]: p = xdrlib.Packer
Filip Gruszczyński grusz...@gmail.com added the comment:
I am well aware of this, Benjamin. I am not trying to force any solution, but
rather trying to point out, that current documentation is misleading. There
might be no need for patching the code, but rather updating the docs to say
Filip Gruszczyński grusz...@gmail.com added the comment:
I'll provide docs patch.
--
assignee: - docs@python
components: +Documentation -None
nosy: +docs@python
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9544
Filip Gruszczyński grusz...@gmail.com added the comment:
Here is a patch that I made against distutils2 tip. I have changed
_FINAL_MARKER from 'f' to 'z', which works with rc. Also I have added constant
_FINAL_MARKER_CHAR, since later in the code you make a check against 'f' and it
surprised
Filip Gruszczyński grusz...@gmail.com added the comment:
Here is a patch for this. I am not much of technical writer, so please be
patient with me. I tried to provide all the information about parameters, that
can be inferred from the code and experimenting. I have left out one parameter
I forgot links:
Homepage: http://code.google.com/p/fathom/
Documentation: http://code.google.com/p/fathom/wiki/Manual
--
Filip Gruszczyński
--
http://mail.python.org/mailman/listinfo/python-list
diagrams in
graphviz dot language, that can be turned into pdf or image files
--
Filip Gruszczyński
--
http://mail.python.org/mailman/listinfo/python-list
New submission from Filip Gruszczyński grusz...@gmail.com:
In argparse documentation parametres of add_subparsers are not listed. And yet
there are some really useful parametres like parser_class. It would be useful,
it they were described there well and one wouldn't have to look into the code
Changes by Filip Gruszczyński grusz...@gmail.com:
--
nosy: +bethard
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11807
___
___
Python-bugs-list
Filip Gruszczyński grusz...@gmail.com added the comment:
I have no idea how I should do this. If you explain to me, how it should be
done, I'll be happy to do this from now on :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Filip Gruszczyński grusz...@gmail.com added the comment:
Here it is.
--
keywords: +patch
Added file: http://bugs.python.org/file21588/11740.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6931
Filip Gruszczyński grusz...@gmail.com added the comment:
Here is a new patch, that uses with in __getitem__. I wonder, if we shouldn't
check for an AttributeError in case object returned by get_file doesn't have
__exit__ method, but does have close and use close instead of with. But it's
Filip Gruszczyński grusz...@gmail.com added the comment:
I am sorry. This is the first time I see contextlib and haven't understood,
that I should use a function from it. Here is a version with mock object having
close method and __getitem__ using contextlib.closing.
--
Added file
Filip Gruszczyński grusz...@gmail.com added the comment:
Shouldn't this be your responsibility to close this descriptor in the object
used as self._factory? When self._factory is called it should read from the
file like object and then simply close it, just as get_message (when
self._factory
Filip Gruszczyński grusz...@gmail.com added the comment:
I have a follow-up question: why keyobject_type needed traverse function? From
what I read in docs I assumed it is required for GC tracked types. Why was it
required here and how it is used
Filip Gruszczyński grusz...@gmail.com added the comment:
I see. Thanks :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11707
___
___
Python
Filip Gruszczyński grusz...@gmail.com added the comment:
Here are some example performance results:
def cmp(x, y):
return y - x
sorted(range(1, 1000), key=cmp_to_key(cmp))
'''
C version:
real0m19.994s
user0m8.053s
sys 0m1.044s
Python version:
real0m28.825s
user
Filip Gruszczyński grusz...@gmail.com added the comment:
I worked a little on the tests. Only then I have noticed, that cmp_to_key tests
weren't run, so I have encountered some problems, when I finally turned them
on. I have added some of my tests, fixed some things in the patch and now
Filip Gruszczyński grusz...@gmail.com added the comment:
The culprit seems to be Differ._fancy_replace. There is a nasty quadratic loop
there, that has pretty complex internal code. I have done a quick a fix, that
makes example run below a second at the expense of not calling _fancy_replace
Changes by Filip Gruszczyński grusz...@gmail.com:
--
nosy: +gruszczy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8905
___
___
Python-bugs-list
Filip Gruszczyński grusz...@gmail.com added the comment:
Check also this:
http://bugs.python.org/issue11740
--
nosy: +gruszczy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6931
Filip Gruszczyński grusz...@gmail.com added the comment:
Here is a patch that passes functools tests. I'll be happy to work on it
further.
--
keywords: +patch
Added file: http://bugs.python.org/file21504/11707.patch
___
Python tracker rep
Filip Gruszczyński grusz...@gmail.com added the comment:
Ok, here is patch that keep python implementation of cmp_to_key if C version
can't be imported.
Thanks again for you help :-)
--
Added file: http://bugs.python.org/file21505/11707_2.patch
Filip Gruszczyński grusz...@gmail.com added the comment:
Is following change in GzipFile class enough:
def read1(self, n):
return self.read(n)
? This satisfies TextIOWrapper to run readline correctly.
--
nosy: +gruszczy
___
Python
Changes by Filip Gruszczyński grusz...@gmail.com:
--
nosy: +gruszczy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11740
___
___
Python-bugs-list
Changes by Filip Gruszczyński grusz...@gmail.com:
--
nosy: +gruszczy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11707
___
___
Python-bugs-list
Changes by Filip Gruszczyński grusz...@gmail.com:
--
nosy: +mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9544
___
___
Python-bugs
Filip Gruszczyński grusz...@gmail.com added the comment:
Here is a test and a patch.
--
keywords: +patch
nosy: +gruszczy
Added file: http://bugs.python.org/file21426/9696.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Filip Gruszczyński grusz...@gmail.com added the comment:
Here is a simple patch with a test. Depending o bytes in this library seems
strange, maybe it should be changed somehow? Anyway, this simple patch should
be a quick fix to the problem.
--
keywords: +patch
nosy: +gruszczy
Added
New submission from Filip Gruszczyński grusz...@gmail.com:
xdrlib defines ConversionError, but very seldom uses it. For example:
def pack_float(self, x):
try: self.__buf.write(struct.pack('f', x))
except struct.error as msg:
raise ConversionError(msg
Filip Gruszczyński grusz...@gmail.com added the comment:
I believe this should be applied also against 3.3. I was working on this using
3.3 code base, so it is not working there too.
--
___
Python tracker rep...@bugs.python.org
http
Filip Gruszczyński grusz...@gmail.com added the comment:
I'm sorry, I wasn't hurrying you. Just wanted to make sure you know.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9696
Filip Gruszczyński grusz...@gmail.com added the comment:
Well, since you are the designer of the package, I believe you have better
knowledge on how to extend it :-). I just provided a patch according to what
you described in the first message. Anyway having separate help formatter seems
for comments and additional ideas for new features..
Documentation can be found here: http://code.google.com/p/fathom/wiki/Manual
Package can be downloaded from PyPi or from here:
http://code.google.com/p/fathom/downloads/list
--
Filip Gruszczyński
--
http://mail.python.org/mailman/listinfo/python
Changes by Filip Gruszczyński grusz...@gmail.com:
Removed file: http://bugs.python.org/file21020/1559549_1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1559549
Changes by Filip Gruszczyński grusz...@gmail.com:
Removed file: http://bugs.python.org/file21031/1559549_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1559549
Filip Gruszczyński grusz...@gmail.com added the comment:
Ok, here is a patch created using mq. I have a problem, however. I managed to
solve following situation:
try:
raise ImportError('failed import' module_name='somemodule')
except ImportError as e:
print(e.module_name)
that would
Thanks for the links.
--
Filip Gruszczyński
--
http://mail.python.org/mailman/listinfo/python-list
Filip Gruszczyński grusz...@gmail.com added the comment:
Bump! Hi Eric, there was no negative feedback for two weeks. How about
commiting the patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11371
Filip Gruszczyński grusz...@gmail.com added the comment:
I had some time today, so I managed to fix the patch. I hope now everything is
ok.
--
Added file: http://bugs.python.org/file21209/6584_3.patch
___
Python tracker rep...@bugs.python.org
http
Filip Gruszczyński grusz...@gmail.com added the comment:
I didn't know about this mq extension. I will do a proper patch with a test
after friday.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1559549
Do you know any open source python3 projects that use function
annotations? I would like to see some real use, so maybe I find them
useful to use in my own project.
--
Filip Gruszczyński
--
http://mail.python.org/mailman/listinfo/python-list
Filip Gruszczyński grusz...@gmail.com added the comment:
Bump! How about commiting this patch? Or maybe there is something missing? I'll
be happy to fix it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6584
Filip Gruszczyński grusz...@gmail.com added the comment:
I'll be very happy to fix this after Friday. Thanks for your comments.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6584
Filip Gruszczyński grusz...@gmail.com added the comment:
Here is patch for distutils2. Or maybe you would prefer a patch made by hg
export?
--
Added file: http://bugs.python.org/file21095/disutils2_8933.patch
___
Python tracker rep
Filip Gruszczyński grusz...@gmail.com added the comment:
Bump! How about applying this patch, Eric? Or maybe there is something else,
that needs to be done. If so, I'll be happy to do it.
--
___
Python tracker rep...@bugs.python.org
http
Filip Gruszczyński grusz...@gmail.com added the comment:
Sure :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8933
___
___
Python-bugs-list
Filip Gruszczyński grusz...@gmail.com added the comment:
I am sorry again for those mistakes, it's all completely new to me. I have
fixed those issues and created new patch. Using hg export, that now spans over
two commits. Is it the way those patches should be provided, or should I gather
1 - 100 of 184 matches
Mail list logo
