[issue19102] Add tests for CLI of the tabnanny module

Jaysinh shukla added the comment: @vstinner I have created the PR here. I wasn't sure so linked the PR with this issue. Thanks! PR URL: https://github.com/python/cpython/pull/7699 -- ___ Python tracker

[issue19102] Add tests for CLI of the tabnanny module

Change by Jaysinh shukla : -- pull_requests: +7315 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19102] Add tests for CLI of the tabnanny module

Jaysinh shukla added the comment: @STINNER Victor Thanks for merging. I will try to observe that patch and will update you here. Have a great day -- ___ Python tracker ___

[issue19102] Add tests for CLI of the tabnanny module

STINNER Victor added the comment: New changeset dfa9643d292dcaa14cbf3c44b8330ba2159976c0 by Victor Stinner (Jaysinh Shukla) in branch 'master': bpo-19382: Adding test cases for module tabnanny (GH-851) https://github.com/python/cpython/commit/dfa9643d292dcaa14cbf3c44b8330ba2159976c0

[issue19382] tabnanny unit tests

STINNER Victor added the comment: Thanks Jaysinh Shukla for adding new unit tests to tabnanny, good job! I don't think that it's worth it to backport the new tests to 2.7, 3.6 or 3.7 branch. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue19382] tabnanny unit tests

STINNER Victor added the comment: New changeset dfa9643d292dcaa14cbf3c44b8330ba2159976c0 by Victor Stinner (Jaysinh Shukla) in branch 'master': bpo-19382: Adding test cases for module tabnanny (GH-851) https://github.com/python/cpython/commit/dfa9643d292dcaa14cbf3c44b8330ba2159976c0

[issue19382] tabnanny unit tests

Changes by Jaysinh shukla : -- pull_requests: +751 ___ Python tracker ___ ___

[issue24833] IDLE tabnanny check fails

Changes by Terry J. Reedy : -- assignee: -> terry.reedy resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue24833] IDLE tabnanny check fails

Roundup Robot added the comment: New changeset 724d9b589cfc by Terry Jan Reedy in branch '2.7': Issue #24833: Add attribute reference needed for 3.x, but optional for 2.7, https://hg.python.org/cpython/rev/724d9b589cfc New changeset cce226356477 by Terry Jan Reedy in branch '3.4': Issue #24833:

[issue24833] IDLE tabnanny check fails

Terry J. Reedy added the comment: I fixed the Idle part but would really like to see the cause of the tokenize error. -- type: - behavior versions: +Python 2.7, Python 3.5, Python 3.6 ___ Python tracker rep...@bugs.python.org

[issue24833] IDLE tabnanny check fails

Terry J. Reedy added the comment: I think there are two issues here. 1. tabnanny is run on the editor file every time Check Module Alt-X or Run Module F5 is used. However, Tabnanny is only rum after the file has been compiled as syntactically correct. I don't think that the tokenize module

[issue24833] IDLE tabnanny check fails

New submission from Сергей Лисов: idlelib.ScriptBinding line 72: tokenize.TokenError object is not iterable -- components: IDLE messages: 248314 nosy: Сергей Лисов priority: normal severity: normal status: open title: IDLE tabnanny check fails versions: Python 3.4

[issue19102] Add tests for CLI of the tabnanny module

Al Sweigart added the comment: Since tabnanny is also a module in the standard library (it is imported by the idle code), wouldn't moving it to lib/test/test_tools make it un-importable? This would be a good case for leaving it where it is. -- nosy: +Al.Sweigart

[issue19102] Add tests for CLI of the tabnanny module

Serhiy Storchaka added the comment: Added comments on Rietveld. Although tabnanny is located in the Lib directory, not in the Tools directory, technically it is a script. May be move test_tabnanny.py to Lib/test/test_tools? -- assignee: - berker.peksag nosy: +serhiy.storchaka type

[issue19382] tabnanny unit tests

Ezio Melotti added the comment: I left a few comments on rietveld. -- nosy: +ezio.melotti type: - enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19382 ___

[issue19382] tabnanny unit tests

New submission from Colin Williams: I didn't test the stdout and stderr stuff, but I got the module up to 74% coverage. -- files: tabnanny.patch keywords: patch messages: 201194 nosy: Colin.Williams priority: normal severity: normal status: open title: tabnanny unit tests Added file

[issue19382] tabnanny unit tests

Berker Peksag added the comment: See also issue 19102. -- components: +Tests nosy: +berker.peksag stage: - patch review versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19382

[issue19382] tabnanny unit tests

Colin Williams added the comment: Alright, I'll wait until that one gets committed, and then add in my changes. I think between the two of us we'll get close to 100% -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19382

[issue19102] Add tests for CLI of the tabnanny module

New submission from Berker Peksag: I was trying to use the argparse module instead of getopt and I couldn't find any tests for CLI of the tabnanny module. -- components: Tests files: test_tabnanny.diff keywords: patch messages: 198467 nosy: berker.peksag priority: low severity: normal

[issue16478] Fix division in tabnanny

Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16478 ___ ___ Python-bugs-list mailing list

[issue16478] Fix division in tabnanny

Ezio Melotti added the comment: The patch looks OK, buy can you provide a way to reproduce the error (if you get any)? Should we add tests for tabnanny? I tried to get an error from tabnanny but the only thing I got was a ResourceWarning (that can be easily fixed by a finally: f.close() near

[issue16478] Fix division in tabnanny

Serhiy Storchaka added the comment: The patch looks OK, buy can you provide a way to reproduce the error (if you get any)? No, I have not any. I am even not sure tabnanny works at all. But this bug is obvious. So, let's fix it and go on. Should we add tests for tabnanny

[issue16478] Fix division in tabnanny

Ezio Melotti added the comment: I can't see a ResourceWarning. A finally: f.close() already exists near the end of the check() method. Looks like it was added in 3.3. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16478

[issue16478] Fix division in tabnanny

Roundup Robot added the comment: New changeset fc17fdd42c66 by Ezio Melotti in branch '3.2': #16478: use floor division in tabnanny and fix a ResourceWarning. Patch by Serhiy Storchaka. http://hg.python.org/cpython/rev/fc17fdd42c66 New changeset d7558e4015a4 by Ezio Melotti in branch '3.3

[issue16478] Fix division in tabnanny

Ezio Melotti added the comment: Applied the patch on all 3 branches and fixed the resource warning in 3.2. Thanks for the report and the patch! -- assignee: - ezio.melotti resolution: - fixed stage: patch review - committed/rejected status: open - closed

[issue16478] Fix division in tabnanny

New submission from Serhiy Storchaka: Tabnanny should use floor division in calculation, the comment says about this. But in the current Python 3 code / was not changed to //. -- components: Demos and Tools, Library (Lib) files: tabnanny_div.patch keywords: easy, patch messages: 175622

[issue16478] Fix division in tabnanny

Changes by Antoine Pitrou pit...@free.fr: -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16478 ___ ___ Python-bugs-list

[issue16478] Fix division in tabnanny

Georg Brandl added the comment: Well, sounds reasonable since we're working with an integer number of spaces :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16478 ___

[issue12811] Tabnanny doesn't close its tokenize files properly

New submission from Anthony Briggs anthony.bri...@gmail.com: Unlike Python 2, Python 3 warns when files aren't closed properly, which raises lots of warnings when running tabnanny: ~/devinabox/cpython$ ./python -m tabnanny Lib/ /home/anthony/devinabox/cpython/Lib/tabnanny.py:93

[issue12811] Tabnanny doesn't close its tokenize files properly

Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset c5cb0aa5bed6 by Nick Coghlan in branch 'default': Fix #12811 by closing files promptly in tabnanny.check. Patch by Anthony Briggs. http://hg.python.org/cpython/rev/c5cb0aa5bed6 -- nosy: +python-dev

[issue12811] Tabnanny doesn't close its tokenize files properly

Changes by Nick Coghlan ncogh...@gmail.com: -- nosy: -python-dev resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12811

[issue8774] tabnanny improperly handles non-ascii source files

STINNER Victor victor.stin...@haypocalc.com added the comment: Commited: r81393 (py3k), r81394 (3.1). -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8774

[issue8774] tabnanny improperly handles non-ascii source files

Changes by Dan Buch daniel.b...@gmail.com: -- title: 0xe7 in ``heapq.__about__`` causes badness - tabnanny improperly handles non-ascii source files ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8774

[issue8774] tabnanny improperly handles non-ascii source files

Changes by Dan Buch daniel.b...@gmail.com: Removed file: http://bugs.python.org/file17413/françois-pinard-killed-my-tabnanny.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8774 ___

[issue8774] tabnanny improperly handles non-ascii source files

Dan Buch daniel.b...@gmail.com added the comment: removed patch because the fix should be made to tabnanny itself -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8774

[issue8774] tabnanny improperly handles non-ascii source files

Benjamin Peterson benja...@python.org added the comment: The correct fix is to use tokenize.detect_encoding, if anyone wants to provide a patch. -- nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8774

[issue8774] tabnanny improperly handles non-ascii source files

STINNER Victor victor.stin...@haypocalc.com added the comment: The correct fix is to use tokenize.detect_encoding, if anyone wants to provide a patch. done :-) Attached patch opens the file in binary mode to call tokenize.detect_encoding() and then use the encoding to open the file a second

[issue8774] tabnanny improperly handles non-ascii source files

Benjamin Peterson benja...@python.org added the comment: You should handle the case of encoding being None. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8774 ___

[issue8774] tabnanny improperly handles non-ascii source files

STINNER Victor victor.stin...@haypocalc.com added the comment: You should handle the case of encoding being None. detect_encoding() never returns None for the encoding. If there is no cookie, utf8 is returned by default. -- ___ Python tracker

[issue8774] tabnanny improperly handles non-ascii source files

Benjamin Peterson benja...@python.org added the comment: 2010/5/20 STINNER Victor rep...@bugs.python.org: STINNER Victor victor.stin...@haypocalc.com added the comment: You should handle the case of encoding being None. detect_encoding() never returns None for the encoding. If there is no

[issue1562716] Spurious Tabnanny error

Kurt B. Kaiser added the comment: backported 2.5.2c1 _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1562716 _ ___ Python-bugs-list mailing list Unsubscribe:

Re: Tabnanny errors when Migrating Python 2.4 code to 2.5

the Run menu Run Module menu item or by pressing F5. It immediately fails with a tabnanny error. If I run it from 2.4's IDLE, it works. and I downloaded the 2.5.1 exe/msi file from python.org to install it. What you downloaded doesn't answer the question about how you installed it. Do you still

Tabnanny errors when Migrating Python 2.4 code to 2.5

Hi, When Python 2.5 first came out, I eagerly downloaded it and immediately had issues with getting it to run my 2.4 code. So I just stuck to 2.4. However, I decided this week that I really should try to get 2.5 to work. Does anyone know why code that works perfectly for months in a 2.4

Re: Tabnanny errors when Migrating Python 2.4 code to 2.5

On Jan 5, 3:56 am, [EMAIL PROTECTED] wrote: Hi, When Python 2.5 first came out, I eagerly downloaded it and immediately had issues with getting it to run my 2.4 code. So I just stuck to 2.4. However, I decided this week that I really should try to get 2.5 to work. Does anyone know why code

Re: Tabnanny errors when Migrating Python 2.4 code to 2.5

On Jan 4, 2:06 pm, John Machin [EMAIL PROTECTED] wrote: On Jan 5, 3:56 am, [EMAIL PROTECTED] wrote: Hi, When Python 2.5 first came out, I eagerly downloaded it and immediately had issues with getting it to run my 2.4 code. So I just stuck to 2.4. However, I decided this week that I

Re: Tabnanny errors when Migrating Python 2.4 code to 2.5

On Jan 5, 8:05 am, [EMAIL PROTECTED] wrote: On Jan 4, 2:06 pm, John Machin [EMAIL PROTECTED] wrote: On Jan 5, 3:56 am, [EMAIL PROTECTED] wrote: Hi, When Python 2.5 first came out, I eagerly downloaded it and immediately had issues with getting it to run my 2.4 code. So I just

[ python-Bugs-1562716 ] Spurious Tabnanny error

, including the initial issue submission, for this request, not just the latest update. Category: IDLE Group: Python 2.5 Status: Closed Resolution: Fixed Priority: 5 Submitted By: torhu (torhu) Assigned to: Kurt B. Kaiser (kbk) Summary: Spurious Tabnanny error Initial Comment: IDLE 1.2, Py 2.5

Tabnanny?

Hello, i am very new to this. Only heard of python a week ago and have never posted before anywhere. But I am trying to rewrite a program that I made in C++ in Python, a radixSort I did as a school project. I get a Tabnanny Tokenizing Error that says Token Error: EOF in multi-line

Re: Tabnanny?

in C++ in Python, a radixSort I did as a school project. I get a Tabnanny Tokenizing Error that says Token Error: EOF in multi-line statement. I gather from the internet that it means I have a tab-error. I just can't seem to find it. Is this something you can help me with? Could I post my

RE: Tabnanny?

is happening. See ya ! Em Quarta 08 Junho 2005 23:36, Anna M. escreveu: Hello, i am very new to this. Only heard of python a week ago and have never posted before anywhere. But I am trying to rewrite a program that I made in C++ in Python, a radixSort I did as a school project. I get a Tabnanny

Re: Tabnanny?

Hi Anna !     idx = idxLargest(data, len(data) In this line we have a missing ), for me, this was the problem. Anyway, Check this line too: passes = len(max) + 1 It is giving me an error. See ya ! -- Douglas Soares de Andrade http://douglasandrade.cjb.net - dsa at unilestemg.br

Re: Tabnanny really useful?

On Mon, 20 Dec 2004 13:00:39 -0600, John Roth [EMAIL PROTECTED] wrote: Tabnanny is intended to check whether indentation has mixed tabs and spaces. Files with mixed tabs and spaces _can_ compile just fine if the editor that produced them agrees with the compiler about the number of spaces

Re: Tabnanny really useful?

Franz Steinhaeusler wrote: Thanks for your explanation. I tried an found: def a(): -print -.print where point is a space. tabnanny here complains and python compile it just fine. really? that's a syntax error (you cannot change indentation nillywilly inside a block), and the Python

Re: Tabnanny really useful?

On Tue, 21 Dec 2004 10:24:40 +0100, Fredrik Lundh [EMAIL PROTECTED] wrote: Franz Steinhaeusler wrote: Thanks for your explanation. I tried an found: def a(): -print -.print where point is a space. tabnanny here complains and python compile it just fine. really? that's a syntax error

Re: Tabnanny really useful?

Franz Steinhaeusler wrote: On Tue, 21 Dec 2004 10:24:40 +0100, Fredrik Lundh [EMAIL PROTECTED] wrote: Franz Steinhaeusler wrote: Thanks for your explanation. I tried an found: def a(): -print -.print where point is a space. tabnanny here complains and python compile it just fine. really? that's

Re: Tabnanny really useful?

not equal e.g. at tab size 1 C:\Python23\Libpython -c print repr(open('c:/franz.py').read()) 'def a():\n\tprint\n \tprint\n' C:\Python23\Libc:/franz.py C:\Python23\Lib Well, you've probably answered your own question, then. Do you think tabnanny is a useful piece of code now? Not really

Re: Tabnanny really useful?

\n' indent not equal e.g. at tab size 1 C:\Python23\Libpython -c print repr(open('c:/franz.py').read()) 'def a():\n\tprint\n \tprint\n' C:\Python23\Libc:/franz.py C:\Python23\Lib Well, you've probably answered your own question, then. Do you think tabnanny is a useful piece of code now

Re: Tabnanny really useful?

On Tue, 21 Dec 2004 09:34:47 -0500, Steve Holden [EMAIL PROTECTED] wrote: Hello Steve, I've used drpython, and liked it. thank you, I'm sure, our project Admin will be pleased to hear this :) I think it would be a good way for people to start to use the language, yes, this project is

Re: Tabnanny really useful?

Steve Holden [EMAIL PROTECTED] wrote in message news:[EMAIL PROTECTED] Do you think tabnanny is a useful piece of code now? I used it a lot when I first started using Python, and still run it over code from unknown sources (no pun intended) from time to time. I think it's a lot less useful

Re: Tabnanny really useful?

John Roth wrote: [...] I know what I would like to see in an editor: First, it autodetects whether the module uses tabs consistently, spaces consistently or a mixture. If it uses tabs consistently, it then uses the current default. If it uses spaces consistently, it should also autodetect the

Re: Tabnanny really useful?

On Tue, 21 Dec 2004 09:06:12 -0600, John Roth [EMAIL PROTECTED] wrote: Steve Holden [EMAIL PROTECTED] wrote in message news:[EMAIL PROTECTED] Do you think tabnanny is a useful piece of code now? I used it a lot when I first started using Python, and still run it over code from unknown

Re: Tabnanny really useful?

I'm told Tabnanny was inspired by lint, the Unix utiltity to check C sources (and probably others). Lint was primarily useful in days long ago when CPUs were slow and a compile used a significant amount of resources. In a multiuser environment (we ran an Intel 286 in multiuser mode

Re: Tabnanny really useful?

Yet Another Mike [EMAIL PROTECTED] writes: I'm told Tabnanny was inspired by lint, the Unix utiltity to check C sources (and probably others). Lint was primarily useful in days long ago when CPUs were slow and a compile used a significant amount of resources. In a multiuser environment

Tabnanny really useful?

Hi, I looked at tabnanny to check a python source file. But I didn't find anything, tabnanny is able to find, what couldn't be found by compile command. Or have I missed something? best regards, -- Franz Steinhaeusler -- http://mail.python.org/mailman/listinfo/python-list

Re: Tabnanny really useful?

Franz Steinhaeusler [EMAIL PROTECTED] wrote in message news:[EMAIL PROTECTED] Hi, I looked at tabnanny to check a python source file. But I didn't find anything, tabnanny is able to find, what couldn't be found by compile command. Or have I missed something? Tabnanny is intended to check whether