Dalba added a comment.
Could you be more specific about the lines with false positive?
I tested the first error (line 557 of PS2) and at seems to be indeed longer than 79 characters:
>>> len(u"'bn': lambda v: slh(v, ['জানুয়ারি', 'ফেব্রুয়ারি', 'মার্চ', 'এপ্রিল', 'মে',")
84TASK
Xqt reassigned this task from Xqt to Dalba.
TASK DETAILhttps://phabricator.wikimedia.org/T199615EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, XqtCc: gerritbot, zhuyifei1999, Xqt, Aklapper, matej_suchanek, pywikibot-bugs-list, Tbscho, MayS, Mdupont,
Xqt closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T201969EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, XqtCc: gerritbot, Dvorapa, pywikibot-bugs-list, Pywikibugs, Aklapper, Sc4s2cg, AndyTan, Gaboe420, Zylc, Versusxo,
Xqt closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T200357EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, XqtCc: gerritbot, Dalba, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, Gaboe420, Versusxo, Majesticalreaper22,
matej_suchanek removed a project: Patch-For-Review.matej_suchanek added a comment.
Another problem I can see is that filter_unique (inside GenFact it is self._filter_unique) is used twice: it's provided to RecentChangesPageGenerator (line 821) and also used for dupfiltergen =
gerritbot added a comment.
Change 445854 abandoned by Xqt:
[IMPR] Use hash key for unique filter by default
Reason:
https://gerrit.wikimedia.org/r/#/c/pywikibot/core/ /451824/
https://gerrit.wikimedia.org/r/445854TASK DETAILhttps://phabricator.wikimedia.org/T199615EMAIL
gerritbot added a comment.
Change 451824 merged by jenkins-bot:
[pywikibot/core@master] Use a key for filter_unique where appropriate
https://gerrit.wikimedia.org/r/451824TASK DETAILhttps://phabricator.wikimedia.org/T199615EMAIL
gerritbot added a comment.
Change 452187 merged by jenkins-bot:
[pywikibot/core@master] pywikibot.tools: Add exceptions for first_upper
https://gerrit.wikimedia.org/r/452187TASK DETAILhttps://phabricator.wikimedia.org/T200357EMAIL
gerritbot added a comment.
Change 453338 merged by jenkins-bot:
[pywikibot/core@master] Fix usages of site.namespaces.NAMESPACE_NAME
https://gerrit.wikimedia.org/r/453338TASK DETAILhttps://phabricator.wikimedia.org/T201969EMAIL
Xqt triaged this task as "Low" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T202189EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Aklapper, Dalba, Xqt, pywikibot-bugs-list, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb,
Xqt created this task.Xqt added projects: Pywikibot-core, Pywikibot-tests.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONdiff-checker.py wrongly counts bytes not unicode length, see
zhuyifei1999 added a comment.
In T202117#4510925, @Xqt wrote:
svn repository is still supported by pwb which is cloned from our git repository. I use svn for my production not because the automerge function of svn is a great advantage against git.
Wasn't aware of that, thanks.TASK
Dvorapa closed this task as "Declined".Dvorapa added a comment.
In T113450#4511149, @JAnD wrote:
In T113450#4504748, @Billinghurst wrote:
In T113450#4502922, @JAnD wrote:
Bot still does not by default marks as botedit
pwb.py touch -family:wikisource -start:Page:!
13 matches
Mail list logo