gerritbot added a comment.
Change 305664 merged by jenkins-bot:
Add support for BotPasswords
https://gerrit.wikimedia.org/r/305664TASK DETAILhttps://phabricator.wikimedia.org/T124466EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot,
gerritbot added a comment.
Change 305664 had a related patch set uploaded (by Merlijn van Deen):
Add support for BotPasswords
https://gerrit.wikimedia.org/r/305664TASK DETAILhttps://phabricator.wikimedia.org/T124466EMAIL
valhallasw added a comment.
I think your patch makes a lot of sense. The current situation already is a bit of a mess (because everything is split through three classes without a clear separation of concerns).
On the one hand having self.login_name feels like storing that information in the wrong
