[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2019-05-22 Thread Lokal_Profil
Lokal_Profil added a comment. I spotted that this task is still mentioned in `proofreadpage.purge()`. Is that method still needed since this is resolved? TASK DETAIL https://phabricator.wikimedia.org/T128994 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2018-02-02 Thread Mpaa
Mpaa added a comment. Only a workaround has been implemented. It is good enough IMO to close the bug, even if the philosophical question of what is 'purge' still remains TASK DETAILhttps://phabricator.wikimedia.org/T128994EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2018-02-01 Thread Framawiki
Framawiki added a comment. Is this task solved ?TASK DETAILhttps://phabricator.wikimedia.org/T128994EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: Framawiki, gerritbot, GOIII, Ineuw, AbdealiJK, pywikibot-bugs-list, Mpaa, Aklapper, jayvdb, Magul,

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-04-21 Thread gerritbot
gerritbot added a comment. Change 284754 merged by jenkins-bot: proofreadpage.py: workaround to allow purging without write rights https://gerrit.wikimedia.org/r/284754 TASK DETAIL https://phabricator.wikimedia.org/T128994 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-20 Thread Mpaa
Mpaa added a comment. Is it an option to remove: @must_be(group='user') from site.def purgepages(self, pages, **kwargs) and not consider "purge" as an action which sets self.write = True in api.Request()? Can it do any harm? I could do: curl --request POST

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread jayvdb
jayvdb added a comment. In https://phabricator.wikimedia.org/T128994#2092569, @Mpaa wrote: > It was failing on my PC. I cleared ~/python/core/tests/apicache-py2 and now it is OK. > Is this cache also cleared? Each travis job start with a cold cache. the proofread page tests

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread Mpaa
Mpaa added a comment. It was failing on my PC. I cleared ~/python/core/tests/apicache-py2. Is this cache also cleared? TASK DETAIL https://phabricator.wikimedia.org/T128994 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc:

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread jayvdb
jayvdb added a comment. The travis builds work with a clean cache for each job, so I doubt the caching is the only problem here. TASK DETAIL https://phabricator.wikimedia.org/T128994 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc:

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread Mpaa
Mpaa added a comment. In https://phabricator.wikimedia.org/T128994#2092448, @jayvdb wrote: > In https://phabricator.wikimedia.org/T128994#2092324, @Mpaa wrote: > > > I think it is already like that -> if not self._soup.find_all('a', attrs=attrs): > > > Yes, I see that. Hmm.

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread jayvdb
jayvdb added a comment. In https://phabricator.wikimedia.org/T128994#2092324, @Mpaa wrote: > I think it is already like that -> if not self._soup.find_all('a', attrs=attrs): Yes, I see that. Hmm. Then the test suite is regularly purging the page, and these attributes, etc are

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread Mpaa
Mpaa added a comment. Is it harmful just set write = True for those test classes? TASK DETAIL https://phabricator.wikimedia.org/T128994 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: pywikibot-bugs-list, Mpaa, Aklapper, jayvdb

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread Mpaa
Mpaa added a comment. I think it is already like that -> if not self._soup.find_all('a', attrs=attrs): TASK DETAIL https://phabricator.wikimedia.org/T128994 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: pywikibot-bugs-list, Mpaa,

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread jayvdb
jayvdb added a comment. Can we detect when the expected class attributes/etc are missing, and only purge when they are missing? (or is the code already doing that?) TASK DETAIL https://phabricator.wikimedia.org/T128994 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread Mpaa
Mpaa added a comment. IIRC, the reason for purging is this: https://phabricator.wikimedia.org/T114318 TASK DETAIL https://phabricator.wikimedia.org/T128994 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: pywikibot-bugs-list, Mpaa,