[Pywikipedia-bugs] [Maniphest] [Commented On] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

gerritbot added a comment. Change 276535 merged by jenkins-bot: Reimplement imageuncat's -recentchanges as a pagegenerators CLA https://gerrit.wikimedia.org/r/276535 TASK DETAIL https://phabricator.wikimedia.org/T129193 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

darthbhyrava added a comment. > However, RecentChangesPageGenerator is requesting many other props which are unnecessary as they are not used. RecentChangesPageGenerator` only uses title and type -- everything else is discarded. So there is a performance improvement which can be made to

[Pywikipedia-bugs] [Maniphest] [Commented On] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

darthbhyrava added a comment. I'm trying to understand the difference between `@deprecated` and `@deprecated()` decorators, as defined in `tools`, and I didn't quite understand what 'callable' in the description of `@deprecated()` meant: # The latter is invoked with the decorator

[Pywikipedia-bugs] [Maniphest] [Commented On] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

darthbhyrava added a comment. gen = (pywikibot.Page(site, x['title']) for x in gen if x['type'] != 'log' or 'title' in x) So, since we don't want to re-implement the non-titled entries bug in imageuncat, that's the issue resolved here. gen.request['rcprop'] =

[Pywikipedia-bugs] [Maniphest] [Commented On] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

darthbhyrava added a comment. That was certainly very instructive. Thanks. :D Looking up APISite.recentchanges , I can see the code you speak of mentioning rcprop in recentchanges: rcgen =

[Pywikipedia-bugs] [Maniphest] [Commented On] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

darthbhyrava added a comment. In https://phabricator.wikimedia.org/T129193#2120073, @Mpaa wrote: > I think that p['ns'] should not be an issue. > > Actually I do not understand why the docstring in RecentChangesPageGenerator says: > > @param changetype: only iterate changes of

[Pywikipedia-bugs] [Maniphest] [Commented On] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

Mpaa added a comment. I think that p['ns'] should not be an issue. Actually I do not understand why the docstring in RecentChangesPageGenerator says: @param changetype: only iterate changes of this type ("edit" for edits to existing pages, "new" for new pages, "log"

[Pywikipedia-bugs] [Maniphest] [Commented On] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

darthbhyrava added a comment. In https://phabricator.wikimedia.org/T129193#2115970, @Mpaa wrote: > Yes, or set the reverse parameter accordingly. Setting reverse to `True` seems more appropriate. I'll do that. Thanks! TASK DETAIL https://phabricator.wikimedia.org/T129193

[Pywikipedia-bugs] [Maniphest] [Commented On] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

Mpaa added a comment. Yes, or set the reverse parameter accordingly. TASK DETAIL https://phabricator.wikimedia.org/T129193 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava, Mpaa Cc: Mpaa, gerritbot, darthbhyrava, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Commented On] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

darthbhyrava added a comment. I've added a patch, but am not sure about the tests. Could someone please take a look? TASK DETAIL https://phabricator.wikimedia.org/T129193 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava Cc:

[Pywikipedia-bugs] [Maniphest] [Commented On] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

gerritbot added a comment. Change 276535 had a related patch set uploaded (by Darthbhyrava): Change: Reimplement imageuncat's -recentchanges as a pagegenerators CL arg https://gerrit.wikimedia.org/r/276535 TASK DETAIL https://phabricator.wikimedia.org/T129193 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

jayvdb added a comment. Improving the existing pagegenerators `-recentchanges` seems the best approach TASK DETAIL https://phabricator.wikimedia.org/T129193 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava, jayvdb Cc: darthbhyrava,

[Pywikipedia-bugs] [Maniphest] [Commented On] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

darthbhyrava added a comment. In https://phabricator.wikimedia.org/T129193#2105538, @jayvdb wrote: > This task is about improving pagegenerators' `-recentchanges` . Please see https://phabricator.wikimedia.org/T67192 and the code used to fix it. I //did// go through that task

[Pywikipedia-bugs] [Maniphest] [Commented On] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

jayvdb added a comment. This task is about improving pagegenerators' -recentchanges . Please see https://phabricator.wikimedia.org/T67192 and the code used to fix it. TASK DETAIL https://phabricator.wikimedia.org/T129193 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

darthbhyrava added a comment. Or I could modify the existing -recentchanges in different ways: - Accept `-recentchanges:x-y` or `-recentchanges-timespan:x-y` such that x is the delay, and y is the block, and both are positive (need to think of error messages if they aren't positive )

[Pywikipedia-bugs] [Maniphest] [Commented On] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

darthbhyrava added a comment. @jayvdb There is already an existing -recentchanges:x command line argument in pagegenerators, which returns the x most recently changed pages (if x not mentioned, then x=60), while the function of -recentchanges in imageuncat is to return pages changed