gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T124466EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lokal_Profil, jayvdb, Liuxinyu970226, Alkamid, Aklapper, StudiesWorld, valhallasw,
gerritbot added a comment.
Change 305664 had a related patch set uploaded (by Merlijn van Deen):
Add support for BotPasswords
https://gerrit.wikimedia.org/r/305664TASK DETAILhttps://phabricator.wikimedia.org/T124466EMAIL
valhallasw added a comment.
I think your patch makes a lot of sense. The current situation already is a bit of a mess (because everything is split through three classes without a clear separation of concerns).
On the one hand having self.login_name feels like storing that information in the wrong
valhallasw added a subscriber: gerritbot.valhallasw added a comment.
This is probably a better place to discuss, so moving the comments from there to here:
In T143417#2567675, @valhallasw wrote:
I think the main thing is to separate the user name and the login name, and thus separating the
Lokal_Profil added a comment.
Is this still open or did the patch fix it?
If still open could it be merged with T108848?TASK DETAILhttps://phabricator.wikimedia.org/T102477EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Lokal_Profil, revi,
Lokal_Profil added a comment.
Duplicate of T143417 (or can that be considered a subtask)?TASK DETAILhttps://phabricator.wikimedia.org/T124466EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Lokal_Profil, jayvdb, Liuxinyu970226, Alkamid,
Lokal_Profil added a project: Pywikibot-login.py.
TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, Aklapper, Zppix, Lokal_Profil, pywikibot-bugs-list, Lewizho99, Mdupont, JJMC89,
Lokal_Profil added a comment.
If we go for this solution we should not forget to #pywikibot-announce it afterwards.TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, valhallasw,
Lokal_Profil added a comment.
If we go for this solution we should not forget to #pywikibot-announce it afterwards since there are rare situations where the fix (despite backwards compatibility) might break existing set-ups.TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Zppix, Lokal_Profil, pywikibot-bugs-list, Lewizho99, Mdupont, JJMC89, Maathavan,
gerritbot added a comment.
Change 305665 had a related patch set uploaded (by Lokal Profil):
Make password_file respect -dir flag
https://gerrit.wikimedia.org/r/305665TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_Profil, gerritbotCc: gerritbot, valhallasw, Aklapper, Lokal_Profil, pywikibot-bugs-list, Lewizho99, Mdupont,
gerritbot added a comment.
Change 305664 had a related patch set uploaded (by Lokal Profil):
Add support for BotPasswords
https://gerrit.wikimedia.org/r/305664TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Lokal_Profil claimed this task.Lokal_Profil added a comment.
Might have a first attemptTASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: valhallasw, Aklapper, Lokal_Profil, pywikibot-bugs-list,
Lokal_Profil added a comment.
In T143417#2567675, @valhallasw wrote:
I think the main thing is to separate the user name and the login name, and thus separating the username from the suffix. I'm inclined to say that the '@suffix' API wasn't a great design -- the suffix should have been part of
Lokal_Profil added a comment.
In T143417#2567648, @Lokal_Profil wrote:
In T143417#2567601, @Lokal_Profil wrote:
My guess is that this needs to be fixed over in pywikibot/tools/__init__.py:DeprecatedRegex.normalize_username() in order to be handled correctly everywhere (several other functions
Lokal_Profil added a parent task: T139492: Switch Erfgoedbot over to BotPassword or OAuth.
TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: valhallasw, Aklapper, Lokal_Profil,
valhallasw added a comment.
I think the main thing is to separate the user name and the login name. I'm inclined to say that the '@suffix' API wasn't a great design -- the suffix should have been part of the password rather than the user name.
As far as pywikibot is concerned, I would actually
Lokal_Profil triaged this task as "High" priority.Lokal_Profil added a comment.
per T142623TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Lokal_Profil, pywikibot-bugs-list,
Lokal_Profil added a comment.
In T143417#2567601, @Lokal_Profil wrote:
My guess is that this needs to be fixed over in pywikibot/tools/__init__.py:DeprecatedRegex.normalize_username() in order to be handled correctly everywhere (several other functions make the same assumption).
But
Lokal_Profil edited the task description. (Show Details)
EDIT DETAILS...Unfortunately this does not handle usernames from BotPasswords (i.e. `@`, `@`)which I will call login_name to avoid confusion).TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL
Lokal_Profil removed Lokal_Profil as the assignee of this task.Lokal_Profil added a comment.
My guess is that this needs to be fixed over in pywikibot/tools/__init__.py:DeprecatedRegex.normalize_username() in order to be handled correctly everywhere (several other functions make the same
Lokal_Profil created this task.Lokal_Profil added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONWhenever (edit) tokens are checked there is also also an assert self.site.user() to ensure that the user is (still) logged-in.
Unfortunately this
23 matches
Mail list logo
