[Pywikipedia-bugs] [Maniphest] [Created] T113212: qualifier misidentified in fromJSON()

2015-09-21 Thread Lokal_Profil
Lokal_Profil created this task. Lokal_Profil added a subscriber: Lokal_Profil. Lokal_Profil added a project: pywikibot-core. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION Currently qualifiers are misidentified as references when `fromJSON()` is called on the parent

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T85385: Implement "Monolingual text" in Pywikibot

2015-09-21 Thread Lokal_Profil
Lokal_Profil added a subscriber: Lokal_Profil. TASK DETAIL https://phabricator.wikimedia.org/T85385 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: Lokal_Profil, gerritbot, Smalyshev, Ricordisamoa, jayvdb, Aklapper, pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-09-22 Thread Lokal_Profil
Lokal_Profil added a comment. In https://phabricator.wikimedia.org/T113212#1661682, @jayvdb wrote: > Interesting; `toJSON` contains `qualifier.isQualifier = True` and > `source.isReference = True`. Those should be asserts! Should we patch this as well before resolving this task? Al

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-09-21 Thread Lokal_Profil
Lokal_Profil added a comment. To clarify. The source of the above error is an false assumption that qualifiers don't have a hash property. TASK DETAIL https://phabricator.wikimedia.org/T113212 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Pywikipedia-bugs] [Maniphest] [Commented On] T120222: Error installing pywikibot on Windows 10 (No handlers could be found for logger "pywiki")

2015-12-08 Thread Lokal_Profil
Lokal_Profil added a comment. Just got confirmed that at least one of the users used git to get the latest version of core. So whilst my problem is solved (point them to 2.0rc3) there is definitely something going on with master on windows (possibly not only 10). TASK DETAIL https

[Pywikipedia-bugs] [Maniphest] [Commented On] T120222: Error installing pywikibot on Windows 10 (No handlers could be found for logger "pywiki")

2015-12-08 Thread Lokal_Profil
Lokal_Profil added a comment. Thanks. I tried a bit more and after a re-boot the above error disappears (but a lot of others appear instead). I removed the pywikibot directory, downloaded 2.0rc3, unpacked, ran `python setup.py install` and now it works. Since I didn't do the initial two

[Pywikipedia-bugs] [Maniphest] [Edited] T120651: pywikibot test_set_redirect_target fails

2015-12-09 Thread Lokal_Profil
Lokal_Profil edited the task description. Lokal_Profil set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T120651 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: jayvdb, Aklapper, Ladsgroup, StudiesWorld

[Pywikipedia-bugs] [Maniphest] [Commented On] T120651: pywikibot test_set_redirect_target fails

2015-12-09 Thread Lokal_Profil
Lokal_Profil added a comment. I added the output to the description TASK DETAIL https://phabricator.wikimedia.org/T120651 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: jayvdb, Aklapper, Ladsgroup, StudiesWorld, Lokal_Profil

[Pywikipedia-bugs] [Maniphest] [Created] T120222: Error installing pywikibot on Windows 10 (No handlers could be found for logger "pywiki")

2015-12-03 Thread Lokal_Profil
Lokal_Profil created this task. Lokal_Profil added subscribers: Lokal_Profil, WereSpielChequers. Lokal_Profil added a project: pywikibot-core. Herald added subscribers: pywikibot-bugs-list, StudiesWorld, Aklapper. TASK DESCRIPTION Last weekend we tried installing pywikibot on a few windows

[Pywikipedia-bugs] [Maniphest] [Created] T120651: pywikibot test_set_redirect_target fails

2015-12-07 Thread Lokal_Profil
Lokal_Profil created this task. Lokal_Profil added subscribers: Lokal_Profil, Ladsgroup. Lokal_Profil added projects: Pywikibot-tests, pywikibot-core. Herald added subscribers: pywikibot-bugs-list, StudiesWorld, Aklapper. TASK DESCRIPTION I just noticed that running `test_set_redirect_target

[Pywikipedia-bugs] [Maniphest] [Commented On] T119963: Add mechanism for removing a qualifier

2015-12-07 Thread Lokal_Profil
Lokal_Profil added a comment. I've now added a test to this as well TASK DETAIL https://phabricator.wikimedia.org/T119963 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: gerritbot, Aklapper, StudiesWorld, Lokal_Profil, pywikibot

[Pywikipedia-bugs] [Maniphest] [Closed] T119963: Add mechanism for removing a qualifier

2015-12-17 Thread Lokal_Profil
Lokal_Profil closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T119963 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: gerritbot, Aklapper, StudiesWorld, Lokal_Profil, pywikibot

[Pywikipedia-bugs] [Maniphest] [Commented On] T119963: Add mechanism for removing a qualifier

2015-12-01 Thread Lokal_Profil
Lokal_Profil added a comment. If needed I could try my hand at adding a test for the method as well. Since I haven't done tests before though it is likely to require some coaching. TASK DETAIL https://phabricator.wikimedia.org/T119963 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Updated] T123882: Implement Identifier datatype in pywikibot

2016-01-17 Thread Lokal_Profil
Lokal_Profil added a comment. Disregarding the https://phabricator.wikimedia.org/T115679 issue. Is there anything that needs to be changed other than extending `Property` (in `page.py`) with two new mappings in `types` and `value_types`? TASK DETAIL https://phabricator.wikimedia.org/T123882

[Pywikipedia-bugs] [Maniphest] [Created] T123882: Implement Identifier datatype in pywikibot

2016-01-17 Thread Lokal_Profil
Lokal_Profil created this task. Lokal_Profil added a subscriber: Lokal_Profil. Lokal_Profil added projects: pywikibot-core, Pywikibot-Wikidata. Herald added subscribers: pywikibot-bugs-list, StudiesWorld, Aklapper. TASK DESCRIPTION In preparation for the new [[ https://lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T115679: Handle property datatype changing gracefully

2016-01-17 Thread Lokal_Profil
Lokal_Profil added a subscriber: Lokal_Profil. TASK DETAIL https://phabricator.wikimedia.org/T115679 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: Lokal_Profil, thiemowmde, daniel, XZise, Ricordisamoa, hoo, Lydia_Pintscher

[Pywikipedia-bugs] [Maniphest] [Created] T123888: Incorrect default month and day for WbTime

2016-01-17 Thread Lokal_Profil
Lokal_Profil created this task. Lokal_Profil added a subscriber: Lokal_Profil. Lokal_Profil added projects: pywikibot-core, Pywikibot-Wikidata. Herald added subscribers: pywikibot-bugs-list, StudiesWorld, Aklapper. TASK DESCRIPTION Per the definition in [[ https://www.mediawiki.org/wiki

[Pywikipedia-bugs] [Maniphest] [Created] T123883: Make Claim.target_equals take precision into account

2016-01-17 Thread Lokal_Profil
Lokal_Profil created this task. Lokal_Profil added a subscriber: Lokal_Profil. Lokal_Profil added projects: pywikibot-core, Pywikibot-Wikidata. Herald added subscribers: pywikibot-bugs-list, StudiesWorld, Aklapper. TASK DESCRIPTION The fact that `Claim.target_equals()` does `WbTime` comparison

[Pywikipedia-bugs] [Maniphest] [Commented On] T123856: Add tests for Wikibase Monolingual text

2016-01-17 Thread Lokal_Profil
Lokal_Profil added a comment. I can take this one. What I thought of so far was: - basic creation from a string - creation from a unicode string - equality - `fromWikibase`-`toWikibase` roundtrip I would also add raising errors if either parameter is an empty string or not a `basestring

[Pywikipedia-bugs] [Maniphest] [Updated] T123856: Add tests for Wikibase Monolingual text

2016-01-19 Thread Lokal_Profil
Lokal_Profil removed a project: Patch-For-Review. Lokal_Profil set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T123856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: Lydia_Pintscher, Liuxinyu970226, Multichill

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T106121: RFC removing old code / code cleanup

2016-02-10 Thread Lokal_Profil
Lokal_Profil added a subscriber: Lokal_Profil. Herald added a subscriber: StudiesWorld. TASK DETAIL https://phabricator.wikimedia.org/T106121 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: Lokal_Profil, StudiesWorld, Multichill

[Pywikipedia-bugs] [Maniphest] [Commented On] T124139: Claim new method has_qualifier

2016-02-10 Thread Lokal_Profil
Lokal_Profil added a subscriber: Lokal_Profil. Lokal_Profil added a comment. It is a bit unclear whar the criteria for a match would be since a source is essentially a lat of Claims. Options are: 1. All provided Claims need to be present in the source. 2. All provided Claims need to be present

[Pywikipedia-bugs] [Maniphest] [Commented On] T123882: Implement Identifier datatype in pywikibot

2016-02-04 Thread Lokal_Profil
Lokal_Profil added a comment. So in addition to the two places I identified above `Claim._formatValue`. I'll put together a patch (since I'm doing one for `math` anyway) but we might not want to merge it yet. In https://phabricator.wikimedia.org/T123882#1992867, @JAnD wrote: > Bot sho

[Pywikipedia-bugs] [Maniphest] [Closed] T127205: Get login token from action=query=tokens

2016-02-29 Thread Lokal_Profil
Lokal_Profil closed this task as "Resolved". Lokal_Profil claimed this task. Lokal_Profil removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T127205 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal

[Pywikipedia-bugs] [Maniphest] [Unblock] T85385: Implement "Monolingual text" in Pywikibot

2016-01-19 Thread Lokal_Profil
Lokal_Profil closed blocking task T123856: Add tests for Wikibase Monolingual text as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T85385 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev, Lokal_Profil Cc: Lo

[Pywikipedia-bugs] [Maniphest] [Updated] T123856: Add tests for Wikibase Monolingual text

2016-01-19 Thread Lokal_Profil
Lokal_Profil removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T123856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: Lydia_Pintscher, Liuxinyu970226, Multichill, Aklapper, jayvdb, Ricordisamoa

[Pywikipedia-bugs] [Maniphest] [Closed] T123856: Add tests for Wikibase Monolingual text

2016-01-19 Thread Lokal_Profil
Lokal_Profil closed this task as "Resolved". Lokal_Profil claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T123856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: Lydia_Pintscher, Liuxinyu970226, Multichill

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T118012: Feature request: allow login with OAuth, getting tokens at runtime

2016-02-17 Thread Lokal_Profil
Lokal_Profil added a subscriber: Lokal_Profil. TASK DETAIL https://phabricator.wikimedia.org/T118012 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: Lokal_Profil, jayvdb, Aklapper, StudiesWorld, pywikibot-bugs-list, Mpaa

[Pywikipedia-bugs] [Maniphest] [Commented On] T127205: Get login token from action=query=tokens

2016-02-18 Thread Lokal_Profil
Lokal_Profil added a comment. My fix should use the new token call for mediaWiki >= 1.27, otherwise business as usual TASK DETAIL https://phabricator.wikimedia.org/T127205 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil

[Pywikipedia-bugs] [Maniphest] [Commented On] T128992: site detection failures

2016-03-09 Thread Lokal_Profil
Lokal_Profil added a comment. I think http://botwiki.sno.cc/wiki/$1 might also be causing problems. Looks like the domain has expired. TASK DETAIL https://phabricator.wikimedia.org/T128992 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Pywikipedia-bugs] [Maniphest] [Commented On] T128987: testQueriesDirectFromClaim fails with TypeError: Cannot construct a query from a claim of type external-id

2016-03-09 Thread Lokal_Profil
Lokal_Profil added a comment. Thanks @Ricordisamoa. Hadn't noticed that basestring got defined differently depending on python version TASK DETAIL https://phabricator.wikimedia.org/T128987 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Pywikipedia-bugs] [Maniphest] [Updated] T128988: TestWiktionaryGraph.test_octagon failing

2016-03-09 Thread Lokal_Profil
Lokal_Profil removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T128988 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: Lokal_Profil, gerritbot, Aklapper, jayvdb, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Closed] T128988: TestWiktionaryGraph.test_octagon failing

2016-03-09 Thread Lokal_Profil
Lokal_Profil closed this task as "Resolved". Lokal_Profil claimed this task. Lokal_Profil added a comment. 15 out of the 20 builds <https://travis-ci.org/wikimedia/pywikibot-core/builds/114880004> now completes successfully . The remaining fails/crashes are

[Pywikipedia-bugs] [Maniphest] [Updated] T128987: testQueriesDirectFromClaim fails with TypeError: Cannot construct a query from a claim of type external-id

2016-03-09 Thread Lokal_Profil
Lokal_Profil added a comment. In https://phabricator.wikimedia.org/T128987#2102815, @Xqt wrote: > Looks like the bug is still there. Travis reports it, e.g. https://travis-ci.org/wikimedia/pywikibot-core/jobs/114767216 That is really weird. Running the same test loca

[Pywikipedia-bugs] [Maniphest] [Commented On] T128987: testQueriesDirectFromClaim fails with TypeError: Cannot construct a query from a claim of type external-id

2016-03-09 Thread Lokal_Profil
Lokal_Profil added a comment. This is likely a result of `P268` being changed from string to external-id. Changing to `P225` fixes the error. However the fact that it is failing indicative of a problem with `wikidataquery.fromClaim()` being too picky in what it allows as STRING claims

[Pywikipedia-bugs] [Maniphest] [Updated] T85385: Implement "Monolingual text" in Pywikibot

2016-03-11 Thread Lokal_Profil
Lokal_Profil removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T85385 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev, Lokal_Profil Cc: Lokal_Profil, Smalyshev, Ricordisamoa, jayvdb, Aklapper, pywikibot

[Pywikipedia-bugs] [Maniphest] [Commented On] T128987: testQueriesDirectFromClaim fails with TypeError: Cannot construct a query from a claim of type external-id

2016-03-09 Thread Lokal_Profil
Lokal_Profil added a comment. There is something subtle going on here: >>> Claim.types.get(claim.type) >>> basestring >>> isinstance(Claim.types.get(claim.type), basestring) False How about I just admit defeat and go for the tu

[Pywikipedia-bugs] [Maniphest] [Updated] T128318: No handlers could be found for logger "pywiki"

2016-03-07 Thread Lokal_Profil
Lokal_Profil added a comment. Is this the same as https://phabricator.wikimedia.org/T113822 ? TASK DETAIL https://phabricator.wikimedia.org/T128318 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: Lokal_Profil, Aklapper

[Pywikipedia-bugs] [Maniphest] [Updated] T131624: add WbTime.today() to pywikibot

2016-04-03 Thread Lokal_Profil
Lokal_Profil added a comment. Any time a statement is sourced/referenced using a web page accessed during the run (i.e. https://phabricator.wikimedia.org/P813). I.e. essentially any bot which adds references. TASK DETAIL https://phabricator.wikimedia.org/T131624 EMAIL PREFERENCES https

[Pywikipedia-bugs] [Maniphest] [Commented On] T131624: add WbTime.today() to pywikibot

2016-04-03 Thread Lokal_Profil
Lokal_Profil added a comment. True if we introduce a `fromTimestamp()` to `__-init.py__.WbTime` which goes from (possibly both ways) `pywikibot.Timestamp` to `WbTime` then: `today = pywikibot.WbTime.fromTimestamp(pywikibot.Timestamp.today())` should do it. techically this can

[Pywikipedia-bugs] [Maniphest] [Updated] T131453: Implement non-strict __cmp__ for WbTime

2016-04-01 Thread Lokal_Profil
Lokal_Profil added a blocked task: T123888: Incorrect default month and day for WbTime. TASK DETAIL https://phabricator.wikimedia.org/T131453 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: Aklapper, pywikibot-bugs-list, Multichill

[Pywikipedia-bugs] [Maniphest] [Updated] T123888: Incorrect default month and day for WbTime

2016-04-01 Thread Lokal_Profil
Lokal_Profil added a blocking task: T131453: Implement non-strict __cmp__ for WbTime. TASK DETAIL https://phabricator.wikimedia.org/T123888 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: Aklapper, StudiesWorld, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Created] T131453: Implement non-strict __cmp__ for WbTime

2016-04-01 Thread Lokal_Profil
Lokal_Profil created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION The `__eq__` of WbRepresentation does not handle precision based comparisons or the fact that dates can be represented in multiple ways (https://phabricator.wikimedia.org/T107870

[Pywikipedia-bugs] [Maniphest] [Created] T131619: add __repr__ to Claim in pywikibot

2016-04-02 Thread Lokal_Profil
Lokal_Profil created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION //Will fill this out better later// Should be something like: # extend pywikibot.Claim with a __repr__ method def new_repr(self): return

[Pywikipedia-bugs] [Maniphest] [Created] T131624: add WbTime.today() to pywikibot

2016-04-02 Thread Lokal_Profil
Lokal_Profil created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION Method for turning todays date into a WbTime. This is used whenever setting fetch dates etc. for references. Something like: def today_as_WbTime(): """

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T123888: Incorrect default month and day for WbTime

2016-04-02 Thread Lokal_Profil
Lokal_Profil added a subscriber: Multichill. Lokal_Profil edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T123888 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: Multichill, Aklapper, StudiesWorld

[Pywikipedia-bugs] [Maniphest] [Commented On] T131624: add WbTime.today() to pywikibot

2016-04-02 Thread Lokal_Profil
Lokal_Profil added a comment. Alternatively instead of sticking this in `__-init.py__.WbTime` it could go inte some helper class... if someone can recommedn a good place. TASK DETAIL https://phabricator.wikimedia.org/T131624 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Pywikipedia-bugs] [Maniphest] [Created] T142623: Login does not work with BotPasswords when password is not pre-provided

2016-08-10 Thread Lokal_Profil
Lokal_Profil created this task.Lokal_Profil added projects: Pywikibot-core, Pywikibot-login.py.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONBotPasswords require you to log in with usernames like COHBot@GAR. When a password is pre-provided pywikibot handles this fine

[Pywikipedia-bugs] [Maniphest] [Commented On] T142623: Login does not work with BotPasswords when password is not pre-provided

2016-08-10 Thread Lokal_Profil
Lokal_Profil added a comment. I'll put together a patch for this.TASK DETAILhttps://phabricator.wikimedia.org/T142623EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89

[Pywikipedia-bugs] [Maniphest] [Edited] T142623: Login does not work with BotPasswords when password is not pre-provided

2016-08-10 Thread Lokal_Profil
Lokal_Profil edited the task description. (Show Details) EDIT DETAILS[[ https://www.mediawiki.org/wiki/Manual:Bot_passwords | BotPasswords ]] require you to log in with usernames like COHBot@GARTASK DETAILhttps://phabricator.wikimedia.org/T142623EMAIL PREFERENCEShttps

[Pywikipedia-bugs] [Maniphest] [Created] T140516: Add beta commons as family

2016-07-15 Thread Lokal_Profil
Lokal_Profil created this task.Lokal_Profil added projects: Pywikibot-core, Pywikibot-Commons.Herald added subscribers: pywikibot-bugs-list, Zppix, Avicennasis, Steinsplitter, Aklapper. TASK DESCRIPTIONThere is currently no test instance for Commons available through pywikibot making testing

[Pywikipedia-bugs] [Maniphest] [Created] T139749: password_file in user-config does not respect -dir flag

2016-07-08 Thread Lokal_Profil
Lokal_Profil created this task.Lokal_Profil added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Zppix, Aklapper. TASK DESCRIPTIONWhen running a script with the flag -dir: it correctly finds the user-config.py file in that directory. If you have specified password_file

[Pywikipedia-bugs] [Maniphest] [Commented On] T139749: password_file in user-config does not respect -dir flag

2016-07-08 Thread Lokal_Profil
Lokal_Profil added a comment. A quick and dirty solution would be to have readPassword() do a os.cwd to config.base_dir before trying to open the file and then os.cwd back before exiting.TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings

[Pywikipedia-bugs] [Maniphest] [Commented On] T142155: Bot can't login. keyError in GetCookie

2016-08-05 Thread Lokal_Profil
Lokal_Profil added a comment. @Multichill: Does using Special:BotPasswords solve the problem for you?TASK DETAILhttps://phabricator.wikimedia.org/T142155EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Lokal_Profil, Tgr, Udo_T, Legoktm, JJMC89

[Pywikipedia-bugs] [Maniphest] [Commented On] T140516: Add beta commons as family

2016-08-08 Thread Lokal_Profil
Lokal_Profil added a comment. In T140516#2533117, @Stan3 wrote: {F4345244}These are the changes I've needed to work with beta commons. That diff doesn't look like it's built on top of commons_family.py in the master branch. Are there more patches in-between?TASK DETAILhttps

[Pywikipedia-bugs] [Maniphest] [Updated] T131619: add __repr__ to Claim in pywikibot

2016-08-09 Thread Lokal_Profil
Lokal_Profil removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T131619EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb

[Pywikipedia-bugs] [Maniphest] [Triaged] T131619: add __repr__ to Claim in pywikibot

2016-08-09 Thread Lokal_Profil
Lokal_Profil triaged this task as "Lowest" priority. TASK DETAILhttps://phabricator.wikimedia.org/T131619EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC

[Pywikipedia-bugs] [Maniphest] [Commented On] T131624: add WbTime.today() to pywikibot

2016-08-09 Thread Lokal_Profil
Lokal_Profil added a comment. Found the open patchset related to this. There is still a need for it and the patch should still be mergeable (I just rebased it). If someone would be willing to review or argue for why it isn't needed.TASK DETAILhttps://phabricator.wikimedia.org/T131624EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity

2017-01-29 Thread Lokal_Profil
Lokal_Profil added a comment. In T143594#2980621, @gerritbot wrote: Change 334908 had a related patch set uploaded (by Lokal Profil): Support adding units to WbQuantity through ItemPage or entity url https://gerrit.wikimedia.org/r/334908 @Dalba: This is your requested solution with only one

[Pywikipedia-bugs] [Maniphest] [Updated] T148280: WbTime comparison is incorrect

2017-01-29 Thread Lokal_Profil
Lokal_Profil added a comment. Part of the problem is that WbTime need to support dates such as 2010-00-00 as (per T123888) the default month and day should both be 00 not 01. There may also be problems with dates such as -01-01 which is allowed (for now) in Wikibase (T94064) as well

[Pywikipedia-bugs] [Maniphest] [Updated] T148280: WbTime comparison is incorrect

2017-01-29 Thread Lokal_Profil
Lokal_Profil added a comment. Related: T131453TASK DETAILhttps://phabricator.wikimedia.org/T148280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, Lokal_ProfilCc: Lokal_Profil, gerritbot, Xqt, Wesalius, Aklapper, pywikibot-bugs-list, Multichill, Th3d3v1ls

[Pywikipedia-bugs] [Maniphest] [Commented On] T92856: Assertion failure testing namespace restriction

2017-02-24 Thread Lokal_Profil
Lokal_Profil added a comment. @Magul One minor comment on the patch. Otherwise it looks good to go.TASK DETAILhttps://phabricator.wikimedia.org/T92856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Magul, Lokal_ProfilCc: Lokal_Profil, valhallasw, Dalba, XXN

[Pywikipedia-bugs] [Maniphest] [Created] T158848: Missing not-equal comparison for Wikibase types

2017-02-23 Thread Lokal_Profil
Lokal_Profil created this task.Lokal_Profil added projects: Pywikibot-core, Pywikibot-Wikidata.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONWe allow for comparison of Wikibase types (e.g. WbMonolingualText) but comparisons for not Equal does not give the expected

[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity

2017-01-16 Thread Lokal_Profil
Lokal_Profil added a comment. In T143594#2932697, @Dalba wrote: You mean having unit take either an entity url or a pywikibot.ItemPage? Rather than splitting these over two parameters? Yes. and keeps it more in line with how Coordinate is handled. Maybe the entity parameter of Coordinate

[Pywikipedia-bugs] [Maniphest] [Updated] T150210: Make WbQuantity handle case without errors

2017-01-19 Thread Lokal_Profil
Lokal_Profil added a comment. In T150210#2953586, @Holger wrote: Is this fix already in 2.0rc5? Getting this error in lots of places. Thanks :) This is not in the PyPI version sadly. You'll need to get the git master from gerrit or the github mirro (you can still use pip with that url

[Pywikipedia-bugs] [Maniphest] [Updated] T139749: password_file in user-config does not respect -dir flag

2016-08-19 Thread Lokal_Profil
Lokal_Profil added a project: Pywikibot-login.py. TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, Aklapper, Zppix, Lokal_Profil, pywikibot-bugs-list, Lewizho99, Mdupont, JJMC89

[Pywikipedia-bugs] [Maniphest] [Updated] T102477: login script -pass parameter ignored

2016-08-19 Thread Lokal_Profil
Lokal_Profil added a comment. Is this still open or did the patch fix it? If still open could it be merged with T108848?TASK DETAILhttps://phabricator.wikimedia.org/T102477EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Lokal_Profil, revi

[Pywikipedia-bugs] [Maniphest] [Updated] T124466: Support logging in with Special:BotPassword passwords

2016-08-19 Thread Lokal_Profil
Lokal_Profil added a comment. Duplicate of T143417 (or can that be considered a subtask)?TASK DETAILhttps://phabricator.wikimedia.org/T124466EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Lokal_Profil, jayvdb, Liuxinyu970226, Alkamid

[Pywikipedia-bugs] [Maniphest] [Commented On] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil
Lokal_Profil added a comment. If we go for this solution we should not forget to #pywikibot-announce it afterwards.TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, valhallasw

[Pywikipedia-bugs] [Maniphest] [Commented On] T139749: password_file in user-config does not respect -dir flag

2016-08-19 Thread Lokal_Profil
Lokal_Profil added a comment. If we go for this solution we should not forget to #pywikibot-announce it afterwards since there are rare situations where the fix (despite backwards compatibility) might break existing set-ups.TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps

[Pywikipedia-bugs] [Maniphest] [Claimed] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil
Lokal_Profil claimed this task.Lokal_Profil added a comment. Might have a first attemptTASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: valhallasw, Aklapper, Lokal_Profil, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Created] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil
Lokal_Profil created this task.Lokal_Profil added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONWhenever (edit) tokens are checked there is also also an assert self.site.user() to ensure that the user is (still) logged-in. Unfortunately

[Pywikipedia-bugs] [Maniphest] [Unassigned] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil
Lokal_Profil removed Lokal_Profil as the assignee of this task.Lokal_Profil added a comment. My guess is that this needs to be fixed over in pywikibot/tools/__init__.py:DeprecatedRegex.normalize_username() in order to be handled correctly everywhere (several other functions make the same

[Pywikipedia-bugs] [Maniphest] [Triaged] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil
Lokal_Profil triaged this task as "High" priority.Lokal_Profil added a comment. per T142623TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Lokal_Profil, pywikibot-bugs-lis

[Pywikipedia-bugs] [Maniphest] [Updated] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil
Lokal_Profil added a parent task: T139492: Switch Erfgoedbot over to BotPassword or OAuth. TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: valhallasw, Aklapper, Lokal_Profil, pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil
Lokal_Profil added a comment. In T143417#2567601, @Lokal_Profil wrote: My guess is that this needs to be fixed over in pywikibot/tools/__init__.py:DeprecatedRegex.normalize_username() in order to be handled correctly everywhere (several other functions make the same assumption

[Pywikipedia-bugs] [Maniphest] [Edited] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil
Lokal_Profil edited the task description. (Show Details) EDIT DETAILS...Unfortunately this does not handle usernames from BotPasswords (i.e. `@`, `@`)which I will call login_name to avoid confusion).TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps

[Pywikipedia-bugs] [Maniphest] [Commented On] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil
Lokal_Profil added a comment. In T143417#2567648, @Lokal_Profil wrote: In T143417#2567601, @Lokal_Profil wrote: My guess is that this needs to be fixed over in pywikibot/tools/__init__.py:DeprecatedRegex.normalize_username() in order to be handled correctly everywhere (several other functions

[Pywikipedia-bugs] [Maniphest] [Updated] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil
Lokal_Profil added a comment. In T143417#2567675, @valhallasw wrote: I think the main thing is to separate the user name and the login name, and thus separating the username from the suffix. I'm inclined to say that the '@suffix' API wasn't a great design -- the suffix should have been part

[Pywikipedia-bugs] [Maniphest] [Closed] T143478: flake8-coding 1.3 does not work with flake8 < 3

2016-08-20 Thread Lokal_Profil
Lokal_Profil closed this task as "Resolved".Lokal_Profil removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T143478EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, Lokal_ProfilCc: gerritbot, TerraCodes, Luke0815

[Pywikipedia-bugs] [Maniphest] [Updated] T139749: password_file in user-config does not respect -dir flag

2016-08-20 Thread Lokal_Profil
Lokal_Profil edited projects, added Pywikibot-Announce; removed Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, Aklapper, Zppix, Lokal_Profil, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Commented On] T131624: add WbTime.today() to pywikibot

2016-08-20 Thread Lokal_Profil
Lokal_Profil added a comment. Thanks for the feedback @jayvdb I've implemented the suggestions in a new patch-set.TASK DETAILhttps://phabricator.wikimedia.org/T131624EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, jayvdb, Xqt

[Pywikipedia-bugs] [Maniphest] [Commented On] T139749: password_file in user-config does not respect -dir flag

2016-08-21 Thread Lokal_Profil
Lokal_Profil added a comment. In T139749#2569985, @Octahedron80 wrote: Now "python pwb.py login" is unable to login. Please check. (I am not sure if it is caused by this patch) Which error message do you get? Are you using a password_file? The should be backwards compatible in all

[Pywikipedia-bugs] [Maniphest] [Commented On] T139749: password_file in user-config does not respect -dir flag

2016-08-22 Thread Lokal_Profil
Lokal_Profil added a comment. Don't think it is due to this patch since the code is only triggered when you have password_file in your user-config.py. When I try python pwb.py login I get a normal login prompt so most likely it is something local on your machine which has changed. If not then I'd

[Pywikipedia-bugs] [Maniphest] [Commented On] T150210: Make WbQuantity handle case without errors

2017-02-28 Thread Lokal_Profil
Lokal_Profil added a comment. Per T150210#2954454 you will need to raise this on the tasks for making a new release. At this point 2.0r5 is so far behind master that it might not be possible to reliably backport individual patches.TASK DETAILhttps://phabricator.wikimedia.org/T150210EMAIL

[Pywikipedia-bugs] [Maniphest] [Updated] T159280: Update the version of pywikibot that is available through pip

2017-03-02 Thread Lokal_Profil
Lokal_Profil added a comment. For previous tasks which touch on this see T152907: Release a new version of pywikibot and T106121: RFC removing old code / code cleanup.TASK DETAILhttps://phabricator.wikimedia.org/T159280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Pywikipedia-bugs] [Maniphest] [Commented On] T139749: password_file in user-config does not respect -dir flag

2016-08-25 Thread Lokal_Profil
Lokal_Profil added a comment. Can be resolved once announced (or if we decide not to announce)TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Octahedron80, gerritbot, Aklapper, Zppix

[Pywikipedia-bugs] [Maniphest] [Updated] T124466: Support logging in with Special:BotPassword passwords

2016-08-25 Thread Lokal_Profil
Lokal_Profil edited projects, added Pywikibot-Announce; removed Patch-For-Review.Lokal_Profil added a comment. Adding the #Pywikibot-Announce since information should go out to users that this is how BotPasswordes should now be stored/entered. Can ideally be bundled with an announcement

[Pywikipedia-bugs] [Maniphest] [Closed] T143417: assert self.site.user() fails when using BotPasswords

2016-08-25 Thread Lokal_Profil
Lokal_Profil closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, valhallasw, Aklapper, Lokal_Profil, pywikibot-bugs-list, Lewizho99, Mdupo

[Pywikipedia-bugs] [Maniphest] [Created] T143905: Add support for BotPasswords in generate_user_files.py

2016-08-25 Thread Lokal_Profil
Lokal_Profil created this task.Lokal_Profil added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONBotPasswords (i.e. Special:BotPasswords) are only fully supported via the password_file parameter in user-config.py. It would therefore be nice

[Pywikipedia-bugs] [Maniphest] [Created] T143594: Add unit support to WbQuantity

2016-08-22 Thread Lokal_Profil
Lokal_Profil created this task.Lokal_Profil added projects: Pywikibot-core, Pywikibot-Wikidata.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONBack in T112130 we ensured that pywikibot no longer crashes when it encounters an item with units. However we still don't support

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T143594: Add unit support to WbQuantity

2016-08-22 Thread Lokal_Profil
Lokal_Profil added a subscriber: Ladsgroup.Lokal_Profil added a comment. In T112130#1628026, @Ladsgroup wrote: [...] we need to discuss on how we want to handle units, we can have Entity class and subclass ItemPage and other pages (alongside with Page) OR we can have unit, calender model

[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity

2016-08-22 Thread Lokal_Profil
Lokal_Profil added a comment. One thing which could help would be if entity_prefix was added to siteinfo (cf. articlepath). That way we could at least easily construct entity references (cf. BasePage.full_url()) for items in (known) wikibase repositories.TASK DETAILhttps

[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity

2016-08-22 Thread Lokal_Profil
Lokal_Profil added a comment. In T143594#2572898, @gerritbot wrote: Change 306037 had a related patch set uploaded (by Lokal Profil): Support adding units to WbQuantity through the entity url https://gerrit.wikimedia.org/r/306037 This only adds the ability to add the entity url directly

[Pywikipedia-bugs] [Maniphest] [Claimed] T139749: password_file in user-config does not respect -dir flag

2016-08-25 Thread Lokal_Profil
Lokal_Profil claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Octahedron80, gerritbot, Aklapper, Zppix, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89

[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity

2016-10-02 Thread Lokal_Profil
Lokal_Profil added a comment. The current patch is the first step in being able to add units using their Qids instead of entity_urls (same set-up as for globe in Coordinates). it is also true that the documentation didn't reflect what was happening. This patch also fixes that.TASK DETAILhttps

[Pywikipedia-bugs] [Maniphest] [Updated] T143594: Add unit support to WbQuantity

2016-10-10 Thread Lokal_Profil
Lokal_Profil added a comment. In T143594#2704023, @Multichill wrote: @Lokal_Profil would be nice if instead of an url, you could just pass an ItemPage object. That would be a good abstraction. For that the ItemPage does need to have a function that returns an entity url like http

[Pywikipedia-bugs] [Maniphest] [Created] T150210: Make WbQuantity handle case without errors

2016-11-07 Thread Lokal_Profil
Lokal_Profil created this task.Lokal_Profil added projects: Pywikibot-core, Pywikibot-Wikidata.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONT115269 means that in addition to "datavalue":{ "value":{ "amount":"+700"

[Pywikipedia-bugs] [Maniphest] [Commented On] T100903: Run pywikibot test suite regularly on beta cluster as part of MediaWiki/Wikimedia CI

2016-11-09 Thread Lokal_Profil
Lokal_Profil added a comment. Does this also manage to run the wikibase tests on wikidata.beta.wmflabs.org or is it limited to just the wikipedia family?TASK DETAILhttps://phabricator.wikimedia.org/T100903EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Pywikipedia-bugs] [Maniphest] [Commented On] T142155: Bot can't login. keyError in GetCookie

2016-11-09 Thread Lokal_Profil
Lokal_Profil added a comment. I don't think the BotPasswords patch is part of the 2.0rc5 release (since it was released two days before that patch). I'm actually don't think it is in the 2.0 branch at all (where login.py hasn't been changed since 2015).TASK DETAILhttps://phabricator.wikimedia.org

  1   2   3   >