[Pywikipedia-bugs] [Maniphest] [Created] T113212: qualifier misidentified in fromJSON()

2015-09-21 Thread Lokal_Profil 
Lokal_Profil created this task.
Lokal_Profil added a subscriber: Lokal_Profil.
Lokal_Profil added a project: pywikibot-core.
Herald added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION
  Currently qualifiers are misidentified as references when `fromJSON()` is 
called on the parent claim.
  
  To test:
  ```
  import pywikibot;repo = pywikibot.Site().data_repository();item = 
pywikibot.ItemPage(repo, 'Q4115189')
  item.exists()
  c = item.claims['P800'][0];sc = c.sources[1]['P813'][0];qc = 
c.qualifiers['P580'][0]
  
  qc.isReference
  qc.isQualifier
  sc.isReference
  sc.isQualifier
  ```
  
  I have a quick patch which simply moves the `isQualifier`/`isReference` 
assignment to the `qualifierFromJSON()`/`referenceFromJSON()` methods. However 
since I'm unsure if `fromJSON()` is ever called directly on a 
qualifer/reference I'm not sure whether this is enough.

TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Aklapper, Lokal_Profil, pywikibot-bugs-list, jayvdb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T85385: Implement "Monolingual text" in Pywikibot

2015-09-21 Thread Lokal_Profil 
Lokal_Profil added a subscriber: Lokal_Profil.

TASK DETAIL
  https://phabricator.wikimedia.org/T85385

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lokal_Profil, gerritbot, Smalyshev, Ricordisamoa, jayvdb, Aklapper, 
pywikibot-bugs-list, Multichill, Liuxinyu970226, Lydia_Pintscher, 
Wikidata-bugs, aude



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-09-22 Thread Lokal_Profil 
Lokal_Profil added a comment.

In https://phabricator.wikimedia.org/T113212#1661682, @jayvdb wrote:

> Interesting; `toJSON` contains `qualifier.isQualifier = True` and 
> `source.isReference = True`.  Those should be asserts!


Should we patch this as well before resolving this task?

Also how is `pywikibot-wikibase` handled? Should pulls be done there as well or 
will that synk up before it goes live (assuming that it is not already)


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: jayvdb, gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-09-21 Thread Lokal_Profil 
Lokal_Profil added a comment.

To clarify. The source of the above error is an false assumption that 
qualifiers don't have a hash property.


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T120222: Error installing pywikibot on Windows 10 (No handlers could be found for logger "pywiki")

2015-12-08 Thread Lokal_Profil 
Lokal_Profil added a comment.

Just got confirmed that at least one of the users used git to get the latest 
version of core. So whilst my problem is solved (point them to 2.0rc3) there is 
definitely something going on with master on windows (possibly not only 10).


TASK DETAIL
  https://phabricator.wikimedia.org/T120222

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Ladsgroup, XZise, valhallasw, Aklapper, WereSpielChequers, StudiesWorld, 
Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T120222: Error installing pywikibot on Windows 10 (No handlers could be found for logger "pywiki")

2015-12-08 Thread Lokal_Profil 
Lokal_Profil added a comment.

Thanks.

I tried a bit more and after a re-boot the above error disappears (but a lot of 
others appear instead). I removed the pywikibot directory, downloaded 2.0rc3, 
unpacked, ran `python setup.py install` and now it works.

Since I didn't do the initial two installs I don't know if my routine differed. 
I'll try to put my hands on a fresh win 10 laptop to see if there is a step 
which needs to be added to the windows specific routine to make it work. Best 
case scenario it is simply that you need to do a re-boot at some point.


TASK DETAIL
  https://phabricator.wikimedia.org/T120222

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: valhallasw, Aklapper, WereSpielChequers, StudiesWorld, Lokal_Profil, 
pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Edited] T120651: pywikibot test_set_redirect_target fails

2015-12-09 Thread Lokal_Profil 
Lokal_Profil edited the task description.
Lokal_Profil set Security to None.

TASK DETAIL
  https://phabricator.wikimedia.org/T120651

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: jayvdb, Aklapper, Ladsgroup, StudiesWorld, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T120651: pywikibot test_set_redirect_target fails

2015-12-09 Thread Lokal_Profil 
Lokal_Profil added a comment.

I added the output to the description


TASK DETAIL
  https://phabricator.wikimedia.org/T120651

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: jayvdb, Aklapper, Ladsgroup, StudiesWorld, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T120222: Error installing pywikibot on Windows 10 (No handlers could be found for logger "pywiki")

2015-12-03 Thread Lokal_Profil 
Lokal_Profil created this task.
Lokal_Profil added subscribers: Lokal_Profil, WereSpielChequers.
Lokal_Profil added a project: pywikibot-core.
Herald added subscribers: pywikibot-bugs-list, StudiesWorld, Aklapper.

TASK DESCRIPTION
  Last weekend we tried installing pywikibot on a few windows laptops and we 
ran into problems with the ones running Windows 10. (Same procedure worked for 
the Windows 8 laptop).
  
  After downloading and unpacking the zipped file, installing `requests`, and 
running `python setup.py` we tried running `python pwb.py version` to trigger 
generating the user_config and got the following error:
  
  ```
  NOTE: 'user-config.py' was not found!
  Please follow the prompts to create it:
  No handlers could be found for logger "pywiki"
  Traceback (most recent call last):
File "pwb.py", line 194, in 
  [])
File "pwb.py", line 120, in run_python_file
  main_mod.__dict__)
File "generate_user_files.py", line 25, in 
  import pywikibot
File "pywikibot\__init__.py", line 37, in 
  from pywikibot import config2 as config
File "pywikibot\config2.py", line 1059, in 
  editor = _detect_win32_editor()
File "pywikibot\config2.py", line 903, in _detect_win32_editor
  editor = _win32_extension_command(ext)
File "pywikibot\config2.py", line 890, in _win32_extension_command
  extension, e))
  UnicodeDecodeError: 'ascii' codec can't decode byte 0xe5 in position 15: 
ordinal not in range(128)
  ```
  
  The critical line seems to be `No handlers could be found for logger 
"pywiki"` as this triggers when trying to run scripts through `pwb.py` or 
running `generate_user_files.py` directly.
  
  It's unclear to me what exactly is causing this and also whether it would 
always fail or if more instructions must simply be added to the documentation 
for a Windows 10 install (e.g. you cannot change the character encoding of the 
command prompt anymore).
  
  Details:
  `python --version: python 2.7.10`
  pywikibot version: whichever was in the package/pywikibot/core_stable.zip on 
2015-11-29

TASK DETAIL
  https://phabricator.wikimedia.org/T120222

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Aklapper, WereSpielChequers, StudiesWorld, Lokal_Profil, 
pywikibot-bugs-list, jayvdb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T120651: pywikibot test_set_redirect_target fails

2015-12-07 Thread Lokal_Profil 
Lokal_Profil created this task.
Lokal_Profil added subscribers: Lokal_Profil, Ladsgroup.
Lokal_Profil added projects: Pywikibot-tests, pywikibot-core.
Herald added subscribers: pywikibot-bugs-list, StudiesWorld, Aklapper.

TASK DESCRIPTION
  I just noticed that running `test_set_redirect_target` fails.
  
  As a follow up. Are these tests run as part of the merge/+2 mechanism in 
gerrit?
  
  I ran it using `python pwb.py tests/wikibase_edit_tests.py 
TestWikibaseWriteGeneral.test_set_redirect_target` with 
`PYWIKIBOT2_TEST_WRITE=1`

TASK DETAIL
  https://phabricator.wikimedia.org/T120651

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Aklapper, Ladsgroup, StudiesWorld, Lokal_Profil, pywikibot-bugs-list, jayvdb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T119963: Add mechanism for removing a qualifier

2015-12-07 Thread Lokal_Profil 
Lokal_Profil added a comment.

I've now added a test to this as well


TASK DETAIL
  https://phabricator.wikimedia.org/T119963

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: gerritbot, Aklapper, StudiesWorld, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Closed] T119963: Add mechanism for removing a qualifier

2015-12-17 Thread Lokal_Profil 
Lokal_Profil closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T119963

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: gerritbot, Aklapper, StudiesWorld, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T119963: Add mechanism for removing a qualifier

2015-12-01 Thread Lokal_Profil 
Lokal_Profil added a comment.

If needed I could try my hand at adding a test for the method as well. Since I 
haven't done tests before though it is likely to require some coaching.


TASK DETAIL
  https://phabricator.wikimedia.org/T119963

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: gerritbot, Aklapper, StudiesWorld, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T123882: Implement Identifier datatype in pywikibot

2016-01-17 Thread Lokal_Profil 
Lokal_Profil added a comment.

Disregarding the https://phabricator.wikimedia.org/T115679 issue. Is there 
anything that needs to be changed other than extending `Property` (in 
`page.py`) with two new mappings in `types` and `value_types`?


TASK DETAIL
  https://phabricator.wikimedia.org/T123882

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Aklapper, StudiesWorld, pywikibot-bugs-list, Lokal_Profil, Ricordisamoa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T123882: Implement Identifier datatype in pywikibot

2016-01-17 Thread Lokal_Profil 
Lokal_Profil created this task.
Lokal_Profil added a subscriber: Lokal_Profil.
Lokal_Profil added projects: pywikibot-core, Pywikibot-Wikidata.
Herald added subscribers: pywikibot-bugs-list, StudiesWorld, Aklapper.

TASK DESCRIPTION
  In preparation for the new [[ 
https://lists.wikimedia.org/pipermail/wikidata/2016-January/007951.html | 
identifier ]] datatype Pywikibot should be extended to handle this.

TASK DETAIL
  https://phabricator.wikimedia.org/T123882

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Aklapper, StudiesWorld, pywikibot-bugs-list, Lokal_Profil, Ricordisamoa, 
jayvdb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T115679: Handle property datatype changing gracefully

2016-01-17 Thread Lokal_Profil 
Lokal_Profil added a subscriber: Lokal_Profil.

TASK DETAIL
  https://phabricator.wikimedia.org/T115679

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lokal_Profil, thiemowmde, daniel, XZise, Ricordisamoa, hoo, 
Lydia_Pintscher, Multichill, Legoktm, Aklapper, jayvdb, pywikibot-bugs-list, 
Wikidata-bugs, aude, Mbch331



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T123888: Incorrect default month and day for WbTime

2016-01-17 Thread Lokal_Profil 
Lokal_Profil created this task.
Lokal_Profil added a subscriber: Lokal_Profil.
Lokal_Profil added projects: pywikibot-core, Pywikibot-Wikidata.
Herald added subscribers: pywikibot-bugs-list, StudiesWorld, Aklapper.

TASK DESCRIPTION
  Per the definition in [[ 
https://www.mediawiki.org/wiki/Wikibase/DataModel#Dates_and_times | 
mw:DataModel ]] the default values for month and day should be `00` and not 
`01`.
  
  As I noted in T107870 this will however break naive date comparisons. As such 
we might want to do more than just change `WbTime.__init__.py`.

TASK DETAIL
  https://phabricator.wikimedia.org/T123888

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Aklapper, StudiesWorld, pywikibot-bugs-list, Lokal_Profil, Ricordisamoa, 
jayvdb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T123883: Make Claim.target_equals take precision into account

2016-01-17 Thread Lokal_Profil 
Lokal_Profil created this task.
Lokal_Profil added a subscriber: Lokal_Profil.
Lokal_Profil added projects: pywikibot-core, Pywikibot-Wikidata.
Herald added subscribers: pywikibot-bugs-list, StudiesWorld, Aklapper.

TASK DESCRIPTION
  The fact that `Claim.target_equals()` does `WbTime` comparison based only on 
year is counter-intuitive to me.
  
  I would suggest making this take precision `target.precision` into account 
and demanding that `target.precision < pywikibot.WbTime.PRECISION['year']` but 
would like to check what the original choice for comparing on year was.
  
  Alternatively (or additionally) having a built in comparison where both 
target and value are `WbTime` would be useful. The method I use myself compares 
year, month, day etc. based on the relevant precision (so that `2010-01-01` and 
`2010-00-00` are equal but only if precision is `year` on both).

TASK DETAIL
  https://phabricator.wikimedia.org/T123883

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Aklapper, StudiesWorld, Lokal_Profil, pywikibot-bugs-list, Ricordisamoa, 
jayvdb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T123856: Add tests for Wikibase Monolingual text

2016-01-17 Thread Lokal_Profil 
Lokal_Profil added a comment.

I can take this one.

What I thought of so far was:

- basic creation from a string
- creation from a unicode string
- equality
- `fromWikibase`-`toWikibase` roundtrip

I would also add raising errors if either parameter is an empty string or not a 
`basestring`, then test that these are raised.

Anything else of the top of anyone's mind?


TASK DETAIL
  https://phabricator.wikimedia.org/T123856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lydia_Pintscher, Liuxinyu970226, Multichill, Aklapper, jayvdb, 
Ricordisamoa, Smalyshev, gerritbot, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T123856: Add tests for Wikibase Monolingual text

2016-01-19 Thread Lokal_Profil 
Lokal_Profil removed a project: Patch-For-Review.
Lokal_Profil set Security to None.

TASK DETAIL
  https://phabricator.wikimedia.org/T123856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lydia_Pintscher, Liuxinyu970226, Multichill, Aklapper, jayvdb, 
Ricordisamoa, Smalyshev, gerritbot, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T106121: RFC removing old code / code cleanup

2016-02-10 Thread Lokal_Profil 
Lokal_Profil added a subscriber: Lokal_Profil.
Herald added a subscriber: StudiesWorld.

TASK DETAIL
  https://phabricator.wikimedia.org/T106121

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lokal_Profil, StudiesWorld, Multichill, valhallasw, jayvdb, XZise, 
Ricordisamoa, Aklapper, Xqt, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T124139: Claim new method has_qualifier

2016-02-10 Thread Lokal_Profil 
Lokal_Profil added a subscriber: Lokal_Profil.
Lokal_Profil added a comment.

It is a bit unclear whar the criteria for a match would be since a source is 
essentially a lat of Claims. Options are:

1. All provided Claims need to be present in the source.
2. All provided Claims need to be present in the source, which can additionally 
contain no other Claims.
3. Any of the provided Claims are present in the source.

While 2. is the most straight forward it is also the least useful since a 
source often consists of a Claim pointing to an external source + a Claim 
giving some time of timestamp. If you are wondering if something is already 
sourced from imdb do you care about the timestamp?
On the other hand for a source made up by three  Claims you might care about 
two of them but not the third (which would make solution 3 less useful). Lastly 
if you use solution 1 you risk that two Claim sources give his when you were in 
fact expecting only a single Claim source.


TASK DETAIL
  https://phabricator.wikimedia.org/T124139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lokal_Profil, Aklapper, pywikibot-bugs-list, Ricordisamoa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T123882: Implement Identifier datatype in pywikibot

2016-02-04 Thread Lokal_Profil 
Lokal_Profil added a comment.

So in addition to the two places I identified above `Claim._formatValue`. I'll 
put together a patch (since I'm doing one for `math` anyway) but we might not 
want to merge it yet.

In https://phabricator.wikimedia.org/T123882#1992867, @JAnD wrote:

> Bot should check, if valie wss not deleted in recent histroy. And in default 
> it should skip that page...


Not sure I understand what you mean here.


TASK DETAIL
  https://phabricator.wikimedia.org/T123882

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: JAnD, Smalyshev, Aklapper, StudiesWorld, pywikibot-bugs-list, Lokal_Profil, 
Ricordisamoa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Closed] T127205: Get login token from action=query=tokens

2016-02-29 Thread Lokal_Profil 
Lokal_Profil closed this task as "Resolved".
Lokal_Profil claimed this task.
Lokal_Profil removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T127205

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Ricordisamoa, gerritbot, Jogo.obb, Aklapper, StudiesWorld, Lokal_Profil, 
pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Unblock] T85385: Implement "Monolingual text" in Pywikibot

2016-01-19 Thread Lokal_Profil 
Lokal_Profil closed blocking task T123856: Add tests for Wikibase Monolingual 
text as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T85385

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev, Lokal_Profil
Cc: Lokal_Profil, Smalyshev, Ricordisamoa, jayvdb, Aklapper, 
pywikibot-bugs-list, Multichill, Lydia_Pintscher, Wikidata-bugs, aude, Mbch331



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T123856: Add tests for Wikibase Monolingual text

2016-01-19 Thread Lokal_Profil 
Lokal_Profil removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T123856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lydia_Pintscher, Liuxinyu970226, Multichill, Aklapper, jayvdb, 
Ricordisamoa, Smalyshev, gerritbot, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Closed] T123856: Add tests for Wikibase Monolingual text

2016-01-19 Thread Lokal_Profil 
Lokal_Profil closed this task as "Resolved".
Lokal_Profil claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T123856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lydia_Pintscher, Liuxinyu970226, Multichill, Aklapper, jayvdb, 
Ricordisamoa, Smalyshev, gerritbot, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T118012: Feature request: allow login with OAuth, getting tokens at runtime

2016-02-17 Thread Lokal_Profil 
Lokal_Profil added a subscriber: Lokal_Profil.

TASK DETAIL
  https://phabricator.wikimedia.org/T118012

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lokal_Profil, jayvdb, Aklapper, StudiesWorld, pywikibot-bugs-list, Mpaa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T127205: Get login token from action=query=tokens

2016-02-18 Thread Lokal_Profil 
Lokal_Profil added a comment.


  My fix should use the new token call for mediaWiki >= 1.27, otherwise 
business as usual

TASK DETAIL
  https://phabricator.wikimedia.org/T127205

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: gerritbot, Jogo.obb, Aklapper, StudiesWorld, Lokal_Profil, 
pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T128992: site detection failures

2016-03-09 Thread Lokal_Profil 
Lokal_Profil added a comment.


  I think http://botwiki.sno.cc/wiki/$1 might also be causing problems. Looks 
like the domain has expired.

TASK DETAIL
  https://phabricator.wikimedia.org/T128992

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lokal_Profil, Xqt, Aklapper, pywikibot-bugs-list, jayvdb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T128987: testQueriesDirectFromClaim fails with TypeError: Cannot construct a query from a claim of type external-id

2016-03-09 Thread Lokal_Profil 
Lokal_Profil added a comment.


  Thanks @Ricordisamoa. Hadn't noticed that basestring got defined differently 
depending on python version

TASK DETAIL
  https://phabricator.wikimedia.org/T128987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Ricordisamoa, Xqt, Lokal_Profil, Aklapper, jayvdb, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T128988: TestWiktionaryGraph.test_octagon failing

2016-03-09 Thread Lokal_Profil 
Lokal_Profil removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T128988

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lokal_Profil, gerritbot, Aklapper, jayvdb, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Closed] T128988: TestWiktionaryGraph.test_octagon failing

2016-03-09 Thread Lokal_Profil 
Lokal_Profil closed this task as "Resolved".
Lokal_Profil claimed this task.
Lokal_Profil added a comment.


  15 out of the 20 builds 
<https://travis-ci.org/wikimedia/pywikibot-core/builds/114880004> now completes 
successfully .
  
  The remaining fails/crashes are due to:
  
  - 4: tests.wikidataquery_tests.py:TestApiSlowFunctions.testQueryApiGetter
  - 12: Non-JSON response received from server wpbeta:en; the server may be 
down.
  - 13: Non-JSON response received from server wpbeta:zh; the server may be 
down.
  - 18, 20: paraminfo_test.py:MediaWikiKnownTypesTestCase.test_content_format

TASK DETAIL
  https://phabricator.wikimedia.org/T128988

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lokal_Profil, gerritbot, Aklapper, jayvdb, pywikibot-bugs-list, Lewizho99



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T128987: testQueriesDirectFromClaim fails with TypeError: Cannot construct a query from a claim of type external-id

2016-03-09 Thread Lokal_Profil 
Lokal_Profil added a comment.


  In https://phabricator.wikimedia.org/T128987#2102815, @Xqt wrote:
  
  > Looks like the bug is still there. Travis reports it, e.g. 
https://travis-ci.org/wikimedia/pywikibot-core/jobs/114767216
  
  
  That is really weird. Running the same test locally and it passes.
  Explicitly constructing a https://phabricator.wikimedia.org/P268 claim and 
testing it in `Claim.types.get(claim.type) == basestring` returns true.
  
  What could account for travis behaving differently?

TASK DETAIL
  https://phabricator.wikimedia.org/T128987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Xqt, Lokal_Profil, Aklapper, jayvdb, pywikibot-bugs-list, Ricordisamoa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T128987: testQueriesDirectFromClaim fails with TypeError: Cannot construct a query from a claim of type external-id

2016-03-09 Thread Lokal_Profil 
Lokal_Profil added a comment.


  This is likely a result of `P268` being changed from string to external-id. 
Changing to `P225` fixes the error.
  
  However the fact that it is failing indicative of a problem with 
`wikidataquery.fromClaim()` being too picky in what it allows as STRING claims.

TASK DETAIL
  https://phabricator.wikimedia.org/T128987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lokal_Profil, Aklapper, jayvdb, pywikibot-bugs-list, Ricordisamoa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T85385: Implement "Monolingual text" in Pywikibot

2016-03-11 Thread Lokal_Profil 
Lokal_Profil removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T85385

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev, Lokal_Profil
Cc: Lokal_Profil, Smalyshev, Ricordisamoa, jayvdb, Aklapper, 
pywikibot-bugs-list, Multichill, Lydia_Pintscher, D3r1ck01, Izno, 
Wikidata-bugs, aude, Mbch331



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T128987: testQueriesDirectFromClaim fails with TypeError: Cannot construct a query from a claim of type external-id

2016-03-09 Thread Lokal_Profil 
Lokal_Profil added a comment.


  There is something subtle going on here:
  
>>> Claim.types.get(claim.type)

>>> basestring

>>> isinstance(Claim.types.get(claim.type), basestring)
False
  
  How about I just admit defeat and go for the tuple solution instead.

TASK DETAIL
  https://phabricator.wikimedia.org/T128987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Xqt, Lokal_Profil, Aklapper, jayvdb, pywikibot-bugs-list, Ricordisamoa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T128318: No handlers could be found for logger "pywiki"

2016-03-07 Thread Lokal_Profil 
Lokal_Profil added a comment.


  Is this the same as https://phabricator.wikimedia.org/T113822 ?

TASK DETAIL
  https://phabricator.wikimedia.org/T128318

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lokal_Profil, Aklapper, StudiesWorld, Xqt, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T131624: add WbTime.today() to pywikibot

2016-04-03 Thread Lokal_Profil 
Lokal_Profil added a comment.


  Any time a statement is sourced/referenced using a web page accessed during 
the run (i.e. https://phabricator.wikimedia.org/P813). I.e. essentially any bot 
which adds references.

TASK DETAIL
  https://phabricator.wikimedia.org/T131624

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: jayvdb, Xqt, Aklapper, Lokal_Profil, pywikibot-bugs-list, Ricordisamoa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T131624: add WbTime.today() to pywikibot

2016-04-03 Thread Lokal_Profil 
Lokal_Profil added a comment.


  True if we introduce a `fromTimestamp()` to `__-init.py__.WbTime` which goes 
from (possibly both ways) `pywikibot.Timestamp` to `WbTime`
  
  then:
  `today = pywikibot.WbTime.fromTimestamp(pywikibot.Timestamp.today())` should 
do it.
  
  techically this can be done already using
  `today = 
pywikibot.WbTime.fromTimestr(pywikibot.Timestamp.today().isoformat())` but I 
think it would make sense to have a converter to go from one of our time 
formats to the other.

TASK DETAIL
  https://phabricator.wikimedia.org/T131624

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Xqt, Aklapper, Lokal_Profil, pywikibot-bugs-list, jayvdb, Ricordisamoa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T131453: Implement non-strict __cmp__ for WbTime

2016-04-01 Thread Lokal_Profil 
Lokal_Profil added a blocked task: T123888: Incorrect default month and day for 
WbTime.

TASK DETAIL
  https://phabricator.wikimedia.org/T131453

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Aklapper, pywikibot-bugs-list, Multichill, Lokal_Profil, jayvdb, 
Ricordisamoa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T123888: Incorrect default month and day for WbTime

2016-04-01 Thread Lokal_Profil 
Lokal_Profil added a blocking task: T131453: Implement non-strict __cmp__ for 
WbTime.

TASK DETAIL
  https://phabricator.wikimedia.org/T123888

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Aklapper, StudiesWorld, pywikibot-bugs-list, Lokal_Profil, jayvdb, 
Ricordisamoa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T131453: Implement non-strict __cmp__ for WbTime

2016-04-01 Thread Lokal_Profil 
Lokal_Profil created this task.
Herald added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION
  The `__eq__` of WbRepresentation does not handle precision based comparisons 
or the fact that dates can be represented in multiple ways 
(https://phabricator.wikimedia.org/T107870).
  
  The desired function would check that precision is the same then compare the 
date only up to that precision.

TASK DETAIL
  https://phabricator.wikimedia.org/T131453

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Aklapper, pywikibot-bugs-list, Multichill, Lokal_Profil, jayvdb, 
Ricordisamoa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T131619: add __repr__ to Claim in pywikibot

2016-04-02 Thread Lokal_Profil 
Lokal_Profil created this task.
Herald added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION
  //Will fill this out better later//
  
  Should be something like:
  
# extend pywikibot.Claim with a __repr__ method
def new_repr(self):
return u'pywikibot.Claim(%s: %s)' % (self.getID(), 
self.getTarget())
pywikibot.Claim.__repr__ = new_repr

TASK DETAIL
  https://phabricator.wikimedia.org/T131619

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Aklapper, Lokal_Profil, pywikibot-bugs-list, jayvdb, Ricordisamoa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T131624: add WbTime.today() to pywikibot

2016-04-02 Thread Lokal_Profil 
Lokal_Profil created this task.
Herald added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION
  Method for turning todays date into a WbTime. This is used whenever setting 
fetch dates etc. for references.
  
  Something like:
  
def today_as_WbTime():
"""Get todays date as a WbTime object.

@return: Todays date correctly formated
@rtype: pywikibot.WbTime
"""
today = datetime.today()
date = pywikibot.WbTime(year=today.year,
month=today.month,
day=today.day)
return date

TASK DETAIL
  https://phabricator.wikimedia.org/T131624

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Aklapper, Lokal_Profil, pywikibot-bugs-list, jayvdb, Ricordisamoa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T123888: Incorrect default month and day for WbTime

2016-04-02 Thread Lokal_Profil 
Lokal_Profil added a subscriber: Multichill.
Lokal_Profil edited the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T123888

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Multichill, Aklapper, StudiesWorld, pywikibot-bugs-list, Lokal_Profil, 
jayvdb, Ricordisamoa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T131624: add WbTime.today() to pywikibot

2016-04-02 Thread Lokal_Profil 
Lokal_Profil added a comment.


  Alternatively instead of sticking this in `__-init.py__.WbTime` it could go 
inte some helper class... if someone can recommedn a good place.

TASK DETAIL
  https://phabricator.wikimedia.org/T131624

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Aklapper, Lokal_Profil, pywikibot-bugs-list, jayvdb, Ricordisamoa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T142623: Login does not work with BotPasswords when password is not pre-provided

2016-08-10 Thread Lokal_Profil 
Lokal_Profil created this task.Lokal_Profil added projects: Pywikibot-core, Pywikibot-login.py.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONBotPasswords require you to log in with usernames like COHBot@GAR.

When a password is pre-provided pywikibot handles this fine.

However if no password is fine then login.py calls check_user_exists() before asking you for the password and check_user_exists() does not deal with the BotPassword username.TASK DETAILhttps://phabricator.wikimedia.org/T142623EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T142623: Login does not work with BotPasswords when password is not pre-provided

2016-08-10 Thread Lokal_Profil 
Lokal_Profil added a comment.
I'll put together a patch for this.TASK DETAILhttps://phabricator.wikimedia.org/T142623EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Edited] T142623: Login does not work with BotPasswords when password is not pre-provided

2016-08-10 Thread Lokal_Profil 
Lokal_Profil edited the task description. (Show Details)
EDIT DETAILS[[ https://www.mediawiki.org/wiki/Manual:Bot_passwords | BotPasswords ]] require you to log in with usernames like COHBot@GARTASK DETAILhttps://phabricator.wikimedia.org/T142623EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T140516: Add beta commons as family

2016-07-15 Thread Lokal_Profil 
Lokal_Profil created this task.Lokal_Profil added projects: Pywikibot-core, Pywikibot-Commons.Herald added subscribers: pywikibot-bugs-list, Zppix, Avicennasis, Steinsplitter, Aklapper.
TASK DESCRIPTIONThere is currently no test instance for Commons available through pywikibot making testing of Commons related code (especially upload) problematic.

AFAIK http://commons.wikimedia.beta.wmflabs.org is the designated test site for Commons. So adding this to the families would be nice.

Two things makes this more complicated:


the domain is not the same as that for commons.wikimedia.org (so I'm not sure it can simply be added as a language in commons_family.py)
beta commons does not (yet) support https (T50501)
TASK DETAILhttps://phabricator.wikimedia.org/T140516EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Steinsplitter, Avicennasis, Zppix, Lokal_Profil, pywikibot-bugs-list, Mdupont, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T139749: password_file in user-config does not respect -dir flag

2016-07-08 Thread Lokal_Profil 
Lokal_Profil created this task.Lokal_Profil added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Zppix, Aklapper.
TASK DESCRIPTIONWhen running a script with the flag -dir: it correctly finds the user-config.py file in that directory.

If you have specified password_file = "secretPasswords" in that config pywikibot still looks for it in the running directory, not .

Reason: login.py:readPassword() is unaware of of the -dir flag.TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Zppix, Lokal_Profil, pywikibot-bugs-list, Mdupont, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T139749: password_file in user-config does not respect -dir flag

2016-07-08 Thread Lokal_Profil 
Lokal_Profil added a comment.
A quick and dirty solution would be to have readPassword() do a os.cwd to config.base_dir before trying to open the file and then os.cwd back before exiting.TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Zppix, Lokal_Profil, pywikibot-bugs-list, Mdupont, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T142155: Bot can't login. keyError in GetCookie

2016-08-05 Thread Lokal_Profil 
Lokal_Profil added a comment.
@Multichill: Does using Special:BotPasswords solve the problem for you?TASK DETAILhttps://phabricator.wikimedia.org/T142155EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Lokal_Profil, Tgr, Udo_T, Legoktm, JJMC89, Pywikibot-Announce, Yamaha5, jayvdb, Ladsgroup, Xqt, valhallasw, Multichill, Anomie, CodeCat, TerraCodes, Luke081515, He7d3r, Basilicofresco, Jagwar, MarcoAurelio, Dalba, Aklapper, Joutbis, pywikibot-bugs-list, Mdupont___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T140516: Add beta commons as family

2016-08-08 Thread Lokal_Profil 
Lokal_Profil added a comment.

In T140516#2533117, @Stan3 wrote:
{F4345244}These are the changes I've needed to work with beta commons.


That diff doesn't look like it's built on top of commons_family.py in the master branch. Are there more patches in-between?TASK DETAILhttps://phabricator.wikimedia.org/T140516EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Stan3, Dalba, Aklapper, Steinsplitter, Avicennasis, Zppix, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T131619: add __repr__ to Claim in pywikibot

2016-08-09 Thread Lokal_Profil 
Lokal_Profil removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T131619EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb, Ricordisamoa___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Triaged] T131619: add __repr__ to Claim in pywikibot

2016-08-09 Thread Lokal_Profil 
Lokal_Profil triaged this task as "Lowest" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T131619EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb, Ricordisamoa___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T131624: add WbTime.today() to pywikibot

2016-08-09 Thread Lokal_Profil 
Lokal_Profil added a comment.
Found the open patchset related to this. There is still a need for it and the patch should still be mergeable (I just rebased it).

If someone would be willing to review or argue for why it isn't needed.TASK DETAILhttps://phabricator.wikimedia.org/T131624EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, jayvdb, Xqt, Aklapper, Lokal_Profil, pywikibot-bugs-list, Lewizho99, Mdupont, JJMC89, Maathavan, Ricordisamoa___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity

2017-01-29 Thread Lokal_Profil 
Lokal_Profil added a comment.

In T143594#2980621, @gerritbot wrote:
Change 334908 had a related patch set uploaded (by Lokal Profil):
 Support adding units to WbQuantity through ItemPage or entity url

https://gerrit.wikimedia.org/r/334908


@Dalba: This is your requested solution with only one parameter. It needs ano additional bit of internal juggling to deal with unit='1' but I think it ends up being better than the previous implementation.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Dalba, Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Ricordisamoa, Wesalius, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T148280: WbTime comparison is incorrect

2017-01-29 Thread Lokal_Profil 
Lokal_Profil added a comment.
Part of the problem is that WbTime need to support dates such as 2010-00-00 as (per T123888) the default month and day should both be 00 not 01. There may also be problems with dates such as -01-01 which is allowed (for now) in Wikibase (T94064) as well as negative years.TASK DETAILhttps://phabricator.wikimedia.org/T148280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, Lokal_ProfilCc: Lokal_Profil, gerritbot, Xqt, Wesalius, Aklapper, pywikibot-bugs-list, Multichill, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Ricordisamoa, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T148280: WbTime comparison is incorrect

2017-01-29 Thread Lokal_Profil 
Lokal_Profil added a comment.
Related: T131453TASK DETAILhttps://phabricator.wikimedia.org/T148280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, Lokal_ProfilCc: Lokal_Profil, gerritbot, Xqt, Wesalius, Aklapper, pywikibot-bugs-list, Multichill, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Ricordisamoa, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T92856: Assertion failure testing namespace restriction

2017-02-24 Thread Lokal_Profil 
Lokal_Profil added a comment.
@Magul One minor comment on the patch. Otherwise it looks good to go.TASK DETAILhttps://phabricator.wikimedia.org/T92856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Magul, Lokal_ProfilCc: Lokal_Profil, valhallasw, Dalba, XXN, Xqt, Magul, gerritbot, jayvdb, pywikibot-bugs-list, Aklapper, XZise, MarcAbonce, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, GPHemsley, Darkdadaah, Masti, Alchimista, Rxy, Krenair___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T158848: Missing not-equal comparison for Wikibase types

2017-02-23 Thread Lokal_Profil 
Lokal_Profil created this task.Lokal_Profil added projects: Pywikibot-core, Pywikibot-Wikidata.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONWe allow for comparison of Wikibase types (e.g. WbMonolingualText)  but comparisons for not Equal does not give the expected results.

To illustrate:

import pywikibot as pwb

A = pwb.WbMonolingualText('Same', 'en')
B = pwb.WbMonolingualText('Same', 'en')
C = pwb.WbMonolingualText('Different', 'en')

A == B  # expect True
> True
A != B  # expect False !!
> True
A == C  # expect False
> False
A != C  # expect True
> TrueTASK DETAILhttps://phabricator.wikimedia.org/T158848EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Lokal_Profil, pywikibot-bugs-list, MarcAbonce, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Ricordisamoa, Wesalius, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity

2017-01-16 Thread Lokal_Profil 
Lokal_Profil added a comment.

In T143594#2932697, @Dalba wrote:
You mean having unit take either an entity url or a pywikibot.ItemPage? Rather than splitting these over two parameters?

Yes.

and keeps it more in line with how Coordinate is handled.

Maybe the entity parameter of Coordinate should also be changed to accept both a URL or an ItemPage?

I haven't checked if combining the two is possible but can take a look if you feel it is a blocker.

I don't know if "blocker" is the right term for it, I wouldn't even -1 the current patch because of this, but I surely appreciate if you could take some time to see if what I suggested can implemented in a neat way or not and maybe upload a separate patch for it.


I'll take a closer look and see if it can be implemented in that way. My only worry (without having looked at it closer yet)  is the fact that "no unit" is passed around as the literal "1".TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Dalba, Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Ricordisamoa, Wesalius, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T150210: Make WbQuantity handle case without errors

2017-01-19 Thread Lokal_Profil 
Lokal_Profil added a comment.

In T150210#2953586, @Holger wrote:
Is this fix already in 2.0rc5?
 Getting this error in lots of places.
 Thanks :)


This is not in the PyPI version sadly. You'll need to get the git master from gerrit or the github mirro (you can still use pip with that url). For more details see T152907 and T106121TASK DETAILhttps://phabricator.wikimedia.org/T150210EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Holger, daniel, Magul, ChongDae, Strainu, gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Ricordisamoa, Wesalius, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T139749: password_file in user-config does not respect -dir flag

2016-08-19 Thread Lokal_Profil 
Lokal_Profil added a project: Pywikibot-login.py.
TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, Aklapper, Zppix, Lokal_Profil, pywikibot-bugs-list, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T102477: login script -pass parameter ignored

2016-08-19 Thread Lokal_Profil 
Lokal_Profil added a comment.
Is this still open or did the patch fix it?

If still open could it be merged with T108848?TASK DETAILhttps://phabricator.wikimedia.org/T102477EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Lokal_Profil, revi, gerritbot, Xqt, Shloub, Aklapper, pywikibot-bugs-list, XZise, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T124466: Support logging in with Special:BotPassword passwords

2016-08-19 Thread Lokal_Profil 
Lokal_Profil added a comment.
Duplicate of T143417 (or can that be considered a subtask)?TASK DETAILhttps://phabricator.wikimedia.org/T124466EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Lokal_Profil, jayvdb, Liuxinyu970226, Alkamid, Aklapper, StudiesWorld, valhallasw, pywikibot-bugs-list, Mdupont, JJMC89___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil 
Lokal_Profil added a comment.
If we go for this solution we should not forget to #pywikibot-announce it afterwards.TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, valhallasw, Aklapper, Lokal_Profil, pywikibot-bugs-list, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T139749: password_file in user-config does not respect -dir flag

2016-08-19 Thread Lokal_Profil 
Lokal_Profil added a comment.
If we go for this solution we should not forget to #pywikibot-announce it afterwards since there are rare situations where the fix (despite backwards compatibility) might break existing set-ups.TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, Aklapper, Zppix, Lokal_Profil, pywikibot-bugs-list, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Claimed] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil 
Lokal_Profil claimed this task.Lokal_Profil added a comment.
Might have a first attemptTASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: valhallasw, Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil 
Lokal_Profil created this task.Lokal_Profil added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONWhenever (edit) tokens are checked there is also also an assert self.site.user() to ensure that the user is (still) logged-in.

Unfortunately this does not handle usernames from BotPasswords (i.e. @).TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Unassigned] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil 
Lokal_Profil removed Lokal_Profil as the assignee of this task.Lokal_Profil added a comment.
My guess is that this needs to be fixed over in pywikibot/tools/__init__.py:DeprecatedRegex.normalize_username() in order to be handled correctly everywhere (several other functions make the same assumption).

But normalize_username() is also used in login.py:LoginManager.readPassword() where we actually want the full username and somewhere else which I have yet to identify.TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Triaged] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil 
Lokal_Profil triaged this task as "High" priority.Lokal_Profil added a comment.
per T142623TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil 
Lokal_Profil added a parent task: T139492: Switch Erfgoedbot over to BotPassword or OAuth.
TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: valhallasw, Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil 
Lokal_Profil added a comment.

In T143417#2567601, @Lokal_Profil wrote:
My guess is that this needs to be fixed over in pywikibot/tools/__init__.py:DeprecatedRegex.normalize_username() in order to be handled correctly everywhere (several other functions make the same assumption).

But normalize_username() is also used in login.py:LoginManager.readPassword() where we actually want the login_name and somewhere else which I have yet to identify.


The other place is in site.py:APISite.login.py() where we call on LoginManager and need to do so with the login_name.TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Edited] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil 
Lokal_Profil edited the task description. (Show Details)
EDIT DETAILS...Unfortunately this does not handle usernames from BotPasswords (i.e. `@`, `@`)which I will call login_name to avoid confusion).TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil 
Lokal_Profil added a comment.

In T143417#2567648, @Lokal_Profil wrote:

In T143417#2567601, @Lokal_Profil wrote:
My guess is that this needs to be fixed over in pywikibot/tools/__init__.py:DeprecatedRegex.normalize_username() in order to be handled correctly everywhere (several other functions make the same assumption).

But normalize_username() is also used in login.py:LoginManager.readPassword() where we actually want the login_name and somewhere else which I have yet to identify.


The other place is in site.py:APISite.login.py() where we call on LoginManager and need to do so with the login_name.


Found one more place  (which you hit if you e.g. do repo = pywikibot.Site().data_repository()).

In __init__.py.Site() user is passed through normalize_username before it is sent on to interface() where it at a later point ends up triggering a login. attempt suing the username ratehr than the login_nameTASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: valhallasw, Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil 
Lokal_Profil added a comment.

In T143417#2567675, @valhallasw wrote:
I think the main thing is to separate the user name and the login name, and thus separating the username from the suffix. I'm inclined to say that the '@suffix' API wasn't a great design -- the suffix should have been part of the password rather than the user name.


I'm inclined to agree. I think that is the gist of T139492.

As far as pywikibot is concerned, I would actually suggest to do that, at least conceptually. In user-config, we would just store the username, but in the passwordfile, we would store an object BotPassword('suffix', 'password') instead of just the password. (I'm not sure how this would map to manual logins, but those don't really make sense in the context of botpasswords anyway). This could then also extend to OAuth, where the password would be an OAuthAsPassword(...) object which stores the oauth data.

Conceptually that is quite nice since we make a clear distinction between username and login_name.

At the same time, I'm not sure how the botpassword support is currently implemented, but I think the password file is directly available to LoginManager, and LoginManager is the only one that needs to know the details of how the user is logging in.

After diving down the rabbit hole which logging in and passing around of the username is I think that re-gigging LoginManager to clearly separate uername and login_name and then have readPassword() overriding login_name with the suffixed username is probably the way forward.

That way we could also drop the BotPassword fix in check_user_exists.

I'm not sure I know the inner workings well enough to fix this myself though.TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: valhallasw, Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Closed] T143478: flake8-coding 1.3 does not work with flake8 < 3

2016-08-20 Thread Lokal_Profil 
Lokal_Profil closed this task as "Resolved".Lokal_Profil removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T143478EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, Lokal_ProfilCc: gerritbot, TerraCodes, Luke081515, jayvdb, Aklapper, Xqt, pywikibot-bugs-list, Mdupont, JJMC89___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T139749: password_file in user-config does not respect -dir flag

2016-08-20 Thread Lokal_Profil 
Lokal_Profil edited projects, added Pywikibot-Announce; removed Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, Aklapper, Zppix, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T131624: add WbTime.today() to pywikibot

2016-08-20 Thread Lokal_Profil 
Lokal_Profil added a comment.
Thanks for the feedback @jayvdb I've implemented the suggestions in a new patch-set.TASK DETAILhttps://phabricator.wikimedia.org/T131624EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, jayvdb, Xqt, Aklapper, Lokal_Profil, pywikibot-bugs-list, Lewizho99, Mdupont, JJMC89, Maathavan, Ricordisamoa___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T139749: password_file in user-config does not respect -dir flag

2016-08-21 Thread Lokal_Profil 
Lokal_Profil added a comment.

In T139749#2569985, @Octahedron80 wrote:
Now "python pwb.py login" is unable to login. Please check. (I am not sure if it is caused by this patch)


Which error message do you get? Are you using a password_file? The should be backwards compatible in all but a few very rare cases.TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Octahedron80, gerritbot, Aklapper, Zppix, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T139749: password_file in user-config does not respect -dir flag

2016-08-22 Thread Lokal_Profil 
Lokal_Profil added a comment.
Don't think it is due to this patch since the code is only triggered when you have password_file in your user-config.py.

When I try python pwb.py login I get a normal login prompt so most likely it is something local on your machine which has changed. If not then I'd open a new ticket for your issue.TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Octahedron80, gerritbot, Aklapper, Zppix, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T150210: Make WbQuantity handle case without errors

2017-02-28 Thread Lokal_Profil 
Lokal_Profil added a comment.
Per T150210#2954454 you will need to raise this on the tasks for making a new release. At this point 2.0r5 is so far behind master that it might not be possible to reliably backport individual patches.TASK DETAILhttps://phabricator.wikimedia.org/T150210EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Mike_Peel, Holger, daniel, Magul, ChongDae, Strainu, gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, jayvdb, Ricordisamoa, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T159280: Update the version of pywikibot that is available through pip

2017-03-02 Thread Lokal_Profil 
Lokal_Profil added a comment.
For  previous tasks which touch on this see
T152907: Release a new version of pywikibot and T106121: RFC removing old code / code cleanup.TASK DETAILhttps://phabricator.wikimedia.org/T159280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Lokal_Profil, Aklapper, pywikibot-bugs-list, Mike_Peel___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T139749: password_file in user-config does not respect -dir flag

2016-08-25 Thread Lokal_Profil 
Lokal_Profil added a comment.
Can be resolved once announced (or if we decide not to announce)TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Octahedron80, gerritbot, Aklapper, Zppix, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T124466: Support logging in with Special:BotPassword passwords

2016-08-25 Thread Lokal_Profil 
Lokal_Profil edited projects, added Pywikibot-Announce; removed Patch-For-Review.Lokal_Profil added a comment.
Adding the #Pywikibot-Announce since information should go out to users that this is how BotPasswordes should now be stored/entered. Can ideally be bundled with an announcement for T139749 (which might be a breaking change in certain edge cases).TASK DETAILhttps://phabricator.wikimedia.org/T124466EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, Lokal_Profil, jayvdb, Liuxinyu970226, Alkamid, Aklapper, StudiesWorld, valhallasw, pywikibot-bugs-list, Mdupont, JJMC89___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Closed] T143417: assert self.site.user() fails when using BotPasswords

2016-08-25 Thread Lokal_Profil 
Lokal_Profil closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, valhallasw, Aklapper, Lokal_Profil, pywikibot-bugs-list, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T143905: Add support for BotPasswords in generate_user_files.py

2016-08-25 Thread Lokal_Profil 
Lokal_Profil created this task.Lokal_Profil added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONBotPasswords (i.e. Special:BotPasswords) are only fully supported via the password_file parameter in user-config.py.

It would therefore be nice if generate_user_files.py could support this too.TASK DETAILhttps://phabricator.wikimedia.org/T143905EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: valhallasw, Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T143594: Add unit support to WbQuantity

2016-08-22 Thread Lokal_Profil 
Lokal_Profil created this task.Lokal_Profil added projects: Pywikibot-core, Pywikibot-Wikidata.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONBack in T112130 we ensured that pywikibot no longer crashes when it encounters an item with units. However we still don't support actually dealing with WbQuantity claims that have units.

That should be changed.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb, Ricordisamoa___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T143594: Add unit support to WbQuantity

2016-08-22 Thread Lokal_Profil 
Lokal_Profil added a subscriber: Ladsgroup.Lokal_Profil added a comment.

In T112130#1628026, @Ladsgroup wrote:
[...] we need to discuss on how we want to handle units, we can have Entity class and subclass ItemPage and other pages (alongside with Page) OR we can have unit, calender model and globes as a general class named IRI(?) which are subclassed ItemPage.


TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb, Ricordisamoa___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity

2016-08-22 Thread Lokal_Profil 
Lokal_Profil added a comment.
One thing which could help would be if entity_prefix was added to siteinfo (cf. articlepath). That way we could at least easily construct entity references (cf. BasePage.full_url()) for items in (known) wikibase repositories.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity

2016-08-22 Thread Lokal_Profil 
Lokal_Profil added a comment.

In T143594#2572898, @gerritbot wrote:
Change 306037 had a related patch set uploaded (by Lokal Profil):
 Support adding units to WbQuantity through the entity url

https://gerrit.wikimedia.org/r/306037


This only adds the ability to add the entity url directly (compare to Coordinate). We still need to figure out how we want to use the unit parameter.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Claimed] T139749: password_file in user-config does not respect -dir flag

2016-08-25 Thread Lokal_Profil 
Lokal_Profil claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Octahedron80, gerritbot, Aklapper, Zppix, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity

2016-10-02 Thread Lokal_Profil 
Lokal_Profil added a comment.
The current patch is the first step in being able to add units using their Qids instead of entity_urls (same set-up as for globe in Coordinates).

it is also true that the documentation didn't reflect what was happening. This patch also fixes that.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T143594: Add unit support to WbQuantity

2016-10-10 Thread Lokal_Profil 
Lokal_Profil added a comment.

In T143594#2704023, @Multichill wrote:
@Lokal_Profil would be nice if instead of an url, you could just pass an ItemPage object. That would be a good abstraction. For that the ItemPage does need to have a function that returns an entity url like http://www.wikidata.org/entity/Q3123


That would be the child task T143910. I'v made a patch to wikibase which would expose http://www.wikidata.org/entity/to the api. The patch here is in preparation for allowing either the ItemPage or the uri to be passed on creation.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa, Wesalius, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T150210: Make WbQuantity handle case without errors

2016-11-07 Thread Lokal_Profil 
Lokal_Profil created this task.Lokal_Profil added projects: Pywikibot-core, Pywikibot-Wikidata.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONT115269 means that
in addition to

"datavalue":{
  "value":{
"amount":"+700",
"unit":"1",
"upperBound":"+710",
"lowerBound":"+690"
  },
  "type":"quantity"
},

clients may now also encounter this:

"datavalue":{
  "value":{
"amount":"+700",
"unit":"1"
  },
  "type":"quantity"
},

WbQuantity should both be able to handle this and we should ensure that we don't add errors unless they are explicitly set.

Before deploying this should be announced on the mailing list as some users may rely on the current error=None -> +/-0 "feature".TASK DETAILhttps://phabricator.wikimedia.org/T150210EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Aklapper, Lokal_Profil, pywikibot-bugs-list, MayS, Mdupont, JJMC89, jayvdb, Ricordisamoa, Wesalius, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T100903: Run pywikibot test suite regularly on beta cluster as part of MediaWiki/Wikimedia CI

2016-11-09 Thread Lokal_Profil 
Lokal_Profil added a comment.
Does this also manage to run the wikibase tests on wikidata.beta.wmflabs.org or is it limited to just the wikipedia family?TASK DETAILhttps://phabricator.wikimedia.org/T100903EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Lokal_Profil, Luke081515, Legoktm, gerritbot, Ricordisamoa, hashar, mmodell, greg, pywikibot-bugs-list, jayvdb, Aklapper, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Alchimista, Rxy, Jay8g, Krenair___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T142155: Bot can't login. keyError in GetCookie

2016-11-09 Thread Lokal_Profil 
Lokal_Profil added a comment.
I don't think the BotPasswords patch is part of the 2.0rc5 release (since it was released two days before that patch).

I'm actually don't think it is in the 2.0 branch at all (where login.py hasn't been changed since 2015).TASK DETAILhttps://phabricator.wikimedia.org/T142155EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Legoktm, Lokal_ProfilCc: Vladis13, Gallicbot, Krinkle, MZMcBride, Jay8g, revi, Paladox, Aschroet, zhuyifei1999, Stashbot, gerritbot, DrTrigon, Betacommand, Lokal_Profil, Tgr, Legoktm, JJMC89, Yamaha5, jayvdb, Ladsgroup, Xqt, valhallasw, Multichill, Anomie, CodeCat, TerraCodes, Luke081515, He7d3r, Basilicofresco, Jagwar, MarcoAurelio, Dalba, Aklapper, Joutbis, pywikibot-bugs-list, MayS, Mdupont, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

  1   2   3   >