[Pywikipedia-bugs] [Maniphest] [Updated] T349599: Translation updates to pywikibot are blocked: pywikibot-i18n-tox-docker has started failing
hashar added a comment. It is possible that CI injecting `TOX_OVERRIDE=testenv.pass_env=XDG_CACHE_HOME,testenv.set_env=PY_COLORS=1` cause it to completely override `pass_env` and `set_env` set in the repo `tox.ini` :-\That was done as part of T348871: tox v4 replacement for TOX_TESTENV_PASSENV <https://phabricator.wikimedia.org/T348871> and I commented about that issue on that task. The tox v4 upgrade is unfortunately not straightforward. TASK DETAIL https://phabricator.wikimedia.org/T349599 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, hashar Cc: Xqt, hashar, Aklapper, pywikibot-bugs-list, Nikerabbit, mevo, Dominika_Naumiuk, Wangombe, PotsdamLamb, PallaviPatke, Jyoo1011, JohnsonLee01, SHEKH, Peteosx1x, Dijkstra, Rileych, Khutuck, Mgagat, Totolinototo3, Zkhalido, 50019062, Zanziii, Sadisticturd, Viztor, Wenyi, Tbscho, srishakatux, MayS, Mdupont, JJMC89, Dvorapa, Soum213, Altostratus, Taiwania_Justo, Avicennasis, mys_721tx, jayvdb, Masti, Arrbee, santhosh, KartikMistry, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T349599: Translation updates to pywikibot are blocked: pywikibot-i18n-tox-docker has started failing
hashar added a comment. In T349599#9308529 <https://phabricator.wikimedia.org/T349599#9308529>, @Xqt wrote: > @hashar: Does the `TOX_OVERRIDE=testenv.pass_env=XDG_CACHE_HOME,testenv.set_env=PY_COLORS=1` override the tox setenv? With tox v4 yes possibly :-( Looks like it is better to set the environment variable in the shell script as you have proposed! TASK DETAIL https://phabricator.wikimedia.org/T349599 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, hashar Cc: Xqt, hashar, Aklapper, pywikibot-bugs-list, Nikerabbit, mevo, Isabelladantes1983, Themindcoder, Dominika_Naumiuk, Adamm71, Jersione, Hellket777, LisafBia6531, Wangombe, 786, Biggs657, PotsdamLamb, PallaviPatke, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Peteosx1x, Dijkstra, Alter-paule, Beast1978, Rileych, Un1tY, Khutuck, Mgagat, Totolinototo3, Zkhalido, 50019062, Hook696, Kent7301, Zanziii, Sadisticturd, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, srishakatux, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Soum213, Altostratus, Taiwania_Justo, Neuronton, Avicennasis, mys_721tx, jayvdb, Masti, Arrbee, santhosh, KartikMistry, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Updated] T301037: Add pypy 3 to CI build machines
hashar added a comment. (blocked on T345695: Deal with tox 4 upgrading <https://phabricator.wikimedia.org/T345695> cause the new images are now using tox v4 and we gotta migrate the repositories before being able to add new packages) TASK DETAIL https://phabricator.wikimedia.org/T301037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: jBond_WMF, hashar, Aklapper, Xqt, pywikibot-bugs-list, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, PotsdamLamb, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Neuronton, binbot, Avicennasis, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Jay8g ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Updated] T301037: Add pypy 3 to CI build machines
hashar added a subtask: T345695: Deal with tox 4 upgrading. TASK DETAIL https://phabricator.wikimedia.org/T301037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: jBond_WMF, hashar, Aklapper, Xqt, pywikibot-bugs-list, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, PotsdamLamb, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Neuronton, binbot, Avicennasis, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Jay8g ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T301037: Add pypy 3 to CI build machines
hashar added a comment. Looks like `pypy` has always been in the CI tox image. It got created in 2017 based on Jessie and the original change did install the `pypy` package ( https://gerrit.wikimedia.org/r/c/integration/config/+/377337 ). That got carried in the `releng/tox-buster` image created in https://gerrit.wikimedia.org/r/c/integration/config/+/643776 and the package is still present: $ docker run --pull --rm -it --entrypoint=pypy docker-registry.wikimedia.org/releng/tox-buster:latest --version Python 2.7.13 (7.0.0+dfsg-3, Mar 24 2019, 15:30:18) [PyPy 7.0.0 with GCC 8.3.0] With Debian providing: | Buster | 7.0.0 | | Bullseye | 7.3.3 | | Bookworm | | | What stands out is `pypy` reports `Python 2.7.13` and I guess virtualenv dropped support for that a while ago or fails to recognize it. I am guessing the package should probably be removed. pywikibot/core removed `pypy` from tox back in 2020 with https://gerrit.wikimedia.org/r/c/pywikibot/core/+/609486 . I guess we can add to the image the `pypy3` package? root@597df94b208f:/src# pypy3 --version Python 3.5.3 (7.0.0+dfsg-3, Feb 21 2019, 03:51:22) [PyPy 7.0.0 with GCC 8.2.0] TASK DETAIL https://phabricator.wikimedia.org/T301037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: jBond_WMF, hashar, Aklapper, Xqt, pywikibot-bugs-list, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, binbot, Avicennasis, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Jay8g ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Edited] T346238: tox v4 with skipsdist=true does not recognize use_develop=true
hashar updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: pywikibot-bugs-list, Aklapper, hashar, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, TheReadOnly, Biggs657, PotsdamLamb, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Peteosx1x, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Mgagat, Totolinototo3, Zkhalido, Hook696, Kent7301, Zanziii, Sadisticturd, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Neuronton, Avicennasis, Liudvikas, thcipriani, mys_721tx, Xqt, jayvdb, Masti, Alchimista, Krenair ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Edited] T346238: tox v4 with skipsdist=true does not recognize use_develop=true
hashar updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: pywikibot-bugs-list, Aklapper, hashar, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, TheReadOnly, Biggs657, PotsdamLamb, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Peteosx1x, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Mgagat, Totolinototo3, Zkhalido, Hook696, Kent7301, Zanziii, Sadisticturd, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Neuronton, Avicennasis, Liudvikas, thcipriani, mys_721tx, Xqt, jayvdb, Masti, Alchimista, Krenair ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T346238: tox v4 with skipsdist=true does not recognize use_develop=true
hashar added a comment. As far as I can tell, the three affected repositories are pywikibot/core integration/quibble integration/tox-jenkins-override (ironically created as part of migrating to tox v4) TASK DETAIL https://phabricator.wikimedia.org/T346238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: pywikibot-bugs-list, Aklapper, hashar, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, TheReadOnly, Biggs657, PotsdamLamb, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Peteosx1x, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Mgagat, Totolinototo3, Zkhalido, Hook696, Kent7301, Zanziii, Sadisticturd, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Neuronton, Avicennasis, Liudvikas, thcipriani, mys_721tx, Xqt, jayvdb, Masti, Alchimista, Krenair ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Edited] T346238: tox v4 with skipsdist=true does not recognize use_develop=true
hashar updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: pywikibot-bugs-list, Aklapper, hashar, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, TheReadOnly, Biggs657, PotsdamLamb, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Peteosx1x, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Mgagat, Totolinototo3, Zkhalido, Hook696, Kent7301, Zanziii, Sadisticturd, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Neuronton, Avicennasis, Liudvikas, thcipriani, mys_721tx, Xqt, jayvdb, Masti, Alchimista, Krenair ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Edited] T346238: tox v4 with skipsdist=true does not recognize use_develop=true
hashar updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: pywikibot-bugs-list, Aklapper, hashar, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, TheReadOnly, Biggs657, PotsdamLamb, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Peteosx1x, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Mgagat, Totolinototo3, Zkhalido, Hook696, Kent7301, Zanziii, Sadisticturd, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Neuronton, Avicennasis, Liudvikas, thcipriani, mys_721tx, Xqt, jayvdb, Masti, Alchimista, Krenair ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Edited] T346238: tox v4 with skipsdist=true does not recognize use_develop=true
hashar updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: pywikibot-bugs-list, Aklapper, hashar, TheReadOnly, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Peteosx1x, Dijkstra, Khutuck, Mgagat, Totolinototo3, Zkhalido, Zanziii, Sadisticturd, Viztor, NebulousIris, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, Xqt, jayvdb, Masti, Alchimista, Krenair ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Edited] T346238: tox v4 with skipsdist=true does not recognize use_develop=true
hashar updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: pywikibot-bugs-list, Aklapper, hashar, TheReadOnly, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Peteosx1x, Dijkstra, Khutuck, Mgagat, Totolinototo3, Zkhalido, Zanziii, Sadisticturd, Viztor, NebulousIris, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, Xqt, jayvdb, Masti, Alchimista, Krenair ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Edited] T346238: tox v4 with skipsdist=true does not recognize use_develop=true
hashar updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: pywikibot-bugs-list, Aklapper, hashar, TheReadOnly, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Peteosx1x, Dijkstra, Khutuck, Mgagat, Totolinototo3, Zkhalido, Zanziii, Sadisticturd, Viztor, NebulousIris, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, Xqt, jayvdb, Masti, Alchimista, Krenair ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T347026: Drop support for Python 3.6
hashar added a comment. > **drop support for Python 3.5 with Pywikibot 9.0** @Xqt the part in bold refers to 3.5, I guess you were meaning 3.6? TASK DETAIL https://phabricator.wikimedia.org/T347026 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hashar, matej_suchanek, Legoktm, JJMC89, Salween, Huji, Lee, Euku, Larske, kscanne, Basilicofresco, Rubin16, Multichill, valhallasw, Dvorapa, Dalba, Framawiki, Mpaa, Strainu, taavi, Ricordisamoa, MarcoAurelio, Aklapper, Xqt, pywikibot-bugs-list, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T346238: tox v4 with skipsdist=true does not recognize use_develop=true
hashar added a comment. With tox 4, `skipsdist = True` cause it to always skip the package installation (`package=skip`) regardless of the value of `usedevelop` which is not even recognized when skipsdist is set. We should thus remove it. With both tox v3 and v4, `usedevelop` causes the `sdist` to be skipped. Side track: when we don't even need the package to be installed (eg to run flake8) we can use `skip_install = True` instead of `usedevelop = True`. Ideally we should have at least one environment running `sdist` to ensure it is working. I have done that in Quibble with tox v3: [testenv:check] skipsdist = False usedevelop = False For tox v4 and removing `skipsdist` entirely, I guess `usedevelop=False` is sufficient and once migrated to tox v4 we can use: `package = sdist`. `usedevelop` can later be changed to `package = editable`. TASK DETAIL https://phabricator.wikimedia.org/T346238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: pywikibot-bugs-list, Aklapper, hashar, TheReadOnly, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Peteosx1x, Dijkstra, Khutuck, Mgagat, Totolinototo3, Zkhalido, Zanziii, Sadisticturd, Viztor, NebulousIris, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, Xqt, jayvdb, Masti, Alchimista, Krenair ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T346238: tox v4 with skipsdist=true does not recognize use_develop=true
hashar added a comment. I filed this one solely for tracking purpose. I intend to do all the debug/code/solution on #upstream <https://phabricator.wikimedia.org/tag/upstream/> https://github.com/tox-dev/tox/issues/2730 . The reason is the issue affects other projects, notably OpenStack / OpenDev from which came the `skipsdist` and `usedevelop` settings back in 2013 and they still rely on them. TASK DETAIL https://phabricator.wikimedia.org/T346238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: pywikibot-bugs-list, Aklapper, hashar, TheReadOnly, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Peteosx1x, Dijkstra, Khutuck, Mgagat, Totolinototo3, Zkhalido, Zanziii, Sadisticturd, Viztor, NebulousIris, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, Xqt, jayvdb, Masti, Alchimista, Krenair ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Created] T346238: tox v4 with skipsdist=true does not recognize use_develop=true
hashar created this task. hashar added projects: Continuous-Integration-Config, Release-Engineering-Team (Priority Backlog ), Pywikibot, Upstream. Restricted Application added a subscriber: pywikibot-bugs-list. TASK DESCRIPTION When skipping the package installation with `skipsdist=true` it is then impossible to install it in editable mode in a testenv. Given: name=tox.ini [tox] skipsdist = true [testenv:py3] use_develop = true With tox v4: $ tox -e py3 --showconf|grep use_develop # !!! unused: use_develop With tox v3 that does not work either: $ tox -e py3 --showconf|grep develop usedevelop = False But works when dropping the underscore (`usedevelop = true`): name=tox.ini [tox] skipsdist = true [testenv:py3] usedevelop = true $ tox -e py3 --showconf|grep develop usedevelop = True This affects the migration of #pywikibot <https://phabricator.wikimedia.org/tag/pywikibot/> to tox v4. I believe #upstream <https://phabricator.wikimedia.org/tag/upstream/> issue is tox4: The usedevelop ineffective with skipsdist / editable package not present in virtual environment #2730 <https://github.com/tox-dev/tox/issues/2730>. TASK DETAIL https://phabricator.wikimedia.org/T346238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: pywikibot-bugs-list, Aklapper, hashar, TheReadOnly, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Peteosx1x, Dijkstra, Khutuck, Mgagat, Totolinototo3, Zkhalido, Zanziii, Sadisticturd, Viztor, NebulousIris, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, Xqt, jayvdb, Masti, Alchimista, Krenair ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T117570: Jenkins output for pywikibot job is hard to read
hashar added a comment. In T117570#8742792 <https://phabricator.wikimedia.org/T117570#8742792>, @JJMC89 wrote: > The documentation <https://flake8.pycqa.org/en/6.0.0/user/options.html#cmdoption-flake8-color> says that the color option cannot be specified in config files, so it must be specified on the command line. Great finding! Thank you very much ;) TASK DETAIL https://phabricator.wikimedia.org/T117570 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: JJMC89, hashar, Dvorapa, zhuyifei1999, fgiunchedi, Xqt, jayvdb, gerritbot, Ricordisamoa, XZise, Aklapper, StudiesWorld, valhallasw, pywikibot-bugs-list, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, PotsdamLamb, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Peteosx1x, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Mgagat, Totolinototo3, Zkhalido, Hook696, Kent7301, Zanziii, Sadisticturd, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Framawiki, Lewizho99, Mdupont, Maathavan, Altostratus, Neuronton, binbot, Avicennasis, mys_721tx, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T117570: Jenkins output for pywikibot job is hard to read
hashar added a comment. Short of figuring the issue in `flake8`, the command line can be passed `--color=always` and that should work on CI. One can then confirm locally by invoking `tox -e flake8-p39|cat` against a workspace that has some flake8 issues. TASK DETAIL https://phabricator.wikimedia.org/T117570 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hashar, Dvorapa, zhuyifei1999, fgiunchedi, Xqt, jayvdb, gerritbot, Ricordisamoa, XZise, Aklapper, StudiesWorld, valhallasw, pywikibot-bugs-list, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Peteosx1x, Dijkstra, Khutuck, Mgagat, Totolinototo3, Zkhalido, Zanziii, Sadisticturd, Viztor, Wenyi, Tbscho, MayS, Framawiki, Mdupont, JJMC89, Altostratus, binbot, Avicennasis, mys_721tx, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T117570: Jenkins output for pywikibot job is hard to read
hashar added a comment.
In a lot of case the tools check whether the standard input is a TTY
(`sys.stdint.isatty()`) and disable color output when it is not. On CI the
containers are spawned without a pseudo tty allocate (`docker run -t`) cause
some other tooling might then prompt the user for some input (example: `Really
proceed [Y\n]`), which Jenkins can't reply to (it is not an AI yet).
And indeed looking at the tip of flake8 code:
class BaseFormatter:
...
self.color = options.color == "always" or (
options.color == "auto"
and sys.stdout.isatty()
and _windows_color.terminal_supports_color
)
To get coloring one should thus use `flake8 --color=always`. Then looking at
`pywikibot/core` it has:
name=tox.ini
[flake8]
color = always
Which I am guessing is not taken in account? If I run flake8 with some
increased verbosity:
$ tox -e flake8-py39 -- - pywikibot/echo.py |grep -i colo
flake8.options.managerMainProcess124 DEBUGRegistered option
"Option(--color, default='auto', choices=('auto', 'always', 'never'),
help='Whether to use color in output. Defaults to `%(default)s`.')".
flake8.options.config MainProcess127 DEBUGOption "color" is not
registered. Ignoring.
^^
It shows a few others:
flake8.options.config MainProcess129 DEBUGOption
"enable-extensions" is not registered. Ignoring.
flake8.options.config MainProcess129 DEBUGOption "color" is not
registered. Ignoring.
flake8.options.config MainProcess129 DEBUGOption "ignore_regex"
is not registered. Ignoring.
They all three come from the repository `tox.ini`:
name=tox.ini
[flake8]
enable-extensions = H203,H204,H205,N818
color = always
ignore_regex=:keyword
And if I had a `hashar_option = hack` the same shows up for it `Option
"hashar_option" is not registered. Ignoring.`.
So it looks like flake8 has a bug which is that it does not recognizes some
options from tox.ini, possibly cause they got renamed (color > colour?) or they
somehow forgot to handle them.
//For the `releng/tox` images, the entry point invokes tox with `PY_COLORS=1`
which I thing was for pip and nose test maybe but that is not recognized by
flake8//
TASK DETAIL
https://phabricator.wikimedia.org/T117570
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: hashar
Cc: hashar, Dvorapa, zhuyifei1999, fgiunchedi, Xqt, jayvdb, gerritbot,
Ricordisamoa, XZise, Aklapper, StudiesWorld, valhallasw, pywikibot-bugs-list,
PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Peteosx1x, Dijkstra, Khutuck,
Mgagat, Totolinototo3, Zkhalido, Zanziii, Sadisticturd, Viztor, Wenyi, Tbscho,
MayS, Framawiki, Mdupont, JJMC89, Altostratus, binbot, Avicennasis, mys_721tx,
Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Updated] T277396: Lint test to match function signature and documentation
hashar removed a project: Release-Engineering-Team (Seen). TASK DETAIL https://phabricator.wikimedia.org/T277396 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: atagar, Dvorapa, Ebrahim, Xqt, DannyS712, Aklapper, Huji, pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, TheReadOnly, NebulousIris, Liudvikas, thcipriani ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T286336: Increase test time for Pywikibot deeptest
hashar added a comment. I have updated the build timeout from 15 to 30 minutes. TASK DETAIL https://phabricator.wikimedia.org/T286336 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hashar, Aklapper, pywikibot-bugs-list, Legoktm, Xqt, Biggs657, Lalamarie69, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Jay8g ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Updated] T285032: Move pywikibot CI from travis-ci.org to travis-ci.com
hashar removed a project: Continuous-Integration-Infrastructure. TASK DETAIL https://phabricator.wikimedia.org/T285032 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Ladsgroup, Legoktm, Rubin16, hashar, Aklapper, Xqt, pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, thcipriani, Jay8g ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Closed] T100670: pywikibot/i18n lacks a license
hashar assigned this task to revi. hashar closed this task as "Resolved". hashar added a comment. Restricted Application added a project: User-revi. I am triaging some tasks I have created years ago. In T100670#1673977 <https://phabricator.wikimedia.org/T100670#1673977>, @revi wrote: > Translations on TWN are licensed under CC BY 3.0 according to TWN Project:About <https://translatewiki.net/wiki/Project:About#Copyright_and_disclaimers>. > >> Translations by translators are licensed CC BY 3.0, and derivative works may also be licensed under the licenses of the respective Free and Open Source projects the translations have been or will be added to. Content of user pages are considered to be "All rights reserved" by the author. All other content is licensed CC BY 3.0 unless a different license or copyright is stated explicitly. That covers my original request which was: which licensing is used?. TASK DETAIL https://phabricator.wikimedia.org/T100670 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: revi, hashar Cc: greg, revi, jayvdb, Ricordisamoa, pywikibot-bugs-list, hashar, Aklapper, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, Slaporte, Masti, Alchimista, Jay8g, Legoktm ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Updated] T100903: Run pywikibot test suite regularly on beta cluster as part of MediaWiki/Wikimedia CI
hashar removed projects: Release-Engineering-Team (Seen), Continuous-Integration-Config, Continuous-Integration-Infrastructure. TASK DETAIL https://phabricator.wikimedia.org/T100903 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Dvorapa, Lokal_Profil, Luke081515, Legoktm, gerritbot, Ricordisamoa, hashar, mmodell, greg, pywikibot-bugs-list, jayvdb, Aklapper, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, CptViraj, Majavah, Viztor, DannyS712, Wenyi, Bsandipan, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Jay8g, Krenair, Mgagat, Totolinototo3, Redabr4, Zanziii, Sadisticturd, NebulousIris, A.S.Kochergin, Liudvikas, thcipriani ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Updated] T255981: Persistant error 500 getting category members
hashar removed a project: Release-Engineering-Team. TASK DETAIL https://phabricator.wikimedia.org/T255981 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Jeff_G, Pigsonthewing, Eatcha, RhinosF1, Xover, CDanis, matej_suchanek, Xqt, Stefan2, ShakespeareFan00, Aklapper, Fae, pywikibot-bugs-list, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Naike, Dijkstra, Muchiri124, CBogen, Khutuck, Zkhalido, eprodromou, Viztor, Wenyi, Amorymeltzer, Ramsey-WMF, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Poyekhali, Agabi10, Altostratus, Taiwania_Justo, Avicennasis, Pchelolo, Ixocactus, Wong128hk, mys_721tx, El_Grafo, Dinoguy1000, jayvdb, Masti, Alchimista, Steinsplitter, Krenair, Keegan, NebulousIris, Liudvikas, thcipriani ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Declined] T279817: TRAVIS jobs cannot be restarted anymore
hashar closed this task as "Declined". hashar added a comment. I guess that was a glitch on Travis side. If it happens again, I guess the best is to reach out to them directly, though I have no idea whether they offer support for Free plan. TASK DETAIL https://phabricator.wikimedia.org/T279817 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hashar, Rubin16, Aklapper, Xqt, pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, NebulousIris, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T279817: TRAVIS jobs cannot be restarted anymore
hashar added a comment. //K-and-R// looks like an organization and is unrelated. If I look at https://travis-ci.com/organizations/wikimedia/plan it states: IMPORTANT: Builds have been temporarily disabled for private and public repositories due to a negative credit balance. Please go to the Plan page to replenish your credit balance. That is the free plan which gives us: | Unlimited unique users | | 1 Credits | | We have 4 Unique users who are running builds but somehow went out of credits: //You have used 10420 of 1 credits// There is no usage listed over the last 3 months. I don't know anything about Travis plans though or what could be fixed if any :-\ TASK DETAIL https://phabricator.wikimedia.org/T279817 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hashar, Rubin16, Aklapper, Xqt, pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, NebulousIris, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T275750: doctest is not processed with jenkins CI tests
hashar added a project: Continuous-Integration-Config. hashar added a comment. I have deployed the CI config. TASK DETAIL https://phabricator.wikimedia.org/T275750 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Jdforrester-WMF, Legoktm, hashar, JanZerebecki, Aklapper, pywikibot-bugs-list, Xqt, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Mgagat, Totolinototo3, Zkhalido, Hook696, Redabr4, Kent7301, Zanziii, Sadisticturd, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, A.S.Kochergin, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T270389: Enable Pywikibot fasttest with Python 3.8 / Python 3.9
hashar added a comment. Sorry my comment was a bit short. The idea is to get python 3.8 packaged T24195 <https://phabricator.wikimedia.org/T24195>, I guess we should also migrate from Stretch to Buster and thus get the other python added :] That will happen eventually! TASK DETAIL https://phabricator.wikimedia.org/T270389 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hashar, Jdforrester-WMF, Aklapper, Xqt, pywikibot-bugs-list, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Mgagat, Totolinototo3, Zkhalido, Redabr4, Zanziii, Sadisticturd, Viztor, NebulousIris, Wenyi, A.S.Kochergin, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T270389: Enable Pywikibot fasttest with Python 3.8 / Python 3.9
hashar added a comment. We don't have Python 3.8 on the CI infrastructure yet. TASK DETAIL https://phabricator.wikimedia.org/T270389 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hashar, Jdforrester-WMF, Aklapper, Xqt, pywikibot-bugs-list, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Mgagat, Totolinototo3, Zkhalido, Redabr4, Zanziii, Sadisticturd, Viztor, NebulousIris, Wenyi, A.S.Kochergin, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T270389: Enable Pywikibot fasttest with Python 3.8 / Python 3.9
hashar added a subtask: T268850: Provide python 3.8 in CI test images. TASK DETAIL https://phabricator.wikimedia.org/T270389 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Jdforrester-WMF, Aklapper, Xqt, pywikibot-bugs-list, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Mgagat, Totolinototo3, Zkhalido, Redabr4, Zanziii, Sadisticturd, Viztor, NebulousIris, Wenyi, A.S.Kochergin, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy, hashar ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Declined] T57654: Recursive clone over ssh uses https for submodules
hashar closed this task as "Declined". TASK DETAIL https://phabricator.wikimedia.org/T57654 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: demon, Paladox, Xqt, Aklapper, jayvdb, valhallasw, pywikibot-bugs-list, Multichill, Ladsgroup, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, A.S.Kochergin, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, D3r1ck01, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy, Jay8g, Krenair, hashar, QChris ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T252310: pywikibot get merge rejections due to zuul-merger not being able to update tags
hashar closed this task as "Resolved". hashar added a comment. And I have restated zuul-scheduler. TASK DETAIL https://phabricator.wikimedia.org/T252310 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: elukey, zhuyifei1999, Jdforrester-WMF, Zoranzoki21, hashar, Urbanecm, Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, NebulousIris, Wenyi, Jayprakash12345, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, Liudvikas, Wong128hk, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Reopened] T252310: pywikibot get merge rejections due to zuul-merger not being able to update tags
hashar reopened this task as "Open". hashar added a subscriber: elukey. hashar added a comment. That is apparently not fully deployed. @elukey had the exact same issue today with analytics/refinery/source . contint2001 runs an outdated version of zuul. Guess I forgot to deploy it there :\ TASK DETAIL https://phabricator.wikimedia.org/T252310 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: elukey, zhuyifei1999, Jdforrester-WMF, Zoranzoki21, hashar, Urbanecm, Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, NebulousIris, Wenyi, Jayprakash12345, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, Liudvikas, Wong128hk, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T252310: pywikibot get merge rejections due to zuul-merger not being able to update tags
hashar closed this task as "Resolved". hashar added a comment. I ran `git fetch --tags --force` on both hosts. Zuul itself now uses `--force` as well. Should be good now :] TASK DETAIL https://phabricator.wikimedia.org/T252310 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: zhuyifei1999, Jdforrester-WMF, Zoranzoki21, hashar, Urbanecm, Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, NebulousIris, Wenyi, Jayprakash12345, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, Liudvikas, Wong128hk, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unblock] T252310: pywikibot get merge rejections due to zuul-merger not being able to update tags
hashar closed subtask T255424: Zuul deployment fails due to unsupported wheel as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T252310 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: zhuyifei1999, Jdforrester-WMF, Zoranzoki21, hashar, Urbanecm, Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, NebulousIris, Wenyi, Jayprakash12345, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, Liudvikas, Wong128hk, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T252310: pywikibot get merge rejections due to zuul-merger not being able to update tags
hashar added a comment. I have updated the `zuul-merger` on `contint1001.wikimedia.org`. I will do `contint2001.wikimedia.org` later on when CI is less busy. TASK DETAIL https://phabricator.wikimedia.org/T252310 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: zhuyifei1999, Jdforrester-WMF, Zoranzoki21, hashar, Urbanecm, Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, NebulousIris, Wenyi, Jayprakash12345, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, Liudvikas, Wong128hk, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T252310: pywikibot get merge rejections due to zuul-merger not being able to update tags
hashar added a subtask: T255424: Zuul deployment fails due to unsupported wheel. TASK DETAIL https://phabricator.wikimedia.org/T252310 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: zhuyifei1999, Jdforrester-WMF, Zoranzoki21, hashar, Urbanecm, Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, JohnsonLee01, SHEKH, Blissjay007, Dijkstra, Oblanco79, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Kent7301, Meekrab2012, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, Avicennasis, Liudvikas, Wong128hk, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T252310: pywikibot get merge rejections due to zuul-merger not being able to update tags
hashar added a comment. I will update Zuul in production when I get time ahead to properly monitor the deployment. It is not convenient for me to do so this morning due to hmm personal reasons. Hopefully this afternoon else later this evening (relative to Europe timezones). TASK DETAIL https://phabricator.wikimedia.org/T252310 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: zhuyifei1999, Jdforrester-WMF, Zoranzoki21, hashar, Urbanecm, Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, JohnsonLee01, SHEKH, Blissjay007, Dijkstra, Oblanco79, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Kent7301, Meekrab2012, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, Avicennasis, Liudvikas, Wong128hk, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Reopened] T252310: pywikibot get merge rejections due to zuul-merger not being able to update tags
hashar reopened this task as "Open". TASK DETAIL https://phabricator.wikimedia.org/T252310 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: zhuyifei1999, Jdforrester-WMF, Zoranzoki21, hashar, Urbanecm, Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, JohnsonLee01, SHEKH, Blissjay007, Dijkstra, Oblanco79, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Kent7301, Meekrab2012, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, Avicennasis, Liudvikas, Wong128hk, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T252310: pywikibot get merge rejections due to zuul-merger not being able to update tags
hashar added a comment.
Repro:
git --version # 2.20.1
pip2 install --user GitPython==2.1.11 gitdb2==2.0.5 smmap2==2.0.5
cd projects/pywikibot/core
python2
>>> import git
>>> repo = git.Repo('.')
>>> repo.remotes.origin.fetch(tags=True)
Traceback (most recent call last):
File "", line 1, in
File "git/remote.py", line 789, in fetch
res = self._get_fetch_info_from_stderr(proc, progress)
File "git/remote.py", line 675, in _get_fetch_info_from_stderr
proc.wait(stderr=stderr_text)
File "git/cmd.py", line 415, in wait
raise GitCommandError(self.args, status, errstr)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
cmdline: git fetch --tags -v origin
Passing `force=True` works:
>>> repo.remotes.origin.fetch(tags=True, force=True)
[, , ,
, , ,
, , ,
, , ,
, , ,
, , ,
, , ,
, , ,
, , ,
, , ]
TASK DETAIL
https://phabricator.wikimedia.org/T252310
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: hashar
Cc: zhuyifei1999, Jdforrester-WMF, Zoranzoki21, hashar, Urbanecm, Xqt,
Aklapper, pywikibot-bugs-list, Dvorapa, JohnsonLee01, SHEKH, Blissjay007,
Dijkstra, Oblanco79, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696,
Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Kent7301, Meekrab2012, joker88john,
Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22,
Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis,
Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906,
Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, Avicennasis, Liudvikas,
Wong128hk, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Jay8g
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Retitled] T252310: pywikibot get merge rejections due to zuul-merger not being able to update tags
hashar renamed this task from "Jenkins can't merge patchsets sometimes" to "pywikibot get merge rejections due to zuul-merger not being able to update tags". hashar claimed this task. hashar edited projects, added Zuul, Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), Release-Engineering-Team (CI & Testing services); removed Gerrit, Continuous-Integration-Config, Release-Engineering-Team. hashar updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T252310 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: zhuyifei1999, Jdforrester-WMF, Zoranzoki21, hashar, Urbanecm, Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, NebulousIris, Wenyi, Jayprakash12345, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, Liudvikas, Wong128hk, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Jay8g, Totolinototo3, Redabr4, Zanziii, Sadisticturd, DannyS712, A.S.Kochergin, D3r1ck01, Paladox, Krenair, QChris ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T252310: Jenkins can't merge patchsets sometimes
hashar added a comment.
That is the same as previously, whenever the `python2` or `stable` tags are
updated, git would plainly refuses to update them with the message: `would
clobber existing tag`:
contint2001:/srv/zuul/git/pywikibot/core$ sudo -u zuul git fetch --tags -v
origin
From ssh://gerrit.wikimedia.org:29418/pywikibot/core
...
! [rejected] python2 -> python2 (would clobber existing tag)
! [rejected] stable -> stable (would clobber existing tag)
$ echo $?
1
Which in git is emitted by:
static int update_local_ref( ... )
{
if (!is_null_oid(>old_oid) &&
starts_with(ref->name, "refs/tags/")) {
if (force || ref->force) {
int r;
r = s_update_ref("updating tag", ref, 0);
format_display(display, r ? '!' : 't', _("[tag
update]"),
r ? _("unable to update local ref")
: NULL,
remote, pretty_ref, summary_width);
return r;
} else {
format_display(display, '!', _("[rejected]"),
_("would clobber existing tag"),
remote, pretty_ref, summary_width);
return 1;
}
}
Or in other term, `git fetch` no more magically update tags. That has to be
explicitly allowed by using `--force`. The change went with git 2.20.
The change to git was done by Ævar Arnfjörð Bjarmason (who contributed a lot
to MediaWiki) :
https://git.kernel.org/pub/scm/git/git.git/commit/?id=0bc8d71b99e91c9e90b519073b639a5066119591
From the manpage:
**git-fetch(1)**
> Until Git version 2.20, and unlike when pushing with git-push(1), any
updates to `refs/tags/*` would be accepted without `+` in the refspec (or
`--force`). When fetching, we promiscuously considered all tag updates from a
remote to be forced fetches.
>
> **Since Git version 2.20**, fetching to update `refs/tags/*` works the same
way as when pushing. I.e. **any updates will be rejected without + in the
refspec (or --force)**.
The root cause is the upgrade of contint servers to Buster which brings git
2.20: T224591 <https://phabricator.wikimedia.org/T224591>
TASK DETAIL
https://phabricator.wikimedia.org/T252310
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: hashar
Cc: zhuyifei1999, Jdforrester-WMF, Zoranzoki21, hashar, Urbanecm, Xqt,
Aklapper, pywikibot-bugs-list, Dvorapa, JohnsonLee01, SHEKH, Dijkstra, Khutuck,
Totolinototo3, Zkhalido, Redabr4, Zanziii, Sadisticturd, Viztor, DannyS712,
NebulousIris, Wenyi, A.S.Kochergin, Jayprakash12345, Tbscho, MayS, Mdupont,
JJMC89, D3r1ck01, Altostratus, Avicennasis, Liudvikas, Wong128hk, thcipriani,
mys_721tx, jayvdb, Masti, Paladox, Alchimista, Rxy, Jay8g, Krenair, QChris
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T252310: Jenkins can't merge patchsets sometimes
hashar added a comment. I have deleted both tags. TASK DETAIL https://phabricator.wikimedia.org/T252310 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Jdforrester-WMF, Zoranzoki21, hashar, Dzahn, Urbanecm, Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, JohnsonLee01, Dijkstra, Totolinototo3, Zkhalido, Redabr4, Zanziii, Sadisticturd, Viztor, NebulousIris, Wenyi, A.S.Kochergin, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T252310: Jenkins can't merge patchsets sometimes
hashar added a comment. In T252310#6168492 <https://phabricator.wikimedia.org/T252310#6168492>, @Xqt wrote: > Now verify always fails if the parent isn't master but another patch set which isn't merged already. For example > https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/598977/ bases on > https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/598876/ which bases on origin/master > > A recheck is successfull after the parent was merged in this example: > https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/560057/ > > This is a regression to the previous behaviour when a patchset chain could be published. For this specific one: contint2001:/srv/zuul/git/pywikibot/core$ sudo -u zuul git fetch --tags -v origin From ssh://gerrit.wikimedia.org:29418/pywikibot/core = [up to date]master -> origin/master = [up to date]3.0.20170403 -> 3.0.20170403 = [up to date]3.0.20170521 -> 3.0.20170521 = [up to date]3.0.20170713 -> 3.0.20170713 = [up to date]3.0.20170801 -> 3.0.20170801 = [up to date]3.0.20171212 -> 3.0.20171212 = [up to date]3.0.20180108 -> 3.0.20180108 = [up to date]3.0.20180204 -> 3.0.20180204 = [up to date]3.0.20180302 -> 3.0.20180302 = [up to date]3.0.20180304 -> 3.0.20180304 = [up to date]3.0.20180403 -> 3.0.20180403 = [up to date]3.0.20180505 -> 3.0.20180505 = [up to date]3.0.20180603 -> 3.0.20180603 = [up to date]3.0.20180710 -> 3.0.20180710 = [up to date]3.0.20180823 -> 3.0.20180823 = [up to date]3.0.20180922 -> 3.0.20180922 = [up to date]3.0.20181203 -> 3.0.20181203 = [up to date]3.0.20190106 -> 3.0.20190106 = [up to date]3.0.20190204 -> 3.0.20190204 = [up to date]3.0.20190301 -> 3.0.20190301 = [up to date]3.0.20190430 -> 3.0.20190430 = [up to date]3.0.20190722 -> 3.0.20190722 = [up to date]3.0.20200111 -> 3.0.20200111 = [up to date]3.0.20200306 -> 3.0.20200306 = [up to date]3.0.20200326 -> 3.0.20200326 = [up to date]3.0.20200405 -> 3.0.20200405 = [up to date]3.0.20200508 -> 3.0.20200508 ! [rejected] python2 -> python2 (would clobber existing tag) ! [rejected] stable -> stable (would clobber existing tag) $ echo $? 1 I have no idea what that `would clobber existing tag` error is about :( TASK DETAIL https://phabricator.wikimedia.org/T252310 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Jdforrester-WMF, Zoranzoki21, hashar, Dzahn, Urbanecm, Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, JohnsonLee01, Dijkstra, Totolinototo3, Zkhalido, Redabr4, Zanziii, Sadisticturd, Viztor, NebulousIris, Wenyi, A.S.Kochergin, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Declined] T252310: Pywikibot post-merge job fails to start up
hashar closed this task as "Declined". hashar added a comment. Restricted Application removed a subscriber: Liuxinyu970226. CI was under maintenance (T224591 <https://phabricator.wikimedia.org/T224591>) which I have announced Thursday on wikitech: https://lists.wikimedia.org/pipermail/wikitech-l/2020-May/093356.html (it is a bit of a short notice, I will do better next time). The next change that merges for pywikibot should trigger the post build job. If not please reopen and I will investigate :) TASK DETAIL https://phabricator.wikimedia.org/T252310 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hashar, Dzahn, Urbanecm, Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, JohnsonLee01, Dijkstra, Totolinototo3, Zkhalido, Redabr4, Zanziii, Sadisticturd, Viztor, NebulousIris, Wenyi, A.S.Kochergin, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Jay8g, Liuxinyu970226 ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T243154: Drop support for MySQLdb
hashar added a comment. Thanks @Xqt ! TASK DETAIL https://phabricator.wikimedia.org/T243154 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Mpaa, zhuyifei1999, Dvorapa, hashar, Aklapper, Xqt, pywikibot-bugs-list, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Framawiki, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T87248: Gerrit replication to Github stalled
hashar added a comment.
OAuth got enabled again via {T234991} which again broke replication T240322:
Gerrit replication to GitHub is broken
<https://phabricator.wikimedia.org/T240322> :]
TASK DETAIL
https://phabricator.wikimedia.org/T87248
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: demon, hashar
Cc: Krinkle, XZise, valhallasw, JanZerebecki, Nikerabbit, siebrand, cpa199,
zhaofengli, llbraughler, adrianheine, Krenair, Xqt, pywikibot-bugs-list,
jayvdb, fbstj, greg, Legoktm, demon, MarkTraceur, matmarex, UltrasonicNXT,
Aklapper, A.S.Kochergin, D3r1ck01, Paladox, Jay8g, hashar, QChris
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T187009: Pywikibot documentation build throws many warnings to console
hashar added a comment. In T187009#5717532 <https://phabricator.wikimedia.org/T187009#5717532>, @Dvorapa wrote: > @hashar Could you please help with > > 08:36:55 WARNING: test command found but not installed in testenv > 08:36:55 cmd: /usr/bin/make > 08:36:55 env: /src/.tox/doc > 08:36:55 Maybe you forgot to specify a dependency? See also the whitelist_externals envconfig setting. > 08:36:55 > 08:36:55 DEPRECATION WARNING: this will be an error in tox 4 and above! > > This warning still occurs in doc tests and I'm unable to find out, what does it mean and how to fix it. That's why there was #continuous-integration-config <https://phabricator.wikimedia.org/tag/continuous-integration-config/> tag `tox` complains because one of the commands comes from outside the virtual env. In this case `make`. In `tox.ini` the `doc` environment is defined as: name=tox.ini [testenv:doc] commands = pip install -e .[security] make html -C ./docs rstcheck --recursive --report warning --ignore-directives automodule,autoclass,autofunction . basepython = python3.4 deps = -rrequirements.txt -rdocs/requirements-py3.txt rstcheck >= 3.3.1 `make html -C ./docs` has been generated by Sphinx which is merely an helper to run the `sphinx-build` command. When it is running, you should see the full command being used which you can use instead of the `make` one. Or use something like: `python setup.py build_sphinx -b html` > `commands = pip install -e .[security]` Unrelated, but I wonder why one has to reinstall those dependencies on every run and why it is in editable mode. Probably that command should be dropped and one can instead use: deps = .[security] TASK DETAIL https://phabricator.wikimedia.org/T187009 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Morgan11235, hashar Cc: hashar, Morgan11235, mstucky, Didicodes, Dalba, Xqt, zhuyifei1999, Zoranzoki21, gerritbot, Aklapper, pywikibot-bugs-list, Dvorapa, AndreasTraut, Chaytanya, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Pavithraes, Urstrulykkr, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Kieubinhtb, Guilhermebm, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Af420, Darkminds3113, Bsandipan, Lordiis, Ivana_Isadora, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, D3r1ck01, Altostratus, Avicennasis, MuhammadShuaib, srodlund, Tmalhotra, SimmeD, mys_721tx, Dinoguy1000, jayvdb, Masti, Alchimista, Rxy, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unblock] T239542: Drop support for Python 3.4
hashar closed subtask T239548: Use Python 3.5 or higher for Jenkins fasttest as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T239542 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Dvorapa, Aklapper, pywikibot-bugs-list, Xqt, AndreasTraut, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T239548: Use Python 3.5 or higher for Jenkins fasttest
hashar closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T239548 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa, hashar Cc: Aklapper, pywikibot-bugs-list, hashar, Xqt, AndreasTraut, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T187009: Pywikibot documentation build throws many warnings to console
hashar removed a project: Continuous-Integration-Config. TASK DETAIL https://phabricator.wikimedia.org/T187009 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Morgan11235, hashar Cc: Morgan11235, mstucky, Didicodes, Dalba, Xqt, zhuyifei1999, Zoranzoki21, gerritbot, Aklapper, pywikibot-bugs-list, Dvorapa, Chaytanya, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Pavithraes, Urstrulykkr, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Kieubinhtb, Guilhermebm, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Af420, Darkminds3113, Bsandipan, Lordiis, Ivana_Isadora, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, D3r1ck01, Altostratus, Avicennasis, MuhammadShuaib, srodlund, Tmalhotra, SimmeD, mys_721tx, Dinoguy1000, jayvdb, Masti, Alchimista, Rxy, Jay8g, Totolinototo3, Redabr4, Zanziii, Sadisticturd, A.S.Kochergin ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T226507: Port pywikibot-core to new pywikibot IV repository (tracking)
hashar added a comment. //I am just a lurker but still have some kind of interest in pywikibot from time to time. Here some feedback based on a couple decades of IT// I would highly recommend to avoid creating a new repository (such as what has been done for compat). That loose all history and confuses people as to which repo should really be used. Instead I would propose you tag a last version of pywikibot that still support python 2.7 and make it extremely clear that is the last ever release to support python 2.7. Then have master branch to only be tested with python3. Done? If your concern is people not switching/upgrading to python3, that surely can be made easier by having some tutorials (eg use `python3` not `python`, how to install python3 etc). Regardless they can still use the last version still tested with python 2.7. > Pywikibot meetup group only agreed that we should not break user scripts and cronjobs running on py2 by deprecation steps. Could we find a better (and still not breaking) solution? The way to achieve that is for users to keep the version they are currently running. If they want the latest bugfix and features, they would have to switch to python3. In all honesty it is not that complicated to handle. In both case (1) creating a new repo like 'compat' (2) keeping compatibility with 2.7, you are going to have troubles having users to actively migrate and would still drag the python2.7 support for months and months. At some point, you should force users to migrate and break the back compatibility. And again, the migration is not that complicated, just install python3? Anyway T226507#5283686 <https://phabricator.wikimedia.org/T226507#5283686> sounds like a sane and safe plan. TASK DETAIL https://phabricator.wikimedia.org/T226507 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: matej_suchanek, Frettie, Geertivp, Tobias1984, Chicocvenancio, Ladsgroup, Aklapper, pywikibot-bugs-list, zhuyifei1999, hashar, D3r1ck01, Lokal_Profil, Framawiki, valhallasw, Multichill, Mpaa, Dvorapa, Dalba, Xqt, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unassigned] T186208: Magul's quick tests doesn't run anymore
hashar removed hashar as the assignee of this task. hashar added a comment. Despite a first try at looking at pywikibot/core and attempting to run the test suite / get familiar with the code, I eventually dropped/forgot about this. I had too many tasks to handle on the CI infrastructure front :-( TASK DETAIL https://phabricator.wikimedia.org/T186208 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: zhuyifei1999, hashar, Liuxinyu970226, Legoktm, Framawiki, Dalba, Dvorapa, Magul, Aklapper, Xqt, pywikibot-bugs-list, Redabr4, Zanziii, Sadisticturd, Viztor, DannyS712, NebulousIris, Wenyi, A.S.Kochergin, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Liudvikas, mys_721tx, jayvdb, dduvall, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T89976: mysql support should fall back to dependency on pure python package PyMySQL
hashar added a comment. Note that pywikibot now defaults to use PyMySQL which is the pure python module and defaults to it. That has been the case since October 2018. I have send a couple patches to clean up the code of mentions to `oursql` and remove support for `MySQLdb` has a fall back. TASK DETAIL https://phabricator.wikimedia.org/T89976 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa, hashar Cc: hashar, gerritbot, Dvorapa, Ricordisamoa, XZise, pywikibot-bugs-list, jayvdb, Aklapper, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186208: Magul's quick tests doesn't run anymore
hashar added a comment.
A few things that are worth investigating and probably could use to be
simplified.
sudo
The default is `sudo: false`, a few environments do have `sudo: require` when
they have `dist: xenial`:
include:
- python: '2.7_with_system_site_packages'
env: LANGUAGE=nb FAMILY=wikipedia PYSETUP_TEST_EXTRAS=1
PYWIKIBOT_TEST_NO_RC=1
dist: xenial
sudo: required
addons:
apt:
packages:
- djvulibre-bin
- graphviz
- liblua5.1-0-dev
- python-ipaddr
- python: '3.7'
env: LANGUAGE=de FAMILY=wikipedia
dist: xenial
sudo: required
- python: '3.8-dev'
env: LANGUAGE=test FAMILY=wikipedia PYWIKIBOT_SITE_ONLY=1
dist: xenial
sudo: required
allow_failures:
- python: '3.8-dev'
env: LANGUAGE=test FAMILY=wikipedia PYWIKIBOT_SITE_ONLY=1
dist: xenial
sudo: required
One sure thing, we can't right know support the env
'2.7_with_system_site_packages' since the CI job do not have sudo access to
install extra packages. For the others, I am not sure why sudo is required on
xenial? Maybe to get python 3.7 or 3.8 dev to be installed?
global env
==
env:
global:
- TEST_TIMEOUT=300
- PYWIKIBOT_NO_L10N_TESTS=1
matrix:
- LANGUAGE=en FAMILY=wikipedia PYWIKIBOT_TEST_PROD_ONLY=1
- LANGUAGE=zh FAMILY=wikisource PYSETUP_TEST_EXTRAS=1
PYWIKIBOT_TEST_PROD_ONLY=1 PYWIKIBOT_TEST_NO_RC=1
The global env matrix sets `LANGUAGE` and `FAMILY` but they are always set in
the matrix below. I would drop them from the global and have the `script:` part
to fail immediately when either is not set.
`PYWIKIBOT_TEST_PROD_ONLY=1` is always set, could be moved up in
`env.global`. Note the environment variable is only listed in
`tests.aspects.py`:
for data in cls.sites.values():
if ('code' in data and data['code'] in ('test', 'mediawiki')
and 'PYWIKIBOT_TEST_PROD_ONLY' in os.environ and not dry):
raise unittest.SkipTest(
'Site code "{}" and PYWIKIBOT_TEST_PROD_ONLY is set.'
.format(data['code']))
Which seems to indicate tests are skipped when they are marked with
`code=test` or `code=mediawiki`. Seems to me the variable can be set when
`LANGUAGE` is set to `test` or `mediawiki` instead of always setting it.
The second global matrix sets `PYWIKIBOT_TEST_NO_RC=1`, seems to be set
because the test suite does not accommodate for some customization made on
sites.
`PYSETUP_TEST_EXTRAS` seems to be a huge hack that affects the build a lot
with a few hacks all other the place.
script
==
The super long yaml script is not convenient. It would be nicer to have all
the logic extracted to a standalone file and just invoke that. Eg:
script:
- citestrunner.sh
TASK DETAIL
https://phabricator.wikimedia.org/T186208
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: hashar
Cc: hashar, Liuxinyu970226, Legoktm, Framawiki, Dalba, Dvorapa, Magul,
Aklapper, Xqt, pywikibot-bugs-list, Redabr4, Zanziii, Sadisticturd,
NebulousIris, Wenyi, A.S.Kochergin, Tbscho, MayS, Mdupont, JJMC89, Avicennasis,
Liudvikas, mys_721tx, jayvdb, dduvall, Masti, Alchimista, Rxy, greg
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186208: Magul's quick tests doesn't run anymore
hashar added a comment. From the `.travis.yml` file. Some global environment variables: env: global: - TEST_TIMEOUT=300 - PYWIKIBOT_NO_L10N_TESTS=1 Then there are two set of globals: env: matrix: - LANGUAGE=en FAMILY=wikipedia PYWIKIBOT_TEST_PROD_ONLY=1 - LANGUAGE=zh FAMILY=wikisource PYSETUP_TEST_EXTRAS=1 PYWIKIBOT_TEST_PROD_ONLY=1 PYWIKIBOT_TEST_NO_RC=1 Then there are 13 entries in the matrix, one of them is allowing to fail (python 3.8-dev). The huge combination of 26 axis ends up being: | python| FAMILY | LANGUAGE | OAUTH_DOMAIN | PYSETUP_TEST_EXTRAS | NO_L10N_TESTS | SITE_ONLY | TEST_NO_RC | PROD_ONLY | TEST_TIMEOUT | | - | --- | | --- | --- | - | - | -- | - | | | 2.7_with_system_site_packages | wikipedia | nb | None | 1 | 1 | None | 1 | 1 | 300 | | 2.7 | wpbeta | en | "en.wikipedia.beta.wmflabs.org" | None| 1 | 1 | None | 1 | 300 | | 3.6 | wpbeta | zh | "zh.wikipedia.beta.wmflabs.org" | None| 1 | 1 | None | 1 | 300 | | 3.4 | wsbeta | en | None | None| 0 | 1 | None | 1 | 300 | | 2.7 | wikia | wikia| None | None| 1 | None | 1 | 1 | 300 | | 3.5 | musicbrainz | en | None | None| 1 | 1 | None | 1 | 300 | | 3.4 | wikipedia | test | "test.wikipedia.org"| None| 1 | 1 | None | 1 | 300 | | 3.4 | wikidata| test | None | None| 1 | 1 | None | 1 | 300 | | 3.4 | wiktionary | ar | None | None| 1 | None | 1 | 1 | 300 | | 3.6 | wikidata| wikidata | None | None| 1 | 1 | None | 1 | 300 | | 3.7 | wikipedia | de | None | None| 1 | None | None | 1 | 300 | | 3.8-dev | wikipedia | test | None | None| 1 | 1 | None | 1 | 300 | | 3.8-dev(failling) | wikipedia | test | None | None| 1 | 1 | None | 1 | 300 | | 2.7_with_system_site_packages | wikipedia | nb | None | 1 | 1 | None | 1 | 1 | 300 | | 2.7 | wpbeta | en | "en.wikipedia.beta.wmflabs.org" | 1 | 1 | 1 | 1 | 1 | 300 | | 3.6 | wpbeta | zh | "zh.wikipedia.beta.wmflabs.org" | 1 | 1 | 1 | 1 | 1 | 300 | | 3.4 | wsbeta | en | None | 1 | 0 | 1 | 1 | 1 | 300 | | 2.7 | wikia | wikia| None | 1 | 1 | None | 1 | 1 | 300 | | 3.5 | musicbrainz | en | None | 1 | 1 | 1 | 1 | 1 | 300 | | 3.4 | wikipedia | test | "test.wikipedia.org"| 1 | 1 | 1 | 1 | 1 | 300 | | 3.4 | wikidata| test | None | 1 | 1 | 1 | 1 | 1 | 300 | | 3.4 | wiktionary | ar
[Pywikipedia-bugs] [Maniphest] [Updated] T186208: Magul's quick tests doesn't run anymore
hashar added a comment. @Dvorapa thank you so much for your replies. I guess I have all the context to jump in and analysis a proper solution :-] > The easy solution for the top priority Magul's test replacement would be something like this: Someone enters a magic keyword in the Gerrit patchset comment -> Wikimedia CI registers it and creates a pull request to GitHub with the code (perhaps using GH API, also closes it immediately as it wil not be needed on GitHub) -> and GitHub-Travis-Appveyor handles the rest of the work. Our situation with GitHub is already rather sort of a mess. Others previously suggested to have a Gerrit -> GitHub -> Travis -> 3rd party tools, I vetoed it as not robust enough. There are too many stacks and it is asking for troubles. That being said, people do take advantage of repositories being synced to Github to activate jobs that run once a change is merged. That is fine since it does not touch Gerrit / Wikimedia CI and thus #release-engineering-team <https://phabricator.wikimedia.org/tag/release-engineering-team/> is not involved :-] > The harder solution would be to mimick Travis/Appveyor in Wikimedia CI as you said, then when someone enters a magic keyword in the Gerrit patchset comment or someone +2 the patchset -> Wikimedia CI registers it and runs the tox on predefined set of environments including several Python versions, three major OS platforms and several presets. The Wikimedia CI uses a Docker container that runs tox. It recently got support for python 2.7, 3.4, 3.5, 3.6 and 3.7 T191764 <https://phabricator.wikimedia.org/T191764>. We should be able to add them right now in `tox.ini` and add CI jobs for them. --- 32bits, yes I agree we can drop it. I don't think pywikibot would have many issues with it anyway. That leaves us with the .travis.yml <https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/.travis.yml>. Seems all of that can be converted to testenv in tox.ini, possibly by invoking different testing scripts. It does not seem too complicated :] TASK DETAIL https://phabricator.wikimedia.org/T186208 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hashar, Liuxinyu970226, Legoktm, Framawiki, Dalba, Dvorapa, Magul, Aklapper, Xqt, pywikibot-bugs-list, Redabr4, Zanziii, Sadisticturd, NebulousIris, Wenyi, A.S.Kochergin, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Liudvikas, mys_721tx, jayvdb, dduvall, Masti, Alchimista, Rxy, greg ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Claimed] T186208: Magul's quick tests doesn't run anymore
hashar claimed this task. hashar added a comment. Restricted Application edited projects, added Release-Engineering-Team (Kanban); removed Release-Engineering-Team. Hello, this got raised to #release-engineering-team <https://phabricator.wikimedia.org/tag/release-engineering-team/> meeting last Monday, thought I was busy with other random duties. This week will be easier so I gotta review the request but in short Wikimedia CI does not support Travis or AppVeyor at all. For Travis, it is heavily tight to github and we cant reproduce that with Gerrit and our CI (Jenkins/Zuul/Docker). That being said, most of the time it is very straightforward to rewrite the travis logic to a Jenkins job. AppVeyor I don't think I have ever heard of it. But I guess it is a third party closed source software and we would probably not be able to reproduce it. Note: we used to have a Jenkins job that ran the pywikibot tests against the #beta-cluster-infrastructure <https://phabricator.wikimedia.org/tag/beta-cluster-infrastructure/> (901f445d1058f55d8ceae23cff4cf7b58537a778 <https://phabricator.wikimedia.org/rCICF901f445d1058f55d8ceae23cff4cf7b58537a778> (T100903 <https://phabricator.wikimedia.org/T100903>). ) but it was broken/never completed and I have removed it T188256 <https://phabricator.wikimedia.org/T188256>. The job was doing: export PYWIKIBOT2_DIR=$WORKSPACE export TOX_TESTENV_PASSENV=PY_COLORS export PY_COLORS=1 tox -e venv -- pip install --upgrade ndg-httpsclient tox -e venv -- python -m generate_family_file 'http://en.wikipedia.beta.wmflabs.org/' 'wpbeta' 'y' tox -e venv -- python -m generate_user_files -dir:$WORKSPACE -family:wpbeta -lang:en -v echo "console_encoding='utf8'" >> $WORKSPACE/user-config.py tox -e venv -- pip install -rdev-requirements.txt tox -e venv -- python setup.py nosetests --tests tests --verbosity=2 -a '"family=wpbeta,code=en"' We can look at moving that as a script directly into `pywikibot/core.git`, add a new testenv in tox (eg: `integration-beta`) and then simply have a Jenkins job that invokes that testenv. Then move forward and fix it :) TASK DETAIL https://phabricator.wikimedia.org/T186208 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hashar, Liuxinyu970226, Legoktm, Framawiki, Dalba, Dvorapa, Magul, Aklapper, Xqt, pywikibot-bugs-list, Redabr4, Zanziii, Sadisticturd, NebulousIris, Wenyi, A.S.Kochergin, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Liudvikas, mys_721tx, jayvdb, dduvall, Masti, Alchimista, Rxy, greg ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T132138: Perform full test suite using Wikimedia CI
hashar edited projects, added Continuous-Integration-Config; removed Continuous-Integration-Infrastructure. TASK DETAILhttps://phabricator.wikimedia.org/T132138EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Magul, hasharCc: Framawiki, Ricordisamoa, jayvdb, Aklapper, JanZerebecki, pywikibot-bugs-list, Sadisticturd, Wenyi, A.S.Kochergin, Mahveotm, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, Dalba, Masti, Alchimista, Rxy, hashar, thcipriani, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T104306: Share Appveyor account credentials with Release Engineering
hashar added a comment. There is some documentation at https://www.appveyor.com/docs/team-setup/ Seems the AppVeyor accounts/team can be tied to the GitHub ones.TASK DETAILhttps://phabricator.wikimedia.org/T104306EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Xqt, Framawiki, Dvorapa, MoritzMuehlenhoff, valhallasw, greg, pywikibot-bugs-list, Aklapper, jayvdb, Matanya, hashar, NebulousIris, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Liudvikas, Luke081515, mys_721tx, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T183860: AppVeyor test not running since months
hashar added a comment. In T183860#4683354, @Dvorapa wrote: I'm not sure, why I added RepoAds, sorry. The problem is that nobody has got an access to Wikimedia account on AppVeyor (which operates with GitHub mirror). There are two possible solutions: contact @jayvdb as he was the Wikimedia AppVeyor account founder That is the subject of T104306. I do not know AppVeyor at all, at least it uses GitHub with OAuth which simplify things a bit. Does it support organization somehow? Then we would be able to add pywikibot maintainers to it and you will be able to modify settings on a self served basis. I am fine being added as an admin as well to help pywikibot people. On a best effort basis though, but I should be able to act when subscribed to tasks. move AppVeyor tests to #jenkins post-merge What kind of tests are being run? We used to have a Jenkins job running some subset of tests against the beta cluster, but it did not ever worked properly. It is surely something we could revisit and should be as simple as defining a new tox environment (eg: smoketest-beta) which would have all the proper commands to initialize pywikibot, select tests and point them at https://en.wikipedia.beta.wmflabs.org/ . We should be able to have the job to report to IRC and by email and run it on a daily/hourly basis.TASK DETAILhttps://phabricator.wikimedia.org/T183860EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: hashar, Krenair, Dvorapa, Framawiki, Ladsgroup, jayvdb, Aklapper, Dalba, Xqt, pywikibot-bugs-list, NebulousIris, Wenyi, A.S.Kochergin, Zylc, God, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Liudvikas, Luke081515, mys_721tx, Masti, Alchimista, Rxy, greg___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T118371: color KeyError problem in _ColorFormatter
hashar added a comment. Sorry I messed up. The above spam is for T119371: Enable MariaDB/MySQL strict mode on CI slavesTASK DETAILhttps://phabricator.wikimedia.org/T118371EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jayvdb, hasharCc: hashar, Stashbot, TerraCodes, Jay8g, jayvdb, totoazero, StudiesWorld, gerritbot, Aklapper, pywikibot-bugs-list, JAnD, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Declined] T188256: Migrate pywikibot-tests-beta-cluster to a tox env in pywikibot/core
hashar closed this task as "Declined".hashar added a comment. I am going to delete it. The job never ran any test.TASK DETAILhttps://phabricator.wikimedia.org/T188256EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Aklapper, zeljkofilipin, MarcoAurelio, hashar, pywikibot-bugs-list, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis, Liudvikas, Luke081515, thcipriani, jayvdb, Dalba, Masti, Alchimista, Addshore, Rxy, Jay8g, greg___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T188256: Migrate pywikibot-tests-beta-cluster to a tox env in pywikibot/core
hashar updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONThe Jenkins job [[ https://integration.wikimedia.org/ci/job/pywikibot-tests-beta-cluster/ | pywikibot-tests-beta-cluster ]] setup pywikibot and runs a test suite against the beta cluster. All the logic should be moved from the job to a testenv in pywikibot/core. ``` lang=shell export PYWIKIBOT2_DIR=$WORKSPACE export TOX_TESTENV_PASSENV=PY_COLORS export PY_COLORS=1 tox -e venv -- pip install --upgrade ndg-httpsclient tox -e venv -- python -m generate_family_file 'http://en.wikipedia.beta.wmflabs.org/' 'wpbeta' 'y' tox -e venv -- python -m generate_user_files -dir:$WORKSPACE -family:wpbeta -lang:en -v echo "console_encoding='utf8'" >> $WORKSPACE/user-config.py tox -e venv -- pip install -rdev-requirements.txt tox -e venv -- python setup.py nosetests --tests tests --verbosity=2 -a '"family=wpbeta,code=en"' ```TASK DETAILhttps://phabricator.wikimedia.org/T188256EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Aklapper, zeljkofilipin, MarcoAurelio, hashar, pywikibot-bugs-list, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis, Liudvikas, Luke081515, thcipriani, jayvdb, Dalba, Masti, Alchimista, Addshore, Rxy, Jay8g, greg___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T188256: Migrate pywikibot-tests-beta-cluster to a tox env in pywikibot/core
hashar created this task.hashar added projects: Continuous-Integration-Infrastructure (shipyard), Release-Engineering-Team (Kanban), Pywikibot-core.Herald added a subscriber: pywikibot-bugs-list. TASK DESCRIPTIONThe Jenkins job pywikibot-tests-beta-cluster setup pywikibot and runs a test suite against the beta cluster. All the logic should be moved from the job to a testenv in pywikibot/core.TASK DETAILhttps://phabricator.wikimedia.org/T188256EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Aklapper, zeljkofilipin, MarcoAurelio, hashar, pywikibot-bugs-list, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis, Liudvikas, Luke081515, thcipriani, jayvdb, Dalba, Masti, Alchimista, Addshore, Rxy, Jay8g, greg___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Reassigned] T109119: Check the style of the commit message
hashar reassigned this task from jayvdb to Dalba.hashar added a comment. Indeed that is resolved by https://gerrit.wikimedia.org/r/#/c/368793/ :)TASK DETAILhttps://phabricator.wikimedia.org/T109119EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, hasharCc: Dalba, zhuyifei1999, jayvdb, Jdforrester-WMF, JanZerebecki, Legoktm, bd808, gerritbot, hashar, greg, Aklapper, pywikibot-bugs-list, XZise, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T181881: pywikibot-core-tox-doc-docker timeouts sporadically
hashar assigned this task to Dalba.hashar closed this task as "Resolved".hashar added a comment. @Dalba managed to find the root cause and bumped the job timeout from 4 minutes to 5 minutes. That should be sufficient. Well done!TASK DETAILhttps://phabricator.wikimedia.org/T181881EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, hasharCc: hashar, Dvorapa, gerritbot, Framawiki, Aklapper, pywikibot-bugs-list, Dalba, Baloch007, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Declined] T130208: Jobs should checkout source in a subdirectory of the workspace to avoid polluting it with CI related files
hashar closed this task as "Declined".hashar added a comment. With the migration toward containers, this is no more relevant.TASK DETAILhttps://phabricator.wikimedia.org/T130208EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Ricordisamoa, pywikibot-bugs-list, Aklapper, hashar, Bigdog222, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unblock] T130207: Migrate pywikibot/i18n npm job to Nodepool
hashar closed subtask T130208: Jobs should checkout source in a subdirectory of the workspace to avoid polluting it with CI related files as "Declined". TASK DETAILhttps://phabricator.wikimedia.org/T130207EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: gerritbot, Ricordisamoa, Aklapper, hashar, pywikibot-bugs-list, Bigdog222, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, Liudvikas, Luke081515, zeljkofilipin, greg___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T100903: Run pywikibot test suite regularly on beta cluster as part of MediaWiki/Wikimedia CI
hashar added a comment. The tests are tagged with familly = wikipedia but the Jenkins job runs them with family=wpbeta and hence no tests are found. As a hack I replaced the 'wikipedia' familly with the generate one for 'wpbeta' $ mv pywikibot/families/wpbeta_family.py pywikibot/families/wikipedia_family.py Then running tests tagged family=wikipedia,code=en using: PYWIKIBOT2_DIR=$(pwd) TOX_TESTENV_PASSENV=PYWIKIBOT2_DIR tox -e venv -- python setup.py nosetests --tests tests --verbosity=2 -a '"family=wikipedia,code=en"' It has a bunch of failures though: -- Ran 113 tests in 10.778s FAILED (SKIP=3, errors=5, failures=4)TASK DETAILhttps://phabricator.wikimedia.org/T100903EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Lokal_Profil, Luke081515, Legoktm, gerritbot, Ricordisamoa, hashar, mmodell, greg, pywikibot-bugs-list, jayvdb, Aklapper, Magul, Tbscho, MayS, Mdupont, JJMC89, TerraCodes, Avicennasis, thcipriani, Dalba, Masti, Alchimista, Rxy, Jay8g, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T109119: Check the style of the commit message
hashar added a comment. Ops asked for some kind of commit message validation for operations/puppet. I went with adding a new env in tox which installs and run commit-message-validator from Pypi. https://gerrit.wikimedia.org/r/#/c/365609/3/tox.ini So it should be straightforward for pywikibot and any repository already relying on a job running tox. For other repositories, we had the idea of crafting a common job that would be attached on every single repos. Maybe we can add the existing job everywhere.TASK DETAILhttps://phabricator.wikimedia.org/T109119EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: zhuyifei1999, jayvdb, Jdforrester-WMF, JanZerebecki, Legoktm, bd808, gerritbot, hashar, greg, Aklapper, pywikibot-bugs-list, XZise, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T152907: Release a new version of pywikibot
hashar added a comment. @valhallasw please accept a tiny barnstar F7220262: Photo le 04-04-2017 à 22.22.jpgTASK DETAILhttps://phabricator.wikimedia.org/T152907EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: gerritbot, zhuyifei1999, Wesalius, Dalba, MZMcBride, Xqt, jayvdb, XZise, hashar, valhallasw, Legoktm, Pintoch, Lokal_Profil, Framawiki, Magul, Aklapper, pywikibot-bugs-list, nichtich, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T152907: Release a new version of pywikibot
hashar added a comment. I don't think I ever released anything on Pypi. I would not mind giving it a try but I cannot get access to my Pypi credentials and their recovery system fails for my account :/TASK DETAILhttps://phabricator.wikimedia.org/T152907EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: zhuyifei1999, Wesalius, Dalba, MZMcBride, Xqt, jayvdb, XZise, hashar, valhallasw, Legoktm, Pintoch, Lokal_Profil, Framawiki, Magul, Aklapper, pywikibot-bugs-list, nichtich, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Lowered Priority] T130208: Jobs should checkout source in a subdirectory of the workspace to avoid polluting it with CI related files
hashar lowered the priority of this task from "Normal" to "Low".hashar added a comment. The banana linter in pywikibot/i18n no ignores /log.TASK DETAILhttps://phabricator.wikimedia.org/T130208EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Ricordisamoa, pywikibot-bugs-list, Aklapper, hashar, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T130208: Jobs should checkout source in a subdirectory of the workspace to avoid polluting it with CI related files
hashar edited projects, added Continuous-Integration-Config; removed Continuous-Integration-Infrastructure, Continuous-Integration-Scaling. TASK DETAILhttps://phabricator.wikimedia.org/T130208EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Ricordisamoa, pywikibot-bugs-list, Aklapper, hashar, Jay8g, greg___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T100903: Run pywikibot test suite regularly on beta cluster as part of MediaWiki/Wikimedia CI
hashar merged a task: T149842: pywikibot-tests-beta-cluster job does not run any test. TASK DETAILhttps://phabricator.wikimedia.org/T100903EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Luke081515, Legoktm, gerritbot, Ricordisamoa, hashar, mmodell, greg, pywikibot-bugs-list, jayvdb, Aklapper, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Alchimista, Rxy, Jay8g, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Merged] T149842: pywikibot-tests-beta-cluster job does not run any test
hashar closed this task as a duplicate of T100903: Run pywikibot test suite regularly on beta cluster as part of MediaWiki/Wikimedia CI. TASK DETAILhttps://phabricator.wikimedia.org/T149842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Aklapper, pywikibot-bugs-list, hashar, jayvdb, MayS, Mdupont, JJMC89, Alchimista, Rxy, Jay8g, greg___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T149842: pywikibot-tests-beta-cluster job does not run any test
hashar added a comment. T100796 was for Travis setup Looks that my task is a duplicate of T100903 based on last comment there.TASK DETAILhttps://phabricator.wikimedia.org/T149842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Aklapper, pywikibot-bugs-list, hashar, jayvdb, MayS, Mdupont, JJMC89, Alchimista, Rxy, Jay8g, greg___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T145484: travis tests fails for apt-get install
hashar added a subscriber: Multichill.hashar added a comment. @Multichill poked me about it. The job is made to use Debian unstable: $ echo "deb http://ftp.us.debian.org/debian unstable main contrib non-free" \ | sudo tee -a /etc/apt/sources.list > /dev/null Which is well, unstable :] The package locales fails completely: Preparing to replace locales 2.13+git20120306-3 (using .../locales_2.24-2_all.deb) ... Unpacking replacement locales ... dpkg: error processing /var/cache/apt/archives/locales_2.24-2_all.deb (--unpack): trying to overwrite '/usr/sbin/update-locale', which is also in package libc-bin 2.15-0ubuntu10.15 dpkg-deb (subprocess): subprocess data was killed by signal (Broken pipe) dpkg-deb: error: subprocess returned error exit status 2 Selecting previously unselected package libc-l10n. dpkg: considering deconfiguration of locales, which would be broken by installation of libc-l10n ... dpkg: yes, will deconfigure locales (broken by libc-l10n). Unpacking libc-l10n (from .../libc-l10n_2.24-2_all.deb) ... De-configuring locales ... Errors were encountered while processing: /var/cache/apt/archives/locales_2.24-2_all.deb No clue why update-locale would be in two packages. Looks like a chicken and egg problem as something is being transitioned in the Debian project. The source package is glibc: https://packages.qa.debian.org/g/glibc.html I highly recommend to NOT use unstable for anything. Ideally you should aim at jessie which is the stable version, and eventually testing (which breaks often though). If jessie does not work for some reaso, that is surely fixable :]TASK DETAILhttps://phabricator.wikimedia.org/T145484EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Multichill, zhuyifei1999, hashar, TerraCodes, Luke081515, Jay8g, valhallasw, jayvdb, Aklapper, Xqt, pywikibot-bugs-list, MayS, Mdupont, JJMC89, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T130208: Jobs should checkout source in a subdirectory of the workspace to avoid polluting it with CI related files
hashar edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T130208 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Ricordisamoa, pywikibot-bugs-list, Aklapper, hashar, Luke081515, Jay8g, greg ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T130208: Jobs should checkout source in a subdirectory of the workspace to avoid polluting it with CI related files
hashar added a comment. Since https://gerrit.wikimedia.org/r/#/c/290690/ JJB has a default: `use-remote-zuul-shallow-clone-to-src` which causes the repo to be cloned under `/src/` Have used it successfully for pywikibot/i18n in https://phabricator.wikimedia.org/T130207. We now should migrate all the jobs to use the same. TASK DETAIL https://phabricator.wikimedia.org/T130208 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Ricordisamoa, pywikibot-bugs-list, Aklapper, hashar, Luke081515, Jay8g, greg ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T130207: Migrate pywikibot/i18n npm job to Nodepool
hashar closed this task as "Resolved". hashar claimed this task. hashar added a comment. The job got migrated to a job that clone to `/src/` (npm-node-0.10). We will migrate it to NodeJs 4.3 whenever it is adjusted to clone under `/src/`as well. TASK DETAIL https://phabricator.wikimedia.org/T130207 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: gerritbot, Ricordisamoa, Aklapper, hashar, pywikibot-bugs-list, Lewizho99, Maathavan, Luke081515 ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T134235: Add pypy to CI build machines
hashar closed this task as "Resolved". hashar added a comment. tox-jessie managed to run flake8 under pypy ! ( https://integration.wikimedia.org/ci/job/tox-jessie/7598/console ) TASK DETAIL https://phabricator.wikimedia.org/T134235 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Stashbot, gerritbot, hashar, Zppix, Aklapper, pywikibot-bugs-list, Ricordisamoa, jayvdb, Lewizho99, Mdupont, Maathavan, Jay8g, greg ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T134235: Add pypy to CI build machines
hashar added a comment. Added on the Jessie images: Python 2.7.8 (2.4.0+dfsg-3, Dec 20 2014, 13:30:46) [PyPy 2.4.0 with GCC 4.9.2] \O/ The pywikibot patch is https://gerrit.wikimedia.org/r/#/c/260909/ TASK DETAIL https://phabricator.wikimedia.org/T134235 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Stashbot, gerritbot, hashar, Zppix, Aklapper, pywikibot-bugs-list, Ricordisamoa, jayvdb, Lewizho99, Mdupont, Maathavan, Jay8g, greg ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T134062: Corrupted repository : pywikibot/core
hashar removed a project: Zuul.
hashar added a comment.
From Zuul:
2016-04-30 15:00:11,440 DEBUG zuul.Repo: Checking out
0d56409652b5add94aecf40991bd0400d15c7c30
2016-04-30 15:00:12,175 DEBUG zuul.Merger: Unable to merge {u'oldrev':
None, u'newrev': None, u'refspec': u'refs/changes/74/286274/1', u'merge_mode':
2, u'number': u'286274', u'project': u'pywikibot/core', u'url':
u'ssh://jenkins-...@ytterbium.wikimedia.org:29418/pywikibot/core', u'branch':
u'master', u'patchset': u'1', u'ref': u'Z74f39c6333e44b81bde4a7672873606c'}
Traceback (most recent call last):
File
"/usr/share/python/zuul/local/lib/python2.7/site-packages/zuul/merger/merger.py",
line 261, in _mergeChange
commit = repo.merge(item['refspec'], 'resolve')
File
"/usr/share/python/zuul/local/lib/python2.7/site-packages/zuul/merger/merger.py",
line 159, in merge
self.fetch(ref)
File
"/usr/share/python/zuul/local/lib/python2.7/site-packages/zuul/merger/merger.py",
line 172, in fetch
origin.fetch(ref)
File
"/usr/share/python/zuul/local/lib/python2.7/site-packages/git/remote.py", line
651, in fetch
res = self._get_fetch_info_from_stderr(proc, progress or
RemoteProgress())
File
"/usr/share/python/zuul/local/lib/python2.7/site-packages/git/remote.py", line
559, in _get_fetch_info_from_stderr
raise GitCommandError(("Error when fetching: %s" % line,), 2)
GitCommandError: 'Error when fetching: fatal: internal server error'
returned with exit code 2
Looks like it can not fetch from Gerrit for some reason.
TASK DETAIL
https://phabricator.wikimedia.org/T134062
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: hashar
Cc: jayvdb, Dereckson, hashar, Aklapper, pywikibot-bugs-list, Linedwell,
Mdupont, Luke081515, Krenair, QChris, greg
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T130208: Jobs should checkout source in a subdirectory of the workspace to avoid polluting it with CI related files
hashar created this task. TASK DESCRIPTION https://phabricator.wikimedia.org/T130207 is about a test in pywikibot/i18n falling because the CI job 'npm-node-4.3' creates a `$WORKSPACE/log` directory which pollute the sources. We should get the repository(ies) checkout under a directory such as `$WORKSPACE/src` and run commands in there. Then if we want to generate build artifacts / log etc, people would reference `../log` which is `$WORKSPACE/log`. TASK DETAIL https://phabricator.wikimedia.org/T130208 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: pywikibot-bugs-list, Aklapper, hashar, Luke081515, greg ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T130207: Migrate pywikibot/i18n npm job to Nodepool
hashar created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION On `pywikibot/i18n` repository, the `npm` job works just fine but the Nodepool based version `npm-node-4.3` breaks with: Running "banana:all" (banana) task Warning: Unable to read "/home/jenkins/workspace/npm-node-4.3/log/qqq.json" file (Error code: ENOENT). Use --force to continue. The reason is `npm-node-4.3` clone the repository under `$WORKSPACE` and then we create a directory `$WORKSPACE/log` which ends up polluting the source checkout. The CI job must not pollute the source checkout! TASK DETAIL https://phabricator.wikimedia.org/T130207 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Aklapper, hashar, pywikibot-bugs-list, Luke081515 ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T58959: Tests: allow for offline operation
hashar added a comment. The job https://integration.wikimedia.org/ci/job/pywikibot-core-tox-nose/ runs `tox -enose`, what it runs is defined in `/tox.ini` and roughly ends up being: python -W error::UserWarning -m generate_user_files -family:test -lang:test -v nosetests --with-doctest --with-detecthttp -v -a '!net' tests pywikibot --ignore-files=(gui\.py|botirc\.py|rcstream\.py|api\.py) Note `-a '!net'` which excludes any test labelled with `net` i.e. requiring network. So I guess running `tox -enose` is offline operation. Invoking simply `tox` will run `python setup.py test` which might well runs everything. TASK DETAIL https://phabricator.wikimedia.org/T58959 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Nemo_bis, XZise, hashar, Aklapper, IoannisKydonis, jayvdb, valhallasw, pywikibot-bugs-list, Ladsgroup ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T74863: add coverage report to tests
hashar edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T74863 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Ricordisamoa, hashar, Andrew, Ladsgroup, XZise, gerritbot, Aklapper, jayvdb, pywikibot-bugs-list ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T87169: run at least pep8 and pep257 for new changesets submitted to pywikibot/core for any user
hashar added a comment. The tox envlist has: flake8 flake8-py3 flake8-docstrings-mandatory py26 py27 py34 Running all of them ends up taking 11 minutes IIRC. Potentially we could use detox <https://pypi.python.org/pypi/detox/> to have them run in parallel. `python2.6` is no more available on Jessie. But we can keep a job running on Trusty where it is available. And if we keep py26 split, we can well keep py27,py34 split. What I found out is that tox supports a specific env `jenkins` which is to override setting when tox detects it runs under Jenkins (i.e.: when env variable `JENKINS_URL` is set). We can probably abuse that feature to override `envlist` in Jenkins context and aggregate the lint/doc envs. So potentially: `tox.ini` [tox] # Defaults env targets for developers envlist = flake8,flake8-py3,flake8-docstrings-mandatory,py26,py27,py34 [testenv:jenkins] # Override default for Jenkins # The py26,py27,py34 run in their own individual jobs on WMF Jenkins envlist = flake8,flake8-py3,flake8-docstrings-mandatory,doc And In Zuul: - name: pywikibot/core test: -- tox-flake8 -- pywikibot-core-tox-flake8-py3-jessie - pywikibot-core-tox-flake8-docstrings # non voting -- pywikibot-core-tox-flake8-docstrings-mandatory - pywikibot-core-tox-nose - pywikibot-core-tox-nose34-jessie -- tox-doc-jessie +- tox-jessie # runs envs from testenv::jenkins ie: flake8,flake8-py3,flake8-docstrings-mandatory,doc gate-and-submit: -- tox-flake8 -- pywikibot-core-tox-flake8-py3-jessie -- pywikibot-core-tox-flake8-docstrings-mandatory - pywikibot-core-tox-nose - pywikibot-core-tox-nose34-jessie -- tox-doc-jessie +- tox-jessie # runs envs from testenv::jenkins ie: flake8,flake8-py3,flake8-docstrings-mandatory,doc That aggregates flake8/doc, but that might end up being over complicated to maintain. Also I noticed we run the `nose`/`nose34` envs, not the `py27`, `py34` ones. Maybe that can be revisited as well. TASK DETAIL https://phabricator.wikimedia.org/T87169 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb, hashar Cc: Ricordisamoa, gerritbot, hashar, Legoktm, pywikibot-bugs-list, jayvdb, Aklapper, greg ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T74863: add coverage report to tests
hashar added subscribers: Andrew, hashar. hashar added a comment. We have an epic task to provide pre merge code coverage report T101544: Provide (pre-merge) code coverage reports on patchsets <https://phabricator.wikimedia.org/T101544> That is blocked on T101545: Provide infrastructure to store files by project/branch post-merge to compare with pre-merge <https://phabricator.wikimedia.org/T101545>. Potentially we could use OpenStack Swift which is already used to hold files for the wiki projects. We need one for the https://phabricator.wikimedia.org/tag/beta-cluster-infrastructure/ to match production T64835: Setup a Swift cluster to match production <https://phabricator.wikimedia.org/T64835>. Quoting @andrew (labs ops) the last update was in November 2014: > To support Swift in labs I want to allow keystone/swift authentication for > service users so that we can have project- or tool-wide swift accounts. This > requires adding a second ldap backend to keystone, and multiple keystone auth > backends was broken in Havana. So as I understand it the idea is to have labs provide a per project Swift container where we will be able to push build artifacts such as logs / reports. Zuul has the support to pass Swift related parameters to jobs. TASK DETAIL https://phabricator.wikimedia.org/T74863 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hashar, Andrew, Ladsgroup, XZise, gerritbot, Aklapper, jayvdb, pywikibot-bugs-list ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T87169: run at least pep8 and pep257 for new changesets submitted to pywikibot/core for any user
hashar added a comment. Currently the Zuul conf has: - name: pywikibot/core test: - tox-flake8 - pywikibot-core-tox-flake8-py3-jessie - pywikibot-core-tox-flake8-docstrings - pywikibot-core-tox-flake8-docstrings-mandatory - pywikibot-core-tox-nose - pywikibot-core-tox-nose34-jessie - tox-doc-jessie gate-and-submit: - tox-flake8 - pywikibot-core-tox-flake8-py3-jessie - pywikibot-core-tox-flake8-docstrings-mandatory - pywikibot-core-tox-nose - pywikibot-core-tox-nose34-jessie - tox-doc-jessie We can replace most of that with `tox-jessie`. TASK DETAIL https://phabricator.wikimedia.org/T87169 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb, hashar Cc: Ricordisamoa, gerritbot, hashar, Legoktm, pywikibot-bugs-list, jayvdb, Aklapper, greg ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T114420: Invalid version number (ValueError exception) for newest pypi version
hashar added a blocked task: T113039: Run unit tests with Jenkins in labs/tools/heritage. TASK DETAIL https://phabricator.wikimedia.org/T114420 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hashar, gerritbot, JeanFred, pywikibot-bugs-list, XZise, Avicennasis, Aklapper, Jagwar ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T114484: pywikibot==2.0rc1.post2 fails with ValueError: Invalid version number "1.27.0-wmf.1"
hashar created this task.
hashar assigned this task to JeanFred.
hashar added subscribers: hashar, gerritbot, JeanFred, Aklapper.
hashar added projects: Wiki-Loves-Monuments-Database, pywikibot-core.
Herald added a subscriber: pywikibot-bugs-list.
TASK DESCRIPTION
`labs/tools/heritage` depends on `pywikibot` which is currently
`2.0rc1.post2` in Pypi:
```
...
File ".tox/py27/lib/python2.7/site-packages/pywikibot/site.py", line 2147,
in _build_namespaces
is_mw114 = MediaWikiVersion(self.version()) >= MediaWikiVersion('1.14')
File "python2.7/distutils/version.py", line 40, in __init__
self.parse(vstring)
File ".tox/py27/lib/python2.7/site-packages/pywikibot/tools/__init__.py",
line 331, in parse
raise ValueError('Invalid version number "{0}"'.format(vstring))
ValueError: Invalid version number "1.27.0-wmf.1"
```
:-(
TASK DETAIL
https://phabricator.wikimedia.org/T114484
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeanFred, hashar
Cc: pywikibot-bugs-list, Aklapper, JeanFred, gerritbot, hashar, intracer, jayvdb
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T114484: pywikibot==2.0rc1.post2 fails with ValueError: Invalid version number "1.27.0-wmf.1"
hashar added a comment. $ . .tox/py27/bin/activate $ pip freeze cov-core==1.15.0 coverage==4.0 funcsigs==0.4 httplib2==0.9.2 ipaddress==1.0.14 mock==1.3.0 mwparserfromhell==0.4.2 MySQL-python==1.2.5 nose==1.3.7 nose-cov==1.6 pbr==1.8.0 pywikibot==2.0rc1.post2 six==1.9.0 wheel==0.24.0 TASK DETAIL https://phabricator.wikimedia.org/T114484 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JeanFred, hashar Cc: pywikibot-bugs-list, Aklapper, JeanFred, gerritbot, hashar, intracer ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T114420: Invalid version number (ValueError exception) for newest pypi version
hashar added a comment. `labs/tools/heritage` now manages to install properly. Thanks! TASK DETAIL https://phabricator.wikimedia.org/T114420 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw, hashar Cc: hashar, gerritbot, JeanFred, pywikibot-bugs-list, XZise, Avicennasis, Aklapper, Jagwar ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T113517: Search test failed
hashar added a subscriber: hashar. hashar closed this task as "Resolved". hashar added a comment. Seems http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query=search=wiki works now. Thanks @Ebernhardson ! TASK DETAIL https://phabricator.wikimedia.org/T113517 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EBernhardson, hashar Cc: hashar, gerritbot, EBernhardson, greg, Luke081515, pywikibot-bugs-list, Aklapper, XZise, Deskana, scfc, jeremyb ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T85335: Jenkins job to validate JSON files submitted to Gerrit repo pywikibot/i18n
hashar added a comment. Summary GruntJS support globbing patterns http://gruntjs.com/configuring-tasks#globbing-patterns. Well done! TASK DETAIL https://phabricator.wikimedia.org/T85335 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb, hashar Cc: Krinkle, Jdforrester-WMF, Legoktm, Ricordisamoa, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, pywikibot-bugs-list, Gryllida, Shizhao, Arrbee, greg, Malyacko ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
