Lokal_Profil added a comment.
In T143594#3086787, @Dalba wrote:
Thanks, André!
Thank you for the patient reviewing :)TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Dalba, Xqt, Beta16,
gerritbot added a comment.
Change 339389 merged by jenkins-bot:
[pywikibot/core] Allow retrieval of unit as ItemPage for WbQuantity
https://gerrit.wikimedia.org/r/339389TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL
gerritbot added a comment.
Change 339389 had a related patch set uploaded (by Lokal Profil):
[pywikibot/core] Allow retrieval of unit as ItemPage for WbQuantity
https://gerrit.wikimedia.org/r/339389TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL
gerritbot added a comment.
Change 319835 abandoned by Lokal Profil:
Support adding units to WbQuantity through the entity url
Reason:
abandoned in favour of https://gerrit.wikimedia.org/r/334908
https://gerrit.wikimedia.org/r/319835TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL
Lokal_Profil added a comment.
In T143594#2980621, @gerritbot wrote:
Change 334908 had a related patch set uploaded (by Lokal Profil):
Support adding units to WbQuantity through ItemPage or entity url
https://gerrit.wikimedia.org/r/334908
@Dalba: This is your requested solution with only one
gerritbot added a comment.
Change 334908 had a related patch set uploaded (by Lokal Profil):
Support adding units to WbQuantity through ItemPage or entity url
https://gerrit.wikimedia.org/r/334908TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL
Lokal_Profil added a comment.
In T143594#2932697, @Dalba wrote:
You mean having unit take either an entity url or a pywikibot.ItemPage? Rather than splitting these over two parameters?
Yes.
and keeps it more in line with how Coordinate is handled.
Maybe the entity parameter of Coordinate
Dalba added a comment.
You mean having unit take either an entity url or a pywikibot.ItemPage? Rather than splitting these over two parameters?
Yes.
and keeps it more in line with how Coordinate is handled.
Maybe the entity parameter of Coordinate should also be changed to accept both a URL or
Lokal_Profil added a comment.
@Dalba: You mean having unit take either an entity url or a pywikibot.ItemPage? Rather than splitting these over two parameters? (Note that there are two patches)
My personal opinion is that the separation makes it clearer, makes it easier to convert between the two
Dalba added a comment.
Would it be a bad idea to use unit for passing its URL, too? I find it more intuitive than entity, but it it could be just me not being familiar with wikibase terminology.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL
Lokal_Profil added a comment.
@Xqt Have you had an opportunity to look at the second two parts of the set of patches?TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Xqt, Beta16, Multichill,
gerritbot added a comment.
Change 319834 merged by jenkins-bot:
Expose the concept url of an ItemPage
https://gerrit.wikimedia.org/r/319834TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Xqt,
gerritbot added a comment.
Change 315645 abandoned by Lokal Profil:
[Not ready] Support adding units to WbQuantity through ItemPage or URI
Reason:
Abandoned in favour of Icdcfed92df7734d5162c432a2c6d3d00a1526491 and it's two dependencies
https://gerrit.wikimedia.org/r/315645TASK
gerritbot added a comment.
Change 306037 abandoned by Lokal Profil:
Support adding units to WbQuantity through the entity url
Reason:
Abandoned in favour of Icdcfed92df7734d5162c432a2c6d3d00a1526491 and it's two dependencies
https://gerrit.wikimedia.org/r/306037TASK
gerritbot added a comment.
Change 319834 had a related patch set uploaded (by Lokal Profil):
Expose the concept url of an ItemPage
https://gerrit.wikimedia.org/r/319834TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL
gerritbot added a comment.
Change 319835 had a related patch set uploaded (by Lokal Profil):
Support adding units to WbQuantity through the entity url
https://gerrit.wikimedia.org/r/319835TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL
Lokal_Profil added a comment.
In T143594#2712657, @Multichill wrote:
Wouldn't it be easier to just except unit as an ItemPage or an entity url? No need to introduce a new "entity" variable here.
Gives it the same structure as Coordinate and makes it easier to go to/from wikibase formatTASK
Multichill added a comment.
Wouldn't it be easier to just except unit as an ItemPage or an entity url? No need to introduce a new "entity" variable here.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Lokal_Profil added a comment.
In T143594#2712037, @gerritbot wrote:
Change 315645 had a related patch set uploaded (by Lokal Profil):
[Not ready] Support adding units to WbQuantity through ItemPage or URI
https://gerrit.wikimedia.org/r/315645
@Multichill This patch should (when upstream is
gerritbot added a comment.
Change 315645 had a related patch set uploaded (by Lokal Profil):
[Not ready] Support adding units to WbQuantity through ItemPage or URI
https://gerrit.wikimedia.org/r/315645TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL
Multichill added a comment.
@Lokal_Profil would be nice if instead of an url, you could just pass an ItemPage object. That would be a good abstraction. For that the ItemPage does need to have a function that returns an entity url like http://www.wikidata.org/entity/Q3123TASK
Lokal_Profil added a comment.
The current patch is the first step in being able to add units using their Qids instead of entity_urls (same set-up as for globe in Coordinates).
it is also true that the documentation didn't reflect what was happening. This patch also fixes that.TASK
ArthurPSmith added a comment.
I'm not sure what the issue is here - you can enter a unit URL via the WbQuantity initializer (unit = 'http://www.wikidata.org/entity/Q') and it works fine. The documentation in __init__.py seems to be out of date on this though.TASK
Lokal_Profil added a comment.
One thing which could help would be if entity_prefix was added to siteinfo (cf. articlepath). That way we could at least easily construct entity references (cf. BasePage.full_url()) for items in (known) wikibase repositories.TASK
Lokal_Profil added a comment.
In T143594#2572898, @gerritbot wrote:
Change 306037 had a related patch set uploaded (by Lokal Profil):
Support adding units to WbQuantity through the entity url
https://gerrit.wikimedia.org/r/306037
This only adds the ability to add the entity url directly
gerritbot added a comment.
Change 306037 had a related patch set uploaded (by Lokal Profil):
Support adding units to WbQuantity through the entity url
https://gerrit.wikimedia.org/r/306037TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL
26 matches
Mail list logo
