[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
Lokal_Profil added a comment. In T143594#3086787, @Dalba wrote: Thanks, André! Thank you for the patient reviewing :)TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Dalba, Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, jayvdb, Ricordisamoa, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
gerritbot added a comment. Change 339389 merged by jenkins-bot: [pywikibot/core] Allow retrieval of unit as ItemPage for WbQuantity https://gerrit.wikimedia.org/r/339389TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Dalba, Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, jayvdb, Ricordisamoa, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
gerritbot added a comment. Change 339389 had a related patch set uploaded (by Lokal Profil): [pywikibot/core] Allow retrieval of unit as ItemPage for WbQuantity https://gerrit.wikimedia.org/r/339389TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Dalba, Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, jayvdb, Ricordisamoa, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
Lokal_Profil added a comment. https://gerrit.wikimedia.org/r/#/c/339389/ Holds the last bit of this puzzle. Returning the unit as an ItemPage for downstream consumption.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Dalba, Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, jayvdb, Ricordisamoa, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
gerritbot added a comment. Change 319835 abandoned by Lokal Profil: Support adding units to WbQuantity through the entity url Reason: abandoned in favour of https://gerrit.wikimedia.org/r/334908 https://gerrit.wikimedia.org/r/319835TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Dalba, Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, MarcAbonce, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, jayvdb, Ricordisamoa, Wesalius, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
gerritbot added a comment. Change 334908 merged by jenkins-bot: Support adding units to WbQuantity through ItemPage or entity url https://gerrit.wikimedia.org/r/334908TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Dalba, Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, MarcAbonce, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Ricordisamoa, Wesalius, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
Lokal_Profil added a comment. @Dalba Sorry for the delayed reply to your review. Have answered nowTASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Dalba, Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Ricordisamoa, Wesalius, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
Lokal_Profil added a comment. In T143594#2980621, @gerritbot wrote: Change 334908 had a related patch set uploaded (by Lokal Profil): Support adding units to WbQuantity through ItemPage or entity url https://gerrit.wikimedia.org/r/334908 @Dalba: This is your requested solution with only one parameter. It needs ano additional bit of internal juggling to deal with unit='1' but I think it ends up being better than the previous implementation.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Dalba, Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Ricordisamoa, Wesalius, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
gerritbot added a comment. Change 334908 had a related patch set uploaded (by Lokal Profil): Support adding units to WbQuantity through ItemPage or entity url https://gerrit.wikimedia.org/r/334908TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Dalba, Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Ricordisamoa, Wesalius, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
Lokal_Profil added a comment. In T143594#2932697, @Dalba wrote: You mean having unit take either an entity url or a pywikibot.ItemPage? Rather than splitting these over two parameters? Yes. and keeps it more in line with how Coordinate is handled. Maybe the entity parameter of Coordinate should also be changed to accept both a URL or an ItemPage? I haven't checked if combining the two is possible but can take a look if you feel it is a blocker. I don't know if "blocker" is the right term for it, I wouldn't even -1 the current patch because of this, but I surely appreciate if you could take some time to see if what I suggested can implemented in a neat way or not and maybe upload a separate patch for it. I'll take a closer look and see if it can be implemented in that way. My only worry (without having looked at it closer yet) is the fact that "no unit" is passed around as the literal "1".TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Dalba, Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Ricordisamoa, Wesalius, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
Dalba added a comment. You mean having unit take either an entity url or a pywikibot.ItemPage? Rather than splitting these over two parameters? Yes. and keeps it more in line with how Coordinate is handled. Maybe the entity parameter of Coordinate should also be changed to accept both a URL or an ItemPage? I haven't checked if combining the two is possible but can take a look if you feel it is a blocker. I don't know if "blocker" is the right term for it, I wouldn't even -1 the current patch because of this, but I surely appreciate if you could take some time to see if what I suggested can implemented in a neat way or not and maybe upload a separate patch for it.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Dalba, Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Ricordisamoa, Wesalius, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
Lokal_Profil added a comment. @Dalba: You mean having unit take either an entity url or a pywikibot.ItemPage? Rather than splitting these over two parameters? (Note that there are two patches) My personal opinion is that the separation makes it clearer, makes it easier to convert between the two and keeps it more in line with how Coordinate is handled. I haven't checked if combining the two is possible but can take a look if you feel it is a blocker.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Dalba, Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Ricordisamoa, Wesalius, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
Dalba added a comment. Would it be a bad idea to use unit for passing its URL, too? I find it more intuitive than entity, but it it could be just me not being familiar with wikibase terminology.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Dalba, Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Ricordisamoa, Wesalius, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
Lokal_Profil added a comment. @Xqt Have you had an opportunity to look at the second two parts of the set of patches?TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Ramalepe, Liugev6, Magul, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa, Wesalius, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
gerritbot added a comment. Change 319834 merged by jenkins-bot: Expose the concept url of an ItemPage https://gerrit.wikimedia.org/r/319834TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa, Wesalius, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
gerritbot added a comment. Change 315645 abandoned by Lokal Profil: [Not ready] Support adding units to WbQuantity through ItemPage or URI Reason: Abandoned in favour of Icdcfed92df7734d5162c432a2c6d3d00a1526491 and it's two dependencies https://gerrit.wikimedia.org/r/315645TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Miriya52, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa, Wesalius, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
gerritbot added a comment. Change 306037 abandoned by Lokal Profil: Support adding units to WbQuantity through the entity url Reason: Abandoned in favour of Icdcfed92df7734d5162c432a2c6d3d00a1526491 and it's two dependencies https://gerrit.wikimedia.org/r/306037TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Miriya52, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa, Wesalius, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
gerritbot added a comment. Change 319834 had a related patch set uploaded (by Lokal Profil): Expose the concept url of an ItemPage https://gerrit.wikimedia.org/r/319834TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Miriya52, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa, Wesalius, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
gerritbot added a comment. Change 319835 had a related patch set uploaded (by Lokal Profil): Support adding units to WbQuantity through the entity url https://gerrit.wikimedia.org/r/319835TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Miriya52, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa, Wesalius, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
Lokal_Profil added a comment. In T143594#2712657, @Multichill wrote: Wouldn't it be easier to just except unit as an ItemPage or an entity url? No need to introduce a new "entity" variable here. Gives it the same structure as Coordinate and makes it easier to go to/from wikibase formatTASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa, Wesalius, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
Multichill added a comment. Wouldn't it be easier to just except unit as an ItemPage or an entity url? No need to introduce a new "entity" variable here.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MultichillCc: Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa, Wesalius, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
Lokal_Profil added a comment. In T143594#2712037, @gerritbot wrote: Change 315645 had a related patch set uploaded (by Lokal Profil): [Not ready] Support adding units to WbQuantity through ItemPage or URI https://gerrit.wikimedia.org/r/315645 @Multichill This patch should (when upstream is deployed) allow you to set unit with either ItemPage or the URI. There are some question marks as to how I set @need_version (or similar) for a particular version of Wikibase and whether pywikibot.warning is the right mechanism for informing users of an undocumented previous feature that they should update their code (I've made it so that their edits work like before though).TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa, Wesalius, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
gerritbot added a comment. Change 315645 had a related patch set uploaded (by Lokal Profil): [Not ready] Support adding units to WbQuantity through ItemPage or URI https://gerrit.wikimedia.org/r/315645TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa, Wesalius, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
Multichill added a comment. @Lokal_Profil would be nice if instead of an url, you could just pass an ItemPage object. That would be a good abstraction. For that the ItemPage does need to have a function that returns an entity url like http://www.wikidata.org/entity/Q3123TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MultichillCc: Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa, Wesalius, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
Lokal_Profil added a comment. The current patch is the first step in being able to add units using their Qids instead of entity_urls (same set-up as for globe in Coordinates). it is also true that the documentation didn't reflect what was happening. This patch also fixes that.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
ArthurPSmith added a comment. I'm not sure what the issue is here - you can enter a unit URL via the WbQuantity initializer (unit = 'http://www.wikidata.org/entity/Q') and it works fine. The documentation in __init__.py seems to be out of date on this though.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArthurPSmithCc: ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
Lokal_Profil added a comment. One thing which could help would be if entity_prefix was added to siteinfo (cf. articlepath). That way we could at least easily construct entity references (cf. BasePage.full_url()) for items in (known) wikibase repositories.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
Lokal_Profil added a comment. In T143594#2572898, @gerritbot wrote: Change 306037 had a related patch set uploaded (by Lokal Profil): Support adding units to WbQuantity through the entity url https://gerrit.wikimedia.org/r/306037 This only adds the ability to add the entity url directly (compare to Coordinate). We still need to figure out how we want to use the unit parameter.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T143594: Add unit support to WbQuantity
gerritbot added a comment. Change 306037 had a related patch set uploaded (by Lokal Profil): Support adding units to WbQuantity through the entity url https://gerrit.wikimedia.org/r/306037TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Mdupont, JJMC89, jayvdb, Ricordisamoa___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
