Re: [Qbs] How to get the full dependency name in a ModuleProvider?

2020-08-01 Thread Alberto Mardegan
On 31/07/20 11:03, Christian Kandeler wrote:
> There's probably no harm in adding a "fullName" property containing the 
> string from the Depends item. Possibly it could even be the value of "name", 
> but I'd have to take a closer look to determine what makes more sense 
> semantically.

Maybe we can keep "name" the way it is (after all, it's the name of the
ModuleProvider, so it kind of makes sense that it matches its location)
and add a "dependencyName" property containing the full dependency name.

Incidentally, the following properties of the Depends item could also be
very useful to the module provider:

submodules : stringList
versionAtLeast : string
versionBelow : string

maybe, then, it would make more sense to add a "dependencyInfo" property
as an object containing the three properties above, and the original
"name" from the Depends directive?

Ciao,
  Alberto

-- 
http://www.mardy.it - Geek in un lingua international
___
Qbs mailing list
Qbs@qt-project.org
https://lists.qt-project.org/listinfo/qbs


Re: [Qbs] How to get the full dependency name in a ModuleProvider?

2020-07-31 Thread Jochen Ulrich
No, I didn't file issues in JIRA yet because there is a discussion going on 
regarding a different way to handle external dependencies.
See https://codereview.qt-project.org/c/qbs/qbs/+/297830

So it's not clear to me yet if the Conan integration will be based on 
ModuleProviders or on that Package mechanism.

Best
Jochen

Am 31.07.20, 13:27 schrieb "Alberto Mardegan" :

Il 31.07.2020 11:28, Jochen Ulrich ha scritto:
> We also stumbled over this and a few more shortcomings of ModuleProviders 
when writing a ModuleProvider to integrate the Conan package manager with Qbs.
> See this thread: 
https://lists.qt-project.org/pipermail/qbs/2020-February/002649.html

Interesting! You didn't find these as issues in JIRA< did you? At least, 
I couldn't find them out of a quick search.

Ciao,
   Alberto

___
Qbs mailing list
Qbs@qt-project.org
https://lists.qt-project.org/listinfo/qbs


Re: [Qbs] How to get the full dependency name in a ModuleProvider?

2020-07-31 Thread Alberto Mardegan

Il 31.07.2020 11:28, Jochen Ulrich ha scritto:

We also stumbled over this and a few more shortcomings of ModuleProviders when 
writing a ModuleProvider to integrate the Conan package manager with Qbs.
See this thread: 
https://lists.qt-project.org/pipermail/qbs/2020-February/002649.html


Interesting! You didn't find these as issues in JIRA< did you? At least, 
I couldn't find them out of a quick search.


Ciao,
  Alberto
___
Qbs mailing list
Qbs@qt-project.org
https://lists.qt-project.org/listinfo/qbs


Re: [Qbs] How to get the full dependency name in a ModuleProvider?

2020-07-31 Thread Jochen Ulrich
Hi!

> it does not look like there is any way to get the full dependency name

We also stumbled over this and a few more shortcomings of ModuleProviders when 
writing a ModuleProvider to integrate the Conan package manager with Qbs.
See this thread: 
https://lists.qt-project.org/pipermail/qbs/2020-February/002649.html

Best
Jochen

___
Qbs mailing list
Qbs@qt-project.org
https://lists.qt-project.org/listinfo/qbs


Re: [Qbs] How to get the full dependency name in a ModuleProvider?

2020-07-31 Thread Christian Kandeler
On Thu, 30 Jul 2020 23:32:11 +0300
Alberto Mardegan  wrote:

>I started playing with ModuleProvider, and I find the "name" property 
> a bit confusing: if the dependency was specified as
> 
>  Depends { name: "myprovider.a" }
> 
> the the module provider in "module-providers/myprovider/provider.qbs" 
> only sees "myprovider" as "name" property -- the "a" is lost.
> 
> But "a" is, in my case, the important bit of information, because I need 
> to look up some files in the filesystem based on which dependency is 
> specified. Looking at the QBS source code 
> (src/lib/corelib/language/moduleloader.cpp), it does not look like there 
> is any way to get the full dependency name.
> 
> Did I overlook something? If not, would you consider the addition of a 
> "relativeName" property, which QBS would set to the second part of the 
> name (the one currently being left out, that is "a" in this example), if 
> I provide the code for it?

There's probably no harm in adding a "fullName" property containing the string 
from the Depends item. Possibly it could even be the value of "name", but I'd 
have to take a closer look to determine what makes more sense semantically.


Christian
___
Qbs mailing list
Qbs@qt-project.org
https://lists.qt-project.org/listinfo/qbs


Re: [Qbs] How to get the full dependency name in a ModuleProvider?

2020-07-31 Thread Alberto Mardegan
Adding one more question, to make sure I do not misunderstand the role 
of a ModuleProvider:


Il 30.07.2020 23:32, Alberto Mardegan ha scritto:
   I started playing with ModuleProvider, and I find the "name" property 
a bit confusing: if the dependency was specified as


     Depends { name: "myprovider.a" }

the the module provider in "module-providers/myprovider/provider.qbs" 
only sees "myprovider" as "name" property -- the "a" is lost.


why does the ModuleProvider name contain a piece of data which is anyway 
known to the ModuleProvider (because it's anyway encoded in its file 
path)? What is the point of this property?


Ciao,
  Alberto
___
Qbs mailing list
Qbs@qt-project.org
https://lists.qt-project.org/listinfo/qbs


[Qbs] How to get the full dependency name in a ModuleProvider?

2020-07-30 Thread Alberto Mardegan

Hi again!
  I started playing with ModuleProvider, and I find the "name" property 
a bit confusing: if the dependency was specified as


Depends { name: "myprovider.a" }

the the module provider in "module-providers/myprovider/provider.qbs" 
only sees "myprovider" as "name" property -- the "a" is lost.


But "a" is, in my case, the important bit of information, because I need 
to look up some files in the filesystem based on which dependency is 
specified. Looking at the QBS source code 
(src/lib/corelib/language/moduleloader.cpp), it does not look like there 
is any way to get the full dependency name.


Did I overlook something? If not, would you consider the addition of a 
"relativeName" property, which QBS would set to the second part of the 
name (the one currently being left out, that is "a" in this example), if 
I provide the code for it?


Ciao,
  Alberto
___
Qbs mailing list
Qbs@qt-project.org
https://lists.qt-project.org/listinfo/qbs