[Qemu-block] [PATCH] block: Fix leak of ignore_children in error path

Reported-by: Max Reitz Signed-off-by: Fam Zheng --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 75a9fd49de..c1fda9fd57 100644 --- a/block.c +++ b/block.c @@ -3671,12 +3671,12 @@ int

[Qemu-block] [PATCH] vvfat: Fix inherit_options flags

Overriding flags violates the precedence rules of bdrv_reopen_queue_child. Just like the read-only option, no-flush should be put into the options. The same is done in bdrv_temp_snapshot_options. Reported-by: Stefan Hajnoczi ---

Re: [Qemu-block] [Qemu-devel] [PULL 18/41] blockjobs: add block-job-finalize

On 03/13/2018 02:47 PM, Eric Blake wrote: > On 03/13/2018 11:17 AM, Kevin Wolf wrote: >> From: John Snow >> >> Instead of automatically transitioning from PENDING to CONCLUDED, gate >> the .prepare() and .commit() phases behind an explicit acknowledgement >> provided by the

Re: [Qemu-block] [PATCH v2 3/5] block/throttle: Remove protocol-related fields

On Mon 12 Mar 2018 11:07:51 PM CET, Fabiano Rosas wrote: > The throttle driver is not a protocol so it should implement bdrv_open > instead of bdrv_file_open and not provide a protocol_name. > > Attempts to invoke this driver using protocol syntax > (i.e. throttle:) will now fail gracefully: > >

Re: [Qemu-block] [PATCH v2 2/5] block/quorum: Remove protocol-related fields

On Mon 12 Mar 2018 11:07:50 PM CET, Fabiano Rosas wrote: > The quorum driver is not a protocol so it should implement bdrv_open > instead of bdrv_file_open and not provide a protocol_name. > > Attempts to invoke this driver using protocol syntax > (i.e. quorum:) will now fail gracefully: > > $

Re: [Qemu-block] [Qemu-devel] [PATCH for 2.12] iotests: Avoid realpath

On 03/14/2018 09:38 AM, Eric Blake wrote: CentOS 6 lacks a realpath binary on the base install, which makes all iotests runs fail: 001 - output mismatch (see 001.out.bad) ./check: line 815: realpath: command not found diff: missing operand after

[Qemu-block] [PATCH for 2.12] iotests: Avoid realpath

CentOS 6 lacks a realpath binary on the base install, which makes all iotests runs fail: 001 - output mismatch (see 001.out.bad) ./check: line 815: realpath: command not found diff: missing operand after `/home/dummy/qemu/tests/qemu-iotests/001.out' diff: Try `diff --help' for more

Re: [Qemu-block] [Qemu-devel] [PATCH 3/7] qcow: Support .bdrv_co_create

On Wed, Mar 14, 2018 at 06:16:18AM -0500, Eric Blake wrote: > On 03/09/2018 03:46 PM, Kevin Wolf wrote: > > This adds the .bdrv_co_create driver callback to qcow, which > > enables image creation over QMP. > > > > Signed-off-by: Kevin Wolf > > --- > > qapi/block-core.json |

Re: [Qemu-block] [PATCH 3/7] qcow: Support .bdrv_co_create

On 03/09/2018 03:46 PM, Kevin Wolf wrote: This adds the .bdrv_co_create driver callback to qcow, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 21 +- block/qcow.c | 196

Re: [Qemu-block] [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration

* Su Hang (suhan...@mails.ucas.ac.cn) wrote: > > Sincerely sorry for my negligence to cause this bug! > I will fix it as quick as I can! > > Sorry again, I'm really ashamed about the mistake I have made. No need to be ashamed; bugs happen! Dave > Su Hang > > > -Original Messages- > >

[Qemu-block] [PATCH v2 1/2] qcow2: Give the refcount cache the minimum possible size by default

The L2 and refcount caches have default sizes that can be overridden using the l2-cache-size and refcount-cache-size (an additional parameter named cache-size sets the combined size of both caches). Unless forced by one of the aforementioned parameters, QEMU will set the unspecified sizes so that

[Qemu-block] [PATCH v2 2/2] docs: Document the new default sizes of the qcow2 caches

We have just reduced the refcount cache size to the minimum unless the user explicitly requests a larger one, so we have to update the documentation to reflect this change. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake --- docs/qcow2-cache.txt | 31

[Qemu-block] [PATCH v2 0/2] Give the refcount cache the minimum possible size by default

Hi, we talked about this the other day, so here are the patches to change the default cache sizes in qcow2. Without this patch: * refcount-cache-size = l2-cache-size / 4 unless otherwise specified by the user. This is wasteful, the refcount cache is accessed sequentially during normal I/O, so

Re: [Qemu-block] [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration

Sincerely sorry for my negligence to cause this bug! I will fix it as quick as I can! Sorry again, I'm really ashamed about the mistake I have made. Su Hang > -Original Messages- > From: "Dr. David Alan Gilbert" > Sent Time: 2018-03-14 04:10:24 (Wednesday) > To: