On 19/03/2020 18:02, John Snow wrote:
> On 3/19/20 8:33 AM, Peter Maydell wrote:
>> On Tue, 17 Mar 2020 at 23:23, John Snow wrote:
>>>
>>> The following changes since commit 373c7068dd610e97f0b551b5a6d0a27cd6da4506:
>>>
>>> qemu.nsi: Install Sphinx documentation (2020-03-09 16:45:00 +)
>>>
On Mon, 23 Mar 2020, John Snow wrote:
On 3/23/20 1:04 PM, BALATON Zoltan wrote:
On Mon, 23 Mar 2020, Peter Maydell wrote:
Coverity points out (CID 1421984) that we are leaking the
memory returned by qemu_allocate_irqs(). We can avoid this
leak by switching to using qdev_init_gpio_in(); the
A discard request deallocates the selected clusters so they read back
as zeroes. This is done by clearing the cluster offset field and
setting QCOW_OFLAG_ZERO in the L2 entry.
This flag is however only supported when qcow_version >= 3. In older
images the cluster is simply deallocated, exposing
When external event sources are disabled fdmon-io_uring falls back to
fdmon-poll. The ->need_wait() callback needs to watch for this so it
can return true when external event sources are disabled.
It is also necessary to call ->wait() when AioHandlers have changed
because io_uring is
The following changes since commit 29e0855c5af62bbb0b0b6fed792e004dad92ba95:
Merge remote-tracking branch 'remotes/elmarco/tags/slirp-pull-request' into
staging (2020-03-22 21:00:38 +)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/block-pull-request
On 3/23/20 10:32 AM, BALATON Zoltan wrote:
> Coverity CID 1421984 reports a leak in allocated irqs, this patch
> attempts to plug that.
>
> Signed-off-by: BALATON Zoltan
Dequeueing in favor of Peter Maydell's patch.
(Let me know if you feel that is a mistake.)
On 3/21/20 10:41 AM, Philippe Mathieu-Daudé wrote:
> Fix warning reported by Clang static code analyzer:
>
> CC hw/ide/sii3112.o
> hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read
> val = 0;
> ^ ~
>
> Fixes: a9dd6604
> Reported-by: Clang
On 3/23/20 1:04 PM, BALATON Zoltan wrote:
> On Mon, 23 Mar 2020, Peter Maydell wrote:
>> Coverity points out (CID 1421984) that we are leaking the
>> memory returned by qemu_allocate_irqs(). We can avoid this
>> leak by switching to using qdev_init_gpio_in(); the base
>> class finalize will
On 3/23/20 8:23 AM, Max Reitz wrote:
> On 12.03.20 23:19, John Snow wrote:
>>
>>
>> On 3/11/20 10:07 AM, Max Reitz wrote:
>>> data_file does not work with v2, and we probably want 026 to keep
>>> working for v2 images. Thus, open a new file for v3-exclusive error
>>> path test cases.
>>>
>>>
On 3/20/20 6:21 AM, Philippe Mathieu-Daudé wrote:
> On 3/13/20 9:36 AM, Kevin Wolf wrote:
>> Waiting for only 1 second proved to be too short on a loaded system,
>> resulting in false positives when testing pull requests. Increase the
>> timeout a bit to make this less likely.
>>
>>
Hi
On Mon, Mar 23, 2020 at 6:41 PM Kevin Wolf wrote:
>
> Am 18.03.2020 um 16:36 hat Markus Armbruster geschrieben:
> > Kevin Wolf writes:
> >
> > > This moves the QMP dispatcher to a coroutine and runs all QMP command
> > > handlers that declare 'coroutine': true in coroutine context so they
>
Hi Kevin,
I'm hoping to get some preliminary ideas from you (capped at five
minutes' effort?) on this subject. My ideas here are a bit shaky, I only
have really rough notions here.
We want to use bitmaps with 'drive' semantics; i.e. tracking changes to
the visible guest data. What we have are
Am 18.03.2020 um 16:36 hat Markus Armbruster geschrieben:
> Kevin Wolf writes:
>
> > This moves the QMP dispatcher to a coroutine and runs all QMP command
> > handlers that declare 'coroutine': true in coroutine context so they
> > can avoid blocking the main loop while doing I/O or waiting for
On Mon, 23 Mar 2020 at 17:04, BALATON Zoltan wrote:
>
> On Mon, 23 Mar 2020, Peter Maydell wrote:
> > Coverity points out (CID 1421984) that we are leaking the
> > memory returned by qemu_allocate_irqs(). We can avoid this
> > leak by switching to using qdev_init_gpio_in(); the base
> > class
On Mon, 23 Mar 2020, Peter Maydell wrote:
Coverity points out (CID 1421984) that we are leaking the
memory returned by qemu_allocate_irqs(). We can avoid this
leak by switching to using qdev_init_gpio_in(); the base
class finalize will free the irqs that this allocates under
the hood.
On Sat, Mar 21, 2020 at 7:50 AM Philippe Mathieu-Daudé
wrote:
>
> pxa2xx_timer_tick4() takes an opaque pointer, then calls
> pxa2xx_timer_update4(), so the static analyzer can not
> verify that the 'n < 8':
>
> 425 static void pxa2xx_timer_tick4(void *opaque)
> 426 {
> 427 PXA2xxTimer4
On Sat, Mar 21, 2020 at 7:52 AM Philippe Mathieu-Daudé
wrote:
>
> Fix warning reported by Clang static code analyzer:
>
> CC hw/timer/stm32f2xx_timer.o
> hw/timer/stm32f2xx_timer.c:225:9: warning: Value stored to 'value' is never
> read
> value = timer_val;
> ^
On Sat, Mar 21, 2020 at 7:50 AM Philippe Mathieu-Daudé
wrote:
>
> Fix warnings reported by Clang static code analyzer:
>
> hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never
> read
> index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
> ^
23.03.2020 17:25, Denis Plotnikov wrote:
The patch adds some preparation parts for incompatible compression type
feature to qcow2 allowing the use different compression methods for
image clusters (de)compressing.
It is implied that the compression type is set on the image creation and
can be
On Sat, Mar 21, 2020 at 7:46 AM Philippe Mathieu-Daudé
wrote:
>
> Rename the unique variable assigned as 'pit' which better
> represents what it holds, to fix a warning reported by the
> Clang static code analyzer:
>
> CC hw/isa/i82378.o
> hw/isa/i82378.c:108:5: warning: Value stored
On Sat, Mar 21, 2020 at 7:45 AM Philippe Mathieu-Daudé
wrote:
>
> Fix warning reported by Clang static code analyzer:
>
> CC hw/i2c/pm_smbus.o
> hw/i2c/pm_smbus.c:187:17: warning: Value stored to 'ret' is never read
> ret = 0;
> ^ ~
>
>
On Sat, Mar 21, 2020 at 7:42 AM Philippe Mathieu-Daudé
wrote:
>
> Fix warning reported by Clang static code analyzer:
>
> block.c:3167:5: warning: Value stored to 'ret' is never read
> ret = bdrv_fill_options(, filename, , _err);
> ^
On Mon, 23 Mar 2020, Philippe Mathieu-Daudé wrote:
On 3/23/20 3:32 PM, BALATON Zoltan wrote:
Coverity CID 1421984 reports a leak in allocated irqs, this patch
attempts to plug that.
Signed-off-by: BALATON Zoltan
---
hw/ide/sii3112.c | 14 +++---
1 file changed, 11 insertions(+), 3
On Mon, 23 Mar 2020 at 15:28, BALATON Zoltan wrote:
> Is this documented anywhere?
Unfortunately not. You're quite right that we should document this
(I hadn't realized/had forgotten that the qdev gpio APIs are
entirely undocumented -- they date from a time when we were
much less strict about
On 3/23/20 4:17 PM, Peter Maydell wrote:
Coverity points out (CID 1421984) that we are leaking the
memory returned by qemu_allocate_irqs(). We can avoid this
leak by switching to using qdev_init_gpio_in(); the base
class finalize will free the irqs that this allocates under
the hood.
On Mon, 23 Mar 2020, Peter Maydell wrote:
On Mon, 23 Mar 2020 at 14:43, BALATON Zoltan wrote:
On Mon, 23 Mar 2020, Peter Maydell wrote:
On Mon, 23 Mar 2020 at 14:06, BALATON Zoltan wrote:
On Mon, 23 Mar 2020, Peter Maydell wrote:
Coverity has flagged up a lot of leaks involving
On 3/23/20 3:46 PM, Peter Maydell wrote:
On Mon, 23 Mar 2020 at 14:43, BALATON Zoltan wrote:
On Mon, 23 Mar 2020, Peter Maydell wrote:
On Mon, 23 Mar 2020 at 14:06, BALATON Zoltan wrote:
On Mon, 23 Mar 2020, Peter Maydell wrote:
Coverity has flagged up a lot of leaks involving
Coverity points out (CID 1421984) that we are leaking the
memory returned by qemu_allocate_irqs(). We can avoid this
leak by switching to using qdev_init_gpio_in(); the base
class finalize will free the irqs that this allocates under
the hood.
Signed-off-by: Peter Maydell
---
This is how the
On 3/23/20 3:55 PM, Laurent Vivier wrote:
Le 23/03/2020 à 15:45, Philippe Mathieu-Daudé a écrit :
On 3/23/20 3:32 PM, Laurent Vivier wrote:
Le 21/03/2020 à 15:40, Philippe Mathieu-Daudé a écrit :
Fix trivial warnings reported by the Clang static code analyzer.
Since v1:
- Addressed
Le 23/03/2020 à 15:45, Philippe Mathieu-Daudé a écrit :
> On 3/23/20 3:32 PM, Laurent Vivier wrote:
>> Le 21/03/2020 à 15:40, Philippe Mathieu-Daudé a écrit :
>>> Fix trivial warnings reported by the Clang static code analyzer.
>>>
>>> Since v1:
>>> - Addressed Markus/Zoltan/Aleksandar review
On 3/23/20 3:32 PM, BALATON Zoltan wrote:
Coverity CID 1421984 reports a leak in allocated irqs, this patch
attempts to plug that.
Signed-off-by: BALATON Zoltan
---
hw/ide/sii3112.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/hw/ide/sii3112.c
On Mon, 23 Mar 2020 at 14:43, BALATON Zoltan wrote:
>
> On Mon, 23 Mar 2020, Peter Maydell wrote:
> > On Mon, 23 Mar 2020 at 14:06, BALATON Zoltan wrote:
> >> On Mon, 23 Mar 2020, Peter Maydell wrote:
> >>> Coverity has flagged up a lot of leaks involving qemu_allocate_irqs();
> >>> most of them
On 3/23/20 3:32 PM, Laurent Vivier wrote:
Le 21/03/2020 à 15:40, Philippe Mathieu-Daudé a écrit :
Fix trivial warnings reported by the Clang static code analyzer.
Since v1:
- Addressed Markus/Zoltan/Aleksandar review comments
Philippe Mathieu-Daudé (11):
block: Avoid dead assignment
On Mon, 23 Mar 2020, Peter Maydell wrote:
On Mon, 23 Mar 2020 at 14:06, BALATON Zoltan wrote:
On Mon, 23 Mar 2020, Peter Maydell wrote:
Coverity has flagged up a lot of leaks involving qemu_allocate_irqs();
most of them I've for the moment just set as "insignificant, fix
required" because
Coverity CID 1421984 reports a leak in allocated irqs, this patch
attempts to plug that.
Signed-off-by: BALATON Zoltan
---
hw/ide/sii3112.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c
index 06605d7af2..c886916873 100644
On Mon, 23 Mar 2020 at 14:06, BALATON Zoltan wrote:
> On Mon, 23 Mar 2020, Peter Maydell wrote:
> > Coverity has flagged up a lot of leaks involving qemu_allocate_irqs();
> > most of them I've for the moment just set as "insignificant, fix
> > required" because they're in called-once functions
Le 21/03/2020 à 15:41, Philippe Mathieu-Daudé a écrit :
> Fix warning reported by Clang static code analyzer:
>
> CC hw/scsi/esp-pci.o
> hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read
> size = 4;
> ^ ~
>
> Reported-by: Clang Static
Le 21/03/2020 à 15:40, Philippe Mathieu-Daudé a écrit :
> Fix trivial warnings reported by the Clang static code analyzer.
>
> Since v1:
> - Addressed Markus/Zoltan/Aleksandar review comments
>
> Philippe Mathieu-Daudé (11):
> block: Avoid dead assignment
> blockdev: Remove dead assignment
>
zstd significantly reduces cluster compression time.
It provides better compression performance maintaining
the same level of the compression ratio in comparison with
zlib, which, at the moment, is the only compression
method available.
The performance test results:
Test compresses and
v9:
* 01: fix error checking and reporting in qcow2_amend compression type part
[Vladimir]
* 03: replace asserts with -EIO in qcow2_zstd_decompression [Vladimir,
Alberto]
* 03: reword/amend/add comments, fix typos [Vladimir]
v8:
* 03: switch zstd API from simple to stream [Eric]
The patch enables processing the image compression type defined
for the image and chooses an appropriate method for image clusters
(de)compression.
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
---
block/qcow2-threads.c | 71
The patch adds some preparation parts for incompatible compression type
feature to qcow2 allowing the use different compression methods for
image clusters (de)compressing.
It is implied that the compression type is set on the image creation and
can be changed only later by image conversion, thus
The test checks fulfilling qcow2 requiriements for the compression
type feature and zstd compression type operability.
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/287 | 128 +
tests/qemu-iotests/287.out
On 16.03.20 07:06, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> I faced use-after-free of bs->backing pointer after bdrv_unref_child in
> bdrv_set_backing_hd.
>
> Fix it, and do similar thing for s->data_file in qcow2.c.
>
> I'm not sure that this is the full fix. Is it safe to keep
On Mon, 23 Mar 2020, Peter Maydell wrote:
On Mon, 23 Mar 2020 at 13:12, BALATON Zoltan wrote:
On Mon, 23 Mar 2020, Philippe Mathieu-Daudé wrote:
Cc'ing qemu-ppc since this is restricted to the aCube Sam460ex board.
On 3/23/20 12:46 PM, Max Reitz wrote:
Hi,
I was triaging new Coverity block
On 18.03.20 23:22, Philippe Mathieu-Daudé wrote:
> bdrv_do_find_format() calls strcmp() using BlockDriver::format_name
> as argument, which must not be NULL. Assert this field is not null
> when we register a block driver in bdrv_register().
>
> Reported-by: Mansour Ahmadi
> Signed-off-by:
On Mon, 23 Mar 2020 at 13:12, BALATON Zoltan wrote:
>
> On Mon, 23 Mar 2020, Philippe Mathieu-Daudé wrote:
> > Cc'ing qemu-ppc since this is restricted to the aCube Sam460ex board.
> > On 3/23/20 12:46 PM, Max Reitz wrote:
> >> Hi,
> >>
> >> I was triaging new Coverity block layer reports today,
On 20.03.20 19:36, Eric Blake wrote:
> If we fail to get bitmap info, we must not leak the encryption info.
>
> Fixes: b8968c875f403
> Fixes: Coverity CID 1421894
> Signed-off-by: Eric Blake
> ---
> block/qcow2.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my block branch:
the G_IO_HUP is watched in tcp_chr_connect, and the callback
vhost_user_blk_watch is not needed, because tcp_chr_hup is registered as
callback. And it will close the tcp link.
Signed-off-by: Li Feng
---
hw/block/vhost-user-blk.c | 19 ---
On Fri, Mar 20, 2020 at 05:31:37AM -0700, dnbrd...@gmail.com wrote:
> From: Daniel Brodsky
>
> - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets
> - replaced result with QEMU_LOCK_GUARD if all unlocks at function end
> - replaced result with WITH_QEMU_LOCK_GUARD if unlock not at end
>
On 23.03.20 14:11, BALATON Zoltan wrote:
> On Mon, 23 Mar 2020, Philippe Mathieu-Daudé wrote:
>> Cc'ing qemu-ppc since this is restricted to the aCube Sam460ex board.
>> On 3/23/20 12:46 PM, Max Reitz wrote:
>>> Hi,
>>>
>>> I was triaging new Coverity block layer reports today, and one that
>>>
On Mon, 23 Mar 2020, Philippe Mathieu-Daudé wrote:
Cc'ing qemu-ppc since this is restricted to the aCube Sam460ex board.
On 3/23/20 12:46 PM, Max Reitz wrote:
Hi,
I was triaging new Coverity block layer reports today, and one that
seemed like a real bug was CID 1421984:
It complains about a
On 12.03.20 13:06, Vladimir Sementsov-Ogievskiy wrote:
> 12.03.2020 14:59, Vladimir Sementsov-Ogievskiy wrote:
>> 11.03.2020 14:06, Max Reitz wrote:
>>> On 30.01.20 16:22, Vladimir Sementsov-Ogievskiy wrote:
Prior to the commit the following command lead to crash:
./qemu-io
On 23.03.2020 15:47, Alberto Garcia wrote:
On Mon 23 Mar 2020 11:20:42 AM CET, Denis Plotnikov wrote:
But consider corrupted image: it may contain any data. And we should
not crash because of it. So, we should return error here.
If the image is corrupted we can't continue anyway. If we
On Mon 23 Mar 2020 11:20:42 AM CET, Denis Plotnikov wrote:
>> But consider corrupted image: it may contain any data. And we should
>> not crash because of it. So, we should return error here.
> If the image is corrupted we can't continue anyway. If we return -EIO
> on this condition, we need to do
On 23.03.2020 15:26, Vladimir Sementsov-Ogievskiy wrote:
23.03.2020 15:22, Denis Plotnikov wrote:
On 23.03.2020 11:00, Vladimir Sementsov-Ogievskiy wrote:
21.03.2020 17:34, Denis Plotnikov wrote:
The patch adds some preparation parts for incompatible compression
type
feature to qcow2
23.03.2020 15:22, Denis Plotnikov wrote:
On 23.03.2020 11:00, Vladimir Sementsov-Ogievskiy wrote:
21.03.2020 17:34, Denis Plotnikov wrote:
The patch adds some preparation parts for incompatible compression type
feature to qcow2 allowing the use different compression methods for
image
On 12.03.20 23:19, John Snow wrote:
>
>
> On 3/11/20 10:07 AM, Max Reitz wrote:
>> data_file does not work with v2, and we probably want 026 to keep
>> working for v2 images. Thus, open a new file for v3-exclusive error
>> path test cases.
>>
>> Fixes: 81311255f217859413c94f2cd9cebf2684bbda94
On 23.03.2020 11:00, Vladimir Sementsov-Ogievskiy wrote:
21.03.2020 17:34, Denis Plotnikov wrote:
The patch adds some preparation parts for incompatible compression type
feature to qcow2 allowing the use different compression methods for
image clusters (de)compressing.
It is implied that
23.03.2020 13:20, Denis Plotnikov wrote:
On 23.03.2020 11:44, Vladimir Sementsov-Ogievskiy wrote:
21.03.2020 17:34, Denis Plotnikov wrote:
zstd significantly reduces cluster compression time.
It provides better compression performance maintaining
the same level of the compression ratio in
Cc'ing qemu-ppc since this is restricted to the aCube Sam460ex board.
On 3/23/20 12:46 PM, Max Reitz wrote:
Hi,
I was triaging new Coverity block layer reports today, and one that
seemed like a real bug was CID 1421984:
It complains about a memleak in sii3112_pci_realize() in
Hi,
I was triaging new Coverity block layer reports today, and one that
seemed like a real bug was CID 1421984:
It complains about a memleak in sii3112_pci_realize() in
hw/ide/sii3112.c, specifically about @irq being leaked (it’s allocated
by qemu_allocate_irqs(), but never put anywhere or
From: Eric Blake
Sent: Friday, March 20, 2020 9:36 PM
To: qemu-de...@nongnu.org
Cc: peter.mayd...@linaro.org ; Andrey Shinkevich
; Kevin Wolf ; Max Reitz
; open list:qcow2
Subject: [PATCH] block: Avoid memleak on qcow2 image info failure
If we fail to get
On Thu, Mar 19, 2020 at 04:35:59PM +, Stefan Hajnoczi wrote:
> When external event sources are disabled fdmon-io_uring falls back to
> fdmon-poll. The ->need_wait() callback needs to watch for this so it
> can return true when external event sources are disabled.
>
> It is also necessary to
On 23.03.2020 11:44, Vladimir Sementsov-Ogievskiy wrote:
21.03.2020 17:34, Denis Plotnikov wrote:
zstd significantly reduces cluster compression time.
It provides better compression performance maintaining
the same level of the compression ratio in comparison with
zlib, which, at the moment,
On Fri, Mar 20, 2020 at 02:35:44PM -0500, Eric Blake wrote:
> On 3/20/20 1:58 PM, Alberto Garcia wrote:
> > Hi,
> >
> > when full_discard is false in discard_in_l2_slice() then the selected
> > cluster should be deallocated and it should read back as zeroes. This
> > is done by clearing the
21.03.2020 17:34, Denis Plotnikov wrote:
zstd significantly reduces cluster compression time.
It provides better compression performance maintaining
the same level of the compression ratio in comparison with
zlib, which, at the moment, is the only compression
method available.
The performance
21.03.2020 17:34, Denis Plotnikov wrote:
The patch adds some preparation parts for incompatible compression type
feature to qcow2 allowing the use different compression methods for
image clusters (de)compressing.
It is implied that the compression type is set on the image creation and
can be
20.03.2020 21:36, Eric Blake wrote:
If we fail to get bitmap info, we must not leak the encryption info.
Fixes: b8968c875f403
Fixes: Coverity CID 1421894
Signed-off-by: Eric Blake
---
block/qcow2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index
69 matches
Mail list logo
