Re: [PATCH 0/3] pci: Fix ARI next function numbers

2023-07-02 Thread Ani Sinha
> On 02-Jul-2023, at 2:03 PM, Akihiko Odaki wrote: > > The ARI next function number field is undefined for VF. The PF should > end the linked list formed with the field by specifying 0. > > Supersedes: <20230701070133.24877-1-akihiko.od...@daynix.com> > ("[PATCH 0/4] pci: Compare function

Re: [PATCH v3 0/2] pcie: Fix ARI next function numbers

2023-07-02 Thread Akihiko Odaki
On 2023/07/03 13:52, Michael S. Tsirkin wrote: On Mon, Jul 03, 2023 at 12:17:16PM +0900, Akihiko Odaki wrote: On 2023/07/02 21:43, Michael S. Tsirkin wrote: On Sun, Jul 02, 2023 at 09:02:25PM +0900, Akihiko Odaki wrote: The ARI next function number field is undefined for VF. The PF should end

Re: [PATCH v3 0/2] pcie: Fix ARI next function numbers

2023-07-02 Thread Michael S. Tsirkin
On Mon, Jul 03, 2023 at 12:17:16PM +0900, Akihiko Odaki wrote: > On 2023/07/02 21:43, Michael S. Tsirkin wrote: > > On Sun, Jul 02, 2023 at 09:02:25PM +0900, Akihiko Odaki wrote: > > > The ARI next function number field is undefined for VF. The PF should > > > end the linked list formed with the

Re: [PATCH v3 0/2] pcie: Fix ARI next function numbers

2023-07-02 Thread Akihiko Odaki
On 2023/07/02 21:43, Michael S. Tsirkin wrote: On Sun, Jul 02, 2023 at 09:02:25PM +0900, Akihiko Odaki wrote: The ARI next function number field is undefined for VF. The PF should end the linked list formed with the field by specifying 0. Supersedes:

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-02 Thread Bernhard Beschow
Am 1. Juli 2023 17:46:59 UTC schrieb Olaf Hering : >According to the 82371FB documentation (82371FB.pdf, 2.3.9. BMIBA—BUS >MASTER INTERFACE BASE ADDRESS REGISTER, April 1997), the register is >32bit wide. To properly reset it to default values, all 32bit need to be >cleared. Bit #0 "Resource

Re: [PATCH v2 1/4] docs: Fix next function numbers in SR/IOV documentation

2023-07-02 Thread Michael S. Tsirkin
On Sun, Jul 02, 2023 at 08:19:43PM +0900, Akihiko Odaki wrote: > On 2023/07/02 19:40, Michael S. Tsirkin wrote: > > On Sun, Jul 02, 2023 at 06:46:25PM +0900, Akihiko Odaki wrote: > > > The ARI next function number field is undefined for VF so the PF should > > > end the linked list formed with the

Re: [PATCH v3 0/2] pcie: Fix ARI next function numbers

2023-07-02 Thread Michael S. Tsirkin
On Sun, Jul 02, 2023 at 09:02:25PM +0900, Akihiko Odaki wrote: > The ARI next function number field is undefined for VF. The PF should > end the linked list formed with the field by specifying 0. > > Supersedes: <20230701070133.24877-1-akihiko.od...@daynix.com> > ("[PATCH 0/4] pci: Compare

[PATCH v3 1/2] pcie: Use common ARI next function number

2023-07-02 Thread Akihiko Odaki
Currently the only implementers of ARI is SR-IOV devices, and they behave similar. Share the ARI next function number. Signed-off-by: Akihiko Odaki --- docs/pcie_sriov.txt | 4 ++-- include/hw/pci/pcie.h | 2 +- hw/net/igb.c | 2 +- hw/net/igbvf.c| 2 +- hw/nvme/ctrl.c

[PATCH v3 2/2] pcie: Specify 0 for ARI next function numbers

2023-07-02 Thread Akihiko Odaki
The current implementers of ARI are all SR-IOV devices. The ARI next function number field is undefined for VF. The PF should end the linked list formed with the field by specifying 0. Fixes: 2503461691 ("pcie: Add some SR/IOV API documentation in docs/pcie_sriov.txt") Fixes: 44c2c09488

[PATCH v3 0/2] pcie: Fix ARI next function numbers

2023-07-02 Thread Akihiko Odaki
The ARI next function number field is undefined for VF. The PF should end the linked list formed with the field by specifying 0. Supersedes: <20230701070133.24877-1-akihiko.od...@daynix.com> ("[PATCH 0/4] pci: Compare function number and ARI next function number") V2 -> V3: Moved the logic to

Re: [PATCH v2 1/4] docs: Fix next function numbers in SR/IOV documentation

2023-07-02 Thread Akihiko Odaki
On 2023/07/02 19:40, Michael S. Tsirkin wrote: On Sun, Jul 02, 2023 at 06:46:25PM +0900, Akihiko Odaki wrote: The ARI next function number field is undefined for VF so the PF should end the linked list formed with the field by specifying 0. This also changes the value of the field for VF; it

Re: [PATCH v2 1/4] docs: Fix next function numbers in SR/IOV documentation

2023-07-02 Thread Michael S. Tsirkin
On Sun, Jul 02, 2023 at 06:46:25PM +0900, Akihiko Odaki wrote: > The ARI next function number field is undefined for VF so the PF should > end the linked list formed with the field by specifying 0. > > This also changes the value of the field for VF; it seems to imply the > value has some meaning

Re: [PATCH 3/3] igb: Fix ARI next function numbers

2023-07-02 Thread Michael S. Tsirkin
On Sun, Jul 02, 2023 at 06:49:50PM +0900, Akihiko Odaki wrote: > On 2023/07/02 18:00, Michael S. Tsirkin wrote: > > On Sun, Jul 02, 2023 at 05:33:56PM +0900, Akihiko Odaki wrote: > > > The ARI next function number field is undefined for VF so the PF should > > > end the linked list formed with the

Re: [PATCH v2 3/4] igb: Fix ARI next function numbers

2023-07-02 Thread Michael S. Tsirkin
On Sun, Jul 02, 2023 at 06:46:27PM +0900, Akihiko Odaki wrote: > The ARI next function number field is undefined for VF so the PF should > end the linked list formed with the field by specifying 0. > > Fixes: 3a977deebe ("Intrdocue igb device emulation") > Signed-off-by: Akihiko Odaki > --- >

Re: [PATCH 3/3] igb: Fix ARI next function numbers

2023-07-02 Thread Akihiko Odaki
On 2023/07/02 18:00, Michael S. Tsirkin wrote: On Sun, Jul 02, 2023 at 05:33:56PM +0900, Akihiko Odaki wrote: The ARI next function number field is undefined for VF so the PF should end the linked list formed with the field by specifying 0. Fixes: 3a977deebe ("Intrdocue igb device emulation")

[PATCH v2 2/4] hw/nvme: Fix ARI next function numbers

2023-07-02 Thread Akihiko Odaki
The ARI next function number field is undefined for VF. The PF should end the linked list formed with the field by specifying 0. Fixes: 44c2c09488 ("hw/nvme: Add support for SR-IOV") Signed-off-by: Akihiko Odaki --- hw/nvme/nvme.h| 1 + hw/core/machine.c | 1 + hw/nvme/ctrl.c| 3 ++- 3

[PATCH v2 3/4] igb: Fix ARI next function numbers

2023-07-02 Thread Akihiko Odaki
The ARI next function number field is undefined for VF so the PF should end the linked list formed with the field by specifying 0. Fixes: 3a977deebe ("Intrdocue igb device emulation") Signed-off-by: Akihiko Odaki --- hw/core/machine.c | 3 ++- hw/net/igb.c | 5 - 2 files changed, 6

[PATCH v2 4/4] pcie: Note a caveat regarding ARI next function number

2023-07-02 Thread Akihiko Odaki
Suggested-by: Michael S. Tsirkin Signed-off-by: Akihiko Odaki --- include/hw/pci/pcie.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/hw/pci/pcie.h b/include/hw/pci/pcie.h index 3cc2b15957..16860e2216 100644 --- a/include/hw/pci/pcie.h +++ b/include/hw/pci/pcie.h @@ -134,7

[PATCH v2 0/4] pcie: Fix ARI next function numbers

2023-07-02 Thread Akihiko Odaki
The ARI next function number field is undefined for VF. The PF should end the linked list formed with the field by specifying 0. Supersedes: <20230701070133.24877-1-akihiko.od...@daynix.com> ("[PATCH 0/4] pci: Compare function number and ARI next function number") V1 -> V2: Fixed migration.

[PATCH v2 1/4] docs: Fix next function numbers in SR/IOV documentation

2023-07-02 Thread Akihiko Odaki
The ARI next function number field is undefined for VF so the PF should end the linked list formed with the field by specifying 0. This also changes the value of the field for VF; it seems to imply the value has some meaning if it differs from one of the PF, but it doesn't. Fixes: 2503461691

Re: [PATCH 3/3] igb: Fix ARI next function numbers

2023-07-02 Thread Michael S. Tsirkin
On Sun, Jul 02, 2023 at 05:33:56PM +0900, Akihiko Odaki wrote: > The ARI next function number field is undefined for VF so the PF should > end the linked list formed with the field by specifying 0. > > Fixes: 3a977deebe ("Intrdocue igb device emulation") > Signed-off-by: Akihiko Odaki I would

Re: [PATCH 4/4] pci: Compare function number and ARI next function number

2023-07-02 Thread Michael S. Tsirkin
On Sun, Jul 02, 2023 at 04:55:48AM -0400, Michael S. Tsirkin wrote: > On Sun, Jul 02, 2023 at 05:46:38PM +0900, Akihiko Odaki wrote: > > On 2023/07/02 13:58, Michael S. Tsirkin wrote: > > > On Sat, Jul 01, 2023 at 04:01:22PM +0900, Akihiko Odaki wrote: > > > > The function number must be lower

Re: [PATCH 4/4] pci: Compare function number and ARI next function number

2023-07-02 Thread Michael S. Tsirkin
On Sun, Jul 02, 2023 at 05:46:38PM +0900, Akihiko Odaki wrote: > On 2023/07/02 13:58, Michael S. Tsirkin wrote: > > On Sat, Jul 01, 2023 at 04:01:22PM +0900, Akihiko Odaki wrote: > > > The function number must be lower than the next function number > > > advertised with ARI. > > > > > >

Re: [PATCH 4/4] pci: Compare function number and ARI next function number

2023-07-02 Thread Akihiko Odaki
On 2023/07/02 13:58, Michael S. Tsirkin wrote: On Sat, Jul 01, 2023 at 04:01:22PM +0900, Akihiko Odaki wrote: The function number must be lower than the next function number advertised with ARI. Signed-off-by: Akihiko Odaki I don't get this logic at all - where is the limitation coming

Re: [PATCH 0/3] pci: Fix ARI next function numbers

2023-07-02 Thread Michael S. Tsirkin
On Sun, Jul 02, 2023 at 05:33:53PM +0900, Akihiko Odaki wrote: > The ARI next function number field is undefined for VF. The PF should > end the linked list formed with the field by specifying 0. > > Supersedes: <20230701070133.24877-1-akihiko.od...@daynix.com> > ("[PATCH 0/4] pci: Compare

Re: [PATCH 3/4] igb: Fix ARI next function numbers

2023-07-02 Thread Michael S. Tsirkin
On Sun, Jul 02, 2023 at 05:38:42PM +0900, Akihiko Odaki wrote: > On 2023/07/02 14:05, Michael S. Tsirkin wrote: > > On Sat, Jul 01, 2023 at 04:01:21PM +0900, Akihiko Odaki wrote: > > > The next function numbers are expected to form a linked list ending with > > > 0. > > > > > > Fixes: 3a977deebe

Re: [PATCH 3/4] igb: Fix ARI next function numbers

2023-07-02 Thread Akihiko Odaki
On 2023/07/02 14:05, Michael S. Tsirkin wrote: On Sat, Jul 01, 2023 at 04:01:21PM +0900, Akihiko Odaki wrote: The next function numbers are expected to form a linked list ending with 0. Fixes: 3a977deebe ("Intrdocue igb device emulation") Signed-off-by: Akihiko Odaki --- hw/net/igb_core.h |

[PATCH 3/3] igb: Fix ARI next function numbers

2023-07-02 Thread Akihiko Odaki
The ARI next function number field is undefined for VF so the PF should end the linked list formed with the field by specifying 0. Fixes: 3a977deebe ("Intrdocue igb device emulation") Signed-off-by: Akihiko Odaki --- hw/net/igb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/3] docs: Fix next function numbers in SR/IOV documentation

2023-07-02 Thread Akihiko Odaki
The ARI next function number field is undefined for VF so the PF should end the linked list formed with the field by specifying 0. This also changes the value of the field for VF; it seems to imply the value has some meaning if it differs from one of the PF, but it doesn't. Fixes: 2503461691

[PATCH 2/3] hw/nvme: Fix ARI next function numbers

2023-07-02 Thread Akihiko Odaki
The ARI next function number field is undefined for VF. The PF should end the linked list formed with the field by specifying 0. Fixes: 44c2c09488 ("hw/nvme: Add support for SR-IOV") Signed-off-by: Akihiko Odaki --- hw/nvme/ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 0/3] pci: Fix ARI next function numbers

2023-07-02 Thread Akihiko Odaki
The ARI next function number field is undefined for VF. The PF should end the linked list formed with the field by specifying 0. Supersedes: <20230701070133.24877-1-akihiko.od...@daynix.com> ("[PATCH 0/4] pci: Compare function number and ARI next function number") Akihiko Odaki (3): docs: Fix