From: John Snow
This saw its last use in 4bfb274165ba.
Signed-off-by: John Snow
Message-Id: <20200806211345.2925343-2-js...@redhat.com>
Signed-off-by: Max Reitz
---
block/rbd.c | 42 --
1 file changed, 42 deletions(-)
diff --git a/block/rbd.c b
n Wolf
Signed-off-by: Max Reitz
---
block/qcow2.h | 4 ++--
block/qcow2-cluster.c | 6 +++---
block/qcow2-refcount.c | 8
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/block/qcow2.h b/block/qcow2.h
index 83cfa0c391..b73a4cf1f8 100644
--- a/block/qcow2.h
+++ b
From: Alberto Garcia
The current text corresponds to an earlier, simpler version of this
function and it does not explain how it works now.
Signed-off-by: Alberto Garcia
Message-Id:
Signed-off-by: Max Reitz
---
block/qcow2-cluster.c | 24 ++--
1 file changed, 14
From: Nir Soffer
Use list comprehension instead of append loop.
Signed-off-by: Nir Soffer
Reviewed-by: Max Reitz
Message-Id: <20200828232152.205833-6-nsof...@redhat.com>
Signed-off-by: Max Reitz
---
tests/qemu-iotests/iotests.py | 5 ++---
1 file changed, 2 insertions(+), 3 del
-by: Max Reitz
[mreitz: Mark compat=0.10 unsupported for iotest 125]
Signed-off-by: Max Reitz
---
block/qcow2.c | 1 +
tests/qemu-iotests/125 | 44 ++
tests/qemu-iotests/125.out | 28 ++--
3 files changed, 53 insertions(+), 20
the final host
offset directly. The function is also renamed accordingly.
See 388e581615 for a similar change to qcow2_get_cluster_offset().
Signed-off-by: Alberto Garcia
Message-Id:
<9bfef50ec9200d752413be4fc2aeb22a28378817.1599833007.git.be...@igalia.com>
Reviewed-by: Max Reitz
Signed-off-b
hen
Reviewed-by: Alberto Garcia
Message-Id:
<5d5f930424c1c770754041aa8ad6421dc4e2b58e.1596536719.git.lukasstra...@web.de>
Signed-off-by: Max Reitz
---
block/quorum.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/block/quorum.c b/block/quoru
From: John Snow
Introduced by d85f4222b468,
These were seemingly never used at all.
Signed-off-by: John Snow
Message-Id: <20200806211345.2925343-3-js...@redhat.com>
Signed-off-by: Max Reitz
---
block/qcow.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/block/qcow.c b
ck2):
But this is more clear and calling optional argument as positional
arguments is bad idea anyway.
Signed-off-by: Nir Soffer
Reviewed-by: Max Reitz
Message-Id: <20200828232152.205833-4-nsof...@redhat.com>
Signed-off-by: Max Reitz
---
tests/qemu-iotests/194| 4 ++--
tests/qem
com>
Reviewed-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Kevin Wolf
Signed-off-by: Max Reitz
---
block/qcow2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index d241fb734c..77c43ce178 100644
--- a/block/qcow2.c
+++ b/block
luster boundaries.
Signed-off-by: Peter Lieven
Message-Id: <20200901125129.6398-1...@kamp.de>
[mreitz: Disable vhdx for 251]
Signed-off-by: Max Reitz
---
qemu-img.c | 22 ++
tests/qemu-iotests/251 | 7 +--
2 files changed, 27 insertions(+), 2 deletions(-)
From: Alberto Garcia
This patch replaces instances of sizeof(uint64_t) in the qcow2 driver
with macros that indicate what those sizes are actually referring to.
Signed-off-by: Alberto Garcia
Message-Id: <20200828110828.13833-1-be...@igalia.com>
Signed-off-by: Max Reitz
---
block/q
or creating temporary files instead
of 3.
Signed-off-by: Nir Soffer
Reviewed-by: Max Reitz
Message-Id: <20200828232152.205833-5-nsof...@redhat.com>
Signed-off-by: Max Reitz
---
tests/qemu-iotests/194| 2 +-
tests/qemu-iotests/208| 2 +-
tests/qemu-iotests/222
base_dir.
Fixes: de263986b5dc
Signed-off-by: Nir Soffer
Message-Id: <20200828232152.205833-3-nsof...@redhat.com>
Signed-off-by: Max Reitz
---
tests/qemu-iotests/iotests.py | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/tests/qemu-iotests/iotest
this is no longer the case, l2meta (nowadays a pointer to a list) is
only allocated when needed and nb_clusters is guaranteed to be > 0 so
this check is unnecessary.
Signed-off-by: Alberto Garcia
Message-Id:
Signed-off-by: Max Reitz
---
block/qcow2.c | 4 +---
1 file changed, 1 insertion(+)
From: Nir Soffer
If os.remove() fails to remove one of the paths, for example if the file
was removed by the test, the cleanup loop would exit silently, without
removing the rest of the files.
Fixes: de263986b5dc
Signed-off-by: Nir Soffer
Reviewed-by: Max Reitz
Message-Id
Message-Id: <20200907113824.134788-1-th...@redhat.com>
Signed-off-by: Max Reitz
---
tests/check-block.sh | 3 +++
tests/qemu-iotests/030 | 2 ++
2 files changed, 5 insertions(+)
diff --git a/tests/check-block.sh b/tests/check-block.sh
index 8e29c868e5..a5a69060e1 100755
--- a/tests/check-block.sh
+
tanix.com>
Signed-off-by: Max Reitz
---
block/vhdx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index 791eb90263..356ec4c455 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -816,9 +816,9 @@ static int vhdx_parse_metadata(BlockDri
request, but it can be
reproduced with the included test case.
Signed-off-by: Alberto Garcia
Message-Id:
<3440a1c4d53c4fe48312b478c96accb338cbef7c.1599150873.git.be...@igalia.com>
Signed-off-by: Max Reitz
---
block/qcow2-cluster.c | 3 --
tests/qemu-iotests/305
The following changes since commit 2d2c73d0e3d504a61f868e46e6abd5643f38091b:
Merge remote-tracking branch
'remotes/pmaydell/tags/pull-target-arm-20200914-1' into staging (2020-09-14
16:03:08 +0100)
are available in the Git repository at:
https://github.com/XanClic/qemu.git
On 11.09.20 16:09, Alberto Garcia wrote:
> This function preallocates metadata structures and then extends the
> image to its new size, but that new size calculation is wrong because
> it doesn't take into account that the host_offset variable is always
> cluster-aligned.
>
> This problem can be
On 14.09.20 21:05, Stefano Garzarella wrote:
> Commit 19ae9ae014 ("block/rbd: Add support for ceph namespaces")
> introduced namespace support for RBD, but we forgot to add the
> new 'namespace' options to qemu_rbd_strong_runtime_opts[].
>
> The 'namespace' is used to identify the image, so it is
On 14.09.20 21:10, Eric Blake wrote:
> If you have the chain 'base.qcow2 <- top.qcow2' and want to merge a
> bitmap from top into base, qemu-img was failing with:
>
> qemu-img: Could not open 'top.qcow2': Could not open backing file: Failed to
> get shared "write" lock
> Is another process using
On 11.09.20 16:09, Alberto Garcia wrote:
> preallocate_co() does not resize the image correctly if the original
> size was not cluster-aligned.
>
> This series should be applied on top of Max's block branch (I tested
> it with commit 8e66c829eda997dad661d49d73668b1fd3e6043d).
>
>
On 14.09.20 18:42, Alberto Garcia wrote:
> On Mon 14 Sep 2020 02:14:36 PM CEST, Max Reitz wrote:
>
>> However, I wonder what you think about “cluster_offset” in
>> qcow2_alloc_host_offset. It isn’t a cluster offset anymore.
>> Can/should we rename it?
>
> That var
On 14.09.20 14:51, Peter Maydell wrote:
> On Mon, 14 Sep 2020 at 13:32, Max Reitz wrote:
>>
>> On 14.09.20 14:31, Peter Maydell wrote:
>>> On Mon, 14 Sep 2020 at 12:39, Max Reitz wrote:
>>>>
>>>> On macOS, (out of the box) readlink does not
; pwd" like is done for
$source_iotests.
Fixes: b1cbc33a3971b6bb005d5ac3569feae35a71de0f
("iotests: Allow running from different directory")
Suggested-by: Peter Maydell
Reported-by: Claudio Fontana
Reported-by: Thomas Huth
Signed-off-by: Max Reitz
---
tests/qemu-iotests/
io Fontana
Reported-by: Thomas Huth
Signed-off-by: Max Reitz
---
v2: Suppress stderr (as requested and suggested by Peter)
---
tests/qemu-iotests/check | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index e14a1f354
On 14.09.20 16:26, Peter Maydell wrote:
> On Mon, 14 Sep 2020 at 15:17, Max Reitz wrote:
>>
>> On macOS, (out of the box) readlink does not have -f. If the recent
>> "readlink -f" call introduced by b1cbc33a397 fails, just fall back to
>> the old behavior
On 14.09.20 14:31, Peter Maydell wrote:
> On Mon, 14 Sep 2020 at 12:39, Max Reitz wrote:
>>
>> On macOS, (out of the box) readlink does not have -f. If the recent
>> "readlink -f" call introduced by b1cbc33a397 fails, just fall back to
>> the old behavior
ta img.qcow2 128k
>
> Signed-off-by: Alberto Garcia
> ---
> block/qcow2.c | 1 +
> tests/qemu-iotests/125 | 40 +-
> tests/qemu-iotests/125.out | 28 --
> 3 files changed, 49 insertions(+), 20
6 +++---
> block/qcow2-cluster.c | 14 ++
> block/qcow2.c | 36 +---
> 3 files changed, 26 insertions(+), 30 deletions(-)
First of all:
Reviewed-by: Max Reitz
However, I wonder what you think about “cluster_offset” in
qcow2_alloc_host_offset. It isn’t
io Fontana
Reported-by: Thomas Huth
Signed-off-by: Max Reitz
---
Hi Thomas,
I thought this would be quicker than writing a witty response on whether
you or me should write this patch. O:)
---
tests/qemu-iotests/check | 4
1 file changed, 4 insertions(+)
diff --git a/tests/qemu-iotests/check
On 14.09.20 12:50, Thomas Huth wrote:
> On 14/09/2020 11.19, Max Reitz wrote:
>> On 12.09.20 14:14, Thomas Huth wrote:
>>> macOS is shipped with a very old version of the bash (3.2), which
>>> is currently not suitable for running the iotests anymore. Add
>
On 11.09.20 17:17, Eric Blake wrote:
> On 9/11/20 3:31 AM, Max Reitz wrote:
>> On 09.09.20 14:33, Eric Blake wrote:
>>> If you have the chain 'base.qcow2 <- top.qcow2' and want to merge a
>>> bitmap from top into base, qemu-img was failing with:
>>>
>>
On 12.09.20 14:14, Thomas Huth wrote:
> macOS is shipped with a very old version of the bash (3.2), which
> is currently not suitable for running the iotests anymore. Add
> a check to skip the iotests in this case - if someone still wants
> to run the iotests on macOS, they can install a newer
On 14.09.20 10:22, Max Reitz wrote:
> On 11.09.20 17:39, Alberto Garcia wrote:
>> On Fri 11 Sep 2020 04:55:08 PM CEST, Alberto Garcia wrote:
>>>> $ qemu-img check prealloc_4G_2M.qcow2
>>>> ERROR: coffset=0x180a0: copied flag must never be set for
>
On 11.09.20 17:39, Alberto Garcia wrote:
> On Fri 11 Sep 2020 04:55:08 PM CEST, Alberto Garcia wrote:
>>> $ qemu-img check prealloc_4G_2M.qcow2
>>> ERROR: coffset=0x180a0: copied flag must never be set for
>>> compressed clusters
>
> I see, this was fixed recently (QEMU 5.0.0 is still
On 06.08.20 23:13, John Snow wrote:
>
>
> John Snow (2):
> block/rbd: remove runtime_opts
> block/qcow: remove runtime opts
>
> block/qcow.c | 9 -
> block/rbd.c | 42 --
> 2 files changed, 51 deletions(-)
Thanks, applied to my block
On 09.09.20 14:37, Alberto Garcia wrote:
> This function checks the current status of a (sub)cluster in order to
> see if an unaligned 'write zeroes' request can be done efficiently by
> simply updating the L2 metadata and without having to write actual
> zeroes to disk.
>
> If the situation does
On 08.09.20 16:08, Alberto Garcia wrote:
> This is a follow-up to "Fix removal of list members from
> BDRVQcow2State.cluster_allocs":
>
>https://lists.gnu.org/archive/html/qemu-block/2020-09/msg00247.html
>
> However the patches themselves are independent and can be applied
> separately.
>
On 09.09.20 14:33, Eric Blake wrote:
> If you have the chain 'base.qcow2 <- top.qcow2' and want to merge a
> bitmap from top into base, qemu-img was failing with:
>
> qemu-img: Could not open 'top.qcow2': Could not open backing file: Failed to
> get shared "write" lock
> Is another process using
On 01.09.20 14:51, Peter Lieven wrote:
> in case of large continous areas that share the same allocation status
> it happens that the value of s->sector_next_status is unaligned to the
> cluster size or even request alignment of the source. Avoid this by
> stripping down the s->sector_next_status
On 07.08.20 12:03, Swapnil Ingle wrote:
> block/vhdx uses qemu block layer where sector size is always 512 bytes.
> This may have issues with 4K logical sector sized vhdx image.
>
> For e.g qemu-img convert on such images fails with following assert:
>
> $qemu-img convert -f vhdx -O raw
On 07.09.20 20:20, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/iotests.py | 11 +++-
> tests/qemu-iotests/307| 117 ++
> tests/qemu-iotests/307.out| 111
> tests/qemu-iotests/group |
urn both its output and its exit code
> """
> -subp = subprocess.Popen(qemu_img_args + list(args),
> +stderr = subprocess.STDOUT if connect_stderr else None
I really despise this notation. It’s like ternary operators in C
weren’t bad enough.
(Again with the personal feelings. Sorry.)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 07.09.20 20:20, Kevin Wolf wrote:
> These QMP commands are replaced by block-export-add/del.
>
> Signed-off-by: Kevin Wolf
> ---
> qapi/block-export.json | 11 +--
> docs/system/deprecated.rst | 8
> 2 files changed, 17 insertions(+), 2 deletions(-)
OK, but:
> diff
rs, and another one that
actually creates the export.
In any case this isn’t the first function in qemu with more than 100 loc
and it won’t be the last; and it allows getting rid of two public
functions, so:
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
lock-export.json | 15 ++-
> block/export/export.c | 16 +++-
> blockdev-nbd.c | 18 +-
> nbd/server.c | 5 -
> qemu-nbd.c | 4 ++--
> 5 files changed, 32 insertions(+), 26 deletions(-)
Reviewed-by: Max Reitz
On 07.09.20 20:20, Kevin Wolf wrote:
> Clients may want to know when an export has finally disappeard
> (block-export-del returns earlier than that in the general case), so add
> a QAPI event for it.
>
> Signed-off-by: Kevin Wolf
> ---
> qapi/block-export.json | 12
>
hanged, 55 insertions(+)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
/export/export.c | 49 +++
> blockdev-nbd.c| 33 -
> nbd/server.c | 38 +++--
> 4 files changed, 63 insertions(+), 61 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
> block/export/export.c | 2 ++
> tests/qemu-iotests/140.out | 1 +
> tests/qemu-iotests/223.out | 4
> 4 files changed, 19 insertions(+)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 10.09.20 15:33, Max Reitz wrote:
> On 07.09.20 20:20, Kevin Wolf wrote:
>> The reference owned by the user/monitor that is created when adding the
>> export and dropped when removing it was tied to the 'exports' list in
>> nbd/server.c. Every block export will have a us
actually still owns it.
>
> Signed-off-by: Kevin Wolf
> ---
> include/block/export.h | 8
> block/export/export.c | 6 ++
> blockdev-nbd.c | 5 -
> nbd/server.c | 2 --
> 4 files changed, 14 insertions(+), 7 deletions(-)
Reviewed-by: Max Reitz
storage-daemon/qemu-storage-daemon.c | 2 +-
> tests/qemu-iotests/223.out | 4 ++--
> 7 files changed, 39 insertions(+), 3 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
);
> -g_free(exp);
> +/* Touch the block_exports list only in the main thread */
> +aio_bh_schedule_oneshot(qemu_get_aio_context(), blk_exp_delete_bh,
> +exp);
Looks safe.
Reviewed-by: Max Reitz
(The effort of spe
;
> Signed-off-by: Kevin Wolf
> ---
> qapi/block-export.json | 27 -
> block/monitor/block-hmp-cmds.c | 6 ++---
> blockdev-nbd.c | 44 +-
> qemu-nbd.c | 2 +-
> 4 files changed,
On 10.09.20 11:13, Kevin Wolf wrote:
> Am 10.09.2020 um 00:09 hat Eric Blake geschrieben:
>> On 9/9/20 4:55 PM, Peter Maydell wrote:
>>
>>>
>>> This fails 'make check' on NetBSD and OpenBSD:
>>>
>>> ./check: line 47: realpath: command not found
>>> ./check: line 60: /common.env: No such file or
On 07.09.20 20:19, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf
> ---
> include/block/export.h | 3 +++
> block/export/export.c | 2 ++
> nbd/server.c | 26 +-
> 3 files changed, 18 insertions(+), 13 deletions(-)
Reviewed-by: Max Reitz
api/block-export.json | 7 ++-
> blockdev-nbd.c | 6 +-
> 2 files changed, 11 insertions(+), 2 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
d.c | 3 +--
> 6 files changed, 67 insertions(+), 21 deletions(-)
[...]
> +if (bdrv_is_read_only(bs)) {
> +export_opts.u.nbd.has_writable = true;
Ah, yes, setting that might be nice. :)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
son.build| 2 ++
> meson.build | 2 +-
> 9 files changed, 133 insertions(+), 10 deletions(-)
> create mode 100644 include/block/export.h
> create mode 100644 block/export/export.c
> create mode 100644 block/export/meson.build
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 08.09.20 09:01, Kevin Wolf wrote:
> Am 07.09.2020 um 22:22 hat Peter Maydell geschrieben:
>> On Mon, 7 Sep 2020 at 12:09, Kevin Wolf wrote:
>>>
>>> The following changes since commit 7c37270b3fbe3d034ba80e488761461676e21eb4:
>>>
>>> Merge remote-tracking branch
>>>
On 07.09.20 13:38, Thomas Huth wrote:
> The test_stream_parallel test still occasionally fails in the CI.
> Thus let's disable it during "make check" for now so that it does
> not cause trouble during merge tests. We can enable it again once
> the problem has been resolved.
>
> Signed-off-by:
On 04.09.20 15:48, Vladimir Sementsov-Ogievskiy wrote:
> 04.09.2020 16:21, Max Reitz wrote:
>> On 28.08.20 18:52, Andrey Shinkevich wrote:
>>> To keep the base node unchanged during the block-stream operation,
>>> freeze it as the other part of the backing chain with
f-by: Kevin Wolf
> ---
> block/file-win32.c | 22 +-
> 1 file changed, 21 insertions(+), 1 deletion(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 19.08.20 03:36, Yi Li wrote:
> Signed-off-by: Yi Li
> ---
> qemu-img.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
signature.asc
Description: OpenPGP digital signature
On 05.09.20 13:24, Thomas Huth wrote:
> The test_stream_parallel test still occasionally fails in the CI.
> Thus let's disable it during "make check" for now so that it does
> not cause trouble during merge tests. We can enable it again once
> the problem has been resolved.
>
> Signed-off-by:
On 28.08.20 18:52, Andrey Shinkevich wrote:
> This patch completes the series with the COR-filter insertion for
> block-stream operations. Adding the filter makes it possible for copied
> regions to be discarded in backing files during the block-stream job,
> what will reduce the disk overuse.
>
On 28.08.20 18:52, Andrey Shinkevich wrote:
> Limit the guest's COR operations by the base node in the backing chain
> during a stream job.
I don’t understand. Shouldn’t we limit the areas where we set the COR
flag?
> Signed-off-by: Andrey Shinkevich
> ---
> block/copy-on-read.c | 49
On 28.08.20 18:52, Andrey Shinkevich wrote:
> To limit the guest's COR operations by the base node in the backing
> chain during stream job, pass the base file name to the copy-on-read
Does it have to be a filename? That sounds really bad to me.
> driver. The rest of the functionality will be
On 28.08.20 18:52, Andrey Shinkevich wrote:
> Provide API for the COR-filter insertion/removal.
Hm. Why?
I see the implementation is just bdrv_open() + bdrv_replace_node(),
which is what I would have expected. Why can’t the caller just do that?
Or maybe it would even make sense to just make
On 04.09.20 12:14, Thomas Huth wrote:
> On 04/09/2020 10.25, Kevin Wolf wrote:
>> Am 04.09.2020 um 07:57 hat Thomas Huth geschrieben:
>>> Test 030 is still occasionally failing in the CI ... so for the
>>> time being, let's disable it in the "auto" group. We can add it
>>> back once it got more
On 04.09.20 11:36, Alberto Garcia wrote:
> On Fri 04 Sep 2020 11:28:18 AM CEST, Max Reitz wrote:
>>> + * If any clusters or subclusters were allocated then @m contains a
>>> + * list with the information of all the affected regions. Note that
>>> + * this ca
On 03.09.20 18:37, Alberto Garcia wrote:
> Hi,
>
> here are the changes from v1:
>
> - Split changes into three different patches.
> - Rewrite the documentation of qcow2_alloc_cluster_offset() [Max]
> - Use peek_file_be in the test case to read the offset of the refcount
> table [Max].
> -
On 03.09.20 18:37, Alberto Garcia wrote:
> The current text corresponds to an earlier, simpler version of this
> function and it does not explain how it works now.
>
> Signed-off-by: Alberto Garcia
> ---
> block/qcow2-cluster.c | 24 ++--
> 1 file changed, 14 insertions(+),
On 04.09.20 07:57, Thomas Huth wrote:
> Test 030 is still occasionally failing in the CI ... so for the
> time being, let's disable it in the "auto" group. We can add it
> back once it got more stable.
>
> Signed-off-by: Thomas Huth
> ---
> I just saw the problem here:
>
On 04.09.20 10:31, Max Reitz wrote:
> On 04.09.20 07:57, Thomas Huth wrote:
>> Test 030 is still occasionally failing in the CI ... so for the
>> time being, let's disable it in the "auto" group. We can add it
>> back once it got more stable.
>>
>> Signed
On 28.08.20 13:08, Alberto Garcia wrote:
> This patch replaces instances of sizeof(uint64_t) in the qcow2 driver
> with macros that indicate what those sizes are actually referring to.
>
> Signed-off-by: Alberto Garcia
> ---
> block/qcow2.h | 6 +++
> block/qcow2-bitmap.c | 11
On 01.09.20 14:51, Peter Lieven wrote:
> in case of large continous areas that share the same allocation status
> it happens that the value of s->sector_next_status is unaligned to the
> cluster size or even request alignment of the source. Avoid this by
> stripping down the s->sector_next_status
On 03.09.20 15:36, Fabian Grünbichler wrote:
> On September 3, 2020 3:23 pm, Kevin Wolf wrote:
>> Am 03.09.2020 um 14:57 hat Max Reitz geschrieben:
>>> On 03.09.20 14:38, Kevin Wolf wrote:
>>>> Am 03.09.2020 um 13:04 hat Max Reitz geschrieben:
>>>>>
wouldn’t allow -o refcount_bits=64.
> +
> +refcount_table_offset=$((0x400))
I would like to suggest $(peek_file_be "$TEST_IMG" 48 8), to set an
example for future generations; but not strictly necessary, of course. O:)
Anyway, at least with the _unsupported_imgopts line completed:
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 03.09.20 14:38, Kevin Wolf wrote:
> Am 03.09.2020 um 13:04 hat Max Reitz geschrieben:
>> On 03.09.20 12:13, Fabian Grünbichler wrote:
>>> On August 21, 2020 3:03 pm, Max Reitz wrote:
>>>> On 18.02.20 11:07, Fabian Grünbichler wrote:
>>> I am not sure
On 02.09.20 13:03, Kevin Wolf wrote:
> It is convenient to be able to edit the tests and run them without
> changing the current working directory back and forth. Instead of
> assuming that $PWD is the qemu-iotests build directory, derive the build
> directory from the executed script.
>
> This
On 03.09.20 12:13, Fabian Grünbichler wrote:
> On August 21, 2020 3:03 pm, Max Reitz wrote:
>> On 18.02.20 11:07, Fabian Grünbichler wrote:
>>
>> [Sorry :/]
>
> same, I've been meaning to ping/pick this back up but other stuff got in
> the way. so thanks for the
On 02.09.20 18:48, Max Reitz wrote:
> Reported-by: Kevin Wolf
> Signed-off-by: Max Reitz
> ---
> block/mirror.c | 20 +---
> 1 file changed, 17 insertions(+), 3 deletions(-)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index 11ebffdf99..27422ab
Reported-by: Kevin Wolf
Signed-off-by: Max Reitz
---
block/mirror.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 11ebffdf99..27422ab7a5 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -649,8 +649,8 @@ static
h I implemented here is
fine until someone complains.
Max Reitz (3):
mirror: Set s->base_overlay only if s->base is set
mirror: Freeze backing chain for sync=top
iotests/041: x-blockdev-reopen during mirror
block/mirror.c | 28 +---
tests/qemu-iotests/041
This way, sync=full will not need a reference to any node other than the
source and the target.
Signed-off-by: Max Reitz
---
block/mirror.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 26acf4af6f..11ebffdf99 100644
--- a/block
Test what happens when you remove the backing file during a mirror with
sync=top.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/041 | 92 ++
tests/qemu-iotests/041.out | 4 +-
2 files changed, 94 insertions(+), 2 deletions(-)
diff --git a/tests/qemu
On 02.09.20 12:23, Kevin Wolf wrote:
> Am 01.09.2020 um 16:33 hat Max Reitz geschrieben:
>> v6: https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg01715.html
>> v7: https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg01357.html
>>
>> Branch: https://
On 02.09.20 10:53, Kevin Wolf wrote:
> Am 01.09.2020 um 16:34 hat Max Reitz geschrieben:
>> This includes some permission limiting (for example, we only need to
>> take the RESIZE permission for active commits where the base is smaller
>> than the top).
>>
>> bas
On 29.08.20 01:21, Nir Soffer wrote:
> Fix some issues introduced when iotests.FilePaths was added and merge it back
> into FilePath keeping the option to create multiple file names.
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
signature.asc
On 27.08.20 23:08, Vladimir Sementsov-Ogievskiy wrote:
> 21.08.2020 17:11, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all!
>>
>> Here is a filter, which does preallocation on write.
>>
>> In Virtuozzo we have to deal with some custom distributed storage
>> solution, where allocation is relatively
Signed-off-by: Max Reitz
Reviewed-by: Andrey Shinkevich
Reviewed-by: Kevin Wolf
---
tests/qemu-iotests/040 | 61 ++
tests/qemu-iotests/040.out | 4 +--
2 files changed, 63 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/040 b/tests/qemu
Add a test for committing an overlay in a sub directory to one of the
images in its backing chain, using both relative and absolute filenames.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/020 | 44 ++
tests/qemu-iotests/020.out | 10 +
2 files
Flushing a qcow2 node must lead to the data-file node being flushed as
well.
Signed-off-by: Max Reitz
Reviewed-by: Andrey Shinkevich
Reviewed-by: Kevin Wolf
---
tests/qemu-iotests/244 | 49 ++
tests/qemu-iotests/244.out | 7 ++
2 files changed, 56
This patch adds some tests on how commit copes with filter nodes.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/040 | 177 +
tests/qemu-iotests/040.out | 4 +-
2 files changed, 179 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/040 b
This changes iotest 204's output, because blkdebug on top of a COW node
used to make qemu-img map disregard the rest of the backing chain (the
backing chain was broken by the filter). With this patch, the
allocation in the base image is reported correctly.
Signed-off-by: Max Reitz
---
qemu
901 - 1000 of 9029 matches
Mail list logo
